Allow searching for content in the editor navigation

Created on 9 April 2025, about 2 months ago

Overview

We currently have a text field for searching for content in the editor navigation that is not functional.

Proposed resolution

Update `\Drupal\experience_builder\Controller\ApiContentControllers::list` to read a `search` query parameter and do a `LIKE` query on the `label` entity key.

Update `contentApi` and `getContentList` to pass the `search` query param.

Update `PageInfo` to pass a function to `Navgation` component's `onSearch` prop to perform a refresh of `useGetContentListQuery` when search is performed.

User interface changes

Pressing "enter" in search no longer shows the "not implemented yet" alert and pages can be searched

Feature request
Status

Active

Version

0.0

Component

Page builder

Created by

🇺🇸United States mglaman WI, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mglaman
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Update `\Drupal\experience_builder\Controller\ApiContentControllers::list` to read a `search` query parameter and do a `LIKE` query on the `label` entity key.

    If only we had QUERY!

    But at least in this case, the querystring itself should be comparatively tiny, so ?search=hello%20world will do just fine 👍

    Note: ApiContentControllers::list() may end up finding hundreds of matches. But the API response does not yet support pagination. Thoughts?

  • 🇺🇸United States mglaman WI, USA

    But the API response does not yet support pagination. Thoughts?

    Technically it'd still be a subset of the default result without a query string. But I do think getting pagination is going to become important pretty soon

  • First commit to issue fork.
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 63s
    #471320
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1611s
    #471321
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1323s
    #471863
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1690s
    #472811
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1532s
    #472879
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 605s
    #472999
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1865s
    #473004
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1537s
    #473128
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1802s
    #473254
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1931s
    #473289
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1523s
    #473639
  • 🇮🇳India deepakkm

    All the threads are resolved hence moving into review.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 1863s
    #473711
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1624s
    #474249
  • Pipeline finished with Failed
    about 2 months ago
    Total: 3691s
    #474641
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1643s
    #474712
  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1377s
    #475723
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 172s
    #476430
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1942s
    #476435
  • Pipeline finished with Failed
    about 1 month ago
    Total: 3294s
    #476490
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 68s
    #478346
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1978s
    #478347
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1618s
    #478383
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1589s
    #478398
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1707s
    #478421
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1775s
    #479831
  • Pipeline finished with Failed
    about 1 month ago
    Total: 505s
    #479857
  • Pipeline finished with Failed
    about 1 month ago
    Total: 2100s
    #479861
  • Pipeline finished with Failed
    about 1 month ago
    Total: 416s
    #479887
  • Pipeline finished with Failed
    about 1 month ago
    Total: 2249s
    #479892
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Per @penyaskito's review.

  • 🇬🇧United Kingdom catch

    I'm a bit confused why this is a 1.0 blocker, there's already ways to search for content in Drupal. Where are the requirements for this feature documented?

  • Pipeline finished with Failed
    about 1 month ago
    Total: 605s
    #481764
  • 🇫🇮Finland lauriii Finland

    Added some more context to the issue summary.

  • Pipeline finished with Canceled
    about 1 month ago
    #483620
  • Pipeline finished with Failed
    about 1 month ago
    #483621
  • Pipeline finished with Failed
    about 1 month ago
    Total: 10790s
    #483823
  • Pipeline finished with Failed
    about 1 month ago
    Total: 980s
    #484436
  • Pipeline finished with Failed
    about 1 month ago
    Total: 847s
    #484639
  • Pipeline finished with Failed
    about 1 month ago
    #485372
  • Pipeline finished with Failed
    about 1 month ago
    #485397
  • 🇮🇳India deepakkm

    I think its good to go now. Hence moving it in review.

  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    @catch's question in #14 is totally fair. Can we please get the designs we're implementing linked here, @lauriii? 🙏

    See detailed review on the MR. Test coverage is not complete enough yet for this to be mergeable. 😅

  • Pipeline finished with Running
    about 1 month ago
    #485685
  • Pipeline finished with Failed
    about 1 month ago
    #485865
  • Pipeline finished with Failed
    about 1 month ago
    Total: 781s
    #487495
  • 🇮🇳India deepakkm

    created to separate ticket to cover autocomplete feature - https://www.drupal.org/project/experience_builder/issues/3522488 🐛 Entity saved with autosaved data is not respected Active

  • Pipeline finished with Failed
    about 1 month ago
    Total: 848s
    #487633
  • Pipeline finished with Failed
    about 1 month ago
    Total: 703s
    #487647
  • Pipeline finished with Failed
    28 days ago
    Total: 690s
    #488831
  • Pipeline finished with Canceled
    28 days ago
    Total: 66s
    #488866
  • Pipeline finished with Failed
    28 days ago
    Total: 713s
    #488867
  • Pipeline finished with Failed
    28 days ago
    Total: 800s
    #488875
  • Pipeline finished with Running
    28 days ago
    #488911
  • Pipeline finished with Failed
    27 days ago
    #489018
  • Pipeline finished with Failed
    27 days ago
    Total: 7371s
    #489156
  • Pipeline finished with Failed
    27 days ago
    Total: 731s
    #489789
  • Pipeline finished with Failed
    27 days ago
    Total: 884s
    #489797
  • Pipeline finished with Failed
    27 days ago
    Total: 1131s
    #489818
  • Pipeline finished with Failed
    26 days ago
    #489986
  • Pipeline finished with Failed
    26 days ago
    #490080
  • Pipeline finished with Failed
    26 days ago
    Total: 864s
    #490928
  • Pipeline finished with Failed
    26 days ago
    Total: 872s
    #490956
  • Pipeline finished with Running
    25 days ago
    #491170
  • Pipeline finished with Failed
    24 days ago
    Total: 853s
    #492325
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    #19: @deepakkm: Please see my response at 🐛 Entity saved with autosaved data is not respected Active , can you please clarify it?

  • Pipeline finished with Failed
    24 days ago
    Total: 999s
    #492391
  • Pipeline finished with Failed
    24 days ago
    Total: 841s
    #492423
  • Pipeline finished with Failed
    24 days ago
    Total: 678s
    #492434
  • Pipeline finished with Failed
    24 days ago
    Total: 657s
    #492441
  • Pipeline finished with Failed
    23 days ago
    Total: 737s
    #493203
  • Pipeline finished with Failed
    23 days ago
    Total: 807s
    #493208
  • Pipeline finished with Failed
    23 days ago
    Total: 1204s
    #493213
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    The List with search test case of ApiContentControllersList has been failing.

    Also: I found a pretty massive bug which indicates the current test coverage is not adequate.

  • Pipeline finished with Failed
    14 days ago
    Total: 773s
    #500572
  • Pipeline finished with Failed
    14 days ago
    Total: 1795s
    #500584
  • Pipeline finished with Failed
    13 days ago
    Total: 884s
    #500701
  • Pipeline finished with Failed
    13 days ago
    Total: 878s
    #500731
  • Pipeline finished with Failed
    13 days ago
    Total: 776s
    #500774
  • Pipeline finished with Failed
    13 days ago
    Total: 3942s
    #500943
  • Pipeline finished with Canceled
    3 days ago
    Total: 437s
    #509637
  • Pipeline finished with Canceled
    3 days ago
    Total: 204s
    #509642
  • Pipeline finished with Canceled
    3 days ago
    Total: 139s
    #509648
  • Pipeline finished with Failed
    3 days ago
    Total: 796s
    #509650
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    I know the sense of urgency y'all were under, so I spent ~30 mins reviewing this during my PTO today.

    This MR is unfortunately not at all ready.

    1. The tests are still hard failing on SQLite and PostgreSQL. You didn't implement what we agreed upon on Wednesday.
    2. navigation.cy.js is consistently failing on the new test coverage, even after I re-tested it.
    3. The information disclosure security vulnerability I pointed out on May 8 is still present, and the review thread was closed with a non-explanation 😅

    … and that's just the big ones. There's plenty of smaller concerns, most of which I pointed out long ago. I have not yet re-reviewed all closed MR threads, because a bunch seem to have been closed prematurely 🙈

Production build 0.71.5 2024