- Issue created by @mglaman
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Update `\Drupal\experience_builder\Controller\ApiContentControllers::list` to read a `search` query parameter and do a `LIKE` query on the `label` entity key.
If only we had
QUERY
!But at least in this case, the querystring itself should be comparatively tiny, so
?search=hello%20world
will do just fine 👍Note:
ApiContentControllers::list()
may end up finding hundreds of matches. But the API response does not yet support pagination. Thoughts? - 🇺🇸United States mglaman WI, USA
But the API response does not yet support pagination. Thoughts?
Technically it'd still be a subset of the default result without a query string. But I do think getting pagination is going to become important pretty soon
- First commit to issue fork.
- Merge request !887Author should be able to search pages by name in navigation → (Open) created by deepakkm
- 🇮🇳India deepakkm
All the threads are resolved hence moving into review.
- 🇬🇧United Kingdom catch
I'm a bit confused why this is a 1.0 blocker, there's already ways to search for content in Drupal. Where are the requirements for this feature documented?
- 🇫🇮Finland lauriii Finland
Linking designs from ✨ Create a navigation modal for changing pages in the editor Active .
- 🇮🇳India deepakkm
created to separate ticket to cover autocomplete feature - https://www.drupal.org/project/experience_builder/issues/3522488 🐛 Entity saved with autosaved data is not respected Active
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
#19: @deepakkm: Please see my response at 🐛 Entity saved with autosaved data is not respected Active , can you please clarify it?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The
List with search
test case ofApiContentControllersList
has been failing.Also: I found a pretty massive bug which indicates the current test coverage is not adequate.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I know the sense of urgency y'all were under, so I spent ~30 mins reviewing this during my PTO today.
This MR is unfortunately not at all ready.
- The tests are still hard failing on SQLite and PostgreSQL. You didn't implement what we agreed upon on Wednesday.
navigation.cy.js
is consistently failing on the new test coverage, even after I re-tested it.- The information disclosure security vulnerability I pointed out on May 8 is still present, and the review thread was closed with a non-explanation 😅
… and that's just the big ones. There's plenty of smaller concerns, most of which I pointed out long ago. I have not yet re-reviewed all closed MR threads, because a bunch seem to have been closed prematurely 🙈