Allow searching for content in the editor navigation

Update `\Drupal\experience_builder\Controller\ApiContentControllers::list` to read a `search` query parameter and do a `LIKE` query on the `label` entity key.

If only we had QUERY!

But at least in this case, the querystring itself should be comparatively tiny, so ?search=hello%20world will do just fine 👍

Note: ApiContentControllers::list() may end up finding hundreds of matches. But the API response does not yet support pagination. Thoughts?

But the API response does not yet support pagination. Thoughts?

Technically it'd still be a subset of the default result without a query string. But I do think getting pagination is going to become important pretty soon

All the threads are resolved hence moving into review.

wim leers → credited larowlan → .

Per @penyaskito's review.

I'm a bit confused why this is a 1.0 blocker, there's already ways to search for content in Drupal. Where are the requirements for this feature documented?

Added some more context to the issue summary.

I think its good to go now. Hence moving it in review.

@catch's question in #14 is totally fair. Can we please get the designs we're implementing linked here, @lauriii? 🙏

See detailed review on the MR. Test coverage is not complete enough yet for this to be mergeable. 😅

Linking designs from ✨ Create a navigation modal for changing pages in the editor Active .

created to separate ticket to cover autocomplete feature - https://www.drupal.org/project/experience_builder/issues/3522488 🐛 Entity saved with autosaved data is not respected Active

#19: @deepakkm: Please see my response at 🐛 Entity saved with autosaved data is not respected Active , can you please clarify it?

The List with search test case of ApiContentControllersList has been failing.

Also: I found a pretty massive bug which indicates the current test coverage is not adequate.

I know the sense of urgency y'all were under, so I spent ~30 mins reviewing this during my PTO today.

This MR is unfortunately not at all ready.

1. The tests are still hard failing on SQLite and PostgreSQL. You didn't implement what we agreed upon on Wednesday.
2. navigation.cy.js is consistently failing on the new test coverage, even after I re-tested it.
3. The information disclosure security vulnerability I pointed out on May 8 is still present, and the review thread was closed with a non-explanation 😅

… and that's just the big ones. There's plenty of smaller concerns, most of which I pointed out long ago. I have not yet re-reviewed all closed MR threads, because a bunch seem to have been closed prematurely 🙈

Mostly covered everything, but in case something is left do let me know.