deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
Yes @darrenwh , you cannot apply a patch for this module for an older version, you need to apply against dev [1.0.x].
Note: You can update your composer.json to load quickedit module dev version and then apply the patch in extra section and it will work fine.
Created a separate issue 🐛 Quick Edit doesn't support inline editing with ckeditor5 Needs work to cover the 2 pipeline issue and require a fresh set of eyes on them as that has dependency on ckeditor 5 module. Hence moving this ticket into review.
deepakkm → created an issue.
rajeshreeputra → credited deepakkm → .
MediaLibraryTest::testButton() - this tests fail when we uncomment the code for skipping the test, this has dependency on 1 of our custom phpunit tests written because we are also doing similar functionality to test insert media button on ckeditor5 editor.
is there any update on this issue, as this is creating tests to fail frequently now.
@purva_shende There are lot of minor human errors, i would suggest before pushing code kindly run phpcs and phpstan fixes locally.
we need to also update the tests accordingly, updating the test now.
Please remove webmozart/path-util from the composer.json file if it is no longer in use. It is causing a message about "abandoned package" during "composer audit" - this is fixed in the latest release of the module, please see this - https://www.drupal.org/project/composer_deploy/releases/8.x-1.8 →
deepakkm → changed the visibility of the branch 3429433-removed-path-util-package to hidden.
@fgm - synthetic dev version numbers will be shown when we pull the dev released branch of that module , in our case backup_migrate.
When you see i pulled up dev branch of that module and i can see the right versioning in it
This will be fixed as part of this ticket - https://www.drupal.org/project/composer_deploy/issues/3429433 📌 Automated Drupal 11 compatibility fixes for composer_deploy Needs review
deepakkm → made their first commit to this issue’s fork.
Changes looks good to me , hence RTBC
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
MR !343 is now ready for review.
deepakkm → made their first commit to this issue’s fork.
@tedbow - are we good to close this or do we need to work on the 4th issue i.e Test with field that does not use dedicated storage?
i know as per our discussion this was a very rare scenario and not as urgent as others.
deepakkm → created an issue.
Just going through the cypress code and i thought i can do these changes for this ticket to get merged.
@cosmicdreams its a rebase, to actually verify one failure related to cypress test which i see is now fixed. Also it will be helpful for someone to RTBC this issue. I hope this helps.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → changed the visibility of the branch 3471028-Expand-test-coverage-module to hidden.
As of now, users do not have support for revisions, and therefore we cannot write tests for it. To start, we will need to provide support for revisioning in user types. see this - https://git.drupalcode.org/project/experience_builder/-/merge_requests/3...
worked on these issues
1.
https://www.drupal.org/project/eu_cookie_compliance/issues/3430336
📌
Automated Drupal 11 compatibility fixes for eu_cookie_compliance
Fixed
2.
https://www.drupal.org/project/eu_cookie_compliance/issues/3408084
📌
Add gitlab CI
Needs work
and raised couple of issues to fix validate and phpunit for this module , also i'm constantly in touch with @svenbergryen for the D11 release.
deepakkm → created an issue.
I think the changes looks good wrt to this ticket. Moving this to RTBC
deepakkm → created an issue.
deepakkm → created an issue.
deepakkm → created an issue.
@tedbow Thanks for reviewing , @wim yes only 2 of them is done in this but as per discussion between me and ted this will go in pieces.
Once this MR is merged I’m going to open another MR for 1 of those tests. Hope that makes sense.
And yes this shouldn’t be RTBC’ed 😜
Hello @japerry - Are there any reasons why credit is not given for this issue, considering that the merged commit was made by me?
Picking this up and assigning to myself
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
Feedback changes done.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
Hello @japerry - any reason credits are not given for reporting the ticket
deepakkm → created an issue.
deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → changed the visibility of the branch 3450893-automated-drupal-11-fix to hidden.
deepakkm → made their first commit to this issue’s fork.
deepakkm → changed the visibility of the branch project-update-bot-only to hidden.
deepakkm → made their first commit to this issue’s fork.
The phpstan fixes are done here in a separate commit - https://www.drupal.org/project/config_update/issues/3465396 📌 Fix validate pipeline Needs review
@VladimirAus - i dont think we should fix the issues related to phpunit 11 here as those are shown in
phpstan (next major)
, but i would leave this call to maintainer whether that should be done here or not.
@ankitv18 when we have already created a separate ticket to fix eslint then its better to fix the issue rather than skipping it
there is already a seperate ticket 📌 Fix validate pipeline Needs review created to fix those as those deprecations are soft in phpunit 10.5 and will be removed from phpunit 11 .
deepakkm → changed the visibility of the branch 3450893-automated-drupal-11-fixes to hidden.
deepakkm → made their first commit to this issue’s fork.
deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
Pipeline is now green , hence requesting review.