Account created on 9 December 2014, over 10 years ago
  • Software engineer at Acquia 
#

Merge Requests

More

Recent comments

🇮🇳India deepakkm

I have no idea now as to how to fix this random cypress failure [component-operation.cy.js] though i reran this test but it still fails and passes locally as shown in the screenshot.

🇮🇳India deepakkm

So right now there are 3 cypress tests failing and i have no idea why these tests are failing. No idea how i can move forward in fixing those. The major problem i have in setting up my cypress test is the XbSetup is throwing error.

Though looking for a way forward on this.

🇮🇳India deepakkm

This is now good for review. The failing pipeline in cypress test is not part of the changes done in this MR.

🇮🇳India deepakkm

The pipeline passed - https://git.drupalcode.org/issue/experience_builder-3516432/-/pipelines/..., when the work was done. but failed after a rebase done from another person and i may know why because of the major changes introduced in ApiLayoutController.

I'll update the test case for this once.

but the actual update in gitlab file goes to this issue - https://www.drupal.org/project/experience_builder/issues/3518292 Allow searching for content in the editor navigation Active , where pipeline failing for 1 and passes for another , i'll update the gitlab file for that. Thanks

🇮🇳India deepakkm

Adding screenshot for single and multiple asset. I do see it just gives around 7-8 assets in result but takes around 2 sec which is still higher in number

🇮🇳India deepakkm

Agree to it that this should be under a feature but not as bug. As it was never worked upon earlier.

🇮🇳India deepakkm

Yes the result count should be 0 in this scenario thats what i meant by saying "However, when we search for 'Untitled Page,' we only get one result, which should not be the case."

🇮🇳India deepakkm

created to separate ticket to cover autocomplete feature - https://www.drupal.org/project/experience_builder/issues/3522488 🐛 Entity saved with autosaved data is not respected Active

🇮🇳India deepakkm

I think its good to go now. Hence moving it in review.

🇮🇳India deepakkm

All the threads are resolved hence moving into review.

🇮🇳India deepakkm

Hello @japerry - we have validated all scenarios and we are good to go with this changes and we are actually catching all the exception and hence i don't think we would require those additional handling of errors. I believe throwing only dam exception should be good to go.

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

@japerry - do you suggest we create the default view mode on hook_ENTITY_TYPE_insert()?

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

deepakkm changed the visibility of the branch 3508635-entity-browser-to-media-library to hidden.

🇮🇳India deepakkm

Pipeline is now green, hence moving in review.

🇮🇳India deepakkm

I think due to the rebase the changes were lost from gitlab CI file, may be the rebase was incorrect.

🇮🇳India deepakkm

Changes looks good to me and verified locally too, hence RTBC'ed

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

this has been taken care in the latest commit as we have handled the situation on the basis of media source now.

If you attempt to create a new media type from Acquia DAM with source Acquia DAM: Video and named "DAM Remote Video" with the machine name "dam_remote_video" it fail to work as expected. This is because the bundle name doesn't align with the predefined one, "acquia_dam_video_asset".

🇮🇳India deepakkm

This issue doesn't replicate on branch 1.0.x, if you read the description of the issue this was working until 1.1.0-rc1 but due to certain commit it started failing and hence this was fixed for 1.1.x branch.

🇮🇳India deepakkm

deepakkm changed the visibility of the branch 3500257-no-revision to hidden.

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

Production build 0.71.5 2024