Account created on 9 December 2014, over 10 years ago
  • Software engineer at Acquia 
#

Merge Requests

More

Recent comments

🇮🇳India deepakkm

Hello @japerry - we have validated all scenarios and we are good to go with this changes and we are actually catching all the exception and hence i don't think we would require those additional handling of errors. I believe throwing only dam exception should be good to go.

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

@japerry - do you suggest we create the default view mode on hook_ENTITY_TYPE_insert()?

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

deepakkm changed the visibility of the branch 3508635-entity-browser-to-media-library to hidden.

🇮🇳India deepakkm

Pipeline is now green, hence moving in review.

🇮🇳India deepakkm

I think due to the rebase the changes were lost from gitlab CI file, may be the rebase was incorrect.

🇮🇳India deepakkm

Changes looks good to me and verified locally too, hence RTBC'ed

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

this has been taken care in the latest commit as we have handled the situation on the basis of media source now.

If you attempt to create a new media type from Acquia DAM with source Acquia DAM: Video and named "DAM Remote Video" with the machine name "dam_remote_video" it fail to work as expected. This is because the bundle name doesn't align with the predefined one, "acquia_dam_video_asset".

🇮🇳India deepakkm

This issue doesn't replicate on branch 1.0.x, if you read the description of the issue this was working until 1.1.0-rc1 but due to certain commit it started failing and hence this was fixed for 1.1.x branch.

🇮🇳India deepakkm

deepakkm changed the visibility of the branch 3500257-no-revision to hidden.

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

🇮🇳India deepakkm

There are still many conflicts which needs to be resolved. Hence moving to needs work

🇮🇳India deepakkm

This is now merged , i think we can change the status of this ticket.

🇮🇳India deepakkm

Yes @darrenwh , you cannot apply a patch for this module for an older version, you need to apply against dev [1.0.x].

Note: You can update your composer.json to load quickedit module dev version and then apply the patch in extra section and it will work fine.

🇮🇳India deepakkm

Created a separate issue 🐛 Quick Edit doesn't support inline editing with ckeditor5 Needs work to cover the 2 pipeline issue and require a fresh set of eyes on them as that has dependency on ckeditor 5 module. Hence moving this ticket into review.

🇮🇳India deepakkm

MediaLibraryTest::testButton() - this tests fail when we uncomment the code for skipping the test, this has dependency on 1 of our custom phpunit tests written because we are also doing similar functionality to test insert media button on ckeditor5 editor.

🇮🇳India deepakkm

is there any update on this issue, as this is creating tests to fail frequently now.

🇮🇳India deepakkm

@purva_shende There are lot of minor human errors, i would suggest before pushing code kindly run phpcs and phpstan fixes locally.

🇮🇳India deepakkm

Please remove webmozart/path-util from the composer.json file if it is no longer in use. It is causing a message about "abandoned package" during "composer audit" - this is fixed in the latest release of the module, please see this - https://www.drupal.org/project/composer_deploy/releases/8.x-1.8

🇮🇳India deepakkm

deepakkm changed the visibility of the branch 3429433-removed-path-util-package to hidden.

🇮🇳India deepakkm

@fgm - synthetic dev version numbers will be shown when we pull the dev released branch of that module , in our case backup_migrate.
When you see i pulled up dev branch of that module and i can see the right versioning in it

🇮🇳India deepakkm

This will be fixed as part of this ticket - https://www.drupal.org/project/composer_deploy/issues/3429433 📌 Automated Drupal 11 compatibility fixes for composer_deploy Needs review

🇮🇳India deepakkm

Changes looks good to me , hence RTBC

🇮🇳India deepakkm

deepakkm made their first commit to this issue’s fork.

Production build 0.71.5 2024