All the threads are resolved hence moving into review.
deepakkm → made their first commit to this issue’s fork.
Looks good
ankitv18 → credited deepakkm → .
deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
Hello @japerry - we have validated all scenarios and we are good to go with this changes and we are actually catching all the exception and hence i don't think we would require those additional handling of errors. I believe throwing only dam exception should be good to go.
deepakkm → made their first commit to this issue’s fork.
deepakkm → created an issue.
deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
Pipeline is now passing, hence moving ahead for review.
deepakkm → made their first commit to this issue’s fork.
@japerry - do you suggest we create the default view mode on hook_ENTITY_TYPE_insert()?
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → changed the visibility of the branch 3508635-entity-browser-to-media-library to hidden.
deepakkm → made their first commit to this issue’s fork.
Pipeline is now green, hence moving in review.
I think due to the rebase the changes were lost from gitlab CI file, may be the rebase was incorrect.
Changes looks good to me and verified locally too, hence RTBC'ed
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
deepakkm → made their first commit to this issue’s fork.
Kindly review MR !118
deepakkm → changed the visibility of the branch 3501895-bulk-import-existing to hidden.
deepakkm → changed the visibility of the branch 3501895-bulk-import-existing to hidden.
deepakkm → made their first commit to this issue’s fork.
this has been taken care in the latest commit as we have handled the situation on the basis of media source now.
If you attempt to create a new media type from Acquia DAM with source Acquia DAM: Video and named "DAM Remote Video" with the machine name "dam_remote_video" it fail to work as expected. This is because the bundle name doesn't align with the predefined one, "acquia_dam_video_asset".
This issue doesn't replicate on branch 1.0.x, if you read the description of the issue this was working until 1.1.0-rc1 but due to certain commit it started failing and hence this was fixed for 1.1.x branch.
Since this is merged can someone close this ticket
deepakkm → created an issue.
deepakkm → created an issue.
verified changes hence RTBC
deepakkm → changed the visibility of the branch 3500257-no-revision to hidden.
deepakkm → created an issue.
deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
deepakkm → created an issue.
ankitv18 → credited deepakkm → .
ankitv18 → credited deepakkm → .
ankitv18 → credited deepakkm → .
rajeshreeputra → credited deepakkm → .
rajeshreeputra → credited deepakkm → .
deepakkm → made their first commit to this issue’s fork.
rajeshreeputra → credited deepakkm → .
rajeshreeputra → credited deepakkm → .
deepakkm → made their first commit to this issue’s fork.
There are still many conflicts which needs to be resolved. Hence moving to needs work
ankitv18 → credited deepakkm → .
ankitv18 → credited deepakkm → .
rajeshreeputra → credited deepakkm → .
deepakkm → created an issue.
This is now merged , i think we can change the status of this ticket.
deepakkm → created an issue.
deepakkm → made their first commit to this issue’s fork.
Yes @darrenwh , you cannot apply a patch for this module for an older version, you need to apply against dev [1.0.x].
Note: You can update your composer.json to load quickedit module dev version and then apply the patch in extra section and it will work fine.
Created a separate issue 🐛 Quick Edit doesn't support inline editing with ckeditor5 Needs work to cover the 2 pipeline issue and require a fresh set of eyes on them as that has dependency on ckeditor 5 module. Hence moving this ticket into review.
deepakkm → created an issue.
rajeshreeputra → credited deepakkm → .
MediaLibraryTest::testButton() - this tests fail when we uncomment the code for skipping the test, this has dependency on 1 of our custom phpunit tests written because we are also doing similar functionality to test insert media button on ckeditor5 editor.
is there any update on this issue, as this is creating tests to fail frequently now.
@purva_shende There are lot of minor human errors, i would suggest before pushing code kindly run phpcs and phpstan fixes locally.
we need to also update the tests accordingly, updating the test now.
Please remove webmozart/path-util from the composer.json file if it is no longer in use. It is causing a message about "abandoned package" during "composer audit" - this is fixed in the latest release of the module, please see this - https://www.drupal.org/project/composer_deploy/releases/8.x-1.8 →
deepakkm → changed the visibility of the branch 3429433-removed-path-util-package to hidden.
@fgm - synthetic dev version numbers will be shown when we pull the dev released branch of that module , in our case backup_migrate.
When you see i pulled up dev branch of that module and i can see the right versioning in it