Add test coverage for access exception in \Drupal\experience_builder\ClientDataToEntityConverter::checkPatchFieldAccess

Needs work for phpstan and probably improve the tests. I think the e2e test are broken in HEAD but since this is only phpunit test changes, it could probably committed while they are still broken

Should the parent be 📌 SdcController cleanup tasks Active so it can be properly tracked?

sound right

Phpunit tests are passing now.

Only failures are playwright(Lee is fixing it in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1142) and cypress e2e tests(component-operations.cy.js random failure).

Also I couldn't remove Draft from the MR so I am assuming only @tedbow can do that.

🐛 Page status changes from "Published" to "Changed" even when no actual changes are made Active causes the need for a reroll here; will take care of that for you.

This relates to this other test-coverage-only issue merged earlier today: 📌 Assert fields the user can't access aren't sent in ApiLayoutController::get Active .

@tedbow Please address your own @todo, then merge when you think this is ready 🙏🚢

See MR comments. It looks good to me

Not passing tests yet: https://git.drupalcode.org/project/experience_builder/-/pipelines/532530...

@wim leers see my MR for my reasoning as to why I removed the failing test and suggested moving it to 📌 Add field access check on `ApiAutoSaveController::post()` Active . I also commented on that issue

this issue still have test coverage for Drupal\experience_builder\ClientDataToEntityConverter::checkPatchFieldAccess which was the original scope

I think issue is good. See my MR comment about moving a test to 📌 Add field access check on `ApiAutoSaveController::post()` Active and the change I reverted because it made entity-form-field-types-test.cy.js fail. I will merge it

🥳

Automatically closed - issue fixed for 2 weeks with no activity.