- Issue created by @larowlan
- Assigned to larowlan
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Thanks for the review!
- I think everybody would agree all of the things you listed should happen eventually.
- But they should not be required to happen now.
We need to be able to iterate quickly, without accumulating enormous MRs like we tend to do in Drupal core. In Drupal core this makes sense because it's already a consistent whole, but that's not yet true for Experience Builder.
In other words: for XB, we intentionally want to avoid the "every commit must be perfect" strategy that Drupal core uses.I acknowledge this means outside participation is more difficult: what is in a "ready for detailed review" state vs "slapped together, don't bother to review" state? So I think that is the challenge we should solve rather than disallowing imperfect/incomplete MRs to be reviewed.
So I propose to introduce a way to convey this. Ideas:
- an impossible to miss
// โ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธ // โ ๏ธ ๐จ๐งน This file is an early iteration. Do not review in detail yet. ๐งน๐จ โ ๏ธ // โ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธโ ๏ธ
at the top of the file
- Issues like the one you created here make for excellent Novice tasks! ๐ So it's not like this is a wasted effort at all. Perhaps we should even intentionally call this out, by adding comments like
// @todo Novice: inject service
,// @todo Novice: introduce new permission
, et cetera? - introduce
src-rough
(back end) andui/src-rough
(front end) directories - โฆ something else?
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Started adopting #4.1: https://git.drupalcode.org/project/experience_builder/-/merge_requests/2... ๐ค
- Assigned to wim leers
- Status changed to Postponed
6 months ago 12:44pm 23 September 2024 - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
I'm going to update the issue summary to outline, to make this a great issue to sprint on at DrupalCon Barcelona :)
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Nobody picked this up during DrupalCon. Narrowing scope. Removing dead routes should happen in ๐ Lift all methods out of `SdcController` into separate invokable services-as-controllers Needs work .
- Issue was unassigned.
- Status changed to Active
29 days ago 6:29pm 5 March 2025 - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Discussed this in detail with @lauriii. Converting this to a meta issue instead.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Refinements:
- Added: (as in: XB
Component
config entities) - Put on hold, see issue summary for details.
- Put on hold, see issue summary for details.
- Added: (as in: XB
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
is a persona that did not exist until now. It's the in the Drupal CMS personas โ .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Closed ๐ Gate editing global regions behind 'administer blocks' permission in the UI Active in favor of this issue.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Updating XB's docs per #12: https://git.drupalcode.org/project/experience_builder/-/merge_requests/828
(This updates the docs that ๐ [PP-1] Diagram tying the product requirements + decisions together Postponed introduced.)
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Oversights in ๐ Provide granular permissions for pages Active clarified by @lauriii. ๐
-
wim leers โ
committed 682c3ffb on 0.x
Issue #3452581 by wim leers, larowlan, lauriii: [META] XB Permissions
-
wim leers โ
committed 682c3ffb on 0.x
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Another important oversight spotted while refining the issue summary for #3508694: #3508694-14: Permissions for XB config entity types โ , asked @lauriii to confirm.