SdcController cleanup tasks

Created on 5 June 2024, 10 months ago

Problem/Motivation

https://git.drupalcode.org/project/experience_builder/-/merge_requests/33 added SdcController to provide a skeleton of backend listings.
In a retrospective review a few issues were flagged

Steps to reproduce

Proposed resolution

* Add typehinting to the closure in getComponentsList
* Make ::components return a CacheableJsonResponse
* Make ::component make use of ComponentPluginManager::find instead of building the full list only to throw it away
* Make ::component return a CacheableJsonResponse
* Make ::renderComponent use ComponentPluginManager::find
* Make ::renderComponent return a CacheableJsonResponse
* Make ::populatePropValues make use of early returns
* Move ::populatePropValues out of the controller into a service or singleton
* Add test coverage

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Active

Component

Page builder

Created by

๐Ÿ‡ฆ๐Ÿ‡บAustralia larowlan ๐Ÿ‡ฆ๐Ÿ‡บ๐Ÿ.au GMT+10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024