Disallow deleting an XB-enabled content entity if it's currently the homepage

This looks like a solid plan. We can do this in XB first but this is probably something core should handle for us. Ideally, even the "bypass node access" wouldn't be able to bypass this but we can leave that to the core issue.

Would be good to create the issues for the XB UI work as well.

Since there is no entitylistbuilder implementation for xb page content type, I went ahead with the approach I could think of. @wim leers please let me know if this is okay or should I create a entitylistbuilder and make the changes accordingly?
Thank you!

Thanks for your work on this, @anjali rathod! 🙏

#6: just add

    'list_builder' => EntityListBuilder::class,

to the Page content entity type 😊

Also reviewed the MR! 🏓

Adding screenshots for how the navigation menu for a page set as homepage looks and how the navigation menu for a page not set as homepage looks like..

I have removed the set as homepage link along with the delete page link from navigation menu for the page set as homepage. For other pages there is no changes.

roshni upadhyay → made their first commit to this issue’s fork.

Reviewed. To note, some parts of this were expected to happen in ✨ Create React Permission Utilities Active and 📌 Update `ApiContentControllers::list()` to expose available content entity operations in `meta` Active Tempted to postpone on those.

Significant parts of feedback have not yet been addressed, and it's still unnecessarily making private APIs public.

This was marked but CI is not passing.

The sole failure is
Drupal\Tests\experience_builder\Functional\XbContentEntityHttpApiTest::testList():

 Array (
-    0 => 'experience_builder__auto_save'
-    1 => 'http_response'
-    2 => 'xb_page_list'
+    0 => 'config:system.site'
+    1 => 'experience_builder__auto_save'
+    2 => 'http_response'
+    3 => 'xb_page:1'
+    4 => 'xb_page:2'
+    5 => 'xb_page:3'
+    6 => 'xb_page_list'
 )

but … this is still using the approach I pushed back against >1 months ago. My feedback from April 10 has not been addressed.

Independently of me, @penyaskito posted similar observations in #12.

Updated proposed resolution now that 📌 Update `ApiContentControllers::list()` to expose available content entity operations in `meta` Active landed.

wim leers → closed merge request !768

#19++ — thanks, @penyaskito! 🙏

Closed the existing MR 768 because per #19: a lot is different now :)

(Plus, keeping commit history since March around is going to make things unnecessarily painful. Just copy over whatever bits are relevant. Credited @anjali rathod for their many commits to that MR.)

This does not seem like a beta blocker to me?

Thanks! Much simpler now! 🥳

At minimum, cacheability is missing from the access results (and hence the test coverage).

@wim-leers I've responded to your comments, can you plz check once?

Marking needs review so we can discuss if cacheability is needed for a non-cacheable HTTP method

Removing needs follow-up, ✨ Create React Permission Utilities Active exists already.

I contributed significantly to this, so @mglaman will do another review pass before passing this to Wim.

RTBCing.

📌 Ensure duplicated pages don't retain path alias of original entity Active landed and conflicts with this. 🫣

Was going to merge, then spotted one last bug: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... 😅

I’m okay with not adding test coverage, if you apply the suggestion and agree with that proposal 😇

+1. Added a test.

Automatically closed - issue fixed for 2 weeks with no activity.