- π«π·France andypost
Ludwig already mentioning that it should be replaced, so asked how to backport route in #3377094-17: Retire Ludwig? β
- π¬π§United Kingdom catch
Splitting into two seems like a good idea. If Ludwig doesn't use any of the routes etc. , I think we could still remove those, and those are the confusing parts.
- π¬π§United Kingdom longwave UK
I was about to post that I think we can and should remove all this without deprecation, but after spending a long time in GitLab search without finding anything useful except duplicate copies of core, I did spot that Ludwig β uses some of the FileTransfer classes, and the module has 11,000 users so I'm not sure we can just drop all of this.
In terms of the UI we believe that nobody is using these features; we don't get any bug reports or support requests about them that I have seen. We do still have users that update without Composer - I see them in the issue queue from time to time - but they still don't use this UI.
Perhaps we can split this into two issues? One to decide what to do about the strictly UI related parts - either we disable a lot of it and add deprecation notices, or outright remove it - and a followup where we deprecate FileTransfer and some of the related parts?
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- πΊπΈUnited States dww
Re #31 : Indeed, see #12 where π Investigate ModuleHandler::add Active was added as related. π
- π¨π¦Canada Charlie ChX Negyesi πCanada
--- a/core/authorize.php +++ /dev/null
The people who quietly work on removing
ModuleHandler::add*
love this quite a bit. Please go ahead and make our lives (much) easier, thanks. - π¬π§United Kingdom catch
I think if we're removing the entire capability then whether we deprecated one API method or not already is not going to matter.
So the one question here is should we make an exception to the BC/continuous upgrade policy to remove this wholesale in 11.2, on the basis that we think noone uses it, it probably doesn't work, and that it directly conflicts with features in Drupal CMS.
For me the answer to that is yes but will ping other committers for more +1s.
- πΊπΈUnited States dww
Cool, thanks @catch.
Would a release manager be willing to:
a) Respond to comment #19 π - Can we really remove stuff in 11.2 that we deprecated in 11.1 for removal in 12?
b) Make a formal decision on what's happening here.
c) Remove the 'Needs release manager review' tag.?
Also, do we need product manager review? If so, is that effectively Gabor or Lauri at this point? Should I try to ping them via Slack?
Thanks!
-Derek - π«π·France andypost
Looks it still blocked on π Replace \PDO::FETCH_* constants to indicate fetch mode with an enumeration Active
- π³π±Netherlands daffie
β¨ [PP-1] Introduce a Connection::executeDdlStatement method Active has landed.