+1, also ran into this issue.
Same PHP & module combinations as mentioned previously.
Good catch Marcos!
Tested, looks good :)
Yep just ran into this issue myself today.
I like the addition of having the dynamic slide count as well. I never really use the macro outside of the UI kit but i think its a welcomed addition. :)
Thanks for submitting the patch Marcos!
aaronchristian → made their first commit to this issue’s fork.
pameeela → credited AaronChristian → .
+1 working for me too.
@Alex_web please check out this issue;
https://www.drupal.org/project/bootstrap_layout_builder/issues/3157194#c... →
Or you can apply another patch to remove the layout requirement altogether (all layouts need to equal 12, but you need it to be a multiple of 12).
https://www.drupal.org/project/bootstrap_layout_builder/issues/3157194#c... →
@HeneryH please check this issue comment here from a few years ago;
https://www.drupal.org/project/bootstrap_layout_builder/issues/3157194#c... →
Thanks @jastraat for picking this up so long after the creation of this issue!
I did try to test the patch but received some errors in doing so;
TypeError: Drupal\section_library\Form\AddSectionToLibraryForm::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php on line 99 in Drupal\section_library\Form\AddSectionToLibraryForm->__construct() (line 88 of /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php).
Wondering if maybe there is still some of the other patch being caught up in the mix here.
I also tried to apply patch #5 but got this error;
TypeError: Drupal\section_library\Form\AddSectionToLibraryForm::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php on line 99 in Drupal\section_library\Form\AddSectionToLibraryForm->__construct() (line 88 of /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php).
Going to mark this as "Needs work" for the time being.
If you manage to sort things out feel free to post back and I'll give it another test.
Thanks again!!!
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
Love the new pin/scrub feature. Nice work @b_sharpe
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
@flyke this has been updated with the latest tagged release 1.1.5 now.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
@Mohd Unfortunately the MR did not fix the problem.
It actually is due to the foreach and if statement being combined in one statement.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
AaronChristian → created an issue.
@chike, sorry for the delay.
This has been fixed and pushed up to the latest 1.0.x branch.
Updating short description for Bootstrap Layout Builder → .
AaronChristian → created an issue.
Thanks @chike, i'll add this to my to-do list this week.
AaronChristian → created an issue.
Ahhh nice catch @ tpzurdo.
Thanks @carolpettirossi and @hfernandes, yep confirmed that this morning.
Thanks for the contributions back everyone.
Marking as RTBC, and I'll get this one merged into dev as well.