🇨🇦Canada @AaronChristian

I tested this, however I still get the warnings in my drush console when using a deploy script to import my content.

Confirming #43 Still works on 10.4.6

Using layout builder, paragraphs, content moderation & entity reference revisions.

@rbrandon, just tested and it works well, but it looks like you're missing the route to the settings form in the last MR.

password_policy.settings:
  path: '/admin/config/security/password-policy/settings'
  defaults:
    _form: '\Drupal\password_policy\Form\SettingsForm'
    _title: 'Password Policy Settings'
  requirements:
    _permission: 'administer site configuration'

aaronchristian → created an issue.

Did a bit more testing, looks like some paragraphs don't get included on the export of one of my content blocks.

Lets take this one back as it looks like it needs a bit more work!

Tested the patch on Drupal 10.4.2. It applied cleanly, and it fixed the frontend. However when trying to edit any menus i received the following error:

Drupal\Core\Database\InvalidQueryException: Query condition 'parent IN ()' cannot be empty. in Drupal\Core\Database\Query\Condition->condition() (line 108 of core/lib/Drupal/Core/Database/Query/Condition.php).

I tried the other patch and got things to work along with a bit of extra twig logic.

https://www.drupal.org/project/drupal/issues/3456536#comment-16000668 🐛 show as expanded is forced to true if menu item has children and you are on child trail Active

This seems to fix the issue for me.

Previously {{ item.is_expanded }} was being forced to true when on the active menu item.

Debugging it reveals false when on the active menu item and it has children, even when its not set to "expanded".

" alt="Expanded - True" />

After applying the patch;

And then just to ensure your menu doesn't print out, ensure you have some logic like;

{% if item.below and item.is_expanded %}
  {{ menus.menu_links(item.below, attributes, menu_level + 1, item) }}
{% endif %}

Thanks for the patch!

@igorgoncalves

This worked really well, thanks for making this a priority this week my friend!

I tested this on all the various places I was able to crash the export previously and they all seem to work as expected.

I'll keep my eye on the "partial export" feature, I think that will be the game changer for this module.

Thanks for the exception module, its always been a HUGE pain point of Drupal, I'm glad there are people out there pushing initiatives like this through for the community.

I'll leave this one open for a bit for others to test with the supplied file I posted above, and then with the patch in place.

Looks good from my side, I would be happy to mark this one as RTBC in the next few days as I work through some more use cases.

Thanks for looking into this one @jannakh.

I had a few patches applied previously so my errors line numbers might have been off, I removed them and started with a fresh install of 1.4.10 and am still noticing a failure on export. The patch seems to address import, and that works as expected, but on the export it fails.

I have a legacy site that has a lot of nodes with a number of paragraphs with links in each of them. When I uncomment lines 116-134 and run the export it actually processes the page and when it finally finishes loading I see it loads all the nodes and their fields, so my file for a single page was over 19MB!

I've attached a really basic file you can test with to reproduce the issue.

This is just menu_link_content, but for some reason it will load the whole referenced node and all its fields. Is it necessary to load all the embedded entities and their field values for links?

Thanks!

Thanks for testing @borg_git

For some reason I'm still encountering this error, even outside of CKEditor.

Here's a menu link im trying to export.

I see the patch doesnt apply anymore, i'm working on a fix, should have something in the next few days to clean things back up.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

Before:

After:

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue. See original summary → .

aaronchristian → created an issue. See original summary → .

aaronchristian → created an issue.

Thanks @pinesso,

This is fixed in the dev branch now!

aaronchristian → created an issue. See original summary → .

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

aaronchristian → created an issue.

Correction, it looks like the media element never gets installed because the bundle type changed.

The field_entity_reference_paragraph entity reference field (entity_type: block_content, bundle: ixm_blocks_hero) no longer has any valid bundle it can reference. The field is not working correctly anymore and has to be adjusted.

Yep, we have this internally working with webpack/yarn as well.

I need to find the time to port this over, shouldn't take too long though!

+1, also ran into this issue.

Same PHP & module combinations as mentioned previously.

Good catch Marcos!

Tested, looks good :)

Yep just ran into this issue myself today.

I like the addition of having the dynamic slide count as well. I never really use the macro outside of the UI kit but i think its a welcomed addition. :)

Thanks for submitting the patch Marcos!

aaronchristian → made their first commit to this issue’s fork.

pameeela → credited AaronChristian → .

+1 working for me too.

@Alex_web please check out this issue;

https://www.drupal.org/project/bootstrap_layout_builder/issues/3157194#c... →

Or you can apply another patch to remove the layout requirement altogether (all layouts need to equal 12, but you need it to be a multiple of 12).

https://www.drupal.org/project/bootstrap_layout_builder/issues/3157194#c... →

@HeneryH please check this issue comment here from a few years ago;

https://www.drupal.org/project/bootstrap_layout_builder/issues/3157194#c... →

Thanks @jastraat for picking this up so long after the creation of this issue!

I did try to test the patch but received some errors in doing so;

TypeError: Drupal\section_library\Form\AddSectionToLibraryForm::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php on line 99 in Drupal\section_library\Form\AddSectionToLibraryForm->__construct() (line 88 of /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php).

Wondering if maybe there is still some of the other patch being caught up in the mix here.

I also tried to apply patch #5 but got this error;

TypeError: Drupal\section_library\Form\AddSectionToLibraryForm::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php on line 99 in Drupal\section_library\Form\AddSectionToLibraryForm->__construct() (line 88 of /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php).

Going to mark this as "Needs work" for the time being.

If you manage to sort things out feel free to post back and I'll give it another test.

Thanks again!!!

AaronChristian → created an issue.

AaronChristian → created an issue.

AaronChristian → created an issue.

AaronChristian → created an issue.

AaronChristian → created an issue.

Love the new pin/scrub feature. Nice work @b_sharpe