Allow filtering between "Section" & "Template" within offcanvas & modal screen

I'm attaching a patch that integrates the MR's changes with the latest dev of section_library. Unfortunately I could not make changes to the MR directly. This also does not resolve the two last issues.

Updated patch that pre-filters template type based on the import link clicked. Still haven't figured out how to get the ajax modal to close after adding a template.

And finally figured out the dialog closing issue. This latest patch addresses both of the outstanding issues mentioned in #3.

Sorry - that earlier patch included some changes from another section_library patch I have applied.
Here's a clean one.

Thanks @jastraat for picking this up so long after the creation of this issue!

I did try to test the patch but received some errors in doing so;

TypeError: Drupal\section_library\Form\AddSectionToLibraryForm::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php on line 99 in Drupal\section_library\Form\AddSectionToLibraryForm->__construct() (line 88 of /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php).

Wondering if maybe there is still some of the other patch being caught up in the mix here.

I also tried to apply patch #5 but got this error;

TypeError: Drupal\section_library\Form\AddSectionToLibraryForm::__construct(): Argument #4 ($module_handler) must be of type Drupal\Core\Extension\ModuleHandler, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php on line 99 in Drupal\section_library\Form\AddSectionToLibraryForm->__construct() (line 88 of /var/www/web/modules/contrib/section_library/src/Form/AddSectionToLibraryForm.php).

Going to mark this as "Needs work" for the time being.

If you manage to sort things out feel free to post back and I'll give it another test.

Thanks again!!!

Hey @AaronChristian thank you for testing! Just to make sure, did you fully clear the Drupal cache after applying the patch? This injects a new service to check for layout_builder_modal.

@jastraat would the patch benefit from a update hook to clear the cache?

Adding a patch with a post-update hook to automatically clear the cache and pick up the updated form dependencies.

I'm afraid my last few patches were corrupted. Here's a new patch with the changes from patch 7 + a post update hook to clear the cache and prevent the error @AaronChristian saw.

jastraat → closed merge request !30