Eugene, OR
Account created on 20 July 2010, almost 15 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States dmundra Eugene, OR

Thank you @jminarick. I see GitLab CI run. Probably will need a follow-up ticket to clear the phpcs and related items.

🇺🇸United States dmundra Eugene, OR

Thank you @theloneliestmonk. I see GitLab CI run. Probably will need a follow-up ticket to clear the phpcs and related items.

🇺🇸United States dmundra Eugene, OR

Thank you @theloneliestmonk. I see GitLab CI run. Probably will need a follow-up ticket to clear the phpcs and related items.

🇺🇸United States dmundra Eugene, OR

Thank you @majorrobot. I can see the GitLab CI run. Hi @jaydarnell, probably will need a follow-up ticket to fix phpcs and related issues.

🇺🇸United States dmundra Eugene, OR

Thank you @jminarick. I can see the GitLab CI pipeline run.

🇺🇸United States dmundra Eugene, OR

Thank you @jastraat. I can see the GitLab CI pipeline run without issue.

🇺🇸United States dmundra Eugene, OR

This is a great module. Wanted to boost it with adding tugboat and gitlab CI.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Adding a preview site to check out the module but also useful for testing future changes.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

The gitlab-ci will allow tests to run to confirm Drupal 11 compatibility. Cleaned up version to be consistent with other modules and also the composer file.

Attaching a patch for users who want to include the update in the composer.json file as well.

I hid the other branches to focus on https://git.drupalcode.org/project/views_tree/-/merge_requests/14

🇺🇸United States dmundra Eugene, OR

dmundra changed the visibility of the branch 3485947-drupal-11-compatibility to hidden.

🇺🇸United States dmundra Eugene, OR

dmundra changed the visibility of the branch 3485947-update-compatibility to hidden.

🇺🇸United States dmundra Eugene, OR

Tests are failing but gitlab CI is working so this can move forward to review and merged and then follow-up tickets created to fix the tests and issues but that is up to the maintainer.

🇺🇸United States dmundra Eugene, OR
🇺🇸United States dmundra Eugene, OR

Failing tests but gitlab CI is working.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Tests are failing but gitlab CI is running and I had to delete the composer.lock file and edit the composer.json (added description) to pass some minor checks that seem appropriate to go with the gitlab CI file.

🇺🇸United States dmundra Eugene, OR

Tests are failing but gitlab CI is running.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR
🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Interesting the .gitlab-ci.yml ran all the linters but not the tests.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Thank you @cmlara. Your questions are appropriate. Another related module is looking at setting up tugboat previews to configure them with enough setup to be useful for testing https://www.drupal.org/project/field_encrypt/issues/3512408 📌 Tugboat preview should configure field_encrypt Active

Is code updated when new code is pushed? If so are these new environments or continuations of the previous environment?

Yes tugboat is updated whenever code is pushed to the open merge request.

We think having the previews would lower the barriers for folks to help test changes especially if there is enough setup already done for them or instructions provided to do that setup.

I think you are right, usefulness will differ module to module so it really up to you and the folks who are invested in this module.

Those are my thoughts.

🇺🇸United States dmundra Eugene, OR

Followed https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... to add the config. Had to close and re-open the merge request to have it show up on the branch but it did once I did that.

Look for 'View live preview' via Tugboat under the branch name. The preview stays up for 5 days after that the MR will need to be closed and reopened.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Fixed the tests.

🇺🇸United States dmundra Eugene, OR

You should see the tugboat preview below the branch and it should last 5 days.

🇺🇸United States dmundra Eugene, OR

Yup, created issue https://www.drupal.org/project/projectownership/issues/3511871 📌 Offering to maintain File Encrypt Active

🇺🇸United States dmundra Eugene, OR

Looks like I need to figure out the test failures. Fixed a couple of issues.

🇺🇸United States dmundra Eugene, OR

I would be interested in being a maintainer of this module.

🇺🇸United States dmundra Eugene, OR

Click the 'View live preview' link to view the tugboat preview. It will last only 5 days so close and reopen the merge request to rebuild it if it has been more than 5 days.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Looks good to me and I can see the site and the module is enabled as expected.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

Production build 0.71.5 2024