🇺🇸United States @dmundra

Reviewing MR https://git.drupalcode.org/project/drupal/-/merge_requests/12122 and seeing that on install.php https://mr12122-4loygljzig4n8abvsdn1mltxwszyebvg.tugboatqa.com/core/inst... of the tugboat site the versions are hashed.

I believe I tackled the first one by essentially not catching the exception and letting it be thrown all the way up. Not ideal but avoids the file being upload in an unencrypted status.

dmundra → made their first commit to this issue’s fork.

dmundra → made their first commit to this issue’s fork.

Completed in #3526491

Added and all steps are passing.

dmundra → created an issue.

Looks like just adding 11 to version is not enough. The config form alterations will need to be made to support D11 structure. Best to follow field_encrypt approach https://git.drupalcode.org/project/field_encrypt/-/tree/4.x?ref_type=heads.

I am going to move my ddev and other cleanup to a new issue and then rebase to focus just on D11 changes.

Added and confirmed the steps in CONTRIBUTING.md works locally.

dmundra → created an issue.

Switching back to 8.x-8.x branch and closing this.

dmundra → created an issue.

So 8.0.x version of elasticsearch_connector connects to elasticsearch ^8 which is not a version available from AWS (at this time) so best to deprecate 8.x-8.x version of this module and focus on 8.x-7.x versions.

Added ddev and elasticsearch to make local dev easier.

I am not seeing this error so closing. Please let us know if you are still seeing the error with the latest version of 8.x-7.x branch.

dmundra → created an issue.

Thank you @wouters_f

dmundra → created an issue.

Might need this fix https://www.drupal.org/node/3471005 → as well.

Tugboat installed and ran without issue

Can I get elevated permissions so I can adjust the default branch in GitLab please?

dmundra → created an issue.

dmundra → created an issue.

Closing as duplicate of #3118104

I believe these changes are in the 7.x version so please try the new release for that one. The key module has been integrated in 8.x branch

Fixing this in #3524843

dmundra → created an issue.

dmundra → created an issue.

I believe this is fixed in newer versions

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

Fixed in newer branches

Will fix this in the newer version.

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

Fixed in 8.x-dev branch

dmundra → created an issue.

8.x-dev has a D10 release now. Will work on D11 next in a different issue.

Since merged marking as closed.

Merged so closing as fixed.

dmundra → created an issue.

Updated gitlab CI and tugboat. Now needs updates to the tests for Drupal 11 support

dmundra → changed the visibility of the branch 3461614-automated-drupal-11 to hidden.

dmundra → made their first commit to this issue’s fork.

Thank you @swirt.

Thank you @jastraat. Merged.

Closing this ticket since 7.x is no longer supported

Closing this ticket since 7.x is no longer supported

wouters_f gave me maintainership

Thank you @rlhawk

Thank you @smustgrave

Duplicate of #3524025 so closing.

Assuming that service credentials contain the project ID so we can look it up.

The current MR is ready to review. QA steps:

1. Use a local instance with the merge request branch
2. Enable vertex ai search if not enabled
3. Create a new search page from /admin/config/search/pages
4. Fill in the Service Account Credentials
5. Click the button 'Lookup Project'
6. Confirm you see the project ID show below the button
7. Copy the ID and save it in the Google Cloud Project ID field
8. Save the rest of the values like usual
9. Confirm the search works as expected

dmundra → created an issue.

@timozura, testing following your instructions is looking good. Do you think a test can be written to check the tokens? Might be hard.

Pushed up to the MR .ddev config, contributing file, drush, and updated .gitignore. To test it, pull down the branch locally and follow the steps in CONTRIBUTING.md to install ddev and get a site running.

@finaukaufusi I am seeing snippets with the current version of 1.0.x so I am not sure why it is not working for you. Moving this to needs more info.

I believe this is working when I test it.

Created a merge request https://git.drupalcode.org/project/vertex_ai_search/-/merge_requests/27 to test the patch

dmundra → made their first commit to this issue’s fork.

dmundra → created an issue.

This is ready for review, from my research last year and right now I think only data stores can be looked up with a service account and project ID + location. I think project ID could be loaded from the service account file path but probably not useful?

The current MR is ready to review. QA steps:

1. Use the tugboat URL or a local instance with the merge request branch
2. Enable vertex ai search if not enabled
3. Create a new search page from /admin/config/search/pages
4. Fill in the Service Account Credentials, Google Cloud Project ID, and change the location if it not set to global
5. Click the button 'Lookup Data Stores'
6. Confirm you see a list of data stores for the project ID and location
7. Copy the ID and save it in the Vertex AI Data Store ID field
8. Save the rest of the values like usual
9. Confirm the search works as expected

From @swirt:

Keep it simple, display a list with instructions to copy paste the values you want into the field.

Going to take a shot at this again.

Thank you @jminarick. I see GitLab CI run. Probably will need a follow-up ticket to clear the phpcs and related items.

Thank you @theloneliestmonk. I see GitLab CI run. Probably will need a follow-up ticket to clear the phpcs and related items.

Thank you @theloneliestmonk. I see GitLab CI run. Probably will need a follow-up ticket to clear the phpcs and related items.

Thank you @majorrobot. I can see the GitLab CI run. Hi @jaydarnell, probably will need a follow-up ticket to fix phpcs and related issues.

Thank you @jminarick. I can see the GitLab CI pipeline run.

Thank you @jastraat. I can see the GitLab CI pipeline run without issue.

This is a great module. Wanted to boost it with adding tugboat and gitlab CI.

dmundra → created an issue.

Adding a preview site to check out the module but also useful for testing future changes.

dmundra → created an issue.

dmundra → created an issue.

The gitlab-ci will allow tests to run to confirm Drupal 11 compatibility. Cleaned up version to be consistent with other modules and also the composer file.

Attaching a patch for users who want to include the update in the composer.json file as well.

I hid the other branches to focus on https://git.drupalcode.org/project/views_tree/-/merge_requests/14

dmundra → changed the visibility of the branch 3485947-drupal-11-compatibility to hidden.

dmundra → changed the visibility of the branch 3485947-update-compatibility to hidden.