How to QA
- Check out the branch from the MR
- Run
ddev restart - Run
rm web/modules/custom/alt_text_validation/*to remove all symlinks - Run
ddev symlink-project - Run
ls -la web/modules/custom/alt_text_validation/ - Confirm the symlinks have been recreated correctly
Sounds good and ya I agree about just newer CVEs. We were just referencing an example about packages.
@greggles Dependency Track is showing both CVE now for both core and contrib but looks like the missing detail is which packages are affected. @grugnog pointed out these examples from the NIST database:
* https://nvd.nist.gov/vuln/detail/CVE-2020-13673 shows packages
* https://nvd.nist.gov/vuln/detail/CVE-2025-6676 currently does not show packages
Preview build was successful with the basic config file. Ready for review.
Ready for review. Let me know if you have any questions. Following the steps in CONTRIBUTING.md file allows one to spin up a ddev instance with the module and its dependencies.
Ready for review, there are a lot of warning but that could be worked on in another issue and then kept track with the gitlab pipeline.
Thank you @kducharm
Thank you @swirt for fixing it.
@swirt tried to re-run the jobs and it still failed.
Looking good merged.
timozura → credited dmundra → .
Looks good to me. I liked the improved interface.
I merged some changes from other tickets and went back trying that and I finally got it to generate styles. Not sure why it started working (also updated local to 10.5). I do see it generate a smaller image that is not encrypted.
Merged thank you.
This should follow the solution from #2946320
Fixed in #3287560
Merged into 8.x-1.x
Creating a MR to see if the tests and pipeline pass.
Thank you cmlara. I will try testing by removing the fix for scenario 1 and seeing if that makes scenario 2 happen.
Okay I fixed it following example from https://www.drupal.org/project/node_read_time/issues/3473652 🐛 Drupal 11 issue on config form, ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct() Fixed
Did get an error when trying to configure the settings
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/lib/tugboat/src/Form/ContentRemindersSettingsForm.php on line 27 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of /var/www/drupal/web/core/lib/Drupal/Core/Form/ConfigFormBase.php).
I used the tugboat site and installed upgrade_status to see if there are any updates needed other than the version upgrade and did not find any. See attached screenshot.
So this is ready for review.
Looks good @mkinnune. I was able to use the tugboat preview to confirm the module installs fine.
The case-insensitive check worked as well.
Looks good and tested it locally and it works.
I am not sure that image styles works at all as the Image styles process cannot read the file since it is not decrypted for it. I think that was pointed out in related issues.
For image styles to work, we would have to either a process where the image is decrypted then styles are applied and then re-encrypted. This would be issue that scenario 2 is getting at I believe. I don't see how else image styles would work. To sufficiently not cause unencrypted data at rest it would better to not sure that feature and for it to be removed.
Fixing this one in #3516802
This change was made in #3370418 so closing.
Reviewing MR https://git.drupalcode.org/project/drupal/-/merge_requests/12122 and seeing that on install.php https://mr12122-4loygljzig4n8abvsdn1mltxwszyebvg.tugboatqa.com/core/inst... of the tugboat site the versions are hashed.
I believe I tackled the first one by essentially not catching the exception and letting it be thrown all the way up. Not ideal but avoids the file being upload in an unencrypted status.
Completed in #3526491
Added and all steps are passing.
Looks like just adding 11 to version is not enough. The config form alterations will need to be made to support D11 structure. Best to follow field_encrypt approach https://git.drupalcode.org/project/field_encrypt/-/tree/4.x?ref_type=heads.
I am going to move my ddev and other cleanup to a new issue and then rebase to focus just on D11 changes.
Added and confirmed the steps in CONTRIBUTING.md works locally.
Switching back to 8.x-8.x branch and closing this.
So 8.0.x version of elasticsearch_connector connects to elasticsearch ^8 which is not a version available from AWS (at this time) so best to deprecate 8.x-8.x version of this module and focus on 8.x-7.x versions.
Added ddev and elasticsearch to make local dev easier.
I am not seeing this error so closing. Please let us know if you are still seeing the error with the latest version of 8.x-7.x branch.
Thank you @wouters_f
Might need this fix https://www.drupal.org/node/3471005 → as well.
Tugboat installed and ran without issue
Can I get elevated permissions so I can adjust the default branch in GitLab please?
Closing as duplicate of #3118104
I believe these changes are in the 7.x version so please try the new release for that one. The key module has been integrated in 8.x branch
Fixing this in #3524843
I believe this is fixed in newer versions
Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.
Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.
Fixed in newer branches
Will fix this in the newer version.
Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.
Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.
Fixed in 8.x-dev branch