Patch worked, merging.
I will review this. Thank you @webbywe
Here is a patch just for 10.4
Creating a patch file from the MR and uploading it here.
Thank you @swirt.
Ya Steve still baffling why you are getting this error. I pulled down your changes, did ddev deleted and was able to get it to work. FYI what is your composer version? Here is mine:
dmundra in ~/workspace/community/alt_text_validation on branch 3503655-get-ddev-working > composer --version
Composer version 2.8.4 2024-12-11 11:57:47
FYI here is example https://git.drupalcode.org/project/svg_image_field/-/merge_requests/26/d... I followed for the contributing file.
@swirt try it now. I think the minimum-stability and other composer values is likely what caused the issue so I switched those values and removed some.
@safoora_mir I believe the error is thrown in search faceted if your filter text or someone's text includes a trailing space. I was able to recreate it with a trailing space.
Tested locally by comparing ddev config in https://www.drupal.org/project/tragedy_commons → to this module and tested it locally. Changes in https://git.drupalcode.org/project/alt_text_validation/-/merge_requests/26. The test is to check out the branch and run the commands from CONTRIBUTING.md to see if you can spin up the site locally.
I believe you need to run 'yarn install' in the core directory and then run the command like 'yarn test:nightwatch tests/Drupal/Nightwatch/Tests/exampleA11yTest.js' to execute a single test.
@heikkiy did you try it locally to see what the issue could be when you try a sandbox site directly?
Thank you @HeikkiY. Changes look good to me.
Thank you @greggles for making CVE for contrib issues. I am already seeing those appear in NIST as well https://nvd.nist.gov/vuln/search/results?form_type=Basic&results_type=ov... so I think we don't think we need to do this additional process.
Re-rolling patch #24 for latest version of dev
Duplicate ticket of the two related issues.
Attaching patch as well for folks who want to test with that.
In the MR for this issue got the tests passing with Drupal 11 by including the dependency on "drupal/elasticsearch_connector": "^8.0@alpha"
. I also made some adjustments as well:
- Cleaned up composer.json
- Updated
tests/src/FunctionalJavascript/IndexFormTest.php
to not include extra save step. - Updated typos in README and other places, ignored some spellings in the gitlab pipeline.
- Moved the module to 'Search' package.
Ready for review. If I need to create a separate MR for just version 11 let me know.
Duplicate of https://www.drupal.org/project/elasticsearch_connector_autocomp/issues/3... 📌 Automated Drupal 10 compatibility fixes RTBC
Needs upgrade to Drupal 11 to run the tests.
dmundra → created an issue.
Will create settings page to edit the text for emails and the various pages.
Custom tags solution worked locally. I will deploy for further testing.
Also following https://drupal.stackexchange.com/questions/207444/implementing-custom-ca...
dmundra → created an issue.
FYI, I had reached out to GitHub support about this issue and they fixed the original 404 for the URLs so https://github.com/dargullin/icheck/archive/refs/tags/1.0.2.zip should be working again.
Hey @jaydarnell
Thank you @jrockowitz for merging and releasing a new version. Appreciate that.
Hiding patch file.
Adding the package to composer.json didn't work because the wikimedia/composer-merge-plugin would still override with the webform version.
The patching of the upstream file in the webform module also didn't work for our project as the patch is applied to late.
Attaching a patch of the MR https://git.drupalcode.org/project/webform/-/merge_requests/561
GitHub issue https://github.com/drgullin/icheck/issues/440
Thanks @aluzzardi. I will try that.
The 1.0.3 and 1.0.2 releases on https://github.com/drgullin/icheck/releases are returning 404s. Might need a work around.
Thank you @longwave, @catch, and @alexpott for fixing it so quickly.
Confirmed this also happens on Drupal 11 with version 7.1.7 of symfony/http-foundation.
How to review:
1. Go to landing page /tragedy_of_the_commons.
2. Click on 'Fill out the REQUEST FORM.'
3. Fill out the request form and click 'Submit Request'.
4. Confirm you get the 'Approved' email.
5. Navigate back to /tragedy_of_the_commons.
6. Expand 'Playing the Multi-person Tragedy of the Commons game'.
7. Put in the test password from the email into the field and click 'Submit'.
8. Confirm you see a start page with 'Name's Game Start Page' text and text saying it is a test.
9. Enter multiple players with different first and last names.
10. For each player confirm you will be taken to the player's game page.
11. For each player enter a number of cows.
12. For each player confirm you are taken to a wait page.
13. Open the manage page for the game using the link in the email or adding manage to the URL after the game ID e.g. '/tragedy_of_the_commons/gamespace/3/manage'.
14. Hit submit to 'complete' the round.
15. Confirm you are taken to the results page with the results of that round and no names being displayed.
16. For each player confirm they are also taken to their player page where it shows the same results, summary at the bottom and a form to submit another round.
17. Confirm the results match the expected results/maths.
Done in https://www.drupal.org/project/tragedy_commons/issues/3468792 📌 Work on main multi player game logic part 1 Needs review
Done in https://www.drupal.org/project/tragedy_commons/issues/3468792 📌 Work on main multi player game logic part 1 Needs review
Done in https://www.drupal.org/project/tragedy_commons/issues/3468792 📌 Work on main multi player game logic part 1 Needs review
Going to hold of on this as we want to preserve records including players and rounds and we can only do that with data in the database.
Keep requests but delete players and rounds.
Get rid of acceptance workflow so no need configuration page.
Create two requests when one request is submitted.
Try again instructions:
If the game doesn't work or the results are problematic fill out the request form again to get a new game.
Submit the request, automatically approve.
Instructions for a second game:
Your game has been approved and is ready to play. This game allows you to play one game, of multiple rounds for one class session.
If you want to play the game in more than one class, fill in the form again from /tragedy_of_the_commons — filling it in one time for each class but add a different letter (NOT a number) to the end of your last name (e.g., mitchella, mitchellb, mitchellc). Why? Because lastnames are the passwords for each game.
How to review:
1. Go to landing page /tragedy_of_the_commons.
2. Click on 'Fill out the REQUEST FORM.'
3. Fill out the request form and click 'Submit Request'.
4. Confirm you get the 'Received' email to the entered email address in the form and 'Approval Sought' email to the hardcoded emails.
5. Navigate to the link in the 'Approval Sought' email (login as needed) to review the request and confirm the Approval and Disapproval buttons display.
6. Navigate to /admin/config/development/tragedy_of_the_commons/results and confirm you see the request in a table.
7. Click on the ID or 'Last Name' links to get to the request page from step 5 with the buttons.
8. On the request page click 'Approve Request' to approve the request. Confirm the buttons disappear.
9. Confirm you get the 'Approved' email.
10. Navigate back to /tragedy_of_the_commons.
11. Expand 'Playing the Multi-person Tragedy of the Commons game'.
12. Put in the test password from the email into the field and click 'Submit'.
13. Confirm you see a start page with 'Game for ...' text and whether it is a test or not.
14. Enter multiple players with different first and last names.
15. For each player confirm you will be taken to the player's game page.
16. For each player enter a number of cows.
17. For each player confirm you are taken to a wait page.
18. Open the manage page for the game using the link in the email or adding manage to the URL after the game ID e.g. '/tragedy_of_the_commons/gamespace/3/manage'.
19. Hit submit to 'complete' the round.
20. Confirm you are taken to the results page with the results of that round and no names being displayed.
21. For each player confirm they are also taken to the results page.
22. Confirm the results match the expected results/maths and look like the existing site.
Yes need this fix for Drupal 11 and the tests will show that is failing when it runs against Drupal 11.
Lol this is a duplicate of https://www.drupal.org/project/session_limit/issues/3464613 🐛 ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct() RTBC . I checked the test failure but not the argument error. Closing as duplicate.
Ready for review.
Also can someone change the default branch https://git.drupalcode.org/project/session_limit to 2.0.x.
Confirmed the patch fixes the issue. Ignore the pipeline test failures as that is related to this issue https://www.drupal.org/project/session_limit/issues/3473171 📌 ConfigurationForm is throwing a 500 error Active
Issue is related to https://www.drupal.org/node/3404140 →
Confirmed the 500 error on the configuration page for Drupal 11. The error:
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /home/public/drupal/modules/session_limit/src/Form/SettingsForm.php on line 35 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 43 of /home/public/drupal/core/lib/Drupal/Core/Form/ConfigFormBase.php).
dmundra → changed the visibility of the branch 3395489-css-and-js to hidden.
This might be related to https://www.drupal.org/project/require_login/issues/3370536 🐛 Aggregated CSS and JS not working anymore with Drupal 10.1 Fixed
dmundra → changed the visibility of the branch 3468792-main-logic-2 to active.
dmundra → changed the visibility of the branch 3468792-main-logic-2 to hidden.
Merging changes to review with Ron for testing. Individual games implemented and forms for multi-player players and rounds.
Merged the patch that was used with NSF.
Tagging Kristian
Couple of small bugs to fix:
* Add a request not found message to the request admin page.
* Fix the following phpcs
81 | ERROR | The $_REQUEST super global must not be accessed directly; inject
| | the request_stack service and use
| | $stack->getCurrentRequest()->request->get('test') instead
How to review:
1. Go to landing page /tragedy_of_the_commons.
2. Click on 'Fill out the REQUEST FORM.'
3. Fill out the request form and click 'Submit Request'.
4. Confirm you get the 'Received' email to the entered email address in the form and 'Approval Sought' email to the hardcoded emails.
5. Navigate to the link in the 'Approval Sought' email (login as needed) to review the request and confirm the Approval and Disapproval buttons display.
6. Navigate to /admin/config/development/tragedy_of_the_commons/results and confirm you see the request in a table.
7. Click on the ID or 'Last Name' links to get to the request page from step 5 with the buttons.
8. On the request page click 'DISapprove Request' to reject the request. Confirm the buttons disappear.
9. Confirm you get the 'Request Denied' email.
10. Create a new request.
11. On the request page click 'Approve Request' to approve the request. Confirm the buttons disappear.
12. Confirm you get the 'Approved' email.
13. Navigate back to /tragedy_of_the_commons.
14. Expand 'Playing the Multi-person Tragedy of the Commons game'.
15. Put in the test password from the email into the field and click 'Submit'.
16. Confirm you see a start page with 'Game for ...' text and whether it is a test or not.
Switching this issue to finish up just the basic forms and create a separate issue for the actual game play.