Eugene, OR
Account created on 20 July 2010, almost 15 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States dmundra Eugene, OR

Looks good to me. I liked the improved interface.

🇺🇸United States dmundra Eugene, OR

I merged some changes from other tickets and went back trying that and I finally got it to generate styles. Not sure why it started working (also updated local to 10.5). I do see it generate a smaller image that is not encrypted.

🇺🇸United States dmundra Eugene, OR

This should follow the solution from #2946320

🇺🇸United States dmundra Eugene, OR

Fixed in #3287560

🇺🇸United States dmundra Eugene, OR

Creating a MR to see if the tests and pipeline pass.

🇺🇸United States dmundra Eugene, OR

dmundra made their first commit to this issue’s fork.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Thank you cmlara. I will try testing by removing the fix for scenario 1 and seeing if that makes scenario 2 happen.

🇺🇸United States dmundra Eugene, OR

Okay I fixed it following example from https://www.drupal.org/project/node_read_time/issues/3473652 🐛 Drupal 11 issue on config form, ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct() Fixed

🇺🇸United States dmundra Eugene, OR

Did get an error when trying to configure the settings

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/lib/tugboat/src/Form/ContentRemindersSettingsForm.php on line 27 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of /var/www/drupal/web/core/lib/Drupal/Core/Form/ConfigFormBase.php).
🇺🇸United States dmundra Eugene, OR

I used the tugboat site and installed upgrade_status to see if there are any updates needed other than the version upgrade and did not find any. See attached screenshot.

So this is ready for review.

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

Looks good @mkinnune. I was able to use the tugboat preview to confirm the module installs fine.

🇺🇸United States dmundra Eugene, OR

The case-insensitive check worked as well.

🇺🇸United States dmundra Eugene, OR

Looks good and tested it locally and it works.

🇺🇸United States dmundra Eugene, OR

I am not sure that image styles works at all as the Image styles process cannot read the file since it is not decrypted for it. I think that was pointed out in related issues.

For image styles to work, we would have to either a process where the image is decrypted then styles are applied and then re-encrypted. This would be issue that scenario 2 is getting at I believe. I don't see how else image styles would work. To sufficiently not cause unencrypted data at rest it would better to not sure that feature and for it to be removed.

🇺🇸United States dmundra Eugene, OR

This change was made in #3370418 so closing.

🇺🇸United States dmundra Eugene, OR

I believe I tackled the first one by essentially not catching the exception and letting it be thrown all the way up. Not ideal but avoids the file being upload in an unencrypted status.

🇺🇸United States dmundra Eugene, OR

dmundra made their first commit to this issue’s fork.

🇺🇸United States dmundra Eugene, OR

Completed in #3526491

🇺🇸United States dmundra Eugene, OR

Added and all steps are passing.

🇺🇸United States dmundra Eugene, OR

Looks like just adding 11 to version is not enough. The config form alterations will need to be made to support D11 structure. Best to follow field_encrypt approach https://git.drupalcode.org/project/field_encrypt/-/tree/4.x?ref_type=heads.

I am going to move my ddev and other cleanup to a new issue and then rebase to focus just on D11 changes.

🇺🇸United States dmundra Eugene, OR

Added and confirmed the steps in CONTRIBUTING.md works locally.

🇺🇸United States dmundra Eugene, OR

Switching back to 8.x-8.x branch and closing this.

🇺🇸United States dmundra Eugene, OR

So 8.0.x version of elasticsearch_connector connects to elasticsearch ^8 which is not a version available from AWS (at this time) so best to deprecate 8.x-8.x version of this module and focus on 8.x-7.x versions.

🇺🇸United States dmundra Eugene, OR

Added ddev and elasticsearch to make local dev easier.

🇺🇸United States dmundra Eugene, OR

I am not seeing this error so closing. Please let us know if you are still seeing the error with the latest version of 8.x-7.x branch.

🇺🇸United States dmundra Eugene, OR

Tugboat installed and ran without issue

🇺🇸United States dmundra Eugene, OR

Can I get elevated permissions so I can adjust the default branch in GitLab please?

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

I believe these changes are in the 7.x version so please try the new release for that one. The key module has been integrated in 8.x branch

🇺🇸United States dmundra Eugene, OR

dmundra created an issue.

🇺🇸United States dmundra Eugene, OR

I believe this is fixed in newer versions

🇺🇸United States dmundra Eugene, OR

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

🇺🇸United States dmundra Eugene, OR

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

🇺🇸United States dmundra Eugene, OR

Will fix this in the newer version.

🇺🇸United States dmundra Eugene, OR

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

🇺🇸United States dmundra Eugene, OR

Closing this issue with the opinion that 5.x is no longer supported. If this issue is still in 8.x then please reopen.

🇺🇸United States dmundra Eugene, OR

8.x-dev has a D10 release now. Will work on D11 next in a different issue.

🇺🇸United States dmundra Eugene, OR

Since merged marking as closed.

🇺🇸United States dmundra Eugene, OR

Merged so closing as fixed.

🇺🇸United States dmundra Eugene, OR

Updated gitlab CI and tugboat. Now needs updates to the tests for Drupal 11 support

🇺🇸United States dmundra Eugene, OR

dmundra changed the visibility of the branch 3461614-automated-drupal-11 to hidden.

🇺🇸United States dmundra Eugene, OR

dmundra made their first commit to this issue’s fork.

🇺🇸United States dmundra Eugene, OR

Thank you @swirt.

🇺🇸United States dmundra Eugene, OR

Thank you @jastraat. Merged.

🇺🇸United States dmundra Eugene, OR

Thank you @smustgrave

🇺🇸United States dmundra Eugene, OR

Duplicate of #3524025 so closing.

🇺🇸United States dmundra Eugene, OR

Assuming that service credentials contain the project ID so we can look it up.

The current MR is ready to review. QA steps:

  1. Use a local instance with the merge request branch
  2. Enable vertex ai search if not enabled
  3. Create a new search page from /admin/config/search/pages
  4. Fill in the Service Account Credentials
  5. Click the button 'Lookup Project'
  6. Confirm you see the project ID show below the button
  7. Copy the ID and save it in the Google Cloud Project ID field
  8. Save the rest of the values like usual
  9. Confirm the search works as expected
Production build 0.71.5 2024