Code quality updates

Created on 2 April 2025, 4 days ago

Problem/Motivation

GitLab CI shows the following code quality issues:

PHP CODE SNIFFER REPORT SUMMARY
----------------------------------------------------------------------
FILE                                                  ERRORS  WARNINGS
----------------------------------------------------------------------
src/EncryptBinaryFileResponse.php                     2       0
src/EncryptStreamWrapper.php                          11      1
src/Controller/ImageStyleDownloadController.php       10      0
src/Hooks/FieldStorageConfigEditFormAlter.php         7       0
src/PathProcessor/PathProcessorImageStyles.php        1       0
tests/src/Functional/FileUploadTest.php               0       1
tests/src/Functional/FunctionalTestBase.php           12      0
tests/src/Functional/ImageFileUploadTest.php          2       0
tests/src/Kernel/EncryptStreamWrapperTest.php         3       1
tests/src/Kernel/FileEncryptDownloadTest.php          1       0
tests/src/Kernel/FileEncryptTestBase.php              2       0
tests/src/Unit/PathProcessorFilesTest.php             6       0
tests/src/Unit/StreamFilterTest.php                   3       0
----------------------------------------------------------------------
A TOTAL OF 60 ERRORS AND 3 WARNINGS WERE FOUND IN 21 FILES
----------------------------------------------------------------------
PHPCBF CAN FIX 44 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
-----------------------------------------------------------------------
    SOURCE                                                        COUNT
-----------------------------------------------------------------------
[x] Drupal.Arrays.DisallowLongArraySyntax.Found                   10
[ ] Drupal.Arrays.Array.LongLineDeclaration                       6
[ ] Drupal.Commenting.DocComment.MissingShort                     6
[x] Drupal.Classes.ClassDeclaration.SpaceBeforeBrace              3
[x] Drupal.Arrays.Array.ArrayIndentation                          2
[x] Drupal.Classes.ClassDeclaration.CloseBraceAfterBody           2
[x] Drupal.Classes.UnusedUseStatement.UnusedUse                   2
[x] Drupal.Commenting.DocComment.ContentAfterOpen                 2
[x] Drupal.Commenting.FunctionComment.Missing                     2
[ ] Drupal.Commenting.FunctionComment.MissingParamType            2
[x] Drupal.Commenting.FunctionComment.ParamCommentFullStop        2
[x] Drupal.Commenting.FunctionComment.ParamCommentIndentation     2
[x] Drupal.Commenting.InlineComment.InvalidEndChar                2
[x] PSR2.Namespaces.UseDeclaration.SpaceAfterLastUse              2
[x] SlevomatCodingStandard.PHP.ShortList.LongListUsed             2
[x] Squiz.WhiteSpace.FunctionSpacing.AfterLast                    2
[x] Drupal.Classes.UseGlobalClass.RedundantUseStatement           1
[x] Drupal.Commenting.ClassComment.Missing                        1
[x] Drupal.Commenting.DocComment.LongFullStop                     1
[ ] Drupal.Commenting.FunctionComment.ParamMissingDefinition      1
[ ] Drupal.Commenting.FunctionComment.ParamNameNoMatch            1
[x] Drupal.Commenting.FunctionComment.ReturnCommentIndentation    1
[ ] Drupal.Commenting.FunctionComment.ReturnTypeSpaces            1
[x] Drupal.Commenting.InlineComment.SpacingAfter                  1
[ ] Drupal.Commenting.VariableComment.EmptyVar                    1
[x] Drupal.Commenting.VariableComment.IncorrectVarType            1
[ ] Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps  1
[x] Squiz.Arrays.ArrayDeclaration.SpaceInEmptyArray               1
[x] Squiz.WhiteSpace.OperatorSpacing.NoSpaceBefore                1
[x] Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines             1
-----------------------------------------------------------------------
A TOTAL OF 63 SNIFF VIOLATIONS WERE FOUND IN 30 SOURCES
πŸ“Œ Task
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jastraat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jastraat
  • First commit to issue fork.
Production build 0.71.5 2024