- Issue created by @kducharm
- 🇺🇸United States kducharm
kducharm → changed the visibility of the branch 3532699-revision to hidden.
- Merge request !160Added new_revision to event series/instance types. → (Open) created by Unnamed author
- 🇧🇬Bulgaria pfrenssen Sofia
I had a quick look at the code but didn't try it out. This looks like a great addition, thanks for starting it! I have a few thoughts:
- Since this uses Drupal 10+ attributes the MR should be rerolled against 3.0.x. The current 2.0.x still supports Drupal 9.3 so the code will not work on older sites that didn't update to Drupal 10 yet.
- The code looks good as far as I can see. I compared it with how the
nodemodule does it and the approach looks the same. - I am not sure whether we should enable the creation of new revisions by default. At the moment this is not the case AFAIK. If we change this to be enabled, then we need an update hook that disables the revisions for each bundle of the event series and bundles. Then existing sites can decide whether they want to enable it or not.
- Would be nice to have a small test, but that is not a hard requirement. We are mostly relying on core functionality.