- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Can the MR be updated for 10.1 please
Left a comment, but since it's updating the schema believe it will need an update hook and thus test for update hook. - Status changed to Needs review
over 1 year ago 6:49am 16 August 2023 - last update
over 1 year ago 29,465 pass, 2 fail - last update
over 1 year ago 29,466 pass - 🇺🇦Ukraine nginex
I cound not create a new MR against 10.1.x as I'm not owner of the existing MR.
But I rerolled existing MR against 10.1.x
The last submitted patch, 43: 3180702-d10-43-TEST-ONLY-FAIL.patch, failed testing. View results →
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 29,962 pass - 🇺🇸United States tim.plunkett Philadelphia
@nginex I rebased the MR (which anyone can do) and @joachim changed the target (which I asked for in Drupal slack)
- 🇺🇦Ukraine nginex
@tim.plunkett, right, I will take this into account next time, thanks
- Status changed to Needs work
over 1 year ago 2:36pm 16 August 2023 - 🇺🇸United States smustgrave
Previously tagged for update path for the new schema item.
If not needed can we document why not please.
Looking good though!
Thanks!
- Issue was unassigned.
- 🇺🇦Ukraine alt.dev
I'm attaching a patch based on the latest MR that can be applied to Drupal 10.2.x.
- 🇹🇷Turkey burak.ikiler
Current d10-49 patch is failing with 10.2.3. I am adding the compatible one.
- 🇮🇳India pratikshad Mumbai
Thanks for sharing the path, it worked for me
https://git.drupalcode.org/project/drupal/-/merge_requests/2383/diffs - 🇪🇸Spain tonibarbera
I've rerolled the #50 patch for the Drupal 10.3.1 version
- 🇪🇸Spain akalam
Patches #50 and #52 are not including the function ViewsConfigUpdater::needsTidFilterWithMultipleVocabulariesUpdate which is being used on the hook post update.
I'm uploading a reroll against 10.3.1 based on patch #49 - 🇪🇸Spain akalam
As reported in the previous comment, patches #50 and #52 were causing a fatal error, so I was creating a new one based on the patch #49. However, after testing, seems like the patch #49 was incorrect too, because is not loading the entity from uuid on the getEntity method as it's being done in the MR, and therefore the patch #53 is incorrect as well.
I'm uploading a direct reroll from the MR against core 10.3.1 in case anyone needs it.