🇺🇦Ukraine @nginex

updated my original comment #25, thanks for the suggestion @fabianfiorotto

Here we go https://www.drupal.org/project/single_content_sync/releases/1.4.8 →

@rodrigoaguilera it might work, thanks, will need to create a new release to include that file, I will review other issues as well, so I can include multiple fixes to a new release

@guido_s

in terms of code it's looking good, there are no breaking changes or so, just one more service is added to dependency injection, so nothing I can do there. I already deployed the upgrade for multiple projects and there were no issues, so I need more details about environment where it happened or at least what drupal core version was used to understand and apply a possible fix.

Hello,

There is a notes in the release https://www.drupal.org/project/single_content_sync/releases/1.4.7 →

Did you try that already?

I noticed it on one project too, but not for others, seems like a cache issue. Reinstall module to fix it

Tested on real project with a complex migration by using this module, no issues spotted after last fixes pushed to the MR.

Try

ByteSizeMarkup::create(Environment::getUploadMaxSize());

See https://www.drupal.org/node/2999981 →

@anish.ir you don't need all this code you provided

Just one line is the way to go

format_size(Environment::getUploadMaxSize());

going to test in a few real projects, if all good will merge it

nginex → created an issue. See original summary → .

@diederik.beirnaert you can uncheck that in the module settings. There is a field "Site UUID check"

Thanks for the contribution, it's a nice improvement, I will commit it as first iteration with possible improvements in the future

Comments export and import will be handled in a separate issue 💬 creating a comment exporter plugin Active as it has different structure and relationship

All the work should happen in 💬 creating a comment exporter plugin Active

nginex → created an issue.

Thanks all for the contribution, I have made a few tricks, so the module still works on Drupal 9.3 and above.

I tested it on Drupal 10 and 11, works like a charm

@mably

Here we go https://www.drupal.org/project/field_hidden/releases/2.1.2 →

D11 support has been added to new release 2.1.2

I leave the issue open for new updates by the bot

Hi @mably

I don't have permission to handle maintership of the module but I can create a new D11 release today, so you will not be blocked

Looks good

it was merged and released 8 months ago

going to include it to new release

nginex → created an issue.

@mlncn There is already issue for that with the patch 🐛 'Leave empty to enable on all content items' doesn't work Active

I managed to add export but still need to handle import.

The export also works for content with comments

nginex → made their first commit to this issue’s fork.

Re-roll of #12

Did not know this category even exists, thanks for the information, I updated the project page, probably will take some time to include the project to the overview.

In my case it was an issue in form-element.html.twig

instead of {{ description }} it's now

<div{{ description.attributes }}>{{ description.content }}</div>

Good call,

Thanks guys,

https://www.drupal.org/project/node_keep/releases/2.2.5 →

@dieterholvoet

Sorry, I did not notice there was open MR, so I accidentally pushed my commit over yours

nginex → made their first commit to this issue’s fork.

greggles → credited nginex → .

@leeksoup, could you please check if your module "single_content_sync_anu_content" is enabled?

The code looks ok

Thanks, nice that you figured this out

@leeksoup I checked your code and here is my notes:

1. If you implement this plugin in your custom module, can you please change your namespace, currently you are using (it must contain your module name, not the contrib module name)

namespace Drupal\single_content_sync\Plugin\SingleContentSyncBaseFieldsProcessor;

2. Your class name "assessment_question" does not follow any standards, could you please follow naming pattern e.g. AssessmentQuestion

Could you please try it, clear cache and let me know if it works

I keep it open for future updates.

a new release is on the way

Here we go https://www.drupal.org/project/node_keep/releases/2.2.4 →

Thanks @grevil for pinging me directly

Leaving open for future changes.

No problems, it makes sense to extend this functionality to support both modal types.

Extended a config form to be able to override ui-dialog classes. Check out the MR!

nginex → made their first commit to this issue’s fork.

Did not check previous patches, just used core/once to handle the issue with multiple issues

nginex → made their first commit to this issue’s fork.

The MR also allows to add any options or alter existing one by implementing a hook_telephone_international_widget_options_alter(&$options) {}

nginex → made their first commit to this issue’s fork.

Applying a patch from 🐛 Unable to change either the Target or Comparison elements Needs review fixes the issue for me, so the module works well afterwards

Added bundle option

nginex → created an issue.

Ignore my previous comment with patch, #54 should work well (I just had a conflict with another issue)

Reroll for latest 10.3.x

@Joseantonio7696

There is no need to apply outdated patch as this fix is already a part of the latest release 8.x-4.0-rc3

Default value is missing (it will be always default view mode which is wrong), I will add layout_builder_background as default value

> Why not use Drush\Commands\AutowireTrait and define the dependencies as properties in the constructor?

great idea