Add a new setting to the configuration form to disable automatic menu link exporting during node export

Created on 8 July 2023, over 1 year ago
Updated 6 September 2024, 3 months ago

Problem/Motivation

In some cases it's not needed to always export menu link item of the node with all the references. Currently it's always enabled.

Let's extend the configuration form to make it optional.

✨ Feature request
Status

Needs work

Version

1.4

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine nginex

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @nginex
  • πŸ‡§πŸ‡ͺBelgium artycal

    @nginex What cases is this issue referring to? I can see some ambiguity for 2 cases:

    1. The entity is referenced in a Menu link, e.g. Main Navigation > node_to_export
    2. The entity references a Menu link, e.g. node_to_export contains menu_link

    I assume it's for the first case, but want to make sure

  • πŸ‡ΊπŸ‡¦Ukraine nginex

    It's follow up of πŸ“Œ Add opportunity to export import content menu items with translations Fixed

    The issue might have some performance impact and in many cases not needed to be enabled by default.

    1. Create a node
    2. On the right sidebar, click to add a menu link.
    3. Export this content (menu link will be also exported)

    I would add this option to existing configuration form.

    This should be developed for 1.3.x first and then migrated to 1.4.x (I can do it during review)

  • @artycal opened merge request.
  • Assigned to nginex
  • Status changed to Needs review over 1 year ago
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    I needed this for 1.4.x so I did a reroll.

    Why not focus efforts on 1.4.x instead of 1.3.x? Users could just update if they want the new features.

  • Issue was unassigned.
  • Pipeline finished with Failed
    11 months ago
    Total: 151s
    #69628
  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    I rebased 3373378-add-a-new-1.4.x onto 1.4.x to fix conflicts. Testrunner shows a phpunit failure so more adjustments are needed.

    3373378-add-a-new-1.4.x-3363087-configure-export-settings contains MR69, plus work in progress on #3363087.

  • πŸ‡ΊπŸ‡¦Ukraine nginex
  • First commit to issue fork.
  • Pipeline finished with Success
    3 months ago
    Total: 201s
    #275965
  • πŸ‡ΊπŸ‡ΈUnited States RoloDMonkey

    I updated merge request 69 with the latest from 1.4.x and fixed the merge conflicts.

    I am going to try using a patch from merge request 69 locally, but I will need other people to review this and see if it is ready.

  • Pipeline finished with Success
    3 months ago
    Total: 298s
    #276037
  • πŸ‡ΊπŸ‡ΈUnited States RoloDMonkey

    I fixed a few minor issues left over from the merge request.

    But, I did find some other problems.

    First, the check for the new setting needs to be more careful, both where the default value is set in the form builder and in the ContentSyncHelper->nodeAllowMenuLinkExportEnabled()
    If the configuration is not set at all, then it should default to true. Even though it is supposed to be set to true in an update hook, there are cases where that update hook can immediately be overridden; for instance by importing the old config immediately after the update.

    Second, there are changes in single_content_sync_preprocess_links__dropbutton__operations() that look like they are from a different issue. Unless these are necessary for this issue to be resolved, they should not be included.

  • Status changed to Needs work 3 months ago
  • πŸ‡ΊπŸ‡ΈUnited States RoloDMonkey
Production build 0.71.5 2024