🇺🇸United States @mortona2k

Seattle
Account created on 16 November 2010, over 14 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States mortona2k Seattle

Loaded the menu.active_trail service to use getActiveTrailIds, and then $parameters->setActiveTrail().

🇺🇸United States mortona2k Seattle

mortona2k made their first commit to this issue’s fork.

🇺🇸United States mortona2k Seattle

mortona2k made their first commit to this issue’s fork.

🇺🇸United States mortona2k Seattle

Hey @rodrigoaguilera, I am trying this module out for the first time and running into this issue.

When you enable layout builder for menu items, and then click manage layout, you get a 404.

Here's the URL it was going to:

/admin/structure/menu/display/primary_nav/layout?bundle=menu_link_content

It's happening with the default display and this custom one.

🇺🇸United States mortona2k Seattle

Enabling layout builder, with custom layout per item works without adding other fields (because custom layout is a field).

🇺🇸United States mortona2k Seattle

I made the change in an issue fork, but forgot to create the MR.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Hello, I took a look at this module today since I saw it got an update.

Looks like this module has a more robust interface vs UI Patterns Library. You can adjust the component values and change the theme.

I have been really liking the UI Patterns modules lately. Compared to another project I'm on with Storybook, it is so much more straightforward to have it all in Drupal.

I'd like to see more collaboration on a Drupal SDC component library (efforts feel fragmented across modules at the moment).

Having a common format for stories is a major step forward, so big +1 from me.

💬 | Edit+ | Roadmap?
🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

I don't think this is related to this module, it happens with the underlying Table view display plugin.

🇺🇸United States mortona2k Seattle

I got the basics working. https://www.retrograde.bike/parts

Category and Part type are the same taxonomy, I used this module to place level 1 and 2 facets. Brand, Groupset, and Groupset series are different taxonomies that have references that create a hierarchy.

They all work the same. With ajax enabled, all filters update with the available facets.

The only thing I am wondering about at this point is the dependee configuration and whether anything is missing from the old api.

🇺🇸United States mortona2k Seattle

I looked into doing this for hierarchical taxonomies with Facets Taxonomy Multilevel: https://www.drupal.org/project/facets_taxonomy_multilevel/issues/3511228 💬 Working with facets 3? Active

Someone else mentioned customizing the links widget plugin on slack: https://drupal.slack.com/archives/C3E9QDZ5M/p1741194501345919

🇺🇸United States mortona2k Seattle

There is already an issue for D11 compatibility, the patch added here is a duplicate.

The next step is for someone to verify that it is working, and if so, set the original issue to "Reviewed and tested by the community".

🇺🇸United States mortona2k Seattle

I have a hierarchical taxonomy working with 3.x and better exposed filters, using default display (select).

It is repopulating the select options with the second level terms. I was expecting a second select list to appear instead, which would be more obvious to the user.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

I rebased the branch onto dev.

The report is working for me and I find it useful as is.

As an additional feature request, I'd like to see a % of content per bundle that has the field value. That can be a little more meaningful than the counts alone.

🇺🇸United States mortona2k Seattle

This is a good idea for a feature.

For some helpful info on image styles that are in use: https://www.drupal.org/project/image_styles_mapping

🇺🇸United States mortona2k Seattle

This is working. Would be nice to add a filter for content type as well.

I would also like to see the field name, for more info on how paragraphs are in use.

These could be separate requests.

🇺🇸United States mortona2k Seattle

Ok that worked.

🇺🇸United States mortona2k Seattle

The conflict line is still there in composer.json, but looks like you're still working on this.

🇺🇸United States mortona2k Seattle

Applied patch in issue branch and fixed a few things.

Moved ExifOrientationCommands to src/Drush/Commands, which got the command to register for drush 12.

Added AccessCheck fixes.

Changed processBatchStep to static call. I don't know if this was necessary, but it fixed a warning.

I'm still getting an error:

TypeError: Drupal\Core\Entity\EntityStorageBase::getEntityClass(): Return value must be of type string, null returned in Drupal\Core\Entity\EntityStorageBase->getEntityClass() (line 115 of /var/www/html/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php).

🇺🇸United States mortona2k Seattle

This worked for me. Anything else needed?

🇺🇸United States mortona2k Seattle

Patch #67 is working on 10.4.

🇺🇸United States mortona2k Seattle

MR 17 working for me.

Without the patch, enabling the Views list view triggered this error - the status field was breaking the view.

The code looks clean to me as well.

Thanks for your work on this!

🇺🇸United States mortona2k Seattle

Actually, this is happening with core. I don't think it's related to this module.

Install a fresh site with the standard profile.

Create Image/Document media items.

Go to Content > Files.

Uploaded image file shows 2 uses, document shows 1.

🇺🇸United States mortona2k Seattle

mortona2k changed the visibility of the branch 8.x-1.x to hidden.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

On a fresh install, a file uploaded as a media item reports that it has 2 usages by that media item.

How is this being calculated?

🇺🇸United States mortona2k Seattle

Rebased branch on 1.7 and regenerated JS.

🇺🇸United States mortona2k Seattle

mortona2k made their first commit to this issue’s fork.

🇺🇸United States mortona2k Seattle

They may have been using Module Usage Documentation, which depends on Configuration Views and provides a Views source for listing modules.

That is working fine for me though.

🇺🇸United States mortona2k Seattle

No, I mean to select entity types from display entirely.

I tried this module on a project that has lots of paragraph types, and those were polluting the display from what I wanted to see.

I was looking for connections within the content, especially entity reference fields to other content types.

I'm thinking the graph legend could have a checkbox to disable the potential entity types that could be displayed.

🇺🇸United States mortona2k Seattle

Same patch already exists in linked issue.

🇺🇸United States mortona2k Seattle

I think the latter is fine. We just need something with 2.1 or above. I don't know if there's an advantage between those two formats.

🇺🇸United States mortona2k Seattle

I tried a few things like defining a custom repository for the 2.0.x branch and overriding as version 2.1 in composer.json.

That worked, but I also found this as the shortest way to go: composer require drupal/config_views:"dev-2.0.x as 2.1.0".

🇺🇸United States mortona2k Seattle

I don't really know how to proceed.

The question in this ticket is actually extremely complex.

What is a component, as a design concept?

What is a component to a developer?

What is a component in Drupal?

What is a component to a content editor?

Components are...

To a designer, components are what they see on the surface. They may not be considering the underlying structure or the UI needed to create components.

To developers, components are code structures that can be reused. They need to know what's available to extend or how changes will affect the system.

In Drupal, we may call a chunk of anything a component. A menu link, a menu block, a region, paragraphs, etc. But the data structure is different from the code file structure. There may not be one single code file that represents what is conceptually a discrete component on the page. For example, a block type rendered with a customized layout in layout builder.

To a content editor, a component may be what is useable by them to edit content in a template.

I am currently reviewing some modules for auditing content architecture. The Xray Audit module has a report that shows available display modes for entities, and a summary of how they are configured.

As far as documenting how "Components" are used within the content model, I think that kind of report covers the expectation. Maybe template overrides in use would be good if we could surface that, or preprocess hooks in use by contrib and custom modules.

I'm hoping that more solutions like UI Patterns come out to help manage use of SDCs in a system. That seems to be the integration point with design systems.

🇺🇸United States mortona2k Seattle

It's working fine on a newer site with fewer entity types.

🇺🇸United States mortona2k Seattle

I tried to use this, but ran into an issue that @swirt called out in #3427434 Content count reports for other entity types Active .

I have been moving a bit away from using actual Views because they are such a pain to try to update once they have been rolled out. And even adding here, most existing sites using the module will never see the nice View you created because they are not installing the module from scratch so it never gets created.

I have built a rudimentary reporting framework that is better for these kinds of things because any improvements roll out to everyone.
There is a little bit of Report making guidance here. And the file NodeCount.php has most of what you would be needed as an example. If you feel like giving it a try, that would be great. If not I can likely get to converting the View into a report in a week or two.

Just thinking out loud here - would this be more useful as a recipe? Is it possible to ship those with modules and provide a way to enable? I don't know if those have gotten advanced enough to replace existing config if it is different.

🇺🇸United States mortona2k Seattle

Both Gin issues have been fixed, I'm no longer seeing any issues.

🇺🇸United States mortona2k Seattle

Adding widget info to field list is proposed in related issue.

(Is that for Field Search, or Content Model Fields?)

🇺🇸United States mortona2k Seattle

I have a site that uses ECK and has dozens of subtypes with a mix of fields.

I would like to enforce some consistency in things like the order of fields and formatter settings.

It is tedious to make adjustments across so many types, and some changes get lost.

It looks like the content model fields list could be enhanced with more form/display info and links to configure.

🇺🇸United States mortona2k Seattle

I have been using SDC for displaying entities using SDC Display. UI Patterns also provides a way to render SDC using different drupal displays (blocks, fields, layout builder).

Just pointing out that this may be an example of how we might want to track usage of these things.

On the other hand, usage of SDC in code is very different to track.

🇺🇸United States mortona2k Seattle

This idea is covered by the related issue for creating a dashboard showing counts for different entity types.

🇺🇸United States mortona2k Seattle

It happens when Browser and proxy cache maximum age is on in Development > Performance.

With caching disabled, there is no issue.

I can toggle it on and off to repro currently.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k changed the visibility of the branch 3293086-remove-whitespace to hidden.

🇺🇸United States mortona2k Seattle

mortona2k changed the visibility of the branch 2.x to hidden.

🇺🇸United States mortona2k Seattle

After staring at this for a bit, I think that there are various use cases for using this module, and there may be a better way to implement what you want. I see the value in a one size fits all or customizeable interface, but currently there are many edge cases that get in the way of using this.

That said, I'm contributing some fixes because it does work and I'm just being picky about html structure.

Some things to note:

The original proposal to use spaceless is now deprecated.

{{- -}} and {{~ ~}} are the replacement, and could potentially work. I think the template would all have to be on one line, and the comments twig debug comments may still be an issue. (I haven't fully explored {{~ ~}}).

This post has tricks on hiding whitespace, with some crafty HTML hacks.. https://css-tricks.com/fighting-the-space-between-inline-block-elements/

I have landed on CSS flex w/ flex wrap as the best way to implement this.

If I were doing this myself, I would make a custom view display or template.

Twig has a {{ loop.last }} variable that can be used within a for loop.

You can print a comma separator with:

<div{{ row.attributes.addClass(row_classes) }}>
  {{- row.content -}}{{ loop.last ?: ', ' }}
</div>

See my comments in the MR for implementation concerns.

🇺🇸United States mortona2k Seattle

Remember to update the version in the test module: https://www.drupal.org/project/confi/issues/3491317 🐛 Use core_version_requirement in config_import_test.info.yml Active

🇺🇸United States mortona2k Seattle

Problem solved.

Patch does not include Drupal 11.

But that can be added in https://www.drupal.org/project/confi/issues/3455179 📌 Automated Drupal 11 compatibility fixes for confi Active .

🇺🇸United States mortona2k Seattle

Is this part of the project description correct?

Note that this module overrides the default Fields row style to output no extra whitespace for each row set other than the whitespace that already exist in field contents.

🇺🇸United States mortona2k Seattle

I was setting it up to be composed in layout builder.

Footer is used as a layout, where you can place footer menu and aside components.

I am interpreting daisyui.com as flexible examples, not a set of limited variations.

I was going for a system that allows maximum customization, especially since we can use UI Styles for color and spacing.

I'm unsure how someone would set up the different variations, it sounds like everything will be hardcoded in page.html.twig?

🇺🇸United States mortona2k Seattle

If a component has multiple links props, I think having a contextual edit link for each menu makes sense.

🇺🇸United States mortona2k Seattle

The main issue I encountered is that the url is a string instead of an object.

To print it in the template took extra checks and manipulation to handle the 3 different link urls.

🇺🇸United States mortona2k Seattle

Take a look at the footer, footer menu, and aside components I created.

Set up links in a footer menu, then add this as a block, select the menu, and the top level links should render as column headers.

You can add an aside. I haven't set up Social Links yet.

Center should be working.

I made some adjustments to the spec and commented on why in https://docs.google.com/document/d/1DJCsANcHH7lnbxfUlHnX7m_2kiWdqAN8YWM9...

I built the footer template to work as a layout section to work on it visually and swap the menu/aside position.
But the implementation has an issue - it switches visually but can't save it.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Social links needed for footer.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

A component placed in block layout has contextual edit links for Configure and Remove, but not for editing the menu.

When placed in layout builder, there are no contextual links for it on the page.

Production build 0.71.5 2024