I have not done any manual testing yet.
mortona2k → created an issue.
The patch was released with Drupal 10.4 today.
Any guidance on what to change if we're using this module?
Thanks!
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
2867991-tab_navigation_fix branch is going back to the fix from #5.
With just this, the date contextual arguments are stripped from the other tabs so they are not broken.
mortona2k → created an issue.
guignonv → credited mortona2k → .
Updated patch for current release.
This change is already in the dev branch.
https://git.drupalcode.org/project/formtips/-/commit/a78f0e90a432c0385d4...
@solideogloria - This is the issue for that UI discrepancy:
https://www.drupal.org/project/drupal/issues/3346391
🐛
Views filter groups: selecting OR works as expected, but displays AND, which can be conflusing to site builders
Needs review
I applied the patch to an issue fork for testing, but it is not working for me.
I was able to get it to display the opposite value for both Or and And, unlike what is specified in the title.
It seems like the filter for the operator selection is changing every group label and not just it's own.
mortona2k → made their first commit to this issue’s fork.
How do we access our user account? I don't see a link in the main navigation anymore.
So this fetches all custom module and theme libraries files, then uses all defined paths in there?
Looks like this will help with including things out side of your theme in the vite build.
mortona2k → created an issue.
Variationcache is no longer a dependency of Flexible Permissions as of 2.x.
https://git.drupalcode.org/project/flexible_permissions/-/commit/b223cf3...
However, group still depends on variationcache with require-dev.
https://git.drupalcode.org/project/group/-/blob/3.3.x/composer.json?ref_...
mortona2k → created an issue.
I see a pattern() function in the docs, is that what you meant?
https://www.drupal.org/docs/contributed-modules/ui-patterns/developer-do... →
There's been some discussion on asset bundling, importmap, and SDC in the Frontend Builder Initiative slack channel.
@brianperry can you elaborate a little more on the use case (In slack if not here)? I hit some things that might be relevant, but I'm not totally sure.
One example is a SDC that imports a js module from npm, like swiper. If a module uses it as a library, and my theme component bundles it, is there some way put the bundled version in the importmap and override the module using the library? I'm not sure if this even makes sense though, or if it just makes more sense to set up front end bundling in the root and override the module to use your library.
There's some overlap in manifest.json files for bundled assets and importmaps. I'm not sure if there's any benefit to using a global importmap vs individually bundled or even globally bundled assets.
Another issue is referencing images or icons in the theme directory. When I bundle in the theme dir, the paths are relative to the theme root and drupal uses the Vite module to translate them to the correct path. Since we don't have libraries defined for images, there's some extra config needed to juggle the paths that I haven't figured out yet. I'm not sure if images in the importmap are possible or would just cause more problems.
mortona2k → created an issue.
Seems like the shortest path to a fix is to review and fix the patch.
mr219 looks like it applies, 227 has a conflict. It's not clear to me what the differences are or if the changes in 227 are good.
Were you able to test 219? Nobody has said anything about it yet, so maybe it works, or you could help clarify what the remaining issues are.
Looks like there are a lot of code quality issues that might be easy to resolve with some patience. That would also help speed this along.
If 219 works for you, you may as well run with it. If you hit any blockers, I'd encourage you to share patches here so we can all collaborate.
mortona2k → created an issue.
I noticed there are 2 ways to select components in a view, the display style and the row style.
Poking around more, I see the option you're talking about.
Happy with this, thanks.
Any plans to support views field values as props?
My page SDC:
$schema: https://git.drupalcode.org/project/drupal/-/raw/HEAD/core/assets/schemas...
name: Page
props:
type: object
properties:
page:
type: array
page.html.twig template, trying to include the component in different ways.
{{ include('unocss_starter:page', with_context = false) }}
or
{% embed 'mantra_starter:page' with {page} only %}
{% endembed %}
Either way, it throws the error unless attributes is defined in the page component.
Created a new issue to request bumping laminas-validator dependency in email-parse to ^3.
3.0 was released yesterday: https://github.com/laminas/laminas-validator/releases/tag/3.0.0
https://github.com/mmucklo/email-parse/issues/33
They will need to create a new version to split the dependency requirements.
I'm not familiar with email-parse. Maybe there's a better package out there, or you could try bumping the version manually to test if it still works.
Looks like there are a few breaking changes to review.
https://github.com/laminas/laminas-servicemanager/releases/tag/4.0.0
https://github.com/laminas/laminas-validator/releases/tag/3.0.0
Some further analysis.
laminas-validator 2.39 requires servicemanager ^3.21.0, but that allows updating to 3.22.0, which supports php 8.3.
servicemanager 3.22.0 - 3.23.x require psr/container:^1, which has these conflicts in my project:
drupal/core-recommended 10.3.6 requires psr/container (~2.0.2)
illuminate/contracts v10.48.22 requires psr/container (^1.1.1|^2.0.1)
league/container 4.2.2 requires psr/container (^1.1 || ^2.0)
pimple/pimple v3.5.0 requires psr/container (^1.1 || ^2.0)
symfony/dependency-injection v6.4.12 requires psr/container (^1.1|^2.0)
symfony/service-contracts v3.5.0 requires psr/container (^1.1|^2.0)
symfony/type-info v7.1.5 requires psr/container (^1.1|^2.0)
(Core being the big blocker there).
servicemanager 4.x adds support for ^1.1 || ^2.0.
So the problem is still the dependency chain on mmucklo/email-parse.
PHP 8.3, Drupal 10.3.6.
Looks like the required laminas package versions don't support PHP 8.3.
mmucklo/email-parse 2.2 requires laminas/laminas-validator: ^2.13.
https://root.packagist.org/packages/mmucklo/email-parse#2.2.1
Looks like PHP support was added to laminals/laminas-validator in 2.39.
https://root.packagist.org/packages/laminas/laminas-validator#2.39.0
2.39 requires laminas-servicemanager 3.21.0, but that does not yet support php 8.3.
So the blocker is mmucklo/email-parse because it's pinned to an outdated release. The laminas packages look like they are fixed, but are not allowed to update.
mortona2k → created an issue.
Oh you're right, I had the contrib version of navigation installed. Looks like this is not really an issue, but it will at least correct it for other people with the same situation until they upgrade.
This plugin may be helpful: https://www.npmjs.com/package/postcss-url/v/7.3.2
mortona2k → created an issue.
I can't create a merge request for some reason.
The dependency wasn't enough. I prefixed the button selector with the selector used in the navigation library, which was colliding.
The navigation library uses [class*="toolbar-button--icon"].
mortona2k → created an issue.
I don't know what exactly was causing it. Possibly including a component inside another component without specifying props to pass (inheriting from the current template/component). Possibly not using the attributes array.
It seemed like it was just from having attributes undefined in the component.yml file, but I also have some that don't have it and it's fine.
The problem was causing a whitescreen error.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
Bumping this issue because when you go to admin/config, you see a list of items that all have a description except, for paragraphs.
The patch is a simple fix, just adds a general description so the UI is consistent.
mortona2k → created an issue.
mortona2k → created an issue.
This is a great idea. This tool works great for themes/modules/profiles. Makes sense to support recipes as well.
This alter hook in this patch can be used to disable the One column layout.
https://www.drupal.org/project/storm/issues/3307055 →
I see the node that it can't be disabled in the Layout Disabled UI. Is that a limitation with the hook, or is it stopping you from doing something you shouldn't?
I am interested in this feature to support theme development.
When using a front end build tool like vite, CSS changes are reloaded on the page instantly.
Changing template code (or SDC) requires a full page reload to see changes. When coding with tailwind classes, this can be a pain.
I am thinking refreshless will have the architecture to trigger a reload by the build tool.
The mechanism for this issue would need to be in place with a way to call it. The build tool can have a plugin that loads in the browser and triggers the refresh when code is changed.
It seems like most people are working around this DX issue by theming entirely in another system like Storybook. But there is still a lot of integration work to do in Drupal, so it would be great if the DX was nice there too.
I recently posted this starter theme to provide unocss/vite setup out of the box, with lots of instructions for local dev setup.
https://www.drupal.org/project/unocss_starter →
What about aligning with the Front End Bundler initiative? https://www.drupal.org/about/core/blog/new-community-initiative-frontend... →
From a recent slack conversation, it sounds like Vite and Foxy are the tech currently in the works.
I am trying to think through a setup issue that may impact others using bundling tools. UnoCSS (Tailwind) needs to parse the code for utility classes to include. If you want to build a base theme with more flexibility, like integrating with a design system, or building assets the same way for module and themes (using shared sass/config), it's unclear how to build the libraries.
For example, I have a starterkit/base theme used in multiple projects. I want to add some customization for one of the projects I don't want to generate from the starterkit because that would fork the code. I want the subtheme to inherit templates and css unless overridden, but configuring vite to ignore templates that are overridden is difficult.
mortona2k → created an issue.
mortona2k → created an issue.
mortona2k → created an issue.
I think I have been working around this by writing component code with more specific selectors.
But I have had all kinds of problems with this as well. I don't know how to get around it because vite doesn't know about drupal's library layers and weights.
If you load stylesheets into a main js file, you can specify the order, but that will bundle them all together.
Maybe it makes sense to bundle them and load in the theme layer? Or component for modules?
Maybe use @layers to specify the order, however these will precede all drupal libraries in the cascade.
The issue I mentioned above is resolved in 1.3.0.
I was able to set up a url alias in ddev vite.SITENAME.ddev.site, and proxy port 5173.
Copy this to your .ddev/nginx_full directory: https://git.drupalcode.org/project/unocss_starter/-/blob/0.2.x/vite.conf...
It's not really necessary though, using the port in the url works fine.
This theme is a starting point for unocss + vite: https://www.drupal.org/project/unocss_starter →
I added a ton of readme notes and preconfigured it to work with lando and ddev.
It should work without unocss as well.
mortona2k → created an issue.
Please test with instructions in README-vite-dev-server.md.
Config can be copied from config.vite.yaml, vite.conf, and .lando.yml.
Some troubleshooting may be required. Please let me know if you encounter any issues and I'll update the notes.
mortona2k → created an issue.
I defined
mortona2k → created an issue.
Demo theme has default menu styles.
See /demo/unocss_starter_demo/libraries/component/menu.css.
Check out UnoCSS Starter Demo in /demo.
Install directly or generate a starter theme.
I can't understand the issue as reported, please explain further.
If you would like to propose a default footer style, with a well documented example, we can add it in the demo theme.
Otherwise, the starter theme only provides starterkit code + unocss/vite configuration.
I think it would be better to have a collection of SDCs that we could include as needed. The demo theme could show how to use those and devs could swap them out as needed.
I usually have code that pushes the footer to the bottom. I think that would be good to include with a demo.
I'm having trouble understanding the issue. Can you please explain further?
See demo/unocss_starter_minimal.
mortona2k → created an issue.
mortona2k → created an issue.
See README.md for explanation.
mortona2k → created an issue.
liberatr → credited mortona2k → .
mortona2k → created an issue.
mortona2k → created an issue.
@pfrenssen Thanks for adding those. This is something I've run into with any recurring date feature, when you set up a bunch of event instances and want to be able to determine whether to keep existing ones and how to adjust them. I would really like to see something like an event management API that is also compatible with Smart Date and Recurring Dates Field.
The docs look like my setup, and this has been working fine for a while.
I'll be talking about my experience with Vite + Drupal at PNW Drupal Summit next month.
I still have this issue though: https://www.drupal.org/project/vite/issues/3468138 🐛 1.2.1 release issues with build urls Active
I have a patch to revert the other half of the change I mentioned in there.
I did a quick test and it it looks like it's working. Thanks!
MR 46 combines this patch and 3410132.
This worked for me.
Without the patch, I was unable to edit a the caption after adding an entity embed.
However this patch conflicts with https://www.drupal.org/project/entity_embed/issues/3410132 🐛 Entity embed dialog can no longer use custom data- attributes in CKEditor 5 RTBC .
Great thank you. I'll explore Entity Reference Hierarchy some more and compare differences.
mortona2k → created an issue.
Oops that is working fine, I made a mistake in setting it up.
I rerolled onto 2.x.
There was one difference, with a new if check wrapping the previous code in the patch.
Seems to be working so far.
Failing test is local tasks?
mortona2k → changed the visibility of the branch 3418138-more-options-for to hidden.
mortona2k → made their first commit to this issue’s fork.
This is working.
With the patch, I see Book Navigation in manage display, and moving it around or disabling is working.
One issue I ran into is that if you enable a content type to be added to the book, we need to clear the cache to rerun book_entity_extra_field_info().
Seems like that could be done on submission of the book settings config form.
@lawxen, if it works with 1.0, dropping support will cause conflicts with other modules.
mortona2k → made their first commit to this issue’s fork.