🇺🇸United States @mortona2k

Seattle
Account created on 16 November 2010, almost 15 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States mortona2k Seattle

See #19 🐛 Arbitrary scroll on dialog open Needs work

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Here's the ajax commands getting returned. I removed all my custom libraries except for file.css. If I remove that one too, the modal opens.

In the console log below, the core libraries get loaded, but the file.css does not.

🇺🇸United States mortona2k Seattle

Do we need to trigger vite HMR when ajax loads assets?

🇺🇸United States mortona2k Seattle

When I open the media library widget, the vite urls for my libraries are correct but the dialog doesn't open. I don't see the libraries getting loaded in the console, but other, non vite libraries are getting included. I don't see any error/warning, but modal just doesn't open. Removing my custom libraries makes it work again.

🇺🇸United States mortona2k Seattle
🇺🇸United States mortona2k Seattle

This one is a duplicate of https://www.drupal.org/project/views_add_button/issues/3489089 📌 Drupal 11 upgrade requirements for Views Add Button Active .
However, there is more work in here, so maybe we should close that one.

Can this one be addressed at the same time? https://www.drupal.org/project/views_add_button/issues/3519204 🐛 Fix Deprecated function: Creation of dynamic property in ViewsAddButtonService line 58 under PHP 8.2+ Active
I think there is some overlap in the changes.

I installed the patch for testing on d10 and 11 sites. Will report any issues.

🇺🇸United States mortona2k Seattle

Commented out a line that was breaking the Popular Tags widget inside the modal.

🇺🇸United States mortona2k Seattle

I made you an admin and set up the menu.

🇺🇸United States mortona2k Seattle

Adding menu link.

🇺🇸United States mortona2k Seattle

Got it, thanks!

🇺🇸United States mortona2k Seattle

We still need to get the docs linked in the project sidebar.

🇺🇸United States mortona2k Seattle

I changed the permissions. Thanks for your all your effort in getting things clarified and documented!

🇺🇸United States mortona2k Seattle

Relaxing permission for others to make changes to the menu.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Great, thank you for the quick response!

🇺🇸United States mortona2k Seattle

I added a note to an issue in Views Ajax History: https://www.drupal.org/project/views_ajax_history/issues/3386120#comment... 📌 Improve module UX Active

🇺🇸United States mortona2k Seattle

In this related issue, I suggested that the archive and glossary views could be created with a pager or grouping plugin, as opposed to the summary option under contextual filter. We would need a way to group by date/year, or first char of title, and display the number of items in the group. The archive does not make sense as a pager, but the glossary could be a pager instead of contextual filter setting + attachment.

🇺🇸United States mortona2k Seattle

Configuring views with these settings is quite challenging. The summary setting is difficult to find, and doesn't make much sense to me as a contextual filter option. Also, the result count there overrides the pager options.

The glossary is basically using an attachment as a pager. What if we moved all of this into a pager plugin?

The archive makes less sense as a pager. Is it possible to do this with results grouping and aggregation?

At the top of the issue, wizards are mentioned. There is also Views Templates , which helps scaffold a view. Maybe something to bring into core? Is the wizard option still available?

A big part of the question is what's the right UX for an interface that has some routine use cases and also highly advanced options that are not very intuitive to regular users. Creating a UI that works for both beginners and experts is a hard problem. Templated setup or a wizard would also help. AI prompting and generating config has potential for sidestepping the issue.

These views are nice to have as long as the capability they demonstrate exists. Maybe they could just be moved into recipes in the standard profile.

🇺🇸United States mortona2k Seattle

I merged dev to rerun the pipelines. Previously it was showing a failure on phpunit, but I don't think that was related to this change.

Now there are only warnings, and they are all coming from other code.

I made the change locally for a quick test and don't see any issues. This is correct usage of the function, so I will mark this as RBTC.

🇺🇸United States mortona2k Seattle

mortona2k made their first commit to this issue’s fork.

🇺🇸United States mortona2k Seattle

I just saw this module get posted: https://www.drupal.org/project/htmx_dialog .

🇺🇸United States mortona2k Seattle

I can see the empty text settings in the config form now, but I don't see it appearing.

🇺🇸United States mortona2k Seattle

Linking to the issue for adding empty text to views facets.

🇺🇸United States mortona2k Seattle

I cannot find the empty facet text settings for facets in views w/ BEF.
Was that setting not carried over from 2.x?

The last patch is just setting a class. Is that working?

🇺🇸United States mortona2k Seattle

Can someone in the know please mention on the project page or docs what the plan is for this module, now that this feature has been added to core: Enable bookmarking of AJAX views Enable bookmarking of AJAX views Needs work .

Looks like that is going into 11.3, so there will be some sites that will want to keep using this until they upgrade. After that, are there any features in the module that are still useful? What will be the upgrade process when we move to 11.3?

🇺🇸United States mortona2k Seattle

Drupal core is adding ajax history capability. In the long run, Views Ajax History may no longer be needed.

🇺🇸United States mortona2k Seattle

The documentation page linked above has been updated as requested by @ressa in #3030506.

Can we add the link to the project page and close out this ticket? Or do we need separate d7/8+ documentation?

🇺🇸United States mortona2k Seattle

Describe Views Field View module.

🇺🇸United States mortona2k Seattle

No pressure. I just installed this for experimentation a while back. I pushed a PR to help others test.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

There is a 0.10.0 release, which is required by Data Logger .

🇺🇸United States mortona2k Seattle

This has been merged, but there is not release with it yet. There are some extra commits that seem to fix install issues as well:
https://git.drupalcode.org/project/content_insights_report/-/compare/1.0...

I was able to install with: composer require drupal/content_insights_report:1.0.x-dev@dev

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

I see that this adds a submodule, entity_hierarchy_child_reference.

It didn't work for me with 5.x:

Error: Call to undefined method Drupal\entity_hierarchy\Storage\RecordCollection::contains() in Drupal\entity_hierarchy_child_reference\Service\ChildReferenceFormAlter->alterHierarchyChildrenForm() (line 151 of modules/contrib/entity_hierarchy/modules/entity_hierarchy_child_reference/src/Service/ChildReferenceFormAlter.php).

🇺🇸United States mortona2k Seattle

I tried the dev release, which has #2985291 merged in. I was unable to set the draggable views parent to use the Entity Hierarchy field.

The docs mention hierarchies, and say you can select a handler. But I think that's for D7?
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib...

🇺🇸United States mortona2k Seattle

I think this ticket has a list of ajaxy things we want to do with views. Maybe not what we're looking for in a POC, but things to cover in the long run? https://www.drupal.org/project/drupal/issues/2022297

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Was looking for this in the 7.0.5 release. I see it's already in 7.1.x.

Could reopen this for a backport, but it's not a priority for me at this time.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Ok, done.

🇺🇸United States mortona2k Seattle

Add menu link.

🇺🇸United States mortona2k Seattle

Needs a reroll on the dev branch. I ran into several conflicts.

🇺🇸United States mortona2k Seattle

I often resort to this module as a workaround for views aggregation issues.

🇺🇸United States mortona2k Seattle
🇺🇸United States mortona2k Seattle

I can reproduce this with a custom/minimal theme, and also with Olivero.

As I click through the pagers, sometimes it scrolls up, and sometimes it doesn't.
Seems like a race condition?

Here's the ajax commands in the response.

🇺🇸United States mortona2k Seattle

If I implement this it will probably be in the form of a sub-module at a first stage so that I don't break existing installations.

Sounds good, thanks!

🇺🇸United States mortona2k Seattle

Quick fix to add the link. Could use some adjustment to how things are parsed and implemented.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

The patch is working to track media used in content via paragraphs entity embed.

🇺🇸United States mortona2k Seattle

#10 fixed the error for me.

🇺🇸United States mortona2k Seattle

This patch fixed my problem above: https://www.drupal.org/project/drupal/issues/3496329#comment-15923800 💬 CKEditor stops loading on existing content after Drupal update to 10.4 Active
Was related to: https://www.drupal.org/project/ace_editor/issues/3499338 🐛 Cannot read properties of undefined (reading 'attach') on D10.4.x Active

🇺🇸United States mortona2k Seattle

This worked, even for gnode. It's working for node and media from the group listing pages.

The page to pick the bundle now has destination query parameters in the url.

I had to add the hook in the description for the add new/existing local tasks. This could be improved by targeting all of them programmatically, and it targets things added by other modules.

function group_menu_local_actions_alter(&$actions) {
  $actions['group_relationship.group_node_add_page']['class'] = \Drupal\group\Plugin\Menu\LocalAction\WithDestination::class;
  $actions['group_relationship.group_node_create_page']['class'] = \Drupal\group\Plugin\Menu\LocalAction\WithDestination::class;
  $actions['group_relationship.group_media_add_page']['class'] = \Drupal\group\Plugin\Menu\LocalAction\WithDestination::class;
  $actions['group_relationship.group_media_relate_page']['class'] = \Drupal\group\Plugin\Menu\LocalAction\WithDestination::class;
}

There is a new class in core that should support this: https://www.drupal.org/node/3490245

🇺🇸United States mortona2k Seattle

Simple code change sorts the paragraph names before creating the options.

Worked for me and did not throw the error mentioned in #3.

🇺🇸United States mortona2k Seattle

Rough draft of a year display.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

I was able to use the autocomplete reference widget. Maybe it's possible to write a custom field/widget for my external entity plugin.

I'd like to be able to post the issue number, and the autocomplete should pull the title from the api to verify it exists and you pasted the correct one. Similar to how related issues work here in the issue queue system.

🇺🇸United States mortona2k Seattle

Here's the system branding block. There should be config options for showing the logo, site name, and slogan.
But we can only override the title here.

🇺🇸United States mortona2k Seattle

This should do it.

🇺🇸United States mortona2k Seattle

When exposed filters are not shown in a block, they are all within a form in the exposed variable, in the views-view template.
Exposed sorts are included here as well.

Printing {{ exposed }} twice in the view template causes the bug in #2876197 🐛 Views multiple exposed form, Ajax enabled, multiple ajax hits on submit Needs work .

Are there any other ways to print the exposed filters/sort in separate forms, without exposing as a block and using Configurable Views Filter Block?

I have been trying things like manipulating the exposed form id:

{% set exposed_modified = exposed|merge({'#id': exposed['#id'] ~ '-sort_by'}) %}
{{ exposed_modified|filter((v,k) => k starts with '#' or k in ['sort_by', 'actions']) }}
{{ exposed }}

This doesn't work though, the first one refreshes the page.

🇺🇸United States mortona2k Seattle

On a fresh site, enable the External Entities Drupalorg submodule.

Create an Issue content type, with an entity reference field to Drupal.org issue - REST.

Default options for the reference field are the autocomplete field. I tried with and without the create is not existing option.

I was able to set up annotations this time, I'm not sure why I couldn't before, but the reference field wasn't showing as an option to select.

🇺🇸United States mortona2k Seattle

I don't think this is working. When I put in an ID value, the node saves without the value.

🇺🇸United States mortona2k Seattle

I tried to merge in upstream changes to another branch.

There is a collision on simplify_hide_field() for the revision_information case.

https://git.drupalcode.org/project/simplify/-/blob/2.x/simplify.module#L661

Looks like this line should be changed:
$form['revision_information']['#attributes']['class'][] = 'visually-hidden';

But what about the line below it?
$form['revision_information']['#group'] = '';

Aside from line number updates, this is the only difference with the previous branch.

🇺🇸United States mortona2k Seattle

Or close in favor of this issue?

🇺🇸United States mortona2k Seattle

D7 version had a button: https://git.drupalcode.org/project/collapse_text/-/tree/7.x-2.x/wysiwyg/...

But not d8+. Can we change to a feature request instead of critical bug?

🇺🇸United States mortona2k Seattle

Removed version change, use patch from #3289938 instead.

🇺🇸United States mortona2k Seattle

Follow up in this other issue?

🇺🇸United States mortona2k Seattle

Is this ready for review?

🇺🇸United States mortona2k Seattle

Has been working for me 3+ months.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

mortona2k created an issue.

🇺🇸United States mortona2k Seattle

Agree with above. Seems like there are different patches to apply for d10/11.

Here's mine for 10:

"patches-ignore": {
    "drupal/media_contextual_crop_embed": {
        "drupal/core": {
            "Patch installed by Media Contextual Crop Embed is outdated": "https://www.drupal.org/files/issues/2024-06-25/2925890-75.patch"
        }
    }
}
"patches": {
    "drupal/core": {
        "Update patch installed by Media Contextual Crop Embed module": "https://www.drupal.org/files/issues/2025-08-11/2925890-84.patch"
        }
    }
}

*patches-ignore didn't work in my external composer.patches.json file, and had to be placed in composer.json.

🇺🇸United States mortona2k Seattle

Reroll needs testing.

🇺🇸United States mortona2k Seattle

Can you provide an example please?

🇺🇸United States mortona2k Seattle

Patch needs reroll.

🇺🇸United States mortona2k Seattle

Drupal 8 has been EOL since 2021: https://www.drupal.org/psa-2021-11-30

D11 support was added to search_api_sorts_widget Dec 2024:
https://www.drupal.org/project/search_api_sorts_widget/releases/1.0.0-beta5

Can we close this? If more work is needed, I suggest opening a new one.
IE to resolve issues with facets mentioned above, or merging the widget module into this one.
Or reopen this one, with an updated title and description.

🇺🇸United States mortona2k Seattle

All this does is update core_version_requirement.

It's working so far without any issues.

🇺🇸United States mortona2k Seattle

This doesn't seem right. I added the reverse reference field mentioned above to the index. When I add the field to a view, it is a linked title field to the content. I expected it to be the group itself. When used as a filter, neither the group name or id works.

Alternative options I'm looking at for indexing/searching group content:

Group Computed Field
But it's not yet available for Drupal 11 📌 Automated Drupal 11 compatibility fixes for group_computed_field Needs review .

Potential issue with search/facets/group access. 📌 Facets with Search API bypass Group module's entity access restrictions Active
New issue and has some traction, with a patch to try.

These modules also do something for computed fields, seemingly related to this:

Group Linked Entity .
No users yet.

Group Relationship Inheritance .
1 user.

Group Extras .
Adds group reference field to content. 13 users.
D8/9 only.

🇺🇸United States mortona2k Seattle

Bumping to the latest branch, where the fix should be applied first.

I'm seeing very similar behavior when using this module vs the patch for the native remove button in the link above.

I encourage directing effort toward the other ticket, since a native remove button means we don't need an extra module.

🇺🇸United States mortona2k Seattle

I'm hitting an issue with this patch that seems similar to comments in linked issue for the Multiple Fields Remove Button module.

When the values are recurring, the remove button doesn't work. I see the form refresh, but comes back with the same values.

🇺🇸United States mortona2k Seattle

The patch in this issue might avoid the need for this extra module.

🇺🇸United States mortona2k Seattle

And if anyone needs media inside of paragraphs, use groupmedia_paragraphs.

🇺🇸United States mortona2k Seattle

Oops, this already exists and works fine.

The option is in the group content settings for the media types.

🇺🇸United States mortona2k Seattle

Perhaps this is a feature request?

Changing bundles programmatically is easy. Load the entity, set the type, save.

The hard part is that fields may be different, and there is no way to map values (yet).

Also, what to do with revisions? (for changed bundles, cloning won't have this problem).

🇺🇸United States mortona2k Seattle

I've been using UI Patterns, which lets you assign entity values to SDC props/slots. That could be used in multiple ways on a site, so having the value attached to an entity instead of calculated in a block would be helpful.

🇺🇸United States mortona2k Seattle

I am also encountering this issue with checkboxes.

The field with checkboxes should be visible and required when a select list has a certain value. Hiding it is working, but making it required is not. Setting the field to required, and using states to make it optional is also not working.

🇺🇸United States mortona2k Seattle

I added a patch for altering the content before extracting tags.

In a custom hook, I rendered the entity and stripped tags to get the full text including paragraphs and layout builder content.

This works for now, but a better way to go would be to create a new plugin for the field widget. It's tricky because the javascript loads values from the form to pass to the controller.

Some additional logic might be needed, like a way to ignore certain fields or values that might be more like labels and not relevant for content tags.

🇺🇸United States mortona2k Seattle

mortona2k changed the visibility of the branch master to hidden.

Production build 0.71.5 2024