🇺🇸United States @mortona2k

Splitting the ticket into the UX issue vs the "Term" label issue.

mortona2k → created an issue.

This is working for me on a Drupal 10.5.1 site with UI Icons Backport.

Drupal 10 support was removed from iconify_icons_provider in: https://git.drupalcode.org/project/iconify_icons/-/commit/eca5c1f4b6b1a9...

There is no mention of why it was removed in the issue: https://www.drupal.org/project/iconify_icons/issues/3495277 📌 Add a link to Iconify Icons Provider configuration in Allowed icon packs settings from UI Icons Field module Active

Seems like it was removed by mistake?

The type declarations were added in https://git.drupalcode.org/project/vite/-/commit/56f50a4067536e8b756e1a2...

Here's a patch made by reverting the commit, which includes some additional changes in test files.

I agree with @vegardjo's proposal. This seems like a good time to investigate whether this can be rolled into the main module.

I had to save the node display form after creating a content type, or else the default display mode is not available for selection.

For the clone displays tab, both the default display and form mode need to be saved, or else they don't appear.

I don't see another issue for this.

Field formatter settings look a little broken too:

I cannot get the separator field to appear.

mortona2k → created an issue.

I'm having a much better experience with Tagify, which I see has become the default widget for entity reference fields in Drupal CMS: https://www.drupal.org/node/3513534 → .

I have been happy with Config Devel for updating install/optional config in my custom modules.

You list the config you want to export in the module's info file, under config_devel: install/optional, and then run drush cde (config devel export). That will export your site's config that is listed into the module's config directory.

This issue is for allowing Config Devel to export to recipes: https://www.drupal.org/project/config_devel/issues/3472623 ✨ Allow writing configuration to recipe's config directory Active

mortona2k → created an issue.

The setting appears on the views display config form as a Table Tools checkbox, under Widgets & Elements.

The tabletools code is in the 1.9.3 zip file linked on the project page, but not the 1.10.x version that gets downloaded with composer by datatables/datatables in the 2.x branch.

Fixes the warning.

The datatables/datatables package is the jquery plugin, distributed on packagist.

This puts it into the vendor directory, which is why the readme says to copy it into /libraries.

It also says to use mnsami/composer-custom-directory-installer to automate that setup.

Buy why use this instead of a more common method like composer merge plugin, or providing instructions to set up the repo in your composer.json so that it installs in /libraries instead of /vendor?

This corrects the spelling of viewed, from "viewd".

Any interest in integrating with UI Styles?

+1 for media support.

Here's a start for the orientation and year filter.

With ajax enabled in the view, the date picker pops open again after the refresh.

I tried to use autoclose: true, but it gets reopened. I'm wondering if using once would prevent this from happening.

mortona2k → created an issue.

I find composer.libraries files to be the most reliable and best DX.

Sometimes asset packagist is out of date, or has weird names/differences between npm and bower.

I just ran into an issue with fontawesome. While waiting for a patch to composer.libraries.json to get accepted, I can just copy the repository definition into my root composer.json.

Can you please also create a 2.x branch for further development?

mortona2k → created an issue.

The problem is that the Drupal.org packaging script info is in the actual repo file (should only be added when installed by composer).

https://git.drupalcode.org/project/edit_media_modal/-/blob/2.x/edit_medi...

That needs to be removed separately, it's conflicting with this MR.

Here is a patch that doesn't have that change.

v17.4 just came out.

Referenced stripe compatibility issue in Give module.

Ha, now this has leapt ahead of other stripe modules and still can't be installed.

drupal/commerce_stripe 2.0.1 requires stripe/stripe-php (^15)
drupal/stripe 2.0.1 requires stripe/stripe-php (^7 || ^8 || ^9 || ^10 || ^11 || ^12 || ^13 || ^14 || ^15 || ^16)

Are you able to allow multiple versions, or does that cause compatibility issues in the code?

mortona2k → created an issue.

This issue sounds the same as the related one, I think it's a duplicate: https://www.drupal.org/project/views_aggregator/issues/3472336 🐛 [META] Fix separators / decimals calculations Active

The patch in this module seems to fix the calculation and formatting issues: https://www.drupal.org/project/views_aggregator/issues/3482129 🐛 Crashes with Drupal\views_aggregator\Plugin\views\style\Table::setAggregatedGroupValues(): Argument #3 ($group_aggregation_results) must be of type int, string given Active

MR36 fixes the issues with number formatting with decimals/commas: https://www.drupal.org/project/views_aggregator/issues/3482129 🐛 Crashes with Drupal\views_aggregator\Plugin\views\style\Table::setAggregatedGroupValues(): Argument #3 ($group_aggregation_results) must be of type int, string given Active

To test, I added a decimal field to the article content type in the standard install profile, and generated content with devel generate.

Then I created a view that lists article titles and the decimal field, formatted with views aggregator.

Group sum:

Column sum:

There are a handful of options to test, like enabling prefix/suffix, which is configured in the field settings.

There are settings for dependent filters within facets, but I think they do 2 consecutive updates, instead of the first just updating options in the second.

Here are some modules to investigate as well:

https://www.drupal.org/project/selective_better_exposed_filters →
https://www.drupal.org/project/views_selective_filters →

A recent use case I had for a window function is to group by a reference field, and then show fields from the entity with a max field value within that group.

It would be great to be able to customize the quarter start/end dates for other business calendars.

This module is an enhanced version of the core menu block. The options are most visible in the block config form.

If you already have a menu block placed, you need to remove and replace it in order to see the new settings.

Changing target branch.

mortona2k → made their first commit to this issue’s fork.

There is some info in here that is potentially helpful: https://www.drupal.org/project/drupal/issues/2353419 📌 Improve the way how views renders their contextual links Postponed: needs info

It looks like the .contextual element that contains the button and links gets removed on the ajax reload.

I think this is because it's inside the element that is getting replaced.

In the browser inspector, I moved the element outside of the .view element, and then ajax reloads don't remove them!

A potential workaround is to just move them after the initial load, but that feels a little dirty.

Are there any other examples of a component being refreshed with ajax that should have contextual links?

Something happening in the views display plugin, Table->setCell().
https://git.drupalcode.org/project/views_aggregator/-/blob/2.1.x/src/Plu...

By tracing the code with xdebug, I was seeing that the value gets rendered as markup, but then extracted as a string value before checking if the field isRenderable() and running renderNewValue(). The issue is somewhere in those functions.

I tested with this, to not process the title field on that line, and it rendered fine.

if ($field_name != 'title' && $is_renderable = $this->isRenderable($field_name, FALSE)) {

Not sure what else is wrong, but hopefully this gives the next person a better starting point.

Sorry, was actually not caused by this module.

mortona2k → created an issue.

Here's where the argument options are loaded in the settings form: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/views...

$relationship_options is empty when the view is aggregated.

The Author argument and Roles field are defined here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/user/...

Setting $data['user__roles']['roles_target_id']['field']['no group by'] = FALSE allows selecting the relationship with aggregation enabled.

I'm not really sure what the implications of this are though.

This issue may be broader, I just encountered it with a Maximum grouping.

Working with an aggregated table recently I was able to hide the problem field, then add Custom Text field, add the token for the problem field to it and then it displays correctly.

This workaround was helpful.

This got it working for me, thanks!

I can't really account the parameter type question, but it looks like this change should be compatible with what's currently there.

There were changes to function definitions from the last commit on dev: https://git.drupalcode.org/project/views_add_button/-/commit/65bd7d0eb8a...

I think there are some differences between dev and the current release in the file you linked.

Since this MR also changes those, you probably want both.

There are two very different approaches in the patches here.

#11 has:

+    if (is_string($value)) {
+      if (strtotime($value) !== FALSE) {
+        $value = date("Y", strtotime($value));
+      }
+    }

This will convert date strings to year.

#18 has:

+    if (is_string($value)) {
+      $value = (float) $value;
+    }

This will convert a date string to to a number like 2025.0.

A patch in #3338895 has:

+    $value = round((float) $value, $precision);

Basically the same as #18, without the check for a string.

I bundled them all together and came up with this:

    if (is_string($value)) {
      if (strtotime($value) !== FALSE) {
        $value = date("U", strtotime($value));
      }
    }

    $value = round((float) $value, $precision);

Now a date string is converted to a timestamp. However, I'm not sure if this does anything for the max comparison, or if this just rendering the value afterwards.

Sorry, these are actually a little different, but overlapping. This one addresses invalid numeric field values, the related issue is about date strings, which can cause this error because they're an invalid number. There is a patch in there that has this code, however there is also one that tries to fix the dates as well.

The description and patch in this issue is the same as #3302573.

This bug is impacting everyone who has had to set up a view with this module.

The code change is a simple fix, and solved the problem for me on D11.

Thank you!

I'm getting this error on a fresh install on Drupal 11.

All I did was create a view, and enable this display. I'm unable to get past the error with any settings.

I think we should use the Enabled modules list, instead of the modules, which can take a while longer to load.

We'll need a link to create documentation in the Enabled modules report. Looks like the code is supposed to do that, but I only see existing ones.

Display the module enable history in the report.

Remove the links

- which ones?

I applied the patch to the 2.x branch and pushed it as MR7. But looks like I forgot to set the MR to merge into 2.x. Just did that.

Closing in favor of: https://www.drupal.org/project/faker/issues/3529201 📌 Support Devel Generate >5.1 Active

It looks like the change was made in https://www.drupal.org/project/faker/issues/3503237 🐛 Unable to access the Devel Generate Content and Generate User Settings forms after enabling Faker module Active

I think Devel Generate code was modified after 5.1, and the linked issue patched faker for compatibility with the previous version.

We should create a 3.1.x branch for compatibility with >=5.1.

Fixed by checking for status field.

Actually this is for the Replicate Actions module.

mortona2k → created an issue.

mortona2k → created an issue.

Pushed the fix.

Sorting the field machine names was easy, and a big QOL improvement when you have lots of fields.

We could check this MR in now and improve it further later. Or create a separate issue?

mortona2k → made their first commit to this issue’s fork.

Add instructions for dialog options.

I figured out how to do this and added a patch for Views Add Button.

The trick was to call Drupal.attachBehaviors(element) after adding the dialog attributes to the links.

I will follow up on this work in https://www.drupal.org/project/views_add_button/issues/3529307 ✨ Open in modal and reload view with ajax Active .

Currently, I'm able to set up an Add content button in the admin content view that can load the content add page, select a type, fill out the form, and refresh the view.

There is already an Add content action button on that page, which can be set up to use a dialog with Admin Dialogs. This script would be useful in the same way, to ajaxify the links on the page and allow the form to load in the modal.

https://git.drupalcode.org/project/views_add_button/-/blob/978b1d92cb8d1...

Added dialog options.

I am seeing the buttons as user 1 at least, but the current code is clearly flawed and the patch corrects it.

Here's a working proof of concept. It uses a form alter hook (currently only articles) to add an #ajax handler to the submit button to close the modal and refresh the view after submitting.

But I have an error when ckeditor is in the form, so hide the body field before trying this.

Here's the error:

Uncaught TypeError: dialogSettings is undefined ckeditor5.js:681:23

We can configure the attributes we need for the modal in the settings form so I wouldn't need Admin Dialogs, but the drupal.dialog.ajax library needs to be loaded. That could be set with a checkbox on the config form.

Looks good.

Here it is in claro.

And my custom theme, with overridden css, I had to update the show hide of the new element in the media query. (rotation not added)

Great, it installed. I'll try it out next time I need to do an import. If you want to close this ticket, I will follow up if I find any issues.

mortona2k → created an issue.

I added an issue for opening the entity add page to get the full list of bundles, with descriptions, which can be helpful for content entry: https://www.drupal.org/project/views_add_button/issues/3529943 ✨ Link to entity add page without bundle Active

Still using Admin Dialogs for the modal. It's working, but the links redirect to the entity form instead of reloading in the modal.

To fix, each link needs to have the use-ajax class, and drupal-dialog-type="modal".

I tested this by modifying template_preprocess_admin_block_content(), where the links are generated. It works!

To implement, we could add some js to add the attributes when the modal loads.

I pushed up plugins for Node and ECK.

To use them, select any bundle, it will just be ignored in the url generation and access check.

mortona2k → created an issue.

I was able to set a variable with {% set pageContent %}

text goes here

{% endset %} syntax, declare a pageContent text control, pass pageContent into the story as an arg, and print the html with {{ pageContent|raw }}.

The storybook control contains the html as text, but renders as markup correctly.

+1

Does anyone have advice on how to set up caching on a dev site so it's usable? I have all caching disabled, and the UI Styles form can take a while to load each time.

mortona2k → created an issue.

I am currently using this on several sites without issue, combined with Entity Prepopulate → .

Example: article={{ raw_arguments.field_article_target_id }}

mortona2k → created an issue.

mortona2k → created an issue.

mortona2k → created an issue.

mortona2k → created an issue.

mortona2k → created an issue.

Patch fixed it for me, with the simple case from my comment above.

Code change looks fine, but I'm not sure what variations of data will be seen here.

I'm working on a minimalist theme that works as an admin theme. It's a bit of a hobby project, but I would like the ability to disable the notice, if added.

More preferable, I'd like an easy way to implement a working display in my theme. I currently have a few hacks in place so I can use it, but it's still buggy.

I'm not sure if it's possible to code a compatible widget without considering the theme it will be rendered in, but I'm thinking along the lines of an SDC with self contained styles via css scoping.

Just thinking out loud, not to hold up progress on this issue.

I'm seeing a vertical scroll when the month view is at a narrow width. If I set the ratio low, like .5, it stretches it out too long.

More clarity/control over this would be much appreciated.

Is the code in here helpful? https://www.drupal.org/project/fullcalendar/issues/3527506 ✨ Extensible javascript FullCalendar object. Active

Workflow has a 2.x release now.

mortona2k → created an issue.

mortona2k → created an issue.

I don't think the profile I created is being called when I use drush genc.

[warning] Undefined array key "faker_profile" FakerContentDevelGenerate.php:45