Support stripe/stripe-php:^7

Created on 17 June 2024, about 1 year ago

Problem/Motivation

The Stripe module requires stripe/stripe-php as ^7.

https://git.drupalcode.org/project/stripe/-/blob/2.x/composer.json?ref_t...

This prevents Give from being installed.

Steps to reproduce

composer require drupal/give drupal/stripe

Proposed resolution

Update stripe version and review changes.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mortona2k
  • πŸ‡ΊπŸ‡¦Ukraine ruslan piskarov Kyiv, Ukraine

    We definitely should update it. Subscribing.

  • I just found this. The current stripe package is ^5 from 2018 while the latest is v17
    Some credit card payments are failing because of lack of authorisation.
    I guess that banks are requiring additional authentication in a popup or something.
    Hopefully upgrading the dependency will fix this.

  • I've now got stripe payments working with the latest Stripe php library.
    However recurring payments are just too much trouble for me and my client.
    So I will disable them until someone wants to develop them.

  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    Ha, now this has leapt ahead of other stripe modules and still can't be installed.

    drupal/commerce_stripe 2.0.1 requires stripe/stripe-php (^15)
    drupal/stripe 2.0.1 requires stripe/stripe-php (^7 || ^8 || ^9 || ^10 || ^11 || ^12 || ^13 || ^14 || ^15 || ^16)

    Are you able to allow multiple versions, or does that cause compatibility issues in the code?

  • thanks for jumping on it.
    Before widening the composer version constraints, we would need to know about API changes.
    This new version I've just done uses a small faction of the stripe library - the paymentIntent class and the /Stripe/Stripe class.
    There's a good chance commerce will work fine with stripe 17, they just didn't update the version constraints yet.

Production build 0.71.5 2024