Kyiv, Ukraine
Account created on 30 January 2009, over 16 years ago
#

Merge Requests

More

Recent comments

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine
🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

The same issue during updating from Group 2.3.2 to 3.3.5.

drush updatedb
[success] No pending updates.

The website encountered an unexpected error. Try again later.
Drupal\Core\Field\FieldException: Attempt to create a field without a field_name. in Drupal\field\Entity\FieldConfig->__construct() (line 124 of core/modules/field/src/Entity/FieldConfig.php).

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Reviewed it on my local project, and I think it is a helpful feature request.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Attaching patch from merge request 97.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you @byronveale, @bkosborne and @vinodhini.e.
Merget to master.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

@byronveale, brilliant. I am going to review tomorrow. Thank you.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

@sourav_paul, you should be credited in #15. I didn't know why it didn't. I will have a look when I have time.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Hey @byronveale.

I think you can use hook_form_alter() in your custom module.
Example:

/**
 * Implements hook_form_alter().
 */
function replicate_actions_form_alter(&$form, FormStateInterface $form_state, $form_id): void {
  if (strpos($form_id, '_replicate_form')) {
    /** @var \Drupal\replicate_actions\Form\ReplicateFormAlter $replicate_form_alter */
    $replicate_form_alter = \Drupal::service('replicate_actions.replicate_form_alter');
    $replicate_form_alter->alterForm($form, $form_state);
  }
}

Or implement your own EventSubscriber:
class ReplicateChangeAutor implements ReplicateSetEntityEdit.

However, if you can create a patch, I will add this functionality to the module. I think it is a great idea.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Look https://www.drupal.org/project/views_ical/issues/3435484 📌 Automated Drupal 11 compatibility fixes for views_ical Needs review

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Hi @hitchshock, I am not sure what I did wrong. As I see you and @joelpittet were tagged.
It's strange that you weren't credited.
I'm going to see how I can fix this.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you @mortona2k and @vinodhini.e.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

ruslan piskarov made their first commit to this issue’s fork.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you, @berliner. Merged.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you @goodboy for your reply. You are right.
Created another issue https://www.drupal.org/project/autoban/issues/3527487 Is is possible to remove the Database Logging dependence? Active .

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

ruslan piskarov made their first commit to this issue’s fork.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

The patch 32 can be applied to Version 3.1.0, but in DEV it was fixed in another way.
You can have a look Database Indexes was never created because incorrect key in hook_schema 🐛 Database Indexes was never created because incorrect key in hook_schema Fixed .
Leaving this task for reference. Decided do not close this task for now.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

ruslan piskarov made their first commit to this issue’s fork.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

We definitely should update it. Subscribing.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Could the author of the module create a new release for Drupal 11? Thanks.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Looks good too. We need a D11 release as soon as possible. Could the author of the module create the 3.0.0 release?

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Looks good too. We need a D11 release as soon as possible. Could the author of the module create a new release?

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Looks good for me.
The community are need a D11 release as soon as possible. Could the author of the module create a new release?

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

We need a D11 release as soon as possible. Could the author of the module create a new release?

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

+ describing. We need a release for Drupal 11 as soon as possible.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

We need review and create a new release for Drupal 11 ASAP. Thanks. As I see the version 3.0.0 supports D10 only.
Why this task was marked as fixed?
Could you create a new release from https://www.drupal.org/project/fontawesome_menu_icons/releases/3.x-dev ?

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

We need review and create a new release for Drupal 11 ASAP. Thanks.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

We need review and create a new release for Drupal 11 ASAP. Thanks.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Added 'datetime' field type.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

@mark_fullmer, you are right. I didn't see #3317769 before. Thank you very much for the quick response, and have a tremendous day.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you, @mark_fullmer, for your reply.
I am looking again.

A fresh D10 site enabled the Linkit module v 7.0.0-alpha1 and media macher.
Create two media 1.jpg and 2.png.
In CKeditor
Create a node with "Text Link" text and two images (one image inserted as media, one uploaded as file).
Link all elements to "2.png" media.

A source code will be

<p>
    <a href="/media/4" data-entity-type="media" data-entity-uuid="2142ef3f-60e0-4115-80ce-8d460aa5406a" data-entity-substitution="media">Text Link</a>
</p>
<a href="/media/4"><drupal-media data-entity-type="media" data-entity-uuid="c390e8a9-0b66-4c44-8bd3-dd79b95d4c65">&nbsp;</drupal-media></a>
<a href="/media/4"><img src="/sites/default/files/inline-images/3.jpg" data-entity-uuid="3d311f2c-0dad-4ef6-a1ec-949d0c069523" data-entity-type="file" width="1800" height="943"></a>

Rendered HTML will be

<p>
  <a href="/sites/default/files/2024-11/2.pdf" 
     data-entity-type="media"  
     data-entity-uuid="2142ef3f-60e0-4115-80ce-8d460aa5406a" 
     data-entity-substitution="media" title="2.pdf">Text Link</a>
</p>
<a href="/media/4">
  <div class="media media--type-image media--view-mode-default">
    <div class="field field--name-field-media-image field--type-image field--label-visually_hidden">
      <div class="field__label visually-hidden">Image</div>
      <div class="field__item">
        <img loading="lazy" src="/sites/default/files/styles/large/public/2024-11/1.jpg.webp?itok=5BbDYn1H"
                                    width="480" height="251" alt="test">
      </div>
    </div>
  </div>
</a>
<a href="/media/4">
  <img data-entity-uuid="3d311f2c-0dad-4ef6-a1ec-949d0c069523" 
       data-entity-type="file"
       src="/sites/default/files/inline-images/3.jpg" width="1800" height="943"
                            loading="lazy">
</a>

So, it works nicely with texts but has media issues.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you, @pianomansam. Have a great time.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I apologize. I meant a new release for Drupal v11.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Will be great if we will have a release for Drupal 10.3.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

+1 for an official release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Yes, we can do as @flyke proposed at #27.
+1 for an official release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

+1 for an official release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

+1 for an official Drupal 11 release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

+1 for an official release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Reviewed MR14 . Looks good for me.
+1 for an official release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

+1 for an official release. Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Reviewed MR12. Looks good for me.
+1 for an official release.
Thanks for working on this!

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Reviewed. I believe we can have a new version for Drupal 11 as soon as possible. Thank you.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Reviewed. I believe we can have a new version for Drupal 11 as soon as possible. Thank you.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I believe we can have a new version for Drupal 11 as soon as possible. Thank you.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Reviewed. I believe we can have a new version for Drupal 11 as soon as possible. Thank you.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I believe we can have a new version for Drupal 11 as soon as possible. Thank you.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I believe we should create a new release for Drupal 11 as soon as possible.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I believe we should to create a new release for Drupal 11 as soon as possible.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Created MR !6. Also I have removed "Information added by Drupal.org". This information will be added for each release automatically. I think we can create a new release for Drupal 11 as soon as possible.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Is it possible to make a new release for Drupal 11?

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you @flyke.
I think need to create a new release ASAP.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I can apply #8 patch to filefield_paths:1.0.0.0-beta7.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Is this issue again in 6.1.4 and 7.0.0-alpha1 or did I miss something?
With "Direct URL to media file entity" option I see an URL like media/XXX.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

I have committed a simple fix.
It can be improved if required by using regex. Also "if (filter_var($string, FILTER_VALIDATE_EMAIL))" can be replaced with something like "\Drupal::service('email.validator')->isValid($string)".
I decided to use explode() instead of preg_replace() because explode() will work faster.

🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine

Thank you, ELC. It was merged into DEV. I will have a look later.
Regarding to tests. Currently, I don't have free time to write this today. I am in Ukraine, and I have other priorities. If someone is willing and able to do it, I appreciate it more.

Production build 0.71.5 2024