Contrib.social

Fix pipeline validate warnings: cspell, phpstan

Open on Drupal.org →
Created on 8 August 2024, 4 months ago
Updated 23 August 2024, 3 months ago

Problem/Motivation

cspell shows unrecognized words:

=== This is _cspell_unrecognized_words.txt ===
Overriden
Piskarov
preven

phpstan shows 

 ------ -------------------------------------------------------------------- 
  Line   tests/src/Functional/AdvupdateTest.php                              
 ------ -------------------------------------------------------------------- 
  33     You should use assertTrue() instead of assertSame() when expecting  
         "true"                                                              
 ------ -------------------------------------------------------------------- 
 [ERROR] Found 1 error

Steps to reproduce

Run testing pipeline against code:
https://git.drupalcode.org/project/advupdate/-/pipelines/173262

Proposed resolution

Add .cspell-project-words.txt with Piskarov in it. Fix the others.

Change the assert.

Make Drupal 11 release. Test against Drupal 11.

Remaining tasks

Make Drupal 11 release as code is compatible: 📌 Automated Drupal 11 compatibility fixes for advupdate Fixed

User interface changes

n/a

API changes

n/a

Data model changes

n/a

📌 Task
Status

Fixed

Version

1.0

Component

Testing

Created by

🇦🇺Australia elc

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024