- 🇺🇸United States smustgrave
With D7 EOL approaching in a month I'm starting to triage the D7 side of quicktabs queue. Thanks though!
If still an issue or needed for 4.0.x (latest branch) feel free to reopen
- 🇧🇪Belgium dieterholvoet Brussels
dieterholvoet → changed the visibility of the branch 3422332-1.0.x to hidden.
- 🇧🇪Belgium dieterholvoet Brussels
dieterholvoet → changed the visibility of the branch 1.0.x to hidden.
- Issue created by @nicxvan
- 🇮🇳India akulsaxena
Sorry, my commit message has wrong spelling for "Updated".
Anyways, Made the suggested changes
Please review. - 🇬🇧United Kingdom joachim
It's core/modules/locale/src/LocaleConfigManager.php that needs fixing.
I have made a merge request addressing this issue this as part of Drupalcon Singapore 2024 Contribution Day.
@larowan came by and suggested to add a message explaining the empty field rather than altering the behaviour of the edit settings gear icon, as this would requireEntityDisplayFormBase::buildFieldRow()
to traverse all the nested fields inside of widget settings form to check if they are visible.
Removing the form element from the settings form was also not advisable as this would change the form schema.- @zoee-y opened merge request.
- @yvonnelmyy opened merge request.
- @starlight-sparkle opened merge request.
- First commit to issue fork.
- 🇵🇭Philippines kenyoOwen
Hi akulsaxena
For the
#Subpathauto
section, for better readability. I prefer thisThe Subpathauto module extends the functionality of the Pathauto module by enabling automatic URL alias creation for sub-paths of existing aliases. This feature helps maintain consistency and usability for nested paths within your Drupal site.
And the#Subpathauto
section missing aproject page
andissue queue
links.
Make sure alsotext manually word-wrapped within around 80 cols
, as Per README.md template.Thanks.
- 🇮🇳India rahul_ Alirajpur
I am still working on this, will continue for another 24 hours.
Till Now -
I fixed most of the Errors mentioned above, and only a few are remaining, once I fix them tomorrow, and test the module, I will mark PR as ready for review.ddev . phpstan analyze web/modules/contrib/quicktabs
- 🇸🇬Singapore anish.a Singapore
@lavanyatalwar It is already being worked on by @rahul_ in DrupalCon Singapore and he is already in finishing stages. I suggest to take up another issue to avoid duplicate work.
- 🇸🇬Singapore Lee Jun Long
Hi, I am looking into this issue queue as part of Drupalcon Singapore 2024 Contribution day, and hope I can contribute in one way or another.
I have made a fresh installation of a Drupal 11 site to check on this, and tried to search the codebase for the code block shown in the Problem/Motivation. I realised that the only location I can find comes from
core/modules/locale/src/LocaleConfigManager.php
. I checked that merge requestMR !6723
, and found that the MR includes changes to bothcore/modules/locale/src/LocaleConfigManager.php
andcore/modules/locale/locale.bulk.inc
. This confused me as I didn't understand the current state of the issue queue, and how I can contribute further. - 🇸🇬Singapore anish.a Singapore
FYI, these are the errors
30/30 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ------------------------------------------------------------------------------ Line quicktabs_accordion/src/Plugin/TabRenderer/AccordionTabs.php ------ ------------------------------------------------------------------------------ 54 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line quicktabs_jqueryui/src/Plugin/TabRenderer/UiTabs.php ------ ------------------------------------------------------------------------------ 27 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ----------------------------------------------------------------------------------- Line src/Controller/QuickTabsController.php ------ ----------------------------------------------------------------------------------- 48 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Form/QuickTabsInstanceEditForm.php ------ ----------------------------------------------------------------------------------- 49 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------- Line src/Plugin/Block/QuickTabsBlock.php ------ ----------------------------------------------------------------------------------- 50 Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static ------ ----------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Plugin/Derivative/QuickTabsBlock.php ------ ------------------------------------------------------------------------------ 18 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/TabRenderer/QuickTabs.php ------ ------------------------------------------------------------------------------ 74 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/TabType/BlockContent.php ------ ------------------------------------------------------------------------------ 67 \Drupal calls should be avoided in classes, use dependency injection instead 69 \Drupal calls should be avoided in classes, use dependency injection instead 75 \Drupal calls should be avoided in classes, use dependency injection instead 81 \Drupal calls should be avoided in classes, use dependency injection instead 97 \Drupal calls should be avoided in classes, use dependency injection instead 98 \Drupal calls should be avoided in classes, use dependency injection instead 121 \Drupal calls should be avoided in classes, use dependency injection instead 122 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ -------------------------------------------------------------------------------------------------------------------- Line src/Plugin/TabType/NodeContent.php ------ -------------------------------------------------------------------------------------------------------------------- 35 \Drupal calls should be avoided in classes, use dependency injection instead 60 \Drupal calls should be avoided in classes, use dependency injection instead 62 Method Drupal\quicktabs\Plugin\TabType\NodeContent::render() should return string but return statement is missing. 64 \Drupal calls should be avoided in classes, use dependency injection instead 70 \Drupal calls should be avoided in classes, use dependency injection instead ------ -------------------------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------ Line src/Plugin/TabType/QtabsContent.php ------ ------------------------------------------------------------------------------ 27 \Drupal calls should be avoided in classes, use dependency injection instead 48 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ ------------------------------------------------------------------------------ Line src/Plugin/TabType/ViewContent.php ------ ------------------------------------------------------------------------------ 76 \Drupal calls should be avoided in classes, use dependency injection instead 81 \Drupal calls should be avoided in classes, use dependency injection instead 86 \Drupal calls should be avoided in classes, use dependency injection instead 89 \Drupal calls should be avoided in classes, use dependency injection instead 102 \Drupal calls should be avoided in classes, use dependency injection instead 180 \Drupal calls should be avoided in classes, use dependency injection instead ------ ------------------------------------------------------------------------------ ------ -------------------------------------------------------------------------------------------------------------------- Line src/Plugin/views/style/Quicktabs.php ------ -------------------------------------------------------------------------------------------------------------------- 5 Interface Drupal\Core\Form\FormStateInterface referenced with incorrect case: Drupal\core\form\FormStateInterface. ------ -------------------------------------------------------------------------------------------------------------------- [ERROR] Found 29 errors
- First commit to issue fork.
I'll be working on this issue for 5 hrs, at DrupalCon Singapore 2024 Contribution Day and my mentor is @anushrikumari.
- 🇺🇸United States smustgrave
So please reserve for them. Ticket isn’t 24hours old yet
- 🇨🇭Switzerland berdir Switzerland
Looks good to me, hook_process_HOOK() was removed a long time ago and doesn't exist anymore.
- Issue created by @smustgrave
- 🇮🇳India sayan_k_dutta
Fixed the phpcs and phpstan issues.
The pipeline is failing for some tests and eslint errors. Someone please look into it. - gaurav gupta Jaipur, Rajasthsan
The changes has been done as per the suggestions in #13.
Moving it to RTBC.
Thanks. - @drdam opened merge request.
- First commit to issue fork.
- 🇦🇺Australia mstrelan
Is this about
hook_process
orhook_process_HOOK
? I think the title needs to be updated. - 🇺🇸United States nicxvan
Well I committed it instead of suggesting so now I can't review.
- 🇺🇸United States nicxvan
Sorry I just realized there is one more, I'll make a suggestion.
- 🇳🇱Netherlands groendijk
Agree with the suggention of Klonos. Remove the hidden span and use
aria-selected
. Following the MDN Web Docs https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/ta... they recommend to use that. Also best practice to usebutton
but perhaps that is outside of this issue scope. - 🇳🇿New Zealand quietone
@sourav_paul, Any contributor is welcome to review an issue. The Contributor Guide → has a step by step guide for how to review → and issue.
Hey, I reviewed the MR and the changes look good enough
The license file was added and composer.json has the required license information
Pipelines are all green.
Moving it to RTBC
Thanks- 🇮🇳India sourav_paul Kolkata
Thank you so much @quietone for explaining regarding novice tag & policies, I'll keep it mind form next time...
But, have a question that can anyone(who isn't novice) review novice issue ?
- 🇮🇳India kulpratap2002
There are still some direct Drupal calls visible in the PHPStan pipeline.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇮🇳India akulsaxena
@jvbrian
Will you be reviewing this? The licence file has been added and the required code for the same is already present in the composer.json file. Let me know if you find any other issue otherwise this can be set to RTBC and then merged. - 🇮🇳India ankitv18
@dinarcon Sure ~~ I'll left the novice tag issues for newbies.
Just review and validate the changes and provide suggestion but if you say I'll untouch the reviewing part to for novice issue. - 🇳🇮Nicaragua dinarcon
Thanks for working on this @akulsaxena
Hi @jvbrian It is indeed strange to add the spaces to those files when such change is not necessary. The current status of the issue is
Needs Review
. Can you verify that the necessary changes, as instructed in the issue summary, have been implemented? And if so, can you add a comment indicating you have reviewed the issue and change the issue status toReviewed & tested by the community
(RTBC)?I have rebased the MR after 📌 Fix cspell and phpcs issues Active The pipelines are already passing.
- First commit to issue fork.
Replace the margin-block-end style with padding-bottom and apply it to the .admin-toolbar__footer rule, instead of the current .admin-toolbar__footer > .toolbar-block:last-of-type. A space will appear, but beneath the button that toggles the child items.
- 🇮🇳India akulsaxena
Hi @jvbrian
I already generated the MR and made the necessary changes.
The issue was already in Needs Review state.
All you have done is add two spaces extra in 2 different files, which is actually not required.
Please ensure if the issue you pick is already assigned to someone or is in needs review state and the work is complete, you should not work on it until it moves back to needs work state and is unassigned. - First commit to issue fork.
- 🇮🇳India akulsaxena
Hi
I have added the LICENSE.txt file as requested
The PHPCS and cspell pipelines are failing but an issue 📌 Fix cspell and phpcs issues Active has already been created for the same.
Please review and merge - @akulsaxena opened merge request.
- First commit to issue fork.
-
dinarcon →
committed 1ffda3d0 on 1.0.x authored by
chandansha →
Issue #3490572: Add GitLabCI template
-
dinarcon →
committed 1ffda3d0 on 1.0.x authored by
chandansha →
- 🇳🇮Nicaragua dinarcon
@chandansha, thank you for making the MR to resolve this issue. This issue is tagged for a
Novice
, which the special tags page → explains "would make a good project for someone who is new to the Drupal contribution process." Since you have over 30 contribution credits, including Drupal core ones, the community expects you to be leaving "Novice" issues to others new to Drupal contribution.@ankitv18 you also have ~300 issue credits. Reviewing and testing issues is also valuable contribution. It would have been a good opportunity for some new to the community to participate.
Thank you both for your time. Because neither of you is relatively new to the community I am not assigning credit in this issue. You can question my decision. See What to do if you believe there is a mistake in issue crediting → for more information.
📌 Fix cspell and phpcs issues Active was opened as a follow up and is not tagged as
Novice
. You are invited to work on that issue as well as many other contribution opportunities → . Automatically closed - issue fixed for 2 weeks with no activity.
- 🇮🇳India ankitv18
Looks good to be merge ~~ Marking this one RTBC.
Warnings of the validate pipeline will be handle separately. - 🇳🇿New Zealand quietone
The deprecated version needs to updated to 11.2.0 instead of 11.0.0.
- 🇮🇳India lavanyatalwar
Hi @nicxvan, I have removed all the comments containing 'hook_process' from the code.
Kindly check :) - @lavanyatalwar opened merge request.
- 🇮🇳India akulsaxena
Hi
I made the suggested changes in the Readme.md file- Replaced the ##Installation section with the text example from the template.
- Left the pathauto note as it is.
- Removed Maintainer section as suggested.
- Added newline at the end of document.
Please review.
- First commit to issue fork.
- First commit to issue fork.
- 🇳🇿New Zealand quietone
I reviewed this and the suggested change is an improvement.
- Issue created by @nicxvan
- 🇮🇹Italy AleDDR
Hi @TomTech,
I really appreciate your contribution and your availability, and I thank you very much.I still need to ask for support to better understand and resolve the issue.
In the meantime, I confirm that I am testing in a Drupal development environment, on Stripe in Test Mode, and the sensitive data shared is anonymized but consistent.
I have performed checks and tests based on your suggestions, and here are the results.Webhook events result in a 500 Internal Server Error
Regarding "Webhook events result in a 500 Internal Server Error", which impacts all transactions, I have made progress by reconfiguring:
- the WebHook on Stripe
- the "Default Checkout flows" on Drupal, adding "Stripe review" in the Review stage, while leaving "Setup future usage" set to "None".
I no longer get the error
No signatures found matching the expected signature for payload...
, but now I have this error: "Drupal\commerce_stripe\Plugin\Commerce\PaymentGateway\StripePaymentElement::processWebHook(): Argument #1 ($webhook_event_id) must be of type int, null given, called in /var/opt/www/[your site domain]/releases/58/web/modules/contrib/commerce_stripe/src/Plugin/Commerce/PaymentGateway/StripePaymentElement.php on line 586
.
I have already read another issue ( #3420717 🐛 Webhook httpstatus 500 Fixed ), but I didn't quite understand what needs to be done to resolve it...
I tried introducing "skip_return_failure": true, where should I insert it?
Has the fix for #3420717 already been applied to commerce_stripe-8.x-1.2, or is it necessary to apply a workaround?
- Here is the request sent by Stripe to the Webhook ( requestBodyAnonymized.tx → t)Payment method: Klarna
I reviewed the scenarios in Klarna's documentation without finding any issues (customer address, currency, order amount, ...)
I believe the problem lies with the configuration of the "Setup Future Usage" option set to "Single use", because I can't find where or how to configure this option. In short, on the requires_payment_method request, the "Setup Future Usage" option remains set to "On-session", and that's why I don't see Klarna.
Let me give you some information about the current configurations:- Configuration of Checkout flows on Drupal ( 20241205_DrupalCheckoutflows.jpg → )
- Configuration of Payment Gateways on Drupal ( 20241205_DrupalPaymentGatewaysStripe.jpg → )
- Configuration of Payment Klarna on Stripe ( 20241205_Stripe-Settings-Payments_Klarna-Configuration.jpg → )
- The Overview screen of Webhooks (Test mode) on Stripe ( 20241205_Stripe-WebhooksOverview_TestMode.jpg → )
Can you help me further with this?
Thank you in advance! Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇮🇳India arunsahijpal
Hi @mherchel,
I've removed the get started bullet point from oilvero theme, please check it. - @arunsahijpal opened merge request.
- First commit to issue fork.