#Novice

@larowlan, Worked on the MR comments.
Kindly check :)

thanks!

Thanks!

I agree this is an improvement, the sentence is awkward. I also updated the IS.

Hi @vinayakmk47, did you check the issue linked in the issue summary? I believe your answer is there.

💬 cannot figure how to integrate into Webforms Active

I am using Drupal 10 with the Advanced Email Validation module (v2.0.2) and Webform (v6.2). I want to integrate the Advanced Email Validation module with a Webform email field, but I don’t see any option for the validation handler under the Form Validation section in the Webform field settings.

Hello,
I am using Drupal 10, the Advanced Email Validation module (v2.0.2), and Webform (v6.2). I am trying to validate a Webform email field using the Advanced Email Validation module but cannot find the validation handler in the Webform field settings.

What I’ve Tried:

Installed the module via composer require drupal/advanced_email_validation.
Enabled the module with Drush: ddev drush en advanced_email_validation -y.
Cleared caches using ddev drush cr.
Configured the module under Configuration > Advanced Email Validation.
Expected Behavior:
I expected to see the Advanced Email Validation handler listed in the Form Validation section of the Webform field settings.

Actual Behavior:
I can only see default options like Required, Unique, and Pattern.

Environment:

Drupal: 10.x
Advanced Email Validation: 2.0.2
Webform: 6.2
Request:
How can I integrate the Advanced Email Validation module with a Webform email field? Am I missing a step?

Thank you for your assistance!

Automatically closed - issue fixed for 2 weeks with no activity.

Left a review, thanks

I was unsure what was meant by fatal error and couldn't find anything specific for loading exceptions so have gone with a normal \Exception. Please could MR !10260 be reviewed.

Thanks

Automatically closed - issue fixed for 2 weeks with no activity.

alexpott → credited sugaroverflow → .

Given this is an allowed change but to a majorly important form I'm only going to make this to next minor branches and not to the patch. branches (10.3.x and 11.0.x)

Committed and pushed 0b78493d29a to 11.x and 27f7b679085 to 11.1.x and 4027f70a0ec to 10.5.x and deead9fdad7 to 10.4.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Merged, thanks!

Crediting

LGTM, though maintainer will confirm this is correct.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Automatically closed - issue fixed for 2 weeks with no activity.

Quite straightforward ~~ changes done as per proposed solution, hence marking this one RTBC

I tryed to fixed documents.Please review and let me if i am wrong to fixed it.
Thanks!!

@mondrake, The pipeline is all green now.
Kindly check and merge :)

Working on it.

@chandansha thanks! The fix is correct, but there is a phpcs issue (extra white line) to be fixed.

Rebase seems good.

I think this is probably fine.

There is a use-case for password reset links where people create a password, don't try to remember or it use a password manager for it, then use reset links each time. drush uli is a similar use-case during local development too.

However, because our password reset links also log you in, making the fields required won't break this - e.g. you can click the link, ignore the form, same as you previously did.

Thanks @traviscarden :)

Congratulations on your first Core commit, @secretsayan! 😄

Committed and pushed 6b6facdc29e to 11.x and 167dc216f33 to 11.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

Looks good. Thanks!

Committed 6025a14 and pushed to 11.x. Thanks!
Committed f54e0fc and pushed to 11.1.x. Thanks!

@ankitv18, thanks for your review. However, I started with the Project Browser issue because I wanted to begin with a simple problem to understand the flow better."

This is a good start, but they're not fields.

Something like:

> Provides default values for menu link plugin definitions.

Automatically closed - issue fixed for 2 weeks with no activity.

Please have a look i have try to fix the issue.let me know if i am wrong to fix this issue.
Thanks!

@shalini_jha Thanks for working on this one ~~ changes looks quite straightforward.
FYI, these kind of issues should be picked by newbies first. :)
For now I'm marking this one RTBC.

Removed the legacy code from DrupalDotOrgJsonApi.php. and raised a MR for this .moving this NR. Kindly review.

Please have a look i try to fixed issue using above reference and let me know if you find any issue.
Thanks!!

@quietone The patch was intented for 10.1.x branch but in the 11.x branch, the test file is only 70 lines long and all the testing functions which were available in the 10.1.x branch are missing from 11.x branch. So the patch changes can not be applied to the test file directly. So should I add all the missing functions and lines of code to the test file which are not included in the 11.x branch?

Automatically closed - issue fixed for 2 weeks with no activity.

Ah okay makes sense, thanks for the link and your answer :).

@quietone I tried to add test file changes but the UpdateSemvertestBase.php contains 70 lines only but the suggested changes in the patch are at line 158 so I am not sure of the code in between those lines. That is why I didn't applied those changes manually.

Rebase with many conflicts due to 📌 Convert entity type discovery to PHP attributes Needs review

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The scope of tokens is limited to the flow (event and successors) in which they have been defined, see https://ecaguide.org/eca/concepts/tokens/#scope-of-tokens

If you require some tokens also in a custom event, you need to explicitly forward them by providing their name in the Tokens to forward field of the trigger custom event action.

Looking into this at NEDCamp. Adding the issue tag.

#58 asks a good question. Here's one answer. Because if they are not required and you use the 1 time login and then save the account without entering a new password it'll save and the resulting form will have the current password field. But you don't have a current password if you've come directly from an email sent due account registration so this is then an impossible task. So I think this change makes sense.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks @dww! Believe feedback has been addressed.

Resolved most of the Test case issues, few pipeline issues are unable to fix.

Automatically closed - issue fixed for 2 weeks with no activity.