#Novice

Automatically closed - issue fixed for 2 weeks with no activity.

All green.. looks good to be merge.
Moving into RTBC.

I took the liberty to jump into this and I create a MR, hope you don't mind.

We are now using the 2.x branch.

Fixed. Thank you.

Thanks. I will commit this later.

LGTM! RTBC +1

From reading the issue where we created a Stable9 theme - #3050374: Create Drupal 9 stable theme → - I can't see any reason given for why we moved items from /misc to /media-library.

My feeling is that someone decided that "misc" is too general, and each template should live somewhere specific. But I don't know why media-library was chosen. It's interesting that we do not have any "misc" folder in Stable9.

I have a suspicion that we can either:

1. Leave it as is, or
2. Decide where we think those templates should go - with the requisite release notes/change record.

If we choose option 2, do we want to (re)create a "misc" directory in the Stable9 theme, or is there somewhere more appropriate to place these templates? Would they all be better placed in the /admin directory? Or maybe feed-icon.html.twig could go in the /views directory?

Hello @arturopanetta

Created the MR with the fix for the issue
Please review and let me know if any other changes are needed

Moving the issue to needs review

Hi @xmacinfo

Created the MR with the proposed solution
Please review and let me know if any other changes are needed

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to active.

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to hidden.

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to active.

adwivedi008 → changed the visibility of the branch 3507917-move-fakeobjects-logo to hidden.

Hello @nod

Can you please suggest what other changes are needed on this
Or do we need to create another issue related to this for cleanup

Hello @daniel

I have taken a look at MR and it seems to be correct

Moving the issue at RTBC
Thank You let's wait for some more feedbacks

daniel.j → closed merge request !11245

daniel.j → changed the visibility of the branch 11.x to hidden.

Rebased onto 11.x and resolved conflicts.

Please review again, thanks!

Added DRUPAL_CORE variable to the Gitlab CI composer build variables and added a .cspell-project-words.txt.

Pipelines are now passing, please review. Thanks!

Added a .eslintrc.yml file to ignore import and no-console eslint errors specifically in the gulpfile.js. Changes also include anonymous function and eslint automatic fixes.

Pipelines are now passing, please review. Thanks!

we've come a long way, baby

This seems like great clean-up and it will help us actually catch bugs. I didn't review the .gitlab-ci.yml changes in depth, to be honest, but I'm not particularly concerned about those anyway. The pipeline looks like it's running, and passing, and that seems right to me. I don't really feel like blocking quality improvements. :)

Rebuilt this based on how XB is handling it, with @todos pointing to 📌 Only run linting jobs if the files changed make sense for the job Active

ankitv18 → changed the visibility of the branch 3477335-include-phpcs.xml.dist to hidden.

tim.plunkett → changed the visibility of the branch 2.0.x to hidden.

It would good to get 🐛 Openapi.yml uses patternProperties which is not supported by our dependencies Needs work fixed next. We still have 3 large parts of openapi.yml spec that is getting ignored, and we will likely add more until we get this fixed(the problem got worse last mont)

Automatically closed - issue fixed for 2 weeks with no activity.

MR!55 is ready for a review.
@pfrenssen please check.

Update credit

The body of the function should also trigger a deprecation I think. Unlikely that anything is calling this, but if it was, it would tell them.

Automatically closed - issue fixed for 2 weeks with no activity.

This is looking great, thanks a lot! We can now configure PHPStan to not allow any failures and this is good to go.

ESLint pipeline still needs attention ~~ few warnings left, please consider to fix them too.

Looks good!! Hence moving into RTBC

Thanks @ b_harold,
Now you can move into review and mark all threads resolved on the MR.

I have restored the latest changes and set Drupal 10.3 as the minimum required version. Let me know if any further adjustments are needed.

I agree, Drupal 10.2 is no longer supported so we can drop it and set Drupal 10.3 as the minimum version.

I would like to suggest to add minimum support of D10.3 and then we can avoid using deprecationHelper or version_compare then things will remain intact.
@pfrenssen Any thoughts ?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Left some comment, please check.
see@ https://www.drupal.org/node/3407994 →
You have to use version_compare to avoid this error.