#Novice

Looks much better now, an extra look would be nice. Setting this to "Needs Review".

I think It looks ok now, a review will be nice (will give a credit !!).

Moved to "Needs Review".

Thanks @neerajsingh, and I agree with removing the extra return before the execution of batch_set.

Merging this to the 3.0.x branch.

Thanks !

Looks ok to me @neerajsingh and thanks for fixing the PHPCS issues.

I'll merge this to the 3.0.x branch.

Thanks @neerajsingh

I will try to add the help hook.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Feel this is one could be endless chasing perfection. Believe what's currently there is definitely better then present. If a standard (apologize if one has been made and I don't know) think this is good.

Going to go on a limb and mark.

Automatically closed - issue fixed for 2 weeks with no activity.

Yep, indeed this seems more complicated than expected, a lot of testing is needed.

Thanks for helping making XB more consistent :)

Some of the seemingly unrelated Playwright failures here are also happening on other MRs: https://git.drupalcode.org/project/experience_builder/-/pipelines/578215 — but there seem to be more here. That is brand new test coverage since last night, so asking those who worked on it to check: #3539554-13: Add Playwright tests for XB AI module → 🤞

Thanks! 🙏 You did all the hard work — I only had to do some touch-ups 😊

Much appreciated!

Thank you @danrod! Great!
Please note the comments over at 📌 Fix the issues reported by phpcs RTBC

Thank you @penyaskito, @wim-leers for your validation and guidance. I have addressed the feedbacks.

I fixed a bunch of PHPCS, CSPELL and STYLELINT issues today, I shall continue with the work tomorrow. A lot of work to do here.

Good night !

Thanks @anybody , I'll look on that now that I have some time (off work).

@danrod: That's indeed confusing a bit, sorry.

I'd say:

1. I'll merge the phpcbf fixes here, none of them are risky
2. I'll update 📌 Fix the issues reported by phpcs RTBC with the fixes
3. For PHPCS continue in 📌 Fix the issues reported by phpcs RTBC - as the issue already has a lot of feedback
4. For the other fixes continue here

Thanks @anybody, I'll use the MR 90 instead, I was confused on which one should work on, this one or the issue #3036556: Fix the issues reported by phpcs

Automatically closed - issue fixed for 2 weeks with no activity.

@danrod I did some preparation work, please use the prepared MR for further fixes.

Thanks @danrod - go for it :)
And please use a MR.

No more existing: https://git.drupalcode.org/search?search=simpletest&nav_source=navbar&pr...

This came up as the daily BSI target and definitely still appears to be relevant

Also see 📌 Fix the issues reported by phpcs RTBC - maybe that's a good starting point

I'd like to work on this, I'll take it, if you don't mind.

This not being done yet is continuing to cause communication confusion — see #3541034-3: Render component instance form for template → .

@neerajsingh — do you think you could address this feedback? 😇🙏 I'd love to merge this MR!

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Perfect, thanks!
Merged.