#Novice

Thanks for the suggestion!
However, the plugin looks like it could just as easily be used for any other date fields, so I don’t think this change is really necessary. In particular, fields with type datetime_iso8601 should be using this plugin as well. If you think others should as well, then maybe we should rather change that than adapt the doc comment.

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → credited mondrake → .

Thanks for working on this.

Just one more thing, the changes here need to be wrapped at 80 characters to meet the Drupal coding standards, https://www.drupal.org/docs/develop/standards/php/php-coding-standards#line-length.

Merged into 1.x. Thanks!

"I applied a line-height of 2.2rem to evaluate its effect. Next, I'll mark it as 'needs review' to gather feedback."
Before: line-height: 1.125rem;

After: line-height: 2.2rem;

Let me know if you need additional adjustments!

phenaproxima → credited heddn → .

Crediting @heddn for some behind-the-scenes mentoring work. :)

Magnificent - thank you! Will merge when tests pass.

If you also don't see a "Create merge request" button in GitLab, maybe try pushing a differently-named branch to this issue fork?

In theory the branch name shouldn't matter, though, so I'm not sure what's going on.

You don't need to run the tests locally. They are will automatically run if you create a merge request in the GitLab UI.

(Also, please do not delete the issue summary when you post comments. :) Maybe refresh the page before posting your next comment, just so that any emptied form fields are refreshed?)

yasminorj → changed the visibility of the branch 2.0.x to hidden.

I will try to test to see if they will pass.

That looks good, but you need to open a merge request so that the tests run and I have something to merge! :)

Here's some (admittedly not very good) documentation on how to do that, if you're unfamiliar with the process: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → . I tried to do it just now but it didn't work for some reason.

Of course. I've already done it. Can you check it please and tell me if it's ok now?

The branch doesn't look correct yet, though. Can you please implement what @jurgenhaas asked for in #2, which calls for removing the dependency on Gin Toolbar, and only relying on Gin?

By accident two empty commits were sent. But I managed to update the two modules with composer and they are already in versions 4.0.0 and 2.0.0 respectively.

As per Jurgen’s comment, the Gin Toolbar dependency should be removed. Looks right to me otherwise.

Hi, I'll take a look at this one

dieterholvoet → credited dj1999 → .

The suggested change was made and committed, looks good.

dieterholvoet → changed the visibility of the branch 2.x to hidden.

When getting around to this, please only require drupal/gin as Gin itself already contains the gint_toolbar dependency.

@abelpzl, has this issue been completed, or is there something else that still needs to be addressed?

Back to NW for the above comment.

Searched for Drupal CI and all 4 instances have been replaced and the MR appears to have good replacements for each wording.

Automatically closed - issue fixed for 2 weeks with no activity.

That's great, thanks!

Updated the MR.

Review comments addressed.

This looks great, except we both didn't spot that with that service removed, there is no longer any reason for this class to have any DI code at all -- create() and __construct() can be completely removed, since they do the same as the parent class's methods.

Please fix the phpunit pipeline, also there are many warnings in the phpstan which needs to be taken care see: https://git.drupalcode.org/issue/recurring_events-3481021/-/jobs/3724042...

 Method                                                                     
         Drupal\recurring_events\Form\EventSeriesRevisionRevertForm::__construct()  
         invoked with 2 parameters, 3 required. 

@dieterholvoet I replaced all final methods and self/static keyword, pipeline for PHPStan, eslint and phpcs is green now.

There are still classes and methods made final in the MR. Same with self/static. PHPStan also reports a syntax error.

I am looking into this.

@DieterHolvoet I have made the changes that are told by you. Have a look.

The pipeline is not passing yet.

Looks mostly okay. Adding final to classes/methods is not necessary though, nor is returning self instead of static in create methods. This makes it so these classes/methods can't be extended anymore.

Fix the eslint warnings and fix some phpstan errors.

Committed to 11.x - thanks!

larowlan → closed merge request !8954

quietone → closed merge request !5015

I had submitted a rough draft and I need some help on finishing it.

larowlan → closed merge request !10444

Committed to 11.x - thanks!

larowlan → closed merge request !10375

Committed to 11.x - thanks!

Committed to 11.x - thanks!

larowlan → closed merge request !10392

usingsession → changed the visibility of the branch 3494257-custom-tokens-tests to hidden.

Issue summary for good practice should still be filled out.

Also the parameter is still optional.

Changing the status and assigning to me as I am continuing working on this.

Created a draft MR. I still need to fix the dependency injection errors, continuing the work.

You seem to have replaced $kernel wit $http_kernel everywhere, not just in the classes concerned in this issue, and also lots of places where it's actually the DrupalKernel!

This issue is only about middleware classes.

Also, please can you make a MR rather than a patch?

I am taking this up. I will push the changes on what I had done by today itself.

I have created the patch please review it

@kenyoowen I made the required changes. Have a look.

quietone → closed merge request !2658

Thank you @koustav_mondal! LGTM!

I verified that this by searching for where the hook was removed. Skimming that changed showed that it really was removed.

$ git log -Shook_process_HOOK
commit 29c09effc38271277b7cad1114be5f32eed5f9f5
Author: Nathaniel Catchpole <catch@35733.no-reply.drupal.org>
Date:   Sat Jul 27 15:26:33 2013 +0100

    Issue #1843650 by Mark Carver, jenlampton, Cottser: Remove the process layer (hook_process() and hook_process_HOOK).

Committed to 11.x and cherry-picked to 11.1.x

Thanks!

quietone → closed merge request !10472

Working on it.

@anybody I have updated the Readme.md file.

Committed and pushed to 11.x and cherry-picked to 11.1.x only, here were conflicts in the phpstan baseline for other branches.

Thanks for improving the documentation in core!

quietone → closed merge request !9858

Committed to 11.x and cherry-picked to 11.1.x 10.5.x 10.4.x 11.0.x 10.3.x

Thanks!

quietone → closed merge request !10006

quietone → closed merge request !10445

That equivalent_update_test_update_100201 returns TranslatableMarkup is unusual but it is part of the testing.

Committed to 11.x and cherry-picked to 11.1.x

Thanks

I have the same issue, I have +/-160 users on my website, I can test some things if you want

@anish.a you can continue from scratch, because due to some mistake, all my code is reverted :(.

Sorry to have wasted some of your time, @utkarsh_kumar_singh 🙈

This was a lesson for me as well, I learned something new about Drupal core here! 😅

Your effort does not go unnoticed nor unappreciated though: you will be credited for this issue! 😊

wim leers → closed merge request !481

Retitling & rescoping.

Ugh … I was wrong 🙈😬

Due to

  public function __construct(…) {
    parent::__construct('Entity', $namespaces, $module_handler, 'Drupal\Core\Entity\EntityInterface');
    …
    $this->discovery = new AnnotatedClassDiscovery('Entity', $namespaces, 'Drupal\Core\Entity\Annotation\EntityType');
    …
  }

in \Drupal\Core\Entity\EntityTypeManager::__construct(), it is impossible to put (content or config or otherwise) entity definitions in any other place than src/Entity! 🤯

This is highly misleading in Drupal core, because, these critical files do live in a …/Config/Entity/… subdirectory:

• Drupal\Core\Config\Entity\ConfigEntityInterface
• \Drupal\Core\Config\Entity\ConfigEntityBase
• …

😬

Move the classes from \Drupal\experience_builder\Entity` to `\Drupal\experience_builder\Config\Entity`. After doing this and changes the all classes name the error is coming.

@koustav_mondal this still doesn't use the https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →

Updated Readme.md file.

All eslint/phpcs/phpstan issues are fixed now. Pipeline is green for eslint/phpcs/phpstan.

Thanks!

Made the changes requested, Please review.

I am working to it.

@rahul_ Can you push the WIP in the branch, so that I can take a look.

Still working on this.

Following up on this, would like to include in the release.

Only did a light review but you get the flow.

Overall looks good though.

I checked this out and all mentions of Drupal CI seem to be gone, I also reran the pipeline to get it to pass. I can't comment on the new wording of the comments since I don't know what it's supposed to become so I'll leave this as Needs Review for now.

ah okay makes sense :)
thanks for your answer

Working on it.

@jvbrian You've made a fork and it says there's a commit you've made, but I don't see anything on the feature branch?

@chhavi.sharma I have reviewed the pipeline failure : https://git.drupalcode.org/issue/drupal-3485084/-/jobs/3674676
and it seems like a random failure not relevant with the changes in MR, try to re-run it will fix. hope that help.

I found the solution, very simple.
I'm really sorry, but I didn't realize that the latest version had not been installed due to an incompatibility with another module. I isolated the incompatibility and installed the latest version, everything works perfectly!

Reverted the out-of-scope changes.
please review

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to active.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to active.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

Working on it.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to active.

adwivedi008 → changed the visibility of the branch 3422919-error-in-docs to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

@owenmck, that page is part of the community documentation and you can make the necessary changes. If the change starts with Drupal 11, then you could precede the paragraph with something like, 'Starting with Drupal 11, ...'.