- First commit to issue fork.
- 🇮🇳India Ashutosh Ahirwal India
Hi @sourojeetpaul Sorry for the late reply can you updated the color which is exist in the background color of login button found on tabs.
- 🇬🇧United Kingdom NexusNovaz
Hey,
This should be ready for review. Added the return type array to Facet::__sleep() in MR #211 - @nexusnovaz opened merge request.
- First commit to issue fork.
- 🇨🇦Canada m4olivei Grimsby, ON
Updated the issue description summarizing comments in favor of using the Megaphone.
- 🇺🇸United States smustgrave
Failure is unrelated.
Appears feedback has been addressed.
- Issue created by @dpi
Hello @Ashutosh, Haven't heard from from you for while now, regarding this.
Can you kindly clarify the confusion mentioned in the comment #6 🐛 Need to design login page with tabs Needs workAutomatically closed - issue fixed for 2 weeks with no activity.
- 🇬🇧United Kingdom NexusNovaz
Nice spot @ksenzee!
Made that adjustment to the MR and should be ready for review!
- 🇺🇸United States smustgrave
There's already a branch for 11.x with an MR, don't think we need to start a new one.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
- 🇮🇳India aman1248
Hy @NexusNovaz
I have reviewed the changes in Your MR! The MR! has a straight forward fix.
It can be merged.
Please & Thank You.** Marking this ticket as RTBC!!
- @ahsannazir opened merge request.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States ksenzee Seattle area
Thanks for working on this! It looks like the diagram needs an update—the code and the diagram don't currently match. I think lines 28-30 need to be indented, so that 2 and 3 lead to 4, not 1 and 2 leading to 4.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States bnjmnm Ann Arbor, MI
The z-indexes in Drupal are documented → and considered stable. Custom Themes and modules are built knowing what these core z-indexes are, so reducing the z-index of a sticky header by 400 could be disruptive, where suddenly many elements can bleed through sticky header that were previously covered by it.
Automatically closed - issue fixed for 2 weeks with no activity.
- Issue created by @joachim
-
drunken monkey →
committed a866fd9b on 8.x-1.x authored by
NexusNovaz →
Issue #3447797 by NexusNovaz, drunken monkey: Fixed documentation of...
-
drunken monkey →
committed a866fd9b on 8.x-1.x authored by
NexusNovaz →
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks, looks good and makes sense! Merging.
- 🇮🇳India deepak5423
Hi @Anybody, I have updated the README.md file as per your comments.
- First commit to issue fork.
- 🇮🇳India Mithun S Bangalore
Pushed a rebase for the PR and now the test failures are passed.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇬🇧United Kingdom NexusNovaz
Hi, I've made MR 8124 which is ready for review. I've added both the patch from #9 and the changes in #16.
Thanks
- @nexusnovaz opened merge request.
Automatically closed - issue fixed for 2 weeks with no activity.
- First commit to issue fork.
- 🇺🇸United States smustgrave
Believe this one has been tested and working fine in safari. Issue summary looks good also.
- 🇺🇸United States smustgrave
Leaving novice tag for those who worked on in Portland. Can the MR be rebased? appears to have test failures
- 🇵🇪Peru diegoe Lima, Perú
@andypost
I thought it was random failure at first, but then found an issue for it: https://www.drupal.org/project/drupal/issues/3448036 🐛 InstallerTranslationExistingFileTest fails on 11.x branch Active -- There's an MR already, so hopefully it will get fixed soon. I'll rebase on top of that when it's merged.
- 🇵🇪Peru diegoe Lima, Perú
Opened a MR:
https://git.drupalcode.org/project/drupal/-/merge_requests/8118Opened a draft CR:
https://www.drupal.org/node/3448089 → - @diegoe opened merge request.
- First commit to issue fork.
- 🇺🇸United States skessler Denver
Maks,
The plan had been to make these changes and then open a new ticket to make all of the changes in the files to include Markdown. I am fine either way. It is going to take me a bit to get all the Markdown changes made.
Thoughts?
Thanks,
Steve Automatically closed - issue fixed for 2 weeks with no activity.
- 🇬🇧United Kingdom NexusNovaz
Hi @joachim.
I've taken the doc string from the interface and replaced the inherit doc with that string. MR 138 is ready for review.
- @nexusnovaz opened merge request.
- First commit to issue fork.
It seems that simply changing the extension doesn't preserve the good formatting for md files. I think they need to be updated to the correct formatting for code, tables, links, etc. This will further improve the visual perception and usability
- 🇺🇸United States skessler Denver
Ready for review: https://git.drupalcode.org/project/drupal/-/merge_requests/8115
- @skessler opened merge request.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇺🇸United States smustgrave
MR has a bunch of test failures.
Also if a new approach is going to be used then issue summary will have to be updated and fresh set of screenshots added. Moving to NW for that.
- 🇵🇰Pakistan isalmanhaider
Explanation:
In Drupal 11, the FieldItemInterface includes two methods: defaultFieldSettings() and defaultStorageSettings(). These methods define default settings for field items at different levels:
- defaultFieldSettings(): Specifies default settings at the field level.
- defaultStorageSettings(): Specifies default settings at the storage level.Issue:
The methods are expected to return settings with unique names. This is crucial because other parts of the core, like BaseFieldDefinition, merge these arrays. Overlapping names can lead to conflicts or unexpected behavior.
Solution:
Document in both methods that setting names must be distinct to avoid such issues.
- 🇮🇳India Mithun S Bangalore
Thought of a different approach without changing the global css. Decreased the z-index value of the table header based on the content page so that the autocomplete dropdown doesn't hide behind it. Also checked the table header remains sticky on the content pages.
Please review. - 🇮🇳India Mithun S Bangalore
Mithun S → changed the visibility of the branch 3444344-claro-Autocomplete-dropdown to hidden.
- @mithun-s opened merge request.
- 🇮🇳India Mithun S Bangalore
Mithun S → made their first commit to this issue’s fork.
- Issue created by @joachim
- 🇮🇳India ehsann_95
The issue was happening due to transform property in the svg itself. Fixed the SVG and moved style to stylesheet