Templates folder structure in stable9 is misleading

Moving remaining issues for 'Stable theme' to 'Stable 9 theme' based on #3332485-5: [Meta] Stable issue triage → by markconroy.

I am now start to working on this issue (writing the change record for this issue)

I have now added a change record for this issue. Change record →

Thanks for working on it.

Would be good in the CR to mention the templates in question.

I have updated the change record and mentioned the templates those has been moved to misc folder.

New MR is actually empty.

sanisaha → closed merge request !7471

sanisaha → reopened merge request !7471

sanisaha → closed merge request !7471

sanisaha → reopened merge request !7471

sanisaha → closed merge request !7471

sanisaha → reopened merge request !7471

sanisaha → closed merge request !7471

@sanisha what is it you’re trying to do?

I have tried to create a new merge request for this issue, and then trying to fix merge conflicts.suddenly found so many comments appeared (sorry for the mess). So I do now create a commit under MR2536, Which has necessary changes for this issue. Should I need to create a new branch from 11.x and make another MR to do merge with 11.x. Thank you

Yes we will need a 11.x branch with the changes in that.

Plus change record updates.

So would try

1. Open a 11.x branch
2. Make sure it's up to date with 11.x, something it's not
3. Move the changes for the fix to the 11.x branch
4. Make sure everything passes
5. Update change records.

File has been moved to misc folder and also change records updated

Believe this is good to go now.

@sanisaha, thank you for working on this and getting this to RTBC! Just so you know, you only need to add screenshots for issues that are changing the UI. And in that case,they should be linked to from the Issue Summary so reviewers can find the latest valid one. Otherwise, screenshot add noise to an issue.

I started my review by reading the Issue Summary, which I see is out of date. It refers to files that are no longer in core. The next thing I want to know is why do these files need to move. The summary states this is done so it is "like they are in the previous version of stable." But then, why were they moved?

Still, I did some research using git. Using git log -- core/themes/stable9/templates/media-library/feed-icon.html.twig I find that the files were moved in #3050374: Create Drupal 9 stable theme → as follows:

• feed-icon.html.twig was moved from core/themes/stable/templates/misc to core/themes/stable9/templates/media-library
• progress-bar.html.twig was moved from core/themes/stable/templates/misc to core/themes/stable9/templates/media-library
• status-messages.html.twig was moved from core/modules/system/templates to /core/themes/stable9/templates/media-library

There was a status-messages.html.twig in core/themes/stable/templates/misc but that is not the one that was moved. Were they the same?

I will check with the other committers about this move.

An outstanding task in the issue summary is to look into why these changed location between Stable and Stable 9 to begin with.

Also, despite #8, I'm not totally convinced the impact of this outweighs the disruption. The stable base themes in general are not supposed to change except between major releases. If we do decide that the disruption is merited, it would probably need to go in the release notes.

A novice contributor could do the git and issue archaeology to look into why the templates ended up in this location. Maybe that can help inform the release and frontend framework manager decisions about why the change was made and whether changing it back is an allowable change in a minor version. Thanks!

Moving to NW to update summary addressing #47 and #48

I'm going to mark this as "Needs more info".

We can make the change quite easily if we do it for D11 only, but we'd need to do that fairly quickly before we release D11 in the coming weeks.

Failing that, I think we need more info about why they were moved to the media directory.

---
Thanks to Code Enigma for sponsoring my time to work on this.

Changing the status to active because there is work here to do, that is the research asked for in the 'remaining tasks'. This could use a better title, so tagging for that as well.

Also, closed a duplicate.