Thanks so much for this. We are just starting to add demo content ourselves, so this will be a great help.
Me and @greg.harvey will be in Brussels. Let's meet.
Hi @quietone,
Thanks for the offer to be a maintainer of Markup subsystem. I confirm:
I h
- ave read and understand the definition of maintainers.
- I accept the Subsystem maintainer responsibilities.
- I am committed to following our community issue procedures and etiquette paying particularly attention to providing constructive feedback.
can you add in an update hook to set Monday as the default for existing sites, if it's not already set
Hi @renaudcuny
Thanks for this. Can you create a merge request from that branch please? Also, we don't want to include the dev version of the theme, let's include minimum beta `drupal/localgov_base_france:^1.0@beta`
@catch I know I mentioned in #15 above that !important seems right here, but often we want to change something from display: none; to display: flex; (or grid, etc) (rather than block), and that !important could come back to bite us.
I'm not saying we should not do it, but just wanted to raise it as a consideration.
I think this is definitely going to need more discussion/consensus.
At the moment we have no aria labels on the facets blocks. But we have a <h3> inside each with gives a title/context. E.G. on the News date block we have <h3>Date</h3>, in a directory facet we have <h4 class="facet-group__title">Country</h4>.
If we accept that the pattern - which is in the MR - is "Search: [node:title]", then if we have more than one facet block we have the same aria-label for all of them on that page.
If we accept that the pattern - which is in the MR - is "Search: [node:title]", then if we are on a news page the news category and news date facets will both have an aria-label such as "Search: this is a great news post" even though those block have nothing to do with the page title per se - they are for showing all news with a certain category or certain date.
The aria label probably should come from the block label, something like "Search news categories" or "Search news date" or "Search directory country". We decided not to do that in https://github.com/localgovdrupal/localgov_microsites_base/pull/324 because we thought the block titles might be too generic (e.g. "Search directory channel") though I think now that using the node title is either even more generic or just plain wrong for many of the blocks.
So ... thoughts?
@xmacinfo when creating a new project now, I create two themes - one from starterkit called for example markconroy_base and one that is a minimal theme which uses markconroy_base as its base theme, for example markconroy. Then any custom templates/CSS/etc that I need are placed in the markconroy theme.
It's not as clean as just using Stable9 for the base theme, but it's pretty close to it.
@tonypaulbarker let's schedule a time and do a screenshare on this to figure out why we are getting different results.
Ignore my branch and work. I got trigger happy and started removing Stable9 instead of deprecating it. I'll close that MR for now.
markconroy → changed the visibility of the branch 3512287-policy-no-patch to hidden.
MR attached. Simple changing the field from required to not required seemed to be enough. No custom code needed, unless I'm missing something.
I can confirm this is still an issue.
Drupal 10.5.8 with preview_link 2.2.0-alpha2
The website encountered an unexpected error. Try again later.
Drupal\Core\Entity\EntityStorageException: The "preview_link" entity type can only be saved in the default workspace. in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
workspaces_entity_presave()
call_user_func_array() (Line: 416)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}() (Line: 395)
Drupal\Core\Extension\ModuleHandler->invokeAllWith() (Line: 415)
Drupal\Core\Extension\ModuleHandler->invokeAll() (Line: 217)
Drupal\Core\Entity\EntityStorageBase->invokeHook() (Line: 900)
Drupal\Core\Entity\ContentEntityStorageBase->invokeHook() (Line: 529)
Drupal\Core\Entity\EntityStorageBase->doPreSave() (Line: 753)
Drupal\Core\Entity\ContentEntityStorageBase->doPreSave() (Line: 483)
Drupal\Core\Entity\EntityStorageBase->save() (Line: 806)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (Line: 82)
Drupal\preview_link\PreviewLinkStorage->save() (Line: 354)
Drupal\Core\Entity\EntityBase->save() (Line: 94)
Drupal\preview_link\Form\PreviewLinkForm->getEntityFromRouteMatch() (Line: 73)
Drupal\Core\Entity\HtmlEntityFormController->getFormObject() (Line: 94)
Drupal\workspaces\Controller\WorkspacesHtmlEntityFormController->getFormObject() (Line: 38)
Drupal\workspaces\Controller\WorkspacesHtmlEntityFormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 637)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)
Marking as fixed, since it has been merged and released.
Let's hold off on this helper module for a bit.
I've updated the MR for ✨ allowing configuring how many top tasks per row Needs review to use a post_update function and it seems to be working exactly as expected - new sites get 4 per row, existing sites get reset back to 3 per row.
That sounds like a very good idea @rupertj
I'll do some experimenting and see how I get on with it. If we definitely want the module, then perhaps we could use post_update to enable it on all sites.
@finn lewis I think you mentioned to me on a call that if we had the latest version of LocalGov Microsites Base, there was no issue. Is that the case? If so, it looks like this is ready to merge and no more work needed.
@tonypaulbarker That looks really good. Looking forward to this.