I think this is a good example of when we would use !important.
In this instance, it's !important that when the class .js-hide is present that the item concerned is hidden.
Perhaps we can use !important just for the hiding part and not for the showing part. For .js-show we may not want display: block all the time (sometimes we might want flex/grid/inline-block/etc) so !important should not be used for that.
After that I think @godotislate "double class" idea is probably best. .js-hide.js-hide. If we use .js-hide[class] it might affect other classes if they are present.
@smustgrave I think this can be closed as "works as designed".
So what I finally did was to also install the contributes stable theme.
Probably that was the intended way to go in the first place.
Fixed via ca7c187f0b787fe3a24c1915b56f86e46407604f
markconroy → created an issue. See original summary → .
Fixed via ca7c187f0b787fe3a24c1915b56f86e46407604f
markconroy → created an issue. See original summary → .
Thanks @kevinfunk for this MR.
@opdavies I think it would be great to have a test to catch this. Thanks.
I was there!
I'm not totally against this idea, but I'm also not totally for it either. As @nicxvan said, I created the issue to track @catch's discussion and so that it wouldn't get lost in the Slack history.
markconroy → created an issue.
I think that's everyone.
When creating custom themes, I quite like the process of just creating the bare minimum
- theme.info.yml
- theme.libraries.yml
- CSS + JS + templates as needed
- everything else inheriting from Stable9 or some other base theme
This means the custom theme directory is as small as possible and very easy to find your way around. Removing Stable9 would mean a change to this process. I'm not against that, but I would guess there are others that have the same process and maybe do not want a copy of every template, for example, in their custom themes.
markconroy → created an issue.
I attended.
Adding credit.
markconroy → created an issue.
markconroy → created an issue.
Adding in credit for company and client.
@liampower is it okay if I tag The Confident as my company for the credit?
liampower → credited markconroy → .
markconroy → created an issue.
markconroy → created an issue.
Adding credits.
markconroy → created an issue.
Adding credits.
markconroy → created an issue.
finn lewis → credited markconroy → .
Thanks @bbrala, MR open now.
Hi @smustgrave
Yes I've read that document and am aware of the duties of a core maintainer.
I'm also core maintainer of the Umami profile.
Mark.
markconroy → created an issue.
From reading the issue where we created a Stable9 theme -
#3050374: Create Drupal 9 stable theme →
- I can't see any reason given for why we moved items from /misc to /media-library.
My feeling is that someone decided that "misc" is too general, and each template should live somewhere specific. But I don't know why media-library was chosen. It's interesting that we do not have any "misc" folder in Stable9.
I have a suspicion that we can either:
- Leave it as is, or
- Decide where we think those templates should go - with the requisite release notes/change record.
If we choose option 2, do we want to (re)create a "misc" directory in the Stable9 theme, or is there somewhere more appropriate to place these templates? Would they all be better placed in the /admin directory? Or maybe feed-icon.html.twig could go in the /views directory?
finn lewis → credited markconroy → .
smustgrave → credited markconroy → .
I was there
I was there.
markconroy → created an issue.
@willguv you could set up one for Friendly Digital if you wanted.
I was there.
markconroy → created an issue.
Closing this individual issue, in favour of just one credit on the aggregated issue: 📌 Localgov Base - fixes eslint issues across the project Active
Closing this individual issue, in favour of just one credit on the aggregated issue: 📌 Localgov Base - fixes eslint issues across the project Active
Closing this individual issue, in favour of just one credit on the aggregated issue: 📌 Localgov Base - fixes eslint issues across the project Active
Closing this individual issue, in favour of just one credit on the aggregated issue: 📌 Localgov Base - fixes eslint issues across the project Active
markconroy → created an issue.
markconroy → created an issue.
markconroy → created an issue.
markconroy → created an issue.
markconroy → created an issue.
markconroy → created an issue.
markconroy → created an issue.
Hi
I was here too!
finn lewis → credited markconroy → .
Can this be closed in favour of 🌱 Plan for Tailwind CSS theme 5.0.0 release Active
We have also worked on the "Stable is deprecated" issue in
✨
Add support for Drupal 11
Active
where we set Stable9 as the theme, so we are not relying on a contrib theme, and also updating from core to core_version_requirement.
For that reason, I think this issue could probably be closed as outdated since it doesn't reflect support for D11.
Update sentence for logical properties from "do have" to "do not have"
I think that MR looks good now, but maybe we should drop support for Drupal 8 + 9 since they are no longer supported.
Also, have you tested that this theme actually works in Drupal 11?
Stable9 is a core theme, so that should be decent evidence for it having a future. It's the core base theme that other themes (in general) are encouraged to use as their base. It was introduced in Drupal 9, then we deprecated stable in 9.5 and moved stable to contrib (I doubt many are using it from contrib) in favour of using Stable9.
Stable9 is the default core theme for Drupal 9 + Drupal 10 + Drupal 11. You can see it's code is here in Drupal 11 - https://git.drupalcode.org/project/drupal/-/tree/11.x/core/themes/stable... - with the note:
Warning: Themes that decide to not use Stable 9 as a base theme will need
continuous maintenance as core changes, so only opt out if you are prepared to
keep track of those changes and how they affect your theme.
Here's the change record from Drupal 9.5 saying to use Stable9 instead of Stable if possible - https://www.drupal.org/node/3309392 →
Here's the Drupal (sub) theming guide - https://www.drupal.org/docs/develop/theming-drupal/sub-theming-using-sta... →
Why are you requiring the contrib version of the Stable theme rather than core's version?
@Rajan Kumar@2026 your MR will not work, as it stipulates that stable is the base theme, but that is not available in Drupal 11.
You will need to update the core_version_requirement and also change stable to stable9.
I'd also suggest, the core_version_requirement removes support for 8 and 9, but that is up to the maintainer to decide.
---
Thanks to The Confident for sponsoring my time to work on this.
The free text filter on the "Extend" page is not a search component.
Please do not work on that as part of this issue.
This issue is to standardise how search will look where search is actually used when it's a single input+button in Drupal 7.
I'm not even sure there are examples of this in Drupal 10/11 core at this stage.
The only thing I can find is this:
With all that being the case, I am going to close this issue. If someone disagrees, please open a new issue with very clear instructions on what you want to achieve.
finn lewis → credited markconroy → .
Giving attribution
---
Thanks to Big Blue Door for sponsoring my time to work on this.
markconroy → created an issue.
smustgrave → credited markconroy → .
From MDN
The :dir() pseudo-class uses only the semantic value of the directionality, i.e., the one defined in the document itself.
Looks like it's document-level.
:dir(rtl) should work perfectly fine for us.
It's a CSS function that has been supported for quite a while.
Forcing bots to run again.
Marking as 'Needs review'
---
Thanks to The Confident for sponsoring my time to work on this.
markconroy → created an issue.
Setting to Needs review.
---
Thanks to The Confident for sponsoring my time to work on this.
markconroy → created an issue.
Merged.
Setting to Needs review so the bots can run.
---
Thanks to The Confident for sponsoring my time to work on this.
markconroy → created an issue.
Closing, will open new issue.
markconroy → created an issue.
Closing this issue now.
---
Thanks to The Confident for sponsoring my time to work on this.
Merged, thanks for working on this.
---
Thanks to The Confident for sponsoring my time to work on this.
Merged, thanks very much for working on this.
---
Thanks to The Confident for sponsoring my time to work on this.
markconroy → made their first commit to this issue’s fork.