Stable theme is deprecated themes after 9.5

Created on 3 January 2023, about 2 years ago
Updated 27 January 2023, about 2 years ago

Problem/Motivation

Based on the https://www.drupal.org/project/drupal/issues/3308890 .

The stable theme is deprecated and will be removed from Drupal 10. Themes depending on the stable theme may use the stable contrib project or switch to stable 9.

Steps to reproduce

1. Use Drupal 9.5 clean website
2. Follow readme.txt download the tailwindcss theme project
3. Enable the theme and check the status report.

Proposed resolution

Set stable project as dependency theme.

Remaining tasks

Update composer.json

User interface changes

No

API changes

No

Data model changes

No

📌 Task
Status

Needs review

Version

5.0

Component

Code

Created by

🇹🇼Taiwan cobenash Taipei

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇭🇺Hungary csakiistvan

    I fixed the D10 compatibility issue too.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs work about 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
    core: 8.x
    -core_version_requirement: ^8 || ^9
    +core_version_requirement: ^8 || ^9 || ^10
    

    core cannot be used with that core_version_requirement value.

    Either that value is changed, or the patch just correct the base theme value, which is the topic of this issue.

  • Status changed to Needs review about 2 years ago
  • 🇭🇺Hungary csakiistvan

    Thank you apaderno for the feedback. I updated the patch and it is modify only the topic of this issue.

  • 🇹🇼Taiwan cobenash Taipei

    @apaderno @csakiistvan Thank you !

    However, the original issue I reported will be added stable theme as dependency theme.

    Therefore, I guess we probably needs to add composer.json and add stable theme in require section.

    Also, we might need to change the installation process in readme.txt. Using composer instead of git clone.

  • Status changed to Needs work about 2 years ago
  • Status changed to Postponed about 2 years ago
  • 🇭🇺Hungary csakiistvan

    The Readme update is on an another issue https://www.drupal.org/project/tailwindcss/issues/3197085 Update the README to document recent changes. Needs review . The composer is a good idea, we should create a new issue for this. What do you think cobenash?

  • 🇹🇼Taiwan cobenash Taipei

    @csakiistvan Thank you.

    I think we could using the following format.

    {
    	"name": "drupal/tailwindcss",
    	"type": "drupal-theme",
    	"description": "A starter kit theme for Drupal 8/9 and Tailwind CSS.",
    	"homepage": "https://www.drupal.org/project/tailwindcss",
    	"license": "GPL-2.0+",
    	"require": {
    		"drupal/stable": ">=2.0.0"
    	}
    }
    

    Although the themes project will be moved to contrib folder if we use composer, but we could add some script to clone a new one on the custom foler.

  • Assigned to csakiistvan
  • 🇭🇺Hungary csakiistvan

    Yes, you are right. I misunderstood the task, I am on it.

  • Status changed to Needs work about 2 years ago
  • 🇭🇺Hungary csakiistvan

    @cobenash do you mean the tailwindcss theme should be move to the themes/custom folder right? There is a vendor-dir option in the composer, we should use this for that

    
    {
    	"name": "drupal/tailwindcss",
    	"type": "drupal-theme",
    	"description": "A starter kit theme for Drupal 8/9 and Tailwind CSS.",
    	"homepage": "https://www.drupal.org/project/tailwindcss",
    	"license": "GPL-2.0+",
    	"require": {
    		"drupal/stable": ">=2.0.0"
    	},
      "config": {
        "vendor-dir": "../../custom/tailwindcss"
      }
    }
    
  • 🇹🇼Taiwan cobenash Taipei

    @csakiistvan

    No, I mean if we use composer to download the theme, drupal will put the theme directly at the theme/contrib folder. But it's fine.

    Instead, I think we should create a basic shell script, copy the theme from theme/contrib/tailwindcss to theme/custom/mytheme

    Also, update the theme name and corresponding file name.

    For example, mytheme might be the new custom tailwindcss.

  • Status changed to Needs review about 2 years ago
  • 🇭🇺Hungary csakiistvan

    I think It looks like a new feature request. Should I create a new issue for this?
    I attached the updated patch

  • 🇹🇼Taiwan cobenash Taipei

    @csakiistvan Thank you for your patch.

    From my end, I think the script is necessary. Here is the example I found from bootstrap_sass https://git.drupalcode.org/project/bootstrap_sass/-/blob/5.x/scripts/cre...

    Or we need to update the readme.txt to write the correct step if we want to use composer download the project.

    It's just my point of view. :)

  • 🇮🇹Italy gambry Milan

    Adding the correct tag for Drupal Global Contribution Weekend 2023.

  • First commit to issue fork.
  • 🇬🇧United Kingdom opdavies Wales

    I think it's also worth testing this with base theme: false and seeing if it works without a base theme.

  • Status changed to Closed: outdated 11 days ago
  • 🇮🇪Ireland markconroy

    We have also worked on the "Stable is deprecated" issue in Add support for Drupal 11 Active where we set Stable9 as the theme, so we are not relying on a contrib theme, and also updating from core to core_version_requirement.

    For that reason, I think this issue could probably be closed as outdated since it doesn't reflect support for D11.

Production build 0.71.5 2024