Account created on 20 April 2009, over 15 years ago
  • Drupal frontend developer at 1xINTERNETΒ  …
#

Merge Requests

Recent comments

πŸ‡­πŸ‡ΊHungary csakiistvan

csakiistvan β†’ changed the visibility of the branch 3488327-use-css-variables to hidden.

πŸ‡­πŸ‡ΊHungary csakiistvan

Tested and reviewed, looks nice. Thanks flo909

πŸ‡­πŸ‡ΊHungary csakiistvan

https://www.drupal.org/project/simple_klaro/issues/3336857 πŸ› Fix link to sample config Fixed

πŸ‡­πŸ‡ΊHungary csakiistvan

csakiistvan β†’ made their first commit to this issue’s fork.

πŸ‡­πŸ‡ΊHungary csakiistvan

It is working for me, thanks for this change.

πŸ‡­πŸ‡ΊHungary csakiistvan

@renukakulkarni for me this patch is is very nice, but the link field will mandatory on the form display (but my field is not mandatory on the field settings.)

πŸ‡­πŸ‡ΊHungary csakiistvan

I attached a patch for the current dev code, please @zcht test it

πŸ‡­πŸ‡ΊHungary csakiistvan

I think It looks like a new feature request. Should I create a new issue for this?
I attached the updated patch

πŸ‡­πŸ‡ΊHungary csakiistvan

There is my patch, based on masterperoo's suggestion.

πŸ‡­πŸ‡ΊHungary csakiistvan

@cobenash do you mean the tailwindcss theme should be move to the themes/custom folder right? There is a vendor-dir option in the composer, we should use this for that


{
	"name": "drupal/tailwindcss",
	"type": "drupal-theme",
	"description": "A starter kit theme for Drupal 8/9 and Tailwind CSS.",
	"homepage": "https://www.drupal.org/project/tailwindcss",
	"license": "GPL-2.0+",
	"require": {
		"drupal/stable": ">=2.0.0"
	},
  "config": {
    "vendor-dir": "../../custom/tailwindcss"
  }
}
πŸ‡­πŸ‡ΊHungary csakiistvan

Yes, you are right. I misunderstood the task, I am on it.

πŸ‡­πŸ‡ΊHungary csakiistvan

After the changes the lint errors are gone, thanks Erik.

πŸ‡­πŸ‡ΊHungary csakiistvan

The Readme update is on an another issue https://www.drupal.org/project/tailwindcss/issues/3197085 ✨ Update the README to document recent changes. Needs review . The composer is a good idea, we should create a new issue for this. What do you think cobenash?

πŸ‡­πŸ‡ΊHungary csakiistvan

Thank you apaderno for the feedback. I updated the patch and it is modify only the topic of this issue.

πŸ‡­πŸ‡ΊHungary csakiistvan

There is the updated Readme.md based on #12 comments too.

πŸ‡­πŸ‡ΊHungary csakiistvan

I fixed the D10 compatibility issue too.

Production build 0.71.5 2024