norman.lol → created an issue.
norman.lol → created an issue.
Provided new MR with info.yml changes done as well. Also removed composer.json which had differing version constraints. composer.json file will get created automatically from drupal.org infra pipelines. You only need to have it, if you have additional PHP dependencies.
Let's get this merged and released. 🙏🏻
norman.lol → made their first commit to this issue’s fork.
Let's get this merged and released 🙏🏻
norman.lol → made their first commit to this issue’s fork.
Bump 🙂
Saw the project listed in https://drupal.stackexchange.com/q/321793/15055
True, now the hook is in src/Hook/ContentTranslationHooks.php?ref_type=tags#L382-415 and the 11.x MR still has it, while the 10.x patch has the hook removed.
But all tests are green 🤔
Are the tests wrong? Or could the hook still stay?
The patch is completely unrelated to this issue.
@tim - Please help us, checking out the current MR, reviewing if it is working for you, reviewing if it fixes any accessbility issues for you.
Maybe you can even help us solving the problem of the initial focus.
Not sure how mirroring a third party JS library on drupal.org should be any good.
Running composer require drupal/better_exposed_filters and pushing the updated composer.json and .lock file, my colleagues pull and upon running composer install the get an error:
- Required package "leongersen/nouislider" is not present in the lock file.
This usually happens when composer files are incorrectly merged or the composer.json file is manually edited.
Read more about correctly resolving merge conflicts https://getcomposer.org/doc/articles/resolving-merge-conflicts.md
and prefer using the "require" command over editing the composer.json file directly https://getcomposer.org/doc/03-cli.md#require-r
Composer [install -n] failed, composer command failed: exit status 4. stderr=
Re-running composer require drupal/better_exposed_filters then updates the .lock file again with leongersen/nouislider in it.
So we should either inform people about needing to run composer require drupal/better_exposed_filters twice or we follow the approach of either providing a libraries.composer.json or add the library into better_exposed_filters' composer.json like for example the Photoswipe contrib module does it: https://git.drupalcode.org/project/photoswipe/-/blob/5.x/composer.json?r...
I honestly don't understand why we would create a mirror of a third party library on drupal.org and try to pull it in like that.
This is working really well so far. 👏🏻
The only thing we would like to change is that we would like to prevent that there's a default focus upon opening the page.
Only after the first time pressing tab we would like the first element to be focused.
The current patch did not account for manually entered URLs in config.
We must cover both absolute library URLs and relative URLs with base path prefixed manually already.
Applied same changes as in 🐛 Library path wrong for subsites (4.x) Active .
The failing pipeline is unrelated to this issue and has already been addressed in 🐛 LazyForm too few arguments Needs review .
There's a config in the module to override this path already. The current patch unfortunately doesn't work if an absolute URL has been entered. And it also won't work if the base path has been manually prefixed already.
I think we need to additionally check two things first:
- 1. Is the URL relative and has the base path already been entered
- 2. Is it an external URL
In both cases the base path should not be added.
norman.lol → created an issue.
💙
I guess that's why I got no credit now. Although I spent time reviewing and testing it. 😿
norman.lol → created an issue.
norman.lol → created an issue.
norman.lol → created an issue.
Needs review and needs follow-up issue to place the currently omitted [OMITTED] Mailchimp keys.
Both types of hero - frontpage and detailpage - are too different. And the frontpage is much different from the blog template as well. So I've put the frontpage hero with just raw markup.
We then only need the hero component for the detailpages.
leymannx → created an issue.
leymannx → created an issue.
Today @klausi and me met in Vienna to get this issue resolved ultimately.
leymannx → created an issue.
leymannx → created an issue. See original summary → .
Friends, please: There's just one ContributionWeekend tag. We want to count all issues afterwards easily and have them all show up on one page easily.
Thank you! Happy contribution weekend everybody 🤗
leymannx → created an issue.
leymannx → created an issue.
leymannx → created an issue.
leymannx → created an issue.
leymannx → made their first commit to this issue’s fork.
Only into the suggest section I'd say. Same as the others
Is this still an ongoing issue? What's the idea on how to proceed here?
leymannx → made their first commit to this issue’s fork.
leymannx → created an issue.
Module marked obsolete in favor of drush generate phpstorm-meta.
The desired feature is probably already included in the file generated with drush generate phpstorm-meta Drush core command.
Module marked obsolete in favor of drush generate phpstorm-meta.
Module marked obsolete in favor of drush generate phpstorm-meta.
Module marked obsolete in favor of drush generate phpstorm-meta.
Module marked obsolete in favor of drush generate phpstorm-meta.
Module marked obsolete in favor of drush generate phpstorm-meta.
Ahaaaa, I see. I didn't know this exists!
You definitely need to fix the README and the project page to print the right command, because neither drush generate-metadata nor drush phpstorm-meta.
It's as you wrote here correctly drush generate phpstorm-meta.
Yes, we should deprecate the module over the native generate command then.