The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π¨π¦Canada joseph.olstad
try this, changes to the automated tests as per the bot suggestions.
- Status changed to Needs review
over 1 year ago 12:16am 31 January 2023 The last submitted patch, 58: drupal-fix_fallback-2951294-58.patch, failed testing. View results β
- Status changed to Needs work
over 1 year ago 11:05am 31 January 2023 - π©πͺGermany Anybody Porta Westfalica
Added π ProcessedText filter doesn't pass in correct language when using language fallback Needs work
- π§πͺBelgium kristiaanvandeneynde Antwerp, Belgium
+1 for somehow making this configurable.
Currently we have a site where I would like to see @sdewitt's suggestion as explained by @plach in #9. I.e: No translation -> 404, unpublished translation -> 403
But I can definitely see websites where you want a fallback at all cost and then it would make more sense to have a fallback in both the above cases. The downside to a toggle is that if you flip it on a live website with existing data, all of a sudden your access logic gets turned upside down.
Query access seems to be fine, as missing or unpublished translations don't show up anyway (fulfulling scenario 1's desires) and the fallback always shows up for both scenarios.