🇩🇪Germany @Anybody

@DudeWeb: Do you have flippy installed on both?

@Grevil: Any ideas? We can have a look at this tomorrow.

Anybody → created an issue.

@viniciusrp Follow-Up: #3447690: Errors applying core patches (composer update impossible) →

This hasn't been fixed yet.

Anybody → created an issue.

Great work @Grevil, RTBC+1 as I can confirm this fixes the issue. Test shows that.

This should please also be committed to 10.3.x to fix it there.

Happy to see this fixed finally. It would be great to also have confirmation by the other participating users here, especially @DieterHolvoet. Thanks!

Okay thank you @mglaman :)

@mfb: Read #12

Thank you very much @markaspot that's cool :)

Still this would be super helpful, but no maintainer activity...

Anybody → created an issue.

Anybody → created an issue.

Anybody → created an issue.

Yes indeed very sad. OpenAPI is super helpful for developers using the API, but currently doesn't work correctly in combination with commerce_api or jsonapi_extras

I there's a clear plan how to fix that correctly, we'd like to help getting things done! :)

I guess it might be caused by this issue? 🐛 Specification includes disabled resources Needs review

@Maintainer: Any chance to review and merge this finally? This is one of the patches for commerce_api ( 📌 Document recommended patches Active ) and has effects like described above.

- #2996114: Argument 2 passed to Drupal\jsonapi\Routing\Routes::Drupal\jsonapi\Routing\{closure}() must be an instance of Drupal\jsonapi\ResourceType\ResourceType, NULL given → has been fixed (removed)
- 📌 Improve installer performance by ~20% by rebuilding the router after the entire installation is complete rather than after each module Fixed has been fixed (removed)
- #3021930: Follow-up to SA-CONTRIB-2018-081: Restore JSON:API filter access → has been fixed (removed)
- #3091299: Support entities that have non-config entity bundles → has been fixed (removed)
- 🐛 Support non-entity bundle types RTBC is RTBC (would be nice to get it merged and released) - upated to https://www.drupal.org/files/issues/2023-06-05/3084914-22.patch →

Guess this should be merged to bring the README.md suggested patches up to date.

FYI: This is still one of the patches required for commerce_api so would be GREAT to finish
📌 Document recommended patches Active

The documented patches at https://git.drupalcode.org/project/commerce_api/-/blob/8.x-1.x/README.md... need to be updated, they don't apply any more, I'll prepare a MR.

Anybody → made their first commit to this issue’s fork.

Thanks @mglaman I just thought the same :)

Until that it might make sense to add information on the module page linking to this issue and pointing out that JSON:API + commerce_api is preferred (but not yet supported) over https://www.drupal.org/project/commerce_cart_api →

I just needed some hours to find out if it's better to use REST or JSON:API with Drupal Commerce. => JSON:API seems to be the better choice but is incompatible with this module.

An alternative to a 2.x version might be a separate project like commerce_api_cart_flyout or something like that, which shows the hierarchy?

@jcnventura can you perhaps create the 2.x branch so we can create a MR against it?

I think this should use MRs instead to make it easier for maintainers to review and merge.

@grathbone are these both standards? Could you give some details / references?

Thanks! Good catch.

Thanks, makes sense in my eyes!

FYI: I closed 🐛 Disabled Content Rest API throws exception on REST Specification page Needs work as duplicate.

So I guess this should be closed as duplicate in favor of 🐛 Specification includes disabled resources Needs review ?

Great work @kasperg! RTBC!

Any maintainers to finally review and merge this important fix?

Anybody → created an issue.

Anybody → created an issue.

Anybody → created an issue.

Perfect!

Anybody → created an issue.

Anybody → created an issue.

You mean the testing issue?

Thanks, failing test now:

There was 1 error:
1) Drupal\Tests\commerce_custom_checkout_message\Functional\CommerceCustomCheckoutMessageGenericTest::testModuleGenericIssues
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'commerce_custom_checkout_message' is missing its dependency module commerce_checkout.

FYI: ✨ Support for translatable attributes Active could be seen as follow-up to make the options individualizable per language. That isn't possible yet and has never been.

Whao, nice one @Grevil. Sorry I didn't see that earlier. That's a run!

Thank you very much @jcnventura! @Grevil will you do that?

This module is so awesome and helpful.

Thank you for your kind words!

Niiiiiiiice, thank you so much @jcnventura! That was fast!

I'd like to second that and would also like to offer my help as (Co-)maintainer. We're using this wonderful module for years in several projects, so we're highly interested to keep it up to date and help pushing things forward :)

Thanks!

This module is for menu_link_content I guess and won't work for programmatically created menu links?

If possible this could be solved in a submodule perhaps, but is very different from what and how the module is currently implemented. Anyone who needs this feel free to create a MR. This is definitely a FR not a bug.

Yes that might make sense, but should be optional then. Feel free to create a MR for review if anyone needs it.

This module is for menu_link_content I guess and won't work for programmatically created menu links?

If possible this could be solved in a submodule perhaps, but is very different from what and how the module is currently implemented. Anyone who needs this feel free to create a MR. This is definitely a FR not a bug.

If anyone needs it, this could be overridden with a MR for this module. Anyone?

#6 was not answered for > 1Y. Should we close this outdated?

Should this be closed now with 🐛 Compatibility with other modules, options being overwritten. Fixed merged?

I can't see any relation to this module? It doesn't manage files?

Ì guess that's a bug that should be reported in menu_fast_edit then?

@daniil_borysenko good point, will you work on this?

https://git.drupalcode.org/project/menu_link_attributes/-/blob/8.x-1.x/m... looks fine to me!

Is this module still installed? Or was it perhaps not uninstalled correctly? (looks like that). So the roles are left over!

Please check latest dev version! Might have been fixed by 🐛 Compatibility with other modules, options being overwritten. Fixed ?

@dstach is this eventually fixed using the latest dev version?

This is perfect and removes the pain from array_merge_recursive :) Thank you @Grevil and @Drupal :)

Anybody → created an issue.

Re #7 yes!

I created a follow-up as I think it needs array_merge_recursive to deep merge the array or use one of these: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util...

📌 Need to deep merge options for compatibility with other modules? Active

Still it makes sense to release this now, as it fixes an important incompatibility and improves the situation.

Anybody → created an issue.

🐛 Compatibility with other modules, options being overwritten. Fixed has already been fixed. Closing this as duplicate.

Merge error!

Merge error

@jcnventura could you please tag a new release containing this fix? We just lost a lot of time to find out this was already fixed in dev...

Thanks!!

Anybody → created an issue.

Anybody → created an issue.

Anybody → created an issue.

Anybody → created an issue.

Thank you very much @apaderno, yes I also tried to contact him month ago without success.

@apaderno sorry my mistake, I should have known that -.- My apologies.
So let's wait for tomorrow.

@Ron Collins which version of the module did you test? Did you test with any other patches / MR's applied?

Am I right in thinking that this is now just an issue with automated tests?

I don't think so. This issue exists in 3.0.x. We'll add clear steps to reproduce this. Like in 🐛 Reset notice is showing up twice (from core and legal module) and don't disappear after password change RTBC we have to ensure we describe all possible paths and have tests for them.

@Grevil: Thanks! We should also check the case @Robert Castelo described and have tests for all possible cases, so we can be sure

1. The message appears as expected
2. The message does not appear multiple times

Both should be checked in the tests.

As a first step the case described by @Robert Castelo should also be checked manually.

@apaderno: Sorry to ask again, but issues like this are really cumbersome for users: 📌 Remove website URL from pane as example Fixed

So if we can't fix this soon I'd create a fork without this advertisement as part of the module. Just one example...

Joachim Namyslo → credited Anybody → .

I guess this will help with debugging: [#3162480]

@Claudia Sotto what does

but only in Drupal 9 menu block

mean?
Are you talking about "modern Drupal" (Drupal 8+ vs. Drupal 7 or is this working in Drupal 8 and 10 for example?

Could you please clarify this or remove the prefix from the title, if it's about 8.1.x. in general? Thanks!

What do the maintainers think about that functionality and fix in general and how can we ensure to track 🐛 Untranslated menu items are displayed in menus Needs work so that if it's merged we don't break the functionality here?

I guess there's no better way then duplicating the core functionality, otherwise it would have been solved differently already?

What do maintainers think about this? Is this going to be accepted as bugfix?

Please note #4. Did you successfully fix that regression in #4 @douggreen?

@chaitanyadessai could you prepare an up to date MR please?

What are the use cases for this?
What do maintainers think about this feature?

Nice one @fskreuz! :)
Could you please use MR's instead of patches in the future? Makes things a lot easier and faster for maintainers.

I'm going to do this here now.

@Lloyd_87 is this still the case?
Perhaps this is a duplicate of 🐛 Language cache context should be passed to the block Needs review ? Are you using content language?

Could you please provide more information about the actual and expected behavior and especially which contexts are changing, while the output is not changing?

Thanks.

Nice one @fskreuz! :)
Could you please use MR's instead of patches in the future? Makes things a lot easier and faster for maintainers.

I'm going to do this here now.

@joelpittet sorry to add another one, but we just ran into 🐛 Language cache context should be passed to the block Needs review in a large project, perhaps you could also have a look at that one, if you have an idea how to proceed there correctly?

Regarding the patch implementation: I'm unsure if that's not something that should already be added in the parent level?

Maybe in SystemMenuBlock? Or is it something that would have to be added by content_translation module?

Do we know anyone who can tell that easily?

Also see 🐛 Untranslated menu items are displayed in menus Needs work for some slightly related issues...