Porta Westfalica
Account created on 9 May 2008, about 17 years ago
  • Drupal Software Engineer & Developer, Project Management at DROWL.de 
#

Merge Requests

More

Recent comments

🇩🇪Germany Anybody Porta Westfalica

Merging current state so that we can then finish this in a follow-up branch.

🇩🇪Germany Anybody Porta Westfalica

anybody created an issue.

🇩🇪Germany Anybody Porta Westfalica

We should also add an explicit permission to enter / edit the JS for security reasons.

🇩🇪Germany Anybody Porta Westfalica

@lrwebks I think a link for adding ad contents would be helpful as last step to use the module?

🇩🇪Germany Anybody Porta Westfalica

field_formatter module allows placing links to the hosting entity (#url in render arrays) on fields (e.g. product variation image) using a boolean formatter setting. It uses the canonical, so I thought this edge-case lead to misbehaviour, but a wrongly configured view (core views settings non-inherited flaw) was the reason! -.-

🇩🇪Germany Anybody Porta Westfalica

Okay finally found out that our issue with field_formatter was not caused by this. So I think the canonical link template for product variations can still make sense, but wasn't the cause of an issue.

Feel free to close this, if you think that a canonical link for product variations is worse than the current implementation.

Thanks a lot!

🇩🇪Germany Anybody Porta Westfalica

Sorry, it works great and correctly, the root cause was a misconfigured view to that the entities were retrieved in the wrong (row instead of content) language!

🇩🇪Germany Anybody Porta Westfalica

I have to agree with @grevil.
This is btw line 25 (since 3 years):
foreach ($entity_field_manager->getFieldStorageDefinitions($entity_type_id) as $field) {
https://git.drupalcode.org/issue/views_order_by_delta-3382073/-/blob/338...

Wondering how the Undefined array key can appear there?

🇩🇪Germany Anybody Porta Westfalica

Okay, testing this out a bit I can see that the product variations (correctly) don't generate a #url from the canonical. The (wrong) link originates from the products, not the product variation.

Still unclear, why the products language ($langcode) is returned wrong here. (de instead of en)

🇩🇪Germany Anybody Porta Westfalica

Thanks for the quick reply @jsacksick - yes my idea was something like using the parent product's route which represents the variation or a redirect route on that, but I see the issue with that... also not really perfect.

🇩🇪Germany Anybody Porta Westfalica

Looking at #3127757: field_linker and link_to_entity #url wrong language this should already be correct, maybe this is a special case for commerce product variations, because they have no canonical URL?

See last patch in #3223974: Views not showing "Link to the Product variation" that adds a canonical link, which they currently don't have: https://git.drupalcode.org/project/commerce/-/blob/3.x/modules/product/s...

🇩🇪Germany Anybody Porta Westfalica

@martins.bruvelis I'm back here, sorry. Would you mind having a look at my comment in the MR and fix the conflicts? Then we should fix the broken test and review and test this once again!

🇩🇪Germany Anybody Porta Westfalica

Let's try to force rendering for these blocks!

🇩🇪Germany Anybody Porta Westfalica

Thank YOU @jsacksick! That's great, we're happy!

🇩🇪Germany Anybody Porta Westfalica

Great, let's use it!

🇩🇪Germany Anybody Porta Westfalica

Nice and defensive implementation @grevil! Thank you!

🇩🇪Germany Anybody Porta Westfalica

I guess Drupal provides a link for removing all the entities on the uninstall page (/admin/modules/uninstall)? Besides the module description.
At least typically it does since Drupal 9 or so...

🇩🇪Germany Anybody Porta Westfalica

@grevil makes sense to me, I couldn't really see a reason for this unexpected behavioru. I'd be fine to assume it's a special bug in @lrwebks's environment... Not worth deeper checks for now?

🇩🇪Germany Anybody Porta Westfalica

Thanks @tbkot, that sounds really good! I'd like to wait for some community feedback before merging this. Totally best would be to have test coverage for the module for a better sleep...

🇩🇪Germany Anybody Porta Westfalica

Nice work @lrwebks thank you!

🇩🇪Germany Anybody Porta Westfalica

@lazzyvn wouldn't it be fair to credit @grevil and me?

🇩🇪Germany Anybody Porta Westfalica

🐛 Access denied to published private file if original translation is unpublished Needs review has been closed in favor of this - should be checked, if it's really duplicates.

🇩🇪Germany Anybody Porta Westfalica

Duplicate of 🐛 LogicException: The database connection is not serializable. Postponed: needs info - where it's already fixed.

🇩🇪Germany Anybody Porta Westfalica

Added a check for the querySelector() elements to be present.

🇩🇪Germany Anybody Porta Westfalica

For me it's

Uncaught CKEditorError: s is undefined

, but I think same root cause.

🇩🇪Germany Anybody Porta Westfalica

I can also confirm the issue. Could someone maybe turn the patch into a MR and follow the steps described in the comments? Thanks!

🇩🇪Germany Anybody Porta Westfalica

Thanks for the ping @j-lee you're right sorry I didn't see it's missing!

🇩🇪Germany Anybody Porta Westfalica

Once someone confirms it works fine, I'm willing to create a new tagged release.

🇩🇪Germany Anybody Porta Westfalica

Merged, sorry I didn't see this issue.

🇩🇪Germany Anybody Porta Westfalica

anybody made their first commit to this issue’s fork.

🇩🇪Germany Anybody Porta Westfalica

Maybe someone could ping @dave-reid? Is he active? Otherwise maybe request (co-)maintainership?
This project is very widely used!

🇩🇪Germany Anybody Porta Westfalica

@lrwebks commented!

Before merging this, I need to test it myself as soon as I have the time.

🇩🇪Germany Anybody Porta Westfalica

@lrwebks: Looks like all subissues have been resolved and this can be set fixed?

🇩🇪Germany Anybody Porta Westfalica

The root cause here is bad function naming!
https://git.drupalcode.org/project/micon/-/blame/2.x/src/MiconIconize.ph...

setIcon() vs. setIconAfter() vs. setIconBefore()

All pretend to do similar things, but do very different things... The latter should be named setIconPositionAfter() and setIconPositionBefore(). Then it would be self-explaining, why this fix is needed...

So RTBC, but the naming should also be fixed in a follow-up to be self-explaining.

🇩🇪Germany Anybody Porta Westfalica

Thanks @sascha_meissner - yes I just think it's a different option, both should be available for typical use-cases in this widely used module.

🇩🇪Germany Anybody Porta Westfalica

Just ran into this once again, here's the backtrace:

Error: Call to a member function isZero() on null in Drupal\commerce_payment\Plugin\Commerce\CheckoutPane\PaymentProcess->isVisible() (line 118 of /web/modules/contrib/commerce/modules/payment/src/Plugin/Commerce/CheckoutPane/PaymentProcess.php) #0 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase..php(113): Drupal\commerce_payment\Plugin\Commerce\CheckoutPane\PaymentProcess->isVisible()
#1 [internal function]: Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\{closure}()
#2 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php(111): array_filter()
#3 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php(132): Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->getVisiblePanes()
#4 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowBase.php(275): Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->isStepVisible()
#5 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Block/CheckoutProgressBlock.php(93): Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowBase->getVisibleSteps()
#6 /web/core/modules/block/src/BlockViewBuilder.php(171): Drupal\commerce_checkout\Plugin\Block\CheckoutProgressBlock->build()
#7 [internal function]: Drupal\block\BlockViewBuilder::preRender()
#8 /web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(113): call_user_func_array()
#9 /web/core/lib/Drupal/Core/Render/Renderer.php(870): Drupal\Core\Render\Renderer->doTrustedCallback()
#10 /web/core/lib/Drupal/Core/Render/Renderer.php(432): Drupal\Core\Render\Renderer->doCallback()
#11 /web/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender()
#12 /web/core/lib/Drupal/Core/Render/Renderer.php(165): Drupal\Core\Render\Renderer->render()
#13 /web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#14 /web/core/lib/Drupal/Core/Render/Renderer.php(164): Drupal\Core\Render\Renderer->executeInRenderContext()
#15 /web/core/lib/Drupal/Core/Render/Renderer.php(191): Drupal\Core\Render\Renderer->renderInIsolation()
#16 /web/core/lib/Drupal/Core/Render/Renderer.php(228): Drupal\Core\Render\Renderer->doRenderPlaceholder()
#17 /web/core/modules/big_pipe/src/Render/BigPipe.php(697): Drupal\Core\Render\Renderer->renderPlaceholder()
#18 /web/core/modules/big_pipe/src/Render/BigPipe.php(524): Drupal\big_pipe\Render\BigPipe->renderPlaceholder()
#19 [internal function]: Drupal\big_pipe\Render\BigPipe->Drupal\big_pipe\Render\{closure}()
#20 /web/core/modules/big_pipe/src/Render/BigPipe.php(531): Fiber->start()
#21 /web/core/modules/big_pipe/src/Render/BigPipe.php(283): Drupal\big_pipe\Render\BigPipe->sendPlaceholders()
#22 /web/core/modules/big_pipe/src/Render/BigPipeResponse.php(113): Drupal\big_pipe\Render\BigPipe->sendContent()
#23 /vendor/symfony/http-foundation/Response.php(423): Drupal\big_pipe\Render\BigPipeResponse->sendContent()
#24 /web/index.php(20): Symfony\Component\HttpFoundation\Response->send()
#25 {main}.
#0 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php(113): Drupal\commerce_payment\Plugin\Commerce\CheckoutPane\PaymentProcess->isVisible()
#1 [internal function]: Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\{closure}()
#2 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php(111): array_filter()
#3 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowWithPanesBase.php(132): Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->getVisiblePanes()
#4 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Commerce/CheckoutFlow/CheckoutFlowBase.php(275): Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowWithPanesBase->isStepVisible()
#5 /web/modules/contrib/commerce/modules/checkout/src/Plugin/Block/CheckoutProgressBlock.php(93): Drupal\commerce_checkout\Plugin\Commerce\CheckoutFlow\CheckoutFlowBase->getVisibleSteps()
#6 /web/core/modules/block/src/BlockViewBuilder.php(171): Drupal\commerce_checkout\Plugin\Block\CheckoutProgressBlock->build()
#7 [internal function]: Drupal\block\BlockViewBuilder::preRender()
#8 /web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(113): call_user_func_array()
#9 /web/core/lib/Drupal/Core/Render/Renderer.php(870): Drupal\Core\Render\Renderer->doTrustedCallback()
#10 /web/core/lib/Drupal/Core/Render/Renderer.php(432): Drupal\Core\Render\Renderer->doCallback()
#11 /web/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender()
#12 /web/core/lib/Drupal/Core/Render/Renderer.php(165): Drupal\Core\Render\Renderer->render()
#13 /web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#14 /web/core/lib/Drupal/Core/Render/Renderer.php(164): Drupal\Core\Render\Renderer->executeInRenderContext()
#15 /web/core/lib/Drupal/Core/Render/Renderer.php(191): Drupal\Core\Render\Renderer->renderInIsolation()
#16 /web/core/lib/Drupal/Core/Render/Renderer.php(228): Drupal\Core\Render\Renderer->doRenderPlaceholder()
#17 /web/core/modules/big_pipe/src/Render/BigPipe.php(697): Drupal\Core\Render\Renderer->renderPlaceholder()
#18 /web/core/modules/big_pipe/src/Render/BigPipe.php(524): Drupal\big_pipe\Render\BigPipe->renderPlaceholder()
#19 [internal function]: Drupal\big_pipe\Render\BigPipe->Drupal\big_pipe\Render\{closure}()
#20 /web/core/modules/big_pipe/src/Render/BigPipe.php(531): Fiber->start()
#21 /web/core/modules/big_pipe/src/Render/BigPipe.php(283): Drupal\big_pipe\Render\BigPipe->sendPlaceholders()
#22 /web/core/modules/big_pipe/src/Render/BigPipeResponse.php(113): Drupal\big_pipe\Render\BigPipe->sendContent()
#23 /vendor/symfony/http-foundation/Response.php(423): Drupal\big_pipe\Render\BigPipeResponse->sendContent()
#24 /web/index.php(20): Symfony\Component\HttpFoundation\Response->send()
#25 {main}

All modules and core are up to date, so this issue clearly still exists.

🇩🇪Germany Anybody Porta Westfalica

Thanks @sascha_meissner - I added disable_powered_by: false default value. Guess attribution should be given by default?

🇩🇪Germany Anybody Porta Westfalica

Yeah still pretty dead. That's really sad, as simplytest.me is really a great tool for quick try's! Thank you all!!

🇩🇪Germany Anybody Porta Westfalica

@lr:

@anybody: As far as I'm aware it did work in 4.x, yes.

Then it shouldn't be hard to find for you? Just look up how it worked and what broke it?

🇩🇪Germany Anybody Porta Westfalica

@lrwebks did it work in 4.x?

🇩🇪Germany Anybody Porta Westfalica

Sadly seems like it isn't. This was also my hope, as I just needed to import some new config files from config/install in a module. My expectation was that only these were imported and updated, but instead a lot of existing configuration was deleted.

🇩🇪Germany Anybody Porta Westfalica

I can confirm this issue still exists in 3.0.x-dev! Also the tests submodule is not marked D11 compatible.

🇩🇪Germany Anybody Porta Westfalica

This is still an open question that would be great to answer on the project page also. Thanks!

🇩🇪Germany Anybody Porta Westfalica

@liam morland: There's nothing to review yet. We should either fix both issues over at 📌 When scrolling, the modal window opens automatically Active or here. They are very closely related, nearly the same and surely have the same fix. As this one is closed, maybe better move over?

So ==> Further work here: https://www.drupal.org/project/webform/issues/3506020 📌 When scrolling, the modal window opens automatically Active <==

🇩🇪Germany Anybody Porta Westfalica

Test Error

Drupal\Tests\drowl_paragraphs_bs_type_video\Functional\GenericDrowlParagraphsBsVideoTest::testModuleGenericIssues
Drupal\Core\Config\PreExistingConfigException: Configuration objects (field.storage.paragraph.field_override_autoplay, field.storage.paragraph.field_override_controls, field.storage.paragraph.field_override_loop, field.storage.paragraph.field_override_muted) provided by drowl_paragraphs_bs_type_video already exist in active configuration

absolutely make no sense to me. They can't pre-exist, because they have not been existing in the past...

Maybe this runs in kind of a loop and tries to re-install them?
The update hook will never be called by the module, I guess so that shouldn't be the reason?

🇩🇪Germany Anybody Porta Westfalica

Ready for review @thomas.frobieter feel free to merge if it's fine and you won't add your code here.

🇩🇪Germany Anybody Porta Westfalica

@thomas.frobieter ready for review. Would you also like to add your code here or only the fields?

Production build 0.71.5 2024