Porta Westfalica
Account created on 9 May 2008, about 16 years ago
  • Drupal Software Engineer & Developer, Project Management at DROWL.deΒ 
#

Merge Requests

More

Recent comments

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Let's simply use view filtering for that.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@sourojeetpaul aaah sorry I got you wrong! Yeah that's something @JoachimFeltkamp has to have a look at. Maybe you can send him a PM?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@sourojeetpaul simply click "Get push access" above and create a MR please.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

You all might be interested in ✨ Add a '#selectall' option for checkboxes element Active
Please contribute :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Let' finally close this in favour of ✨ Add a '#selectall' option for checkboxes element Active
Please contribute :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@joachim I finally did it ;)
Here's the core feature request: ✨ Add a '#selectall' option for checkboxes element Active

Happy to read your feedback. I hope I'll find the time to implement this soon!
@Vivek Panicker perhaps you'd like to help?

Let's postpone this issue to the day it'll be merged, so we can simply enable '#checkall' for field_tools :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Anybody β†’ created an issue.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Anybody β†’ created an issue.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Okay it was an issue I created at Field tools, but @joachim also suggested solving it in core.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@mlncn perhaps better remove the dependency from the composer.json for now and instead add a suggestion?

The module still can't be installed with composer at all.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Requested since Drupal 6 :D

Here's a Drupal 8+ quickfix module, but I think we should have this as a FAPI option in core and as a field widget setting in checkboxes widgets (e.g. entity references, lists, ...)

I'm quite sure I saw an issue for that somewhere...

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@ThomasDik thanks, could you please create a MR instead of a patch for review? Thanks!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

We also need to remove the blanks / spaces here, once πŸ› Remove unexpected space (" ") from Modify field values append method RTBC is agreed on by the maintainers!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

A good example is that you may want to append or prepend a character to an SKU - you'll never want the space. But there are also very many other examples where the user should be in charge of that decision.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

+1 on the suggestion. Any plan to finish this @joshmiller?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Anybody β†’ changed the visibility of the branch 3459045-add-a-prepend-option-in-modify-field-values to hidden.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Sorry, created the issue in the wrong project -.-

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica
πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@mqanneh nice! Thank you for your reply! :) All good now that you're back. I was frightened you might not be active anymore.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@john.karam I can't confirm #4 in our case with the hotfix. It seems to work. Could you dive deeper?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Changing this to a full maintainership request as there was no sign of activity from the maintainer yet and there's a critical issue with Drupal 10.3.0 so it makes sense this module has an active maintainer.
Still co-maintainership would also be fine if the maintainer is still active.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Looks great, I think we should simply have a short demonstration together tomorrow.

My only point of criticism is that partially I'd like to more to have some lines of comment explaining what the method does or what's the *expected* functionality so that the human-readable comment is confirmed by code. I like that a lot because you can read the comment to see what's the author's intention and then this gets approved by code or else wise if something doesn't work as expected you still have the comment to understand what *should* go on, but doesn't.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Anybody β†’ changed the visibility of the branch 3049155-disclose-flagging-view to hidden.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Yes, of course it's related to #20 but I thought NULL was also used in core for that in some places. Might have been D7 then perhaps, where I had seen that in the past.

Core uses "default" or "full" in some places, for example https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/block...

But I'd also vote to keep it NULL until the fallback is removed, I think it's most clear, if it has no other disadvantages.
That said I'm also totally fine with changing this if it has any benefits.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

FYI: If someone needs this, please provide a MR to review or sponsor someone to do so. We're not planning to implement this unless we need it. Thanks.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

FYI: If someone needs this, please provide a MR to review or sponsor someone to do so. We're not planning to implement this unless we need it. Thanks.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Yeah cross-checking the data attributes in the output totally makes sense. Good idea.

Happy to review a MR if someone implements this. I'm going to tag this novice for such tests.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

FYI: If someone needs this, please provide a MR to review or sponsor someone to do so. We're not planning to implement this unless we need it. Thanks.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Here's the related GitHub issue: https://github.com/scaleflex/js-cloudimage-360-view/issues/122

I'll assign this to Scaleflex for that reason. Please ping here once it's fixed so we can add the composer integration maybe.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@idebr I think I've seen NULL as default also in core for that. Core then falls back to default if needed, if I'm correct. So that seems right to me!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@idebr maybe you'd also like to take a look at the new MR based on your patch. One test is failing, I'm not yet sure why.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Thanks, all good :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

What's /admin/config/user-interface/views-html-tags?

This module provides a block type, so has no canonical route to point to?!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@claudiu.cristea Re #20 I implemented:
βœ… Strict typing it to string
βœ… Make it optional, defaulting to NULL, otherwise is breaking BC for all sites extending these methods
βœ… If NULL is received, we should
βœ… Trigger a deprecation error
❓ Log a warning message

βœ… Messages should state that the param will be mandatory in the following Flag major version.
πŸ”œ A change notice should be issued.

Could you perhaps take a brief look, if that's what you expected? So we can push things forward here.
I was a bit unsure at which places we should implement the deprecation errors, quite a lot of places.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

We've just run into the same issue sadly and need the information about the view mode in the flag template. So it's indeed not an edge-case. Going to push this forward now.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@Berdir thanks! I can only tell that we didn't switch the PHP version when upgrading to 10.3 where the issue appeared. So it's indeed still a mystery.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Ok I think we need something similar sooner or later: ✨ Implement a mass-email-sending protection (frequency capping) Active
Just ran into a case with hundreds of mails triggered by a search engine crawler triggering a lot of error log entries...

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Thank you @nevergone :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Thank you very very much @saschaeggi! :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@Dave Reid still running into this 5 years after the report. Any chance to merge this and tag a new release? ;D

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Thanks @Balu Ertl you're right. Sorry for my mistake!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Hi @liquidcms sorry yes. This module isn't ready yet to be honest. It was / is a student project in our company which we'll proceed with as soon as possible. Once it's ready we should indeed have kind of a demo or something.

And I think it needs a clear readme to explain the concept and functionalities in detail.

This is meant for internal customer documentation within a Drupal project, provided by the Agency for example, allowing the client to also create pages, if allowed. This is not meant for "Visitors" or as a regular Wiki replacement.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Anybody β†’ created an issue.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

I can sadly confirm this issue in all multilanguage projects.

@ndewhurst you say the patch in #70 is superior. Should this be turned into a MR against 11.x then and also implement tests (eventually the test copied from the existing MR?)

I agree this is major for all multilingual projects!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

No worries @kristiaanvandeneynde! :) But please feel free to test the latest dev and reply here.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@gbyte: SEO tools complain that the URL with the trailing slash is not a canonical URL, but should be. And I guess they're right.

So it would make sense to reopen this issue and rtrim the "/" from the URL, even if Drupal returns it with the slash.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Nice, good enough to fix the issue. Can't be perfect, I think...

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@mqanneh needs to do that as maintainer.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

PS: Please don't forget to credit the participants using the checkboxes below. The old commit message crediting doesn't work anymore.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@mqanneh thank you!!

FYI: Closed (fixed) will be set automatically by Drupal.org - typically you just set Fixed as maintainer.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

As the preloader already had the defer attribute, I agree it might make sense to have the same for the conf.

After testing this, we should first keep it in dev and test it for some time. The most risk I can see is, that other scripts and especially analytics scripts execution might change? (But I actually don't think so, just to write down my thoughts and potential side-effects).

Another thing we need to ensure is, that the both libraries are loaded in the correct order.

@kristiaanvandeneynde I'd very much like to have your feedback and also ping @Grevil and @JFeltkamp for feedback here, before we commit this.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

This won't have any effect yet?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Perfect! :)

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

I'm also running into these log entries now and the URLs it complains about don't seem to be old.
In our case, I can see that the &'s in part of the URL are encoded like this:
&amp%3Btheme=example_theme&scope=footer

That seems to cause the issue for us. Any ideas how and where that can happen? The strange thing is, that not all &'s are affected. And %3B (escaped ;) implies the URL is double-encoded somewhere.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Could someone perhaps prepare a comparison documentation page or snippet for the module page which the maintainer can use?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@mqanneh any plans to finish this? Assigned to you since 2022-07.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

@scott_euser I think there's one mistake, then this is ready to go! I left a comment. Could you fix that?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Well done, RTBC!

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

I think this is a valid request, because

Unrecognized username or password. Forgot your password?

should be something like

Unrecognized username / email or password. Forgot your password?

@adam_b could you prepare a MR to fix this?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Just had several of the same entries in log. URL called:
/user/register?_wrapper_format=drupal_ajax&ajax_form=1&element_parents=account%2Fmail%2F%23value

MR !2827 seems correct to me and I can't see any feedback saying it doesn't work as expected. So what's left here is a test to pass an array (and NULL?) to the validation and ensure it reacts as expected?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Technically, the MR makes sense to me and looks correct.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

See https://www.drupal.org/project/drupal/issues/3302755#comment-15659626 πŸ“Œ On-the-fly JavaScript minification Fixed

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

See https://www.drupal.org/project/drupal/issues/3302755#comment-15659626 πŸ“Œ On-the-fly JavaScript minification Fixed

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Sorry to comment on this fixed issue, but I hope we can get a short information here, if this needs a follow-up issue.

In COOKiES (for GDPR) we need to disable preprocessing (preprocess: false) because the JS files may not be aggregated to be able to block them.
But setting preprocess: false has the side-effect that the resulting JS wll also not be minified, while it would be totally okay aka "good" to have it minified.

So I think it may need a more granular separation of "preprocess" / "aggregate" / "minified" to be able to solve such cases?

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

Okay I think this might be a COOKiES issue, as it needs to set preprocess=false which might also disable the minification?
https://git.drupalcode.org/project/cookies/-/blob/1.2.x/modules/cookies_...

It would be best to have aggregation (preprocess) OFF, but minification ON ( https://www.drupal.org/node/3305725 β†’ ).
Not yet sure if that's possible.

πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

I think this might be caused by COOKiES preprocess=false. We need to find out, if we can minify this without having to preprocess / combine this. https://git.drupalcode.org/project/cookies/-/blob/1.2.x/modules/cookies_...
I think preprocessing is not even the issue, but the scripts may not be combined with other JS. But that doesn't mean it may not be minified.

Production build 0.69.0 2024