- Issue created by @Anybody
- First commit to issue fork.
- @lrwebks opened merge request.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@lrwebks thinks it's too heavy for him :)
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@lrwebks it's not that hard as you think, please review and test manually by time.
Guess it's a great chance to learn how it works (and be less in fear then for the future :))
- ๐ฉ๐ชGermany Anybody Porta Westfalica
PS: My implementation is untested, so please review and try carefully!
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@grevil: Please review code-wise.
@lrwebks please test if this works as expected and nothing is broken - ๐ฉ๐ชGermany lrwebks Porta Westfalica
@anybody: Tested it with multiple different ad types and it works as expected! Even the problem I had personally, where the ads would only display for regular users and not admins, seems to have resolved itself. That leads me to believe it might actually have been a JQuery quirk as wellโฆ Who knows?
- ๐ฉ๐ชGermany lrwebks Porta Westfalica
Re #4 by the way: The solution you have implemented is totally understandable to me and I can definitely grasp the fetch API. But converting that myself would have certainly wasted more worker hours than it should! So, glad that someone else took care of it.
- ๐ฉ๐ชGermany lrwebks Porta Westfalica
Code-wise, this also looks good to me!
-
lrwebks โ
committed f6df46dc on 11.x
Issue #3534874 by anybody, lrwebks: Replace jQuery by vanilla JS
-
lrwebks โ
committed f6df46dc on 11.x
- Status changed to Fixed
19 days ago 9:54am 17 September 2025