Telephone field does not support setting a custom size of the input field

Applied changes in comment #78 to the 10.1.x branch of Drupal and then added the remarks made in #81.

 ../vendor/bin/phpunit modules/telephone/tests/*
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Testing /app/build/core/modules/telephone/tests/src
.............                                                     13 / 13 (100%)

Time: 02:18.388, Memory: 10.00 MB

OK (13 tests, 133 assertions)

Applied changes in comment #78 to the 10.1.x branch of Drupal and then added the remarks made in #81. Also included updated tests for Drupal 6 phone field widget migration.

 ../vendor/bin/phpunit ./modules/field/tests/src/Kernel/Migrate/d6/MigrateFieldWidgetSettingsTest.php
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\field\Kernel\Migrate\d6\MigrateFieldWidgetSettingsTest
.                                                                   1 / 1 (100%)

Time: 00:14.362, Memory: 10.00 MB

OK (1 test, 42 assertions)

 ../vendor/bin/phpunit modules/telephone/tests/*
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Testing /app/build/core/modules/telephone/tests/src
.............                                                     13 / 13 (100%)

Time: 02:20.311, Memory: 10.00 MB

OK (13 tests, 133 assertions)

Issue summary can be updated to include the default issue default.

Also this will need an upgrade path as it is adding a new config setting to existing fields. Upgrade path should have a simple test case also.

Thanks.

Added the template to the issue summary, still needs filling in

Added MR along with other required changes to cover test coverage & updated IS as well, tried to check whether upgrade path needed or not, to verify followed following steps :

1. Enabled the telephone module, added telephone field in content type, content add with telephone field
2. Then added MR changes, test following scenario:
- Go to the manage form display of content type in which existing telephone field added , try to save the field & manage form display:
no config error display
- Added new field in which size of telephone field visible & configure it, which is working fine when add node
So what I concluded here upgrade path not required or either I 'm missing something

In the existing TelephoneFieldTest added newly added size attribute test code , not sure need confirmation do we need still separate test coverage or this 'll be fine?

PLease review, moving to NR

Upgrade path still stands. There's a new config key being introduced that existing sites won't have.

Thanks for swift response, I have quickly verify from config sync, got your concerns, there is new config key missing from entity form display, can you please suggest any core files that I can refer for upgrade path (to follow standard)

View may be good resource. Or image

Will have to be done on using batch api as some sites could have many fields to check.

I have tried to add upgrade path. Please review, moving NR.

Left a comment on the MR.

Totally agree that this is missing in the field widgets and just found that it's missing on many of them, also for example on integer & decimal inputs, so I created a generic parent task: 🐛 Field widget "size" setting is not available across all field types Active

Maybe we should consider adding this in a base class or trait?