- š·š“Romania amateescu
I think this small cleanup is still worth doing, even after all these years :) The issue summary update was requested for the D8 beta phase evaluation, but now it's needed to just follow the current IS standard.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Will land this tomorrow AM to reduce the change rate for #3519247 now that it's unblocked again per #3519247-23: Acquia DAM and Canvas integration ā .
- šŗšøUnited States smustgrave
Since the summary is pretty unclear and been about 10 years since tagged for a summary update going to close this one out. If still valid please re-open
Thanks all!
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- šŗšøUnited States smustgrave
@fgm so think this issue should be re-scoped?
- šØš¦Canada mparker17 UTC-4
It seems this bug exists in the 7.x-1.x, 7.x-2.x, and 7.x-5.x branches, but all of those are unsupported, and Drupal 7 is end-of-life now ā .
That being said, as of August 31, 2025, only ~251 sites are using the 7.x- versions of this module ā .
Is there still interest in fixing this?
How I determined which versions the bug exists on...
$ git remote -vv origin git@git.drupal.org:project/elasticsearch_connector.git (fetch) origin git@git.drupal.org:project/elasticsearch_connector.git (push) $ git fetch --all -t -pP $ git branch -r origin/7.x-1.x origin/7.x-2.x origin/7.x-5.x origin/8.0.x origin/8.x-1.x origin/8.x-2.x origin/8.x-5.x origin/8.x-6.x origin/8.x-7.x origin/HEAD -> origin/8.0.x $ git switch 7.x-1.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '7.x-1.x' Your branch is up to date with 'origin/7.x-1.x'. ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc:function elasticsearch_connector_statistics_tokens($type, $tokens, array $data = array(), array $options = array()) { ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); $ git switch 7.x-2.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '7.x-2.x' Your branch is up to date with 'origin/7.x-2.x'. ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc:function elasticsearch_connector_statistics_tokens($type, $tokens, array $data = array(), array $options = array()) { ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); $ git switch 7.x-5.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '7.x-5.x' Your branch is up to date with 'origin/7.x-5.x'. ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc:function elasticsearch_connector_statistics_tokens($type, $tokens, array $data = array(), array $options = array()) { ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); ./modules/elasticsearch_connector_statistics/elasticsearch_connector_statistics.tokens.inc: $statistics = elasticsearch_connector_statistics_get($node->nid); $ git switch 8.x-1.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '8.x-1.x' Your branch is up to date with 'origin/8.x-1.x'. $ git switch 8.x-2.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '8.x-2.x' Your branch is up to date with 'origin/8.x-2.x'. $ git switch 8.x-5.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '8.x-5.x' Your branch is up to date with 'origin/8.x-5.x'. $ git switch 8.x-6.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '8.x-6.x' Your branch is up to date with 'origin/8.x-6.x'. $ git switch 8.x-7.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '8.x-7.x' Your branch is up to date with 'origin/8.x-7.x'. $ git switch 8.0.x ; grep -r 'elasticsearch_connector_statistics_tokens' . ; grep -r -w 'elasticsearch_connector_statistics_get' . Switched to branch '8.0.x' Your branch is up to date with 'origin/8.0.x'.If the bug had been fixed then I would have seen a line with
function elasticsearch_connector_statistics_get() {The bug isn't present on any branches that don't return any results for either of the
greplines. The Needs Review Queue Bot ā tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide ā to find step-by-step guides for working with issues.
- š³š±Netherlands idebr
Based on the issue summary, comments and related issues the immediate problem is limited to single select elements and client side validation. If I missed something, let me know and I can update the issue accordingly
Refactoring the
_nonevalue itself is being worked on in š Convert '_none' option to a constant and deprecate form_select_options() Needs work - š«š·France nod_ Lille
Can someone confirm which MR is the one RTBC (12460?) and that the comments from MR 7008 are addressed in the latest MR?
- š³š±Netherlands idebr
To minimize the BC break, I suggest we map the
_noneoption to the Select#empty_optionand set#empty_valueto an empty string in a process callback.This implementation allows existing options to remain unchanged; only client side logic is impacted (eg. JavaScript)
- @acbramley opened merge request.
- šŗšøUnited States muriqui
Responding to acbramley's comment, I took a first pass at de-duplicating the entity form and node form. The node form is now a subclass of the entity form, with a few selective overrides as needed to preserve the former behavior. Also resolved the differences in the table layouts, so that the entity form now looks and acts like the node form did before these changes.
- First commit to issue fork.
Changed the functional test for media to a kernel test, and added a unit test for more generic coverage.
- šŗšøUnited States smustgrave
Since there's been no follow up or summary update going to close out. Please re-open if still experiencing this and update summary using full template.
Thanks all.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- šŗšøUnited States smustgrave
Lots of users here so I just credited everyone.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- First commit to issue fork.
- First commit to issue fork.
- ivnish Kazakhstan
@poker10
I don't like idea to removing previous messages. As I know Drupal (and symfony) can't remove message by ID or text. But without removing we have 2 messages and messages region shows twice. Any ideas how to fix it?
- š¦šŗAustralia Stefan Lehmann
I just tested it and can verify that you now have to enter a leading slash as mentioned in #91 as minimal verification. (on Drupal 10.4.5).
.. and as nobody has been complaining about this issue for years. I think this can be closed?
- šŗšøUnited States kentr Durango, CO
It looks like the original plan was to check for non-empty
#titleproperties, but the MR only checked withisset().Empty text doesn't provide an accessible name, so I changed the check to fully disallow empty
#titleproperties. This caused a lot of new errors. Some of them are from š Content: Publishing status (grouped) is missing labels for inputs Active . I think the others are from the Views exposed filter forms themselves.I also added
aria-labelto the conditions. - šøš°Slovakia poker10
Thanks for working on this.
I manually tested the MR since there are no tests to prove that the message is actually shown. It worked as expected. Anyway, I think we should extend the existing
SiteMaintenanceTestto check if the code is working as expected and to prevent regressions in the future, especially if we are "blindly" removing original status message(s).I also have some additional questions:
1. Aren't we worried that we could potentially remove more messages when using this code
\Drupal::messenger()->deleteByType(MessengerInterface::TYPE_STATUS);? For example if there will be any custom messages included. We are not checking the actual message being removed.2. Route
system.site_maintenance_modehas permissions ofadminister site configuration+administer software updates, which means that if you have onlyadminister software updates, you still have access to the maintenance mode form. But if you do not haveadminister site configurationpermission, the newly added link to the Performance page will not work. Are we OK with keeping it there even if the user won't have access to it?
