- ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
Wonder if this is still needed?
I'll make the call. These CSS moving efforts were worth pursuing when Drupal 8 was in development - but now that it's been around close to a decade such a change would be more disruptive than beneficial.
- ๐บ๐ธUnited States smustgrave
Since there has not been a follow up in a few years going to close out.
- ๐บ๐ธUnited States laura.gates
Just adding to the above conversation, I got around this by adding a field to media asking users to select what aspect ratio they want:
- default 16:9
- square 1:1
- vertical 4:5
I then themed as normal for my different display modes.
- ๐ณ๐ฟNew Zealand quietone
This still needs a title that will have meaning when scanning the git log years from now. It is changing the API and adding a new method, after all. Something along the lines of 'Add BreakpointInterface::hasMediaQuery() for ...'?
Got another issue with this patch.
During the installation from the profile I got issue
The service "inline_entity_form.inline_block_dependency_subscriber" has a dependency on a non-existent service "node.node_route_context".This patch should add additional dependency on the node module.
- ๐บ๐ธUnited States drpldrp San Francisco, CA
drpldrp โ changed the visibility of the branch 2839195-10.3.x to hidden.
- ๐บ๐ธUnited States drpldrp San Francisco, CA
drpldrp โ changed the visibility of the branch 2839195-10.3.x to active.
- ivnish Kazakhstan
Automatically closed because Drupal 7 security and bugfix support has ended โ as of 5 January 2025. If the issue verifiably applies โ to later versions, please reopen with details and update the version.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
The only failing test is because of ๐ Cypress test publish-validation is flaky Active
- ๐บ๐ธUnited States smustgrave
Just following up if this should be re-open,. if no follow up in 3 months could be closed
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Discussed with @longwave and @catch given we're never going to upgrade 10.5.x to Twig 4 we don't need to do this one.
- ๐ฆ๐บAustralia acbramley
Given the lack of updates here I'm going to close this one out.
Please feel free to reopen with an updated issue summary including steps to reproduce if this still affects you.
- ๐ฆ๐บAustralia acbramley
Needs a reroll onto an MR.
The IS also needs an update to use the standard template.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
What a fantastic start! ๐คฉ๐
- ๐บ๐ธUnited States smustgrave
Thank you for sharing your idea for improving Drupal.
We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
- ๐ท๐ดRomania vasike Ramnicu Valcea
MR threads addressed ... so back to review.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
> Update all of our API responses (both GET individual and GET list) to provide the entity operations' link relationship for those operations that are permitted
There's no individual GET for ApiContentControllers. I don't think this should be also on auto-saved data, so this should be good now?
- ๐ณ๐ฟNew Zealand quietone
The Ideas project is deprecated, moving this to core.
- @penyaskito opened merge request.
- First commit to issue fork.
@rajveergangwar could you please fix PHP 8.4 deprecation warning in the latest patch?
Deprecated: Drupal\layout_builder\Plugin\Block\InlineBlock::__construct(): Implicitly marking parameter $logger as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/core/modules/layout_builder/src/Plugin/Block/InlineBlock.php
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
AFAICT ๐ Calculate field and component dependencies on save and store them in an easy to retrieve format Active would actually provide the necessary information! ๐ค๐ค
- ๐ฎ๐ณIndia sagarmohite0031
Hello,
Verified and Tested on Drupal 11,
MR applied successfully,
Working as expectedSteps to reproduce
1. Install Drupal 10.1.x-dev version.
2. Go to "Configuration"->Basic Site Setting-> Add Site Slogan->Save.
3. Go to Homepage and Click on the Site branding "Configure Block option and enable site slogan checkbox -> Save Block
4. Go to Homepage and observe the slogan not displayed in the site branding block.Check attachments -
Moving this to RTBC - ๐ฎ๐ณIndia rajveergangwar Delhi
In previous patch, the test file was missing, so adding correct one.
- ๐บ๐ธUnited States drumm NY, US
๐ Manually test TUF-enabled Composer projects Active is where weโve been getting some real-world testing
I think the memory usage looks a blocker: https://github.com/php-tuf/composer-integration/issues/127
Otherwise, we havenโt seen production issues in the last few weeks. When we do see them, they are hard to debug: https://github.com/php-tuf/composer-integration/issues/128
packages.drupal.org
is TUF-enabled. For core, thedrupal/*
&php-tuf/*
namespaces, there ispackagist-signed.drupalcode.org
to be added as another Composer repository. Iโm guessing we might want a separate issue for adding the repository beforepackages.drupal.org
\Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.
during the cache clearing.Got this error after patch apply and cache clearing (drush cr)
Module version: 3.0.0-rc20
Drupal version: 11.1.6- ๐ฌ๐งUnited Kingdom ChandeepKhosa
I can confirm that #115 solved the problem on Drupal core 8.9.20 (silver lining while upgrading a very out of date site).
- ๐ฎ๐ณIndia rajveergangwar Delhi
for my case patch #118 isnt applied completaly, so i created another patch which is working fine for me.
- ๐ฌ๐งUnited Kingdom catch
Pretty sure this logic hasn't changed. There is an entity iterator issue around which would help with this, but a one off with a @todo for that issue also seems fine.
- ๐ธ๐ฐSlovakia poker10
There is still one @todo in the MR - do we need to discuss that? I do not see it mentioned anywhere in this issue. Thanks!
- ๐บ๐ธUnited States smustgrave
Believe feedback has been addressed on this one.