- First commit to issue fork.
I will update the title and confirm the steps in the updated summary by EOD Monday 2024-07-29.
- 🇺🇸United States mherchel Gainesville, FL, US
The
3250234-back-to-top-mikes-sdc-branch
above is ready for review. I added a JS fallback for older browsers and fixed some linting.Note the scroll progress only works in Chromium as progressive enhancement. I don't want to add a scroll event, which has the potential to slow down the browser.
@ehsann_95 I see you're still putting in a bit of effort on the other branch. You're welcome to continue to do so, but there's still quite of work to be done. You're welcome to review the new MR, which should be a bit closer to complete.
- 🇨🇦Canada SKAUGHT
@ahsannazir thanks for the followup. hiding old branch to reduce confusion.
- 🇧🇪Belgium herved
This seems to relate/overlap with 🐛 Error: Call to a member function uuid() on null in Drupal\media_library\MediaLibraryEditorOpener->getSelectionResponse() (line 72 of /app/docroot/core/modules/media_library/src/MediaLibraryEditorOpener.php) Needs work .
The MR there seems to fix it but I haven't compared the code of both solutions yet. The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → changed the visibility of the branch 3450175-typeerror-fieldtypepluginmanagercreatefielditem-called to hidden.
- @samit310gmailcom opened merge request.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → made their first commit to this issue’s fork.
- 🇳🇿New Zealand quietone New Zealand
Trying for a better title. On scanning I kept thinking this was a regression.
- 🇺🇸United States mherchel Gainesville, FL, US
I created a new branch using SDC and CSS only (using scroll animations).
Right now the scroll stuff only works on Chromium. The main functionality works on all browsers.
That being said, I think we might still want to use Intersection Observer so that the show/hide works also works on all browsers.
- @mherchel opened merge request.
- 🇦🇺Australia acbramley
Now that I'm actually manually testing the scenario described in the IS I don't think this is a valid bug anymore (see my comment on the MR).
Perhaps at the time this issue was created, we didn't call
$this->fail()
insidecheckPermissions
OR as per #32 phpunit halts execution on a fail.Since we fail when there's an invalid permission, the original issue in the IS does not happen because drupalLogin is never called when an invalid permission is passed through.
Settintg to PMNMI to see if there's other scenarios that we need to account for.
- 🇫🇷France zenimagine
Nice work. For the animation, how will you handle the infinite scrolling pages? Maybe by disabling the feature?
- 🇺🇸United States mherchel Gainesville, FL, US
Left some general comments. We should also move this to a single directory component. It's a perfect use case.
- 🇩🇪Germany Anybody Porta Westfalica
The fork needs to be updated and conflicts needs to be resolved. Anyway, this looks quite far implemented. Thank you @tBKoT for pushing things forward.
✨ Implement a generic revision UI Fixed and 🐛 Revert and Delete actions should not be available for the current revision Fixed are both resolved in core. So this should be compared to what https://www.drupal.org/node/3160443 → suggests.Maybe "Needs tests" tag can be removed, I can see the Mr has tests.
I think there are quite a few projects where it would be great to have revisions for products and product variations to be able to track changes and revert them if needed!
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇳🇴Norway eiriksm Norway
Hey 👋 Thanks for your contribution! 🚀
The issue summary is a bit lacking. Especially with regards to how to reproduce the issue. Could you for example try to formulate it in a way where we could reproduce it from a clean install?
And what versions are you using? Drupal and PHP especially.
In addition, it's a bit disappointing that our tests do not cover this, so I would like to add test coverage as well. This would also be much easier with exact steps to reproduce
Thanks again ♥️
- @magaki opened merge request.
- 🇮🇳India Chandansha
I've tested MR 8872 with the help of View live preview link.
i attached the video for refference.
I move it to RTBC.
THANKS!! - First commit to issue fork.
- 🇫🇷France andypost
Filed new issue to explore replacement of the library with new native dom extension implementation - ✨ Explore PHP 8.4 native HTML 5 parser vs html5-php Active
- 🇺🇸United States mortona2k Seattle
The new official endoint is: https://www.drupal.org/jsonapi →
https://www.drupal.org/project/project_browser/issues/3462173 📌 Use the production URL for Drupal.org endpoint Fixed
- 🇬🇧United Kingdom amityweb
I am sorry @Anybody it is a complaint. I am new to Drupal and its extremely frustrating that features you expect to be standard in 2024 are just not there, or so hard to implement, or just do not work. I tried another extension just now, Simple ReCaptcha, it has V3 support. It does't work for me! I am not familiar enough with Drupal hooks and modules to do it myself, but I have created my own bespoke PHP form with Google ReCaptcha in a few hours. Less that I take to try and debug simple recaptcha. But thats not drupal, so not sure what I need to do for Drupal. Its just very frustrating especially after seeing this was raised 7 years ago.
Due to no other solution I can find, I will use v2 captcha on this for now. I do think v2 checkbox is more reliable in my experience anyway, just does not look as good.
One good thing from this though... I am very happy someone has replied to me! I have posted issues on many other extensions and no one ever replies. I often wonder if this website is even used! So now I know it is, and thank you for replying!
- 🇬🇧United Kingdom james.williams
@amityweb maybe you - or anyone else! - could help with one of the following?
- Have you tested whether the latest work in the MR !15 is working for you? Could you report back with your findings?
- The phpunit job in the pipeline in MR !15 is failing, but it's doing so with code that seems to be passing fine in the latest 8.x-3.x code. I couldn't see why that would be.
- There is a 'TODO' note in the issue summary, suggesting "the NOSCRIPT fallback no longer works and need to be removed if invisible captcha is used" - can you check whether this is still the case? Either this needs to be done, or that note can be removed. I've added the 'Needs issue summary update' tag in the meantime.
- This issue has the 'needs documentation' tag, which was added in comment #145 ✨ Integrate Invisible reCAPTCHA option from Google Needs work by the former maintainer @hass . They wanted clarification on all sorts of details within the code changes, presumably as code comments. Do the current maintainers feel this is still necessary? I imagine that adding clarification with accurate code comments could do little harm anyway though.
- 🇩🇪Germany Anybody Porta Westfalica
@amityweb please don't complain, but take the time or invest money to finish this. This is open source, it's not someones job ;)
I understand the frustration and I'm running into the same sometimes, but it's not fair.What have YOU done to resolve this? (Looking above the answer seems to be: "Nothing", but hopefully "yet" ;))
And yes, I agree this already took a lot too long, but comments like that don't help getting things done, please remember this. Participation helps!
- 🇬🇧United Kingdom amityweb
Why is this so hard and so long to do? Why is it a patch? Come on guys this isn't rocket science
- @anupsingh-0 opened merge request.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to hidden.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to active.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to active.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to hidden.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India samit.310@gmail.com
Hi @handkerchief,
Agree with your point, but here the idea is the only trusted or some specific user roles have this permission Use the site in maintenance mode(
access site in maintenance mode
).The functionality will remain the same for other users, meaning whenever the maintenance mode will on all the users except those with the above permission will logout.
Thanks
Samit K. - 🇳🇿New Zealand quietone New Zealand
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
The trusted hosts setting in settings.PHP allow lists valid hosts
- 🇫🇷France zenimagine
hi, I found the website below which has a button to go up to the top of the page. It's great because when you scroll the page, it displays around the arrow the length of the page. Can you add an animation for the length of the page (a circle like on the website below):
- 🇺🇸United States smustgrave
Seems all the tags are still needed. Also forgot issue summary update from before
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
Only briefly skimmed but any change will need test coverage.
Also issue summary appears incomplete, recommend using default issue template. Sounds like from previous comment MR solution isn't along the idea so definitely needs a summary update.
- 🇺🇸United States smustgrave
Thanks for working on this
Tagging for issue summary as that appears to be incomplete, recommend using the standard issue template
Tagging for tests as feel a simple assertion could be added to an existing test.
- @skaught opened merge request.
- 🇮🇹Italy kopeboy Mainland
I see no mention of CSS issue in the summary nor in the patch, which does the job! Thank you! +3
- 🇺🇸United States cilefen
Thanks for that information. The PHP module doesn't exist in Drupal Core since version 8. As there doesn't seem to be anything actionable here, I am postponing this. If this is about adding some developer documentation you will have to explain that.
Report security bugs → in the proper place, which is not here.
- 🇮🇳India Kanchan Bhogade
Hi
I've tested MR 8872 on Drupal 11
The MR is applied cleanly...For no page scroll, there is No back-to-top button as expected, and when the page scrolls, the back-to-top button appears.
Attaching SS for reference
RTBC+1 - 🇳🇿New Zealand quietone New Zealand
The release managers discussed this at the end of May and I am only now commenting. We noted that this is part of the Workflow Initiative but that initiative has ended and there isn't anything here for us to review. We also are aware that there is the Trash module and a core issue to move that to core, 📌 Add experimental Trash module Active .
This issue was also closed; as won't fix in 2017 and then re-opened in 2019. But since then there has been no activity here despite a prompt for more information 2 years ago. After 5 years without comment here from someone from the workflow initiative it seems sensible to restore the won't fix from 2017.
And, if that there is a desire to add this to core, then it would be better to start fresh with a new initiative or plan. Therefore, I am going to close this. I trust someone will correct that if it is wrong.
- 🇬🇷Greece vensires
Considering the fact that there are other issues related like 🐛 Unable to explore tokens Needs work and that Fast Token Browser is not usable in D8 (see #3054481: Port Fast Token Browser to Drupal 8 → ), might it be time for this issue to change to the D8 version? And if we prefer this to still exist as a separate module, then let's focus our efforts there.
- 🇳🇿New Zealand janpongos
another tag that gets strips out that's good to be whitelisted is "drupal-media" when using core's ckeditor5.
- 🇺🇸United States steyep
I could not get the patch in #74 nor the diff from the MR to apply cleanly in 10.3. I've attached a re-rolled the patch for 10.3
- 🇬🇧United Kingdom catch
Also if we were to add this, I think it should be its own filter doing this generally for all site-relative links, not within the file reference filter.
For example https://www.drupal.org/project/rel_to_abs → provides this in contrib.
- 🇬🇧United Kingdom catch
The issue summary doesn't explain the problem with relative URLs, why is this a problem?
Additionally, Drupal sites can be run from multiple domains, using domain module and similar. Relative URLs allow this to work, I don't think we're able to cache text formats by arbitrary cache contexts so it would probably break that.
- 🇬🇧United Kingdom catch
Moving this to a plan.
We discussed the general problem (on-the-fly table creation and transactions) at Drupal dev days but I don't think that discussion made it back into an issue, this is probably the right one.
Generally, I still think it's a good idea to make database-implementations-of-services (cache, lock, flood etc.) responsible for creating their database schema, so that if you have a redis backend installed, you don't have 10 empty cache tables in your database for no reason.
However, we could use an interface + tagged services to allow those services to create their schema during module install at an explicit point, so that the fallback is only necessary if you change services.yml to switch an implementation (e.g. from redis to sql) on runtime. And we could maybe do the same tagged services check on a cache clear all so that sites can trigger table creation without having to wait for an entity save or something to do it for them.
This way we'd still have on-demand table creation but we'd be able to... demand it.
- 🇺🇸United States adam-delaney
Patch #46 breaks due to upstream change in Drupal Core 10.3 InlineBlockEntityOperations, see commit: https://git.drupalcode.org/project/drupal/-/commit/71a1ab746b9731cb30213.... This change removes the parent getPluginBlockId method and causes a WSOD. It looks like that method was getting the plugin id from configuration so the patch could likely be updated to code around this. I don't see this patch as long term viable unless core allows for these classes and services to be open to contrib projects so we are planning on getting out of this patch.
- 🇺🇸United States mortona2k Seattle
I looked into how Project Browser is pulling info, and found that it's using a new Drupal.org JSON API endpoint:
https://drupalorg.prod.cluster.drupalsystems.org/jsonapi
Used in: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...
- 🇬🇧United Kingdom longwave UK
Yep this should have been postponed initially, but this is eligible to work on now 🐛 Disabled text formats can't be seen in the GUI Fixed has landed.
- 🇨🇭Switzerland handkerchief
@samit.310@gmail.com But not logging out does not automatically mean that users should continue to use the website despite maintenance.
Example from practice:
Website is briefly switched to maintenance mode several times a day because automatic backups are performed. However, it is correct that during backups, no user administers the website and therefore should not have the permission “Use the site in maintenance mode”. But the users should not all be logged out just because maintenance mode was switched on briefly. If you have a website with a community where many users are logged in, then they are automatically logged out several times a day. I updated the steps to reproduce the issue according to the updated test and opened a merge request with the fix.
- 🇮🇳India samit.310@gmail.com
HI,
We have permission provided by Drupal Use the site in maintenance mode(
access site in maintenance mode
) that allow any user to work on maintenance mode, A simple change can fix this user logout issue,Here all the users who have Use the site in maintenance mode(
access site in maintenance mode
) permission, will not logout if the site goes to maintenance mode.Here is the PR link: https://git.drupalcode.org/project/drupal/-/merge_requests/8876/diffs
Thanks
Samit K. - @kksandr opened merge request.
- @samit310gmailcom opened merge request.
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → made their first commit to this issue’s fork.
- 🇺🇸United States smustgrave
Issue summary still appears to have the old screenshot. Don’t need to keep deleted text either
- @ahsannazir opened merge request.
- 🇺🇸United States mortona2k Seattle
It takes quite a while to build the tracking info, 2+ hours to fetch 1040 pages of 50 items. Only including nid and title in the index. I think most of this time is just waiting for the api, which seems to take about 10 seconds per page.
After the search tracker is built, it runs the index and loads each external entity item. The data is already cached, so it should load it from there instead. How can I customize that?
Looks like XNTT Manager was able to set up a synchronization schedule, but that's not available for v3 yet.
I'm thinking we need more caching options to store the results per page, then on the entity store the page it was found on to look it up from the cache? Or build the single entity cache with the list results?
Will annotations help? Like when the entity is created, does it store the data for the item found in the list?
- 🇺🇸United States smustgrave
Summary appears to be outdated, example the "Apply to selected items" button no longer is there
Proposed solution appears to be missing.
I did test the "Filter" button and it passed contrast.
- 🇺🇸United States mortona2k Seattle
I have a search api view working, but it takes forever to index.
I installed the HTTP Client Log module, and I can see that it's doing a query for each item. This is not necessary because all the data is included in the listing results.
We need a way to tell it to use the data from the list instead of rerunning each item individually.
Also, the max count is not really usable for this API. We need to parse the url in the "last" key and get the page parameter. I put in 60000, which is more than the total number of modules and that seems to work, but can add extra pages to the default external entity list.
- 🇦🇺Australia jannakha Brisbane!
patch #466 applies to D10.3, but selected image styles are not visible in CKEditor 5 while adding/editing image:
Config works as expected:
Selected image styles are not available in CKEditor5:
- 🇺🇸United States mortona2k Seattle
I documented working config for 3.x using just the Rest client. Feel free to copy any of this to the official docs.
https://www.drupalarchitect.info/articles/configure-external-entities-3x...
TODO: Document how to use this in a search api view.
- 🇳🇱Netherlands Summit
Hi, having the same issue, is there already a patch underway?
thanks for your reply in advance, greetings,
- 🇳🇿New Zealand quietone New Zealand
If I read this correctly, in #8 @jhodgdon said there were no changes to be made on this page. Then, in #28 said that this could be changed to adjusting URLs here and elsewhere. But, URLs have been updated in 🐛 [META] Many documentation / handbook URLs redirect to D7 content Needs work and [##3248078]. So, as far as I can tell, there is nothing to do here. I am closing as outdated. If that is wrong add an explanatory comment and set the status to 'active'.