- 🇦🇺Australia acbramley
Removing the constraint would mean changing live menu links when creating pending revisions. Supporting this would require a huge overhaul to the menu system to account for pending revisions. This isn't a Node issue.
See #2858434: Menu changes from node form leak into live site when creating draft revision → where this was introduced.
- 🇩🇰Denmark uv516 Denmark
#260 ✨ Allow tokens in entity reference views selection arguments Needs review is working with D 10.4.6 too.
- 🇮🇹Italy mondrake 🇮🇹
To meaningfully manual test this, apply the MR patch locally, break some tests, and run tests via run-tests.sh, and llok at results.
- 🇺🇸United States smustgrave
Leaning on the screenshots of #134 and reading the summary seems like a good addition. Not entirely sure how to best test it out but since it's been close to 2 months I'm going to mark to see if we can maybe try out on 11.x. Wonder if it's one of those things that will help when actually used.
- 🇳🇿New Zealand quietone
This issue this was postponed on was fixed 9 years ago. Since, then there has been no discussion here for 9 years. Perhaps this has been resolved?
I am setting the status to Postponed (maintainer needs more info) to find out if this is still needed. If confirmation that this is needed is not given, this may be closed after three months.
- 🇳🇿New Zealand quietone
There has been no activity here for over 9 years.
Is this Plan still needed?
- 🇺🇸United States smustgrave
Came up as daily BSI target.
Based on the title this seems like a task vs a bug
Issue summary should be updated with the standard template
- 🇳🇿New Zealand quietone
What is the purpose of 🌱 Make views consistent in code, schema, tests, and APIs Needs review
- 🇮🇳India ahsannazir
The slogan is visible if slogan text is added. Also the gap has been added between the logo and the text.
Hence moving it to RTBC
- 🇨🇦Canada joseph.olstad
patch file for D10.4.6 , upgrading a D10.3.x site for a client
- 🇺🇸United States mradcliffe USA
I resolved the CS nits. I removed the use of t completely because other tests do not use it such as MapBaseFieldTest and FieldItemTest. Also I switched to using FieldType attribute.
- First commit to issue fork.
- 🇳🇿New Zealand quietone
@luke.stewart, until Migrate Drupal is deprecated, the code is maintained and bugs should be fixed.
There hasn't been further reports of this problem and none on currently supported versions of Drupal. There isn't any data loss and there is a workaround. Put all that together, I think this can be closed as outdated.
If anyone has this problem I suggest seeking support from the options listed on our Support page → . This is 'Get Support' at the top of Drupal.org. There is also information about Drupal Slack → , at 'Get Support -> Drupal Slack' also at the top of Drupal.org. You may get better replies in one of those places.
- 🇦🇺Australia mstrelan
Came across this triaging issues for Bug Smash Initiative and have a few thoughts:
- Since we're moving to Navigation module I checked if that is also affected and it is
- Since Claro and Starterkit Theme are unaffected should we really be fixing it for Stark?
- As per bnjmnm a stylesheet is certainly better than a style attribute. Not just for customisations, but for Content Security Policy also.
- I don't think toolbar.module is the right component for this since the issue is really with the dialog. Probably Javascript or Stark would be better. Even if it's a css fix, it's a javascript component we're styling.
- 🇦🇺Australia mstrelan
Is this still relevant since ✨ Use one-time login link instead of user login form in BrowserTestBase tests Fixed ? In most cases the test no longer requires the login form, unless the
$useOneTimeLoginLinks
property is false. Furthermore, the report in the issue summary suggests you're using Drupal Test Traits → , so you could always override thedrupalLogin
method in your own test base class. - 🇳🇱Netherlands arantxio Dordrecht
I've worked on the setting the revisions by default and it seems to work for us now.
- 🇳🇿New Zealand quietone
More information was asked for 8 years ago and it has not been supplied. Due to lack of interest I am closing this issue.
If you are interested in this idea, open a new issue in the core issue queue and add this issue as a related issue.
- 🇧🇪Belgium f2boot
For those using composer and cweagans/composer-patches, "sites/default/default.settings.php" may not exist at time of patching. In this case, we can patch the file before scaffolding at "core/assets/scaffold/files/default.settings.php".
Joining a new patch for this configuration.
- 🇳🇱Netherlands arantxio Dordrecht
It seems it doesn't save the default revision state from the settings, so it need some new logic, ill continue working on this.
- 🇳🇿New Zealand quietone
The ideas project is being deprecated, moving this to core.
I suspect that there are existing issues for adding filters to the pages listed.
- 🇳🇱Netherlands arantxio Dordrecht
I merged the branch and worked on making it able to set the default for revision for product types.
I tested this on our environment and it seems to be working as expected.
- First commit to issue fork.
- 🇬🇧United Kingdom catch
This was partly changed in 🐛 Umami page.tpl.php breaks block placeholders Needs review which was similar but I think more problems were identified here.
@berdir just opened 🐛 Umami page template renders header regions multiple times Active too.
- 🇩🇪Germany geek-merlin Freiburg, Germany
Bot has some cs nits:
FILE: ...pal11/core/tests/Drupal/KernelTests/Core/Field/FieldMappingStorageTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
19 | ERROR | Missing member variable doc comment
29 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
-------------------------------------------------------------------------------- - 🇧🇪Belgium Robin.Houtevelts
Rebased the MR that got previously reviewed in #111, #112
Also adding a patch file for cweagans/composer-patches usageAs #112 mentioned, there are a few outstanding questions left
- 🇧🇪Belgium Robin.Houtevelts
robin.houtevelts → made their first commit to this issue’s fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇦🇺Australia acbramley
Definitely looks like a duplicate of 🐛 Access cacheability is not correct when "view own unpublished content" is in use Needs work , please reopen if not.