#Needs issue summary update

Left some comments on the MR.

So I tested it out and pretty basic, creating a new content type and the promoted to front checkbox is unchecked

Hiding old patches
Tweaked the CR just slightly with an image for the visual people out there.

I imagine this may break some contrib tests (hopefully not a lot) but seems like a right step.

This has been tagged for steps and issue summary. So moving to PNMI for that info.

Rebased the MR.

Attached patch is a snapshot of the latest state of the MR for safe usage with composer patches.

Closing this as outdated.

Updated IS with references for every tag added to the list.

Added to allowed tags in the MR (from 🐛 element stripped by $adminTags Active ).
Patches for composer.

Added <template> to allowed list to the MR (from ✨ Xss::filterAdmin() to allow "template" elements Active ).
Patches for composer.

Glad to see tracting here again! :)

Here is a simplified patch for Drupal 10.4 for live projects.

Fixed missing attributes lost in the reroll.
Added <audio> tag as well. (thanks #86 for that suggestion)
Again, attached patch for composer.

If video is added, audio should probably be added as well...

Rerolled and cleaned MR.
Added <button> to the allowed list.
Patch attached for composer (11.x).

Wonder if this is still needed actually? Classy shouldn't be the starter point for any theme, instead the starterkit_theme should be used.

Re: #143/#144: Or don't start chromedriver locally and try to run any FunctionalJavascript test.

We've seen this bug on our site running Drupal 10.4.5.

First there was no "more link" displayed at all. That was fixed by applying the change from #7 in https://www.drupal.org/project/drupal/issues/3481310 🌱 "Some" Pager Plugin and [view:total-rows] Regression Issue Active and clearing Drupal's caches.

Then we found that for authenticated users the "more link" only showed the first time they viewed the page. When they revisited the page (or used F5 to refresh the page), the "more link" was not displayed. (The "more link" displayed correctly every time for anonymous users.)

After applying the patch from #79 🐛 More link disappears when time-based views cache is enabled Needs work , the "more link" displays correctly every time, for both anonymous and authenticated users.

Using Drupal v11.1.3 it is possible to add the span tags without changing any code.

1. Go to /admin/config/content/formats
2. Click the 'Configure' button of the Text format you want to change
3. Add <span class> to the 'Source editing' tab under the 'CKEditor 5 plugin settings' section
4. Click 'Save configuration' button
5. Click the 'Configure' button of the Text format you want to change again
6. Under the 'Toolbar configuration' section move the 'Style' button from 'Available buttons' to 'Active toolbar'
7. Click the 'Style' tab under the 'CKEditor 5 plugin settings' section
8. Add the following styles:

span.text-large|Large
span.text-primary|Primary Color
span.text-secondary|Secondary Color

9. Click 'Save configuration' button

The 3 styles are now available under the Style menu in the CKEditor toolbar.

This is still happening on Drupal 10.4. I had another look at this. Some details:

• The first patch above (#17) started with its own Layout-Builder-specific scrollTop command.
• Patch #20 removed most of that command, but not everything, and used the new default ScrollTopCommand instead.
• This doesn't seem to work, or at least not reliable. I got a JavaScript error "scrollTarget.get is not a function". Line 1882 in the scrollTop function does look to me like the jQuery call is missing.
• There is a ticket trying to radically simplify the scrollTop function: https://www.drupal.org/project/drupal/issues/3478087 ✨ Modernize Drupal.ajaxCommands.scrollTop() Active

I tried both versions, but none of them worked for the first error. If I hit "Submit" a second, theird etc. time, sometimes it works and scrolls up, sometimes it scrolls up a bit and sometimes it doesn't.

Does anybody know if this is specific to Layout Builder? Scrolling on the main part of the page is controlled by the Layout Builder to stay on the block currently being edited. Could this somehow interfere with our scrolling attempts here? If I have a good idea how to fix this, I'm more than happy to provide a correct patch in an MR.

Re-titling for the deprecation of the overall functionality.

I added an update path test.

I think the answer to that is yes. This provides the validation that other issues can build on.

For 104

Came up as a daily BSI target and still seems to be relevant.

Could this be used instead: https://www.drupal.org/project/views_argument_token → ?

I agree with moving search stuff to the search module, but it looks like this hook is directly invoked from the node_search search plugin, so maybe it does belong in node? Who knows how often this stuff is actually used though, maybe we can eventually move node search stuff to a node_search contrib module.

In any case, this needs a reroll on to an MR which is going to require quite a bit of rework for OOP hooks I imagine.

After applying the MR confirmed I'm getting the same results as the screenshots in the issue summary. Tested at various mobile widths and confirmed the breadcrumb__item always stayed at 24px.

Believe this one is good.

Tried to investigate the failing test. There's an issue with bubbling of that stuff. Within VariationCache::set(), that cache context is correctly optimized away and the cache tag added, but the information doesn't bubble up because RenderCache::set() doesn't do anything with the cacheability object. and I think it should. But it seems to work in the other test method, just not the node within the test entity.

Since there hasn't been a follow up in 2+ years going to close out as can't reproduce. If still an issue in D11 please re-open.

Few things to fix still.

The spacing between the logo and title went from 0.75em to 0.5em, it should probably be fixed so that the spacing doesn't change.

Can someone open a follow-up issue to deal with the placement of the a tag as mentioned in #97, #98?

Added a basic upgrade path, needs tests though.

Yes, but if we remove the checkboxes on new install, we do not need to worry about the checkbox being unchecked.

We aren't removing checkboxes, we're hiding them. It actually makes more sense to default to unchecked once we hide the fields, otherwise new sites will be creating "promoted" content without the checkbox even being visible. We have to do things in small steps (see the history of this issue) otherwise we'll never get anywhere :) Just look at how many tests in core assume things are promoted by default!

CR created https://www.drupal.org/node/3517642 →

We need an upgrade path here though unfortunately.

Currently if you:
1. Install Standard profile on 11.x
2. Check out this branch
3. Clear cache
4. Notice the Article node type no longer defaults to Promoted. Page correctly still defaults to Not Promoted because Standard ships with base_field_override config

Yes, but if we remove the checkboxes on new install, we do not need to worry about the checkbox being unchecked.

@xmacinfo no - this is different. This is making the checkbox on the NodeType form itself to be unchecked.

Based on #29338: Hide Promoted/Sticky fields by default in Form display → , we should be marking this ticket as “Outdated” or “Duplicate”.

Removing the constraint would mean changing live menu links when creating pending revisions. Supporting this would require a huge overhaul to the menu system to account for pending revisions. This isn't a Node issue.

See #2858434: Menu changes from node form leak into live site when creating draft revision → where this was introduced.

#260 ✨ Allow tokens in entity reference views selection arguments Needs review is working with D 10.4.6 too.

To meaningfully manual test this, apply the MR patch locally, break some tests, and run tests via run-tests.sh, and llok at results.

Leaning on the screenshots of #134 and reading the summary seems like a good addition. Not entirely sure how to best test it out but since it's been close to 2 months I'm going to mark to see if we can maybe try out on 11.x. Wonder if it's one of those things that will help when actually used.

This issue this was postponed on was fixed 9 years ago. Since, then there has been no discussion here for 9 years. Perhaps this has been resolved?

I am setting the status to Postponed (maintainer needs more info) to find out if this is still needed. If confirmation that this is needed is not given, this may be closed after three months.

There has been no activity here for over 9 years.

Is this Plan still needed?

Came up as daily BSI target.

Based on the title this seems like a task vs a bug

Issue summary should be updated with the standard template

Done! :)

Committed 4760161 and pushed to 11.x. Thanks!

nod_ → closed merge request !6303

What is the purpose of 🌱 Make views consistent in code, schema, tests, and APIs Needs review

The slogan is visible if slogan text is added. Also the gap has been added between the logo and the text.

Hence moving it to RTBC

patch file for D10.4.6 , upgrading a D10.3.x site for a client