- 🇮🇹Italy kimlop
I tested the last two patches (#71 #64) with core 10.3.5 and both don't work.
- 🇫🇷France duaelfr Montpellier, France
Patch #64 applies on Drupal 10.3.x and fixes the issue.
I updated the IS and I believe that comments from #60 and #61 don't apply anymore with the approach followed in the patch.For novices: please convert #64 patch to a MR to ease maintainers job.
- Merge request !10046Issue #1464244: Rewrite as URL adding equals sign to end of url. → (Open) created by sayan_k_dutta
- 🇺🇾Uruguay rsbarbano
Patch #64 is working for me in a Drupal version 11.0.4.
Thank you!. - Status changed to Needs review
about 1 month ago 6:48am 9 December 2024 - 🇧🇷Brazil igorgoncalves
Hi Sayan, thanks for the effort.
Despite the fact that tests have "Pass" status, there's one warning left, and checking the detail says:Drupal\Tests\Core\Utility\UnroutedUrlAssemblerTest::testAssembleWithExternalUrl with data set #7 Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'https://example.com/test?foo' +'https://example.com/test?foo='
which sounds like pretty much what we are testing here, isnt?
- 🇮🇳India sayan_k_dutta
@igorgoncalves yes, indeed the two strings of urls are different, that is what we need here. Do I need to make changes to test files, to remove the warnings. I don't have much knowledge of phpunit tests, but can look into it.