Rewrite as URL adding equals sign to end of url.

Patch #64 updated to apply on Drupal 10.2.4.

I tested the last two patches (#71 #64) with core 10.3.5 and both don't work.

Patch #64 applies on Drupal 10.3.x and fixes the issue.
I updated the IS and I believe that comments from #60 and #61 don't apply anymore with the approach followed in the patch.

For novices: please convert #64 patch to a MR to ease maintainers job.

Fixes should be in MRs

Have not reviewed yet.

Working on it.

Created MR for patch #64. Please review it.

Patch #64 is working for me in a Drupal version 11.0.4.
Thank you!.

Have re-ran tests twice and they still fail.

Tests are now passing, moving to Needs Review.

Hi Sayan, thanks for the effort.
Despite the fact that tests have "Pass" status, there's one warning left, and checking the detail says:

Drupal\Tests\Core\Utility\UnroutedUrlAssemblerTest::testAssembleWithExternalUrl with data set #7
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'https://example.com/test?foo'
+'https://example.com/test?foo='

which sounds like pretty much what we are testing here, isnt?

@igorgoncalves yes, indeed the two strings of urls are different, that is what we need here. Do I need to make changes to test files, to remove the warnings. I don't have much knowledge of phpunit tests, but can look into it.

All tests are now passing, warnings are resolved. Please review.

Checked in my local setup before and after changes. Attaching screenshots. LGTM+

The fix has issues - added a comment to MR.

Updated the MR with @alexpott's recommended changes and also replaced strpos() with preg_match() using a regex that should prevent the false positives due to substring overlap that @alexpott noted by ensuring that the matches are either at the beginning of the query string or after a &.

Rebased as this MR was 800 commits back

Feedback appears to be addressed on this one.

NR for a small commment improvement suggestion I made on the MR. It's okay to re-RTBC the issue if the suggestion is accepted (no need for an extra review cycle over something small).

Feedback from xym appears to be addressed, saving credit for xjm review in the MR.

Line 227 of UrlHelper.php, removed comment that could confuse the meaning of the comment addition in this MR. Cannot see any purpose in it at all except to confuse people.

Restored comment removed from else block in UrlHelper::parse(). Not sure why that was removed (was removed in one of the earlier patches that preceded the MR).

Reverted my most recent commit to restore removed comment (see #95). Failed to realize that @oily was describing a change that had already been made and not requesting a change. Apologies for the confusion.

Thanks for the update!

Despite my earlier comment: This is pretty low-level, and the approach has changed several times over the issue's 13-year (!) history. So, I'd like subystem and/or framework signoff for the fix. Leaving RTBC for that.