#Needs backport to D7

I fixed most of the issues reported by the Queue Bot, but there's still a PHPSTAN issue to fix: https://git.drupalcode.org/issue/drupal-1818764/-/jobs/5007233

 ------ --------------------------------------------------------------------- 
  Line   core/modules/update/update.module                                    
 ------ --------------------------------------------------------------------- 
  207    Function _update_manager_access not found.                           
         🪪  function.notFound                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  

Where is this function _update_manager_access implemented? was it ever implemented in this MR? I think it's a legacy function from D7 that needs to be refactored here:

/**
 * Access callback: Resolves if the current user can access updater menu items.
 *
 * It both enforces the 'administer software updates' permission and the global
 * kill switch for the authorize.php script.
 *
 * @return
 *   TRUE if the current user can access the updater menu items; FALSE
 *   otherwise.
 *
 * @see update_menu()
 */
function update_manager_access() {
  return variable_get('allow_authorize_operations', TRUE) && user_access('administer software updates');
}

Automatically closed - issue fixed for 2 weeks with no activity.

rbrissaud → changed the visibility of the branch 2842780-11.x to hidden.

rbrissaud → changed the visibility of the branch 2842780-11.x to hidden.

rbrissaud → changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.

rbrissaud → changed the visibility of the branch 2842780-11.x to hidden.

rbrissaud → changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.

rbrissaud → changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.

rbrissaud → changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.

No worries @penyaskito 😁 you're not the only one who has been misleaded by unresolved threads. I don't really know what it depends on. Sometimes I see the "Resolve thread" button at GitLab, but sometimes not.

OK, I'll stop messing around. It's already fixed, just we can't resolve threads.

NW per https://git.drupalcode.org/project/drupal/-/merge_requests/11220#note_49.... We should accept that suggestion, then IMHO we should be good to go.

Since the changes look good to me and the tests pass, I believe it's safe to switch back to RTBC.

Thanks @godotislate!

Added CR: https://www.drupal.org/node/3519307 →

I added a couple minor comments on the MR after looking again while writing the CR.

We need a change record to detail the addition of StateInterface::getValuesSetDuringRequest() - https://www.drupal.org/node/add/changenotice?field_project=3060&field_is... →

Back to NR for the feedback from @acbramley

Settings read well to me.

16 years and this one may be good

Rebased on 11.x and added docs to default.settings.php