#Needs backport to D7

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

OK, but with this new version I can't see any goup option in the formatter settings or the phtoswipe settings page (/admin/config/media/photoswipe)?

@steveoriol Did you remove the field wrapper? The module adds the photoswipe-gallery class to the field wrappers attributes. The behaviour of wrapping each image in a photoswipe-gallery wrapper is the fallback if no outer photoswipe-gallery wrapper is present.

I resolved the issue that the review bot raised however there is the nightwatch test failing. Unsure if its just glitching and a rerun is fine, or if its because we're behind on commits?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

After updating the photoswipe module from version (4.0.1 => 5.0.5) ( maj DB, new composer require, clean cache).
Clicking on the photos works again, but the gallery (arrows in photoswipe mode to go to the next photo in the group) no longer work on several websites.
It's strange, but I have the impression that the ‘.photoswipe-gallery’ is added to each photo displayed with the photoswipe formatter? so maybe the system sees each photo as a group of 1 photo (so no arrows).

There has been no activity here for 12 years except to ask if this is still valid. There has been no answer so I am closing this.

If there is work to do here, then either re-open the issue and add a comment or open a new issue and reference this one.

This was committed to Drupal 8. I am restoring the meta data to that time.

I don't think that subclassing the version history controller is a good solution for this issue.

The Diff module is a great example. From the perspective of another contrib module which also needs to alter the revision overview, and in order to support both core's controller and Diff's override, it has to subclass both of them. A third one with similar requirements would bring chaos :)

Adding a hook as in the current MR is one way to do it, but I think converting that controller to a form would be more helpful in the long run, especially since Diff (which is a very popular module) already does that.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Everything looks in order here. I also updated credit.

I also tested the MR and it works as expected, it just needs a cache clear.

I can still use a grouping feature, so it's still relevant. Do you think a native solution, built into the module will be possible, or is your opinion the same as in August 2022?

[...] I think this can't work, setting this won't fix for that reason. Proof me wrong otherwise and I'll reopen this.

... or perhaps this has become more feasible in version 5?

There has been response in the past nearly two years to confirm that this is still needed. Plus hook_field_attach_validate was removed in #1969728: Implement Field API "field types" as TypedData Plugins → .

If there is work to do here, then either re-open the issue and add a comment or open a new issue and reference this one.

3.x is unsupported, what's the situation in 5.x? Can we close this outdated?

It's been another few months without any steps to reproduce so closing this one out.

If you are able to provide steps to reproduce, feel free to re-open this.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!