- ๐จ๐ฆCanada danrod Ottawa
I fixed most of the issues reported by the Queue Bot, but there's still a PHPSTAN issue to fix: https://git.drupalcode.org/issue/drupal-1818764/-/jobs/5007233
------ --------------------------------------------------------------------- Line core/modules/update/update.module ------ --------------------------------------------------------------------- 207 Function _update_manager_access not found. ๐ชช function.notFound ๐ก Learn more at https://phpstan.org/user-guide/discovering-symbols
Where is this function
_update_manager_access
implemented? was it ever implemented in this MR? I think it's a legacy function from D7 that needs to be refactored here:/** * Access callback: Resolves if the current user can access updater menu items. * * It both enforces the 'administer software updates' permission and the global * kill switch for the authorize.php script. * * @return * TRUE if the current user can access the updater menu items; FALSE * otherwise. * * @see update_menu() */ function update_manager_access() { return variable_get('allow_authorize_operations', TRUE) && user_access('administer software updates'); }
- First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch 2842780-11.x to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch 2842780-11.x to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch 2842780-11.x to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
No worries @penyaskito ๐ you're not the only one who has been misleaded by unresolved threads. I don't really know what it depends on. Sometimes I see the "Resolve thread" button at GitLab, but sometimes not.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
OK, I'll stop messing around. It's already fixed, just we can't resolve threads.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
NW per https://git.drupalcode.org/project/drupal/-/merge_requests/11220#note_49.... We should accept that suggestion, then IMHO we should be good to go.
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
Since the changes look good to me and the tests pass, I believe it's safe to switch back to RTBC.
Thanks @godotislate!
Added CR: https://www.drupal.org/node/3519307 โ
I added a couple minor comments on the MR after looking again while writing the CR.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
We need a change record to detail the addition of
StateInterface::getValuesSetDuringRequest()
- https://www.drupal.org/node/add/changenotice?field_project=3060&field_is... โ - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Back to NR for the feedback from @acbramley
- ๐บ๐ธUnited States smustgrave
Settings read well to me.
16 years and this one may be good
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Rebased on 11.x and added docs to
default.settings.php