- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - 🇩🇪Germany Anybody Porta Westfalica
This needs a reroll against 11.x-dev now. #168 doesn't apply against 10.1.x for me?!
- last update
about 1 year ago Patch Failed to Apply - last update
about 1 year ago Patch Failed to Apply - First commit to issue fork.
- last update
about 1 year ago 29,531 pass, 1 fail - @rpayanm opened merge request.
- last update
12 months ago 29,573 pass - Status changed to Needs review
12 months ago 7:30am 1 July 2023 - Status changed to RTBC
12 months ago 10:20pm 2 July 2023 - 🇺🇸United States smustgrave
Going to mark it but left 1 comment in the MR for the committer.
- last update
12 months ago 29,573 pass - 🇳🇱Netherlands Neograph734 Netherlands
FYI, casting to string is a requirement for assertSame. See the link in failing test of #184.
- last update
12 months ago 29,803 pass - last update
12 months ago 29,804 pass - last update
12 months ago 29,804 pass 9:29 7:39 Running- last update
12 months ago 29,813 pass - last update
12 months ago 29,817 pass - last update
12 months ago 29,817 pass - last update
12 months ago 29,448 pass - last update
12 months ago 29,817 pass - Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
11 months ago Waiting for branch to pass - last update
11 months ago 29,448 pass - last update
11 months ago 29,452 pass - last update
11 months ago 29,455 pass - last update
11 months ago 29,456 pass - last update
11 months ago 29,457 pass - last update
11 months ago 29,458 pass - last update
11 months ago 29,459 pass - last update
11 months ago 29,460 pass - last update
11 months ago 29,460 pass - last update
11 months ago 29,461 pass - last update
11 months ago 29,467 pass - last update
11 months ago 29,467 pass - last update
11 months ago 29,467 pass - Status changed to Needs work
11 months ago 6:54am 15 August 2023 - 🇳🇿New Zealand quietone New Zealand
I am doing triage on the core RTBC queue → .
I read the issue summary. There is a proposed resolution so reviewers know what to look for. However, the remaining tasks show another issue, is this issue supposed to be postponed on that or is a follow up needed?
This is adding tokens so there should be a Change record. This should include examples. I am adding the tag and setting to NW.
I then read the comments, mostly trying to find unanswered questions. Its that @Neograph734 did a very nice job keeping up with the feedback. It is hard to follow but I think everything has been responded to expect for two items.
1) There was concern about emails, #17. I am not sure if that was resolved. Or does this need documentation, including the CR, on how using these new tokens with mail will work.
2) Should be using a site-wide token, #173 - #180. In #176 @Berdir stated the proposed structure wouldn't work and there has been no other response from them on the subject. Has this truly been resolved? If that has been resolved it is worth adding a summary of that discussion in the Issue Summary so that it is clear for a committer.I then read the MR, I did not do a code review. I spotted some things that need changing which I have commented on in the MR.
I am removing the 'Needs maintainer tag' because I think that intention is covered by 'Needs subsystem maintainer review' and it is not a defined special tag → .
This is long issue in comments as well as time (7 years), thanks everyone for getting the bulk of the work done. Just a few more things to do. - 🇮🇳India atul4drupal
I tried to read through the thread to understand it, and as far I understood for #191 ✨ Add a token for the site logo Needs work point 2:
@Berdir I believe is responding to the proposed suggestion for having seperate token type to which he disaggred, and that is something still not addressed as we see a new token type "site-logo" being introduced in the code.Also @Berdir expressed for someone to verify if suggestions from #161 are implemented which I verifed have been incorporated and this was also verified in #180.
#191 point 1 (refering #17) this I think will relate to what approach we take with respect to the concern raised around introducing new token type, as in the current solution if we take off the new token type, #17 remain open.
It is a situation in hand, will spend some time on it however some direction around how to address #17 will be helpful, keeping in mind that people in general are not inclined towards introducing a new token type.
- 🇮🇳India atul4drupal
Adding patch to update changes as suggested in #191.
Still have a few open TODO items on the issue:
1) Decide on an approach to address concern raised in #17 (possibly without adding new token type). If new token type needed then this need to be discussed and agreed upon before moving forward with this approach.
2) IS to be updated
(leaving this for someone who has more hold on this issue thread, will revisit to update IS if not updated in some time). - 🇮🇳India gouthamraon
#168 patch is not applying with the Drupal 10.1.5 version.
Issue with kernal test changes. Updated the changes and adding the new patch. - last update
9 months ago Custom Commands Failed - last update
8 months ago 30,407 pass, 1 fail - last update
8 months ago Patch Failed to Apply - last update
8 months ago Custom Commands Failed - last update
8 months ago 30,419 pass