- ๐บ๐ฆUkraine voleger Ukraine, Rivne
rebased `9.2.0` against latest `11.x` branch and pushed to `2903336-allow_tokens_for_url` fork branch. I suggest closing MR !1076 and hiding the `9.2.0` fork branch to avoid confusion.
Attaching the patch from the new MR - @voleger opened merge request.
- First commit to issue fork.
- ๐บ๐ธUnited States smustgrave
Not sure why I tagged for sub-maintainer but that was when we just got NRQI off the ground.
Ran the test-only feature here https://git.drupalcode.org/issue/drupal-3126761/-/jobs/6378866
1) Drupal\Tests\Core\PathProcessor\PathProcessorFrontTest::testProcessInbound with data set "frontpage with query parameters and request query parameters" ('/node?example=muh', '/', '/node', ['muh', 'buh'], ['buh']) Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( 'example' => 'muh' - 'example2' => 'buh' ) /builds/issue/drupal-3126761/core/tests/Drupal/Tests/Core/PathProcessor/PathProcessorFrontTest.php:41 2) Drupal\Tests\Core\PathProcessor\PathProcessorFrontTest::testProcessInbound with data set "frontpage with query parameters and replacement request query parameters" ('/node?example=muh', '/', '/node', ['cuh', 'buh'], ['cuh', 'buh']) Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ Array ( - 'example' => 'cuh' - 'example2' => 'buh' + 'example' => 'muh' )
The actual fix core/lib/Drupal/Core/PathProcessor/PathProcessorFront.php makes complete sense.
LGTM!