- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch 2842780-11.x to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch 2842780-11.x to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch 2842780-11.x to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ซ๐ทFrance rbrissaud
rbrissaud โ changed the visibility of the branch drupal-2842780-10.4.x-add-token-site-logo to hidden.
- ๐ฌ๐งUnited Kingdom catch
๐ Consider falling back to webp based on filesize Active has a possible approach to the trade-offs between AVIF and webp for filesize.
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
No worries @penyaskito ๐ you're not the only one who has been misleaded by unresolved threads. I don't really know what it depends on. Sometimes I see the "Resolve thread" button at GitLab, but sometimes not.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
OK, I'll stop messing around. It's already fixed, just we can't resolve threads.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
NW per https://git.drupalcode.org/project/drupal/-/merge_requests/11220#note_49.... We should accept that suggestion, then IMHO we should be good to go.
- ๐ช๐ธSpain vidorado Logroรฑo (La Rioja)
Since the changes look good to me and the tests pass, I believe it's safe to switch back to RTBC.
Thanks @godotislate!
Added CR: https://www.drupal.org/node/3519307 โ
I added a couple minor comments on the MR after looking again while writing the CR.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
We need a change record to detail the addition of
StateInterface::getValuesSetDuringRequest()
- https://www.drupal.org/node/add/changenotice?field_project=3060&field_is... โ - ๐บ๐ธUnited States smustgrave
Just following up if additional steps can be provided, else we could probably close this one out.
- ๐ฆ๐บAustralia acbramley
As per https://www.drupal.org/project/drupal/issues/2709387#comment-16039612 ๐ Node creation date is populated on creation form Needs work
hook_entity_presave
could be used to implement this in your custom module if needed.