- π©πͺGermany Grevil
Patch #52 doesn't apply on 9.5.10. 9.5.7 works just fine.
- last update
over 1 year ago 30,293 pass, 57 fail - Status changed to Needs review
over 1 year ago 10:10pm 17 August 2023 - last update
over 1 year ago 29,985 pass, 57 fail - πΊπΈUnited States benjifisher Boston area
It is too late for this issue to be fixed for D9, so I am re-rolling the patch from #53 for 11.x. The conflicts come from π Missing mapping for "nodereference_url" widget Fixed .
I have not done anything to fix the tests, but I am setting the status to NR in order to trigger a new test.
- πΊπΈUnited States benjifisher Boston area
In #54, @Anybody pointed out that there are outstanding points from the review in #35. I am adding that to the issue summary (remaining tasks).
The last submitted patch, 58: 3204212-field-migration-widget-formatter-mapping-58-D11--fix-only.patch, failed testing. View results β
- Status changed to Needs work
11 months ago 9:28am 17 January 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This is still blocking β¨ [PP-1] Provide option for contrib modules to map their D6 / D7 field formatter and widget plugin IDs to the equivalent D9 plugin ID Postponed and #3108302: [PP-2] Field formatter & widget settings: fall back to default if missing plugin β .
Without the infrastructure added here + those 2 issues, it is IMPOSSIBLE for contrib modules providing field formatters and widgets to provide a D7 β D9/10/11 migration π¬
I guess most people just manually migrate those settings and hence this has never been a priority for migration system contributors?
I know that #35 requested this to be split up more. But it's already been split up in 3 parts.
https://www.drupal.org/project/acquia_migrate β has been running with these patches for years now. And we've contributed many patches to contrib modules that build on top of these. Clearly many others are interested in it too π I'm hoping somebody else can push the remaining pieces forward π€
#54: I don't either π Only core committers can do that!
@quietone can you please change the target branch to
11.x
? π#35:
- I think you're right! π
- This is not new infrastructure. This API was added in
#2906203: Widgets/formatters: D7 Plain text fields incorrectly migrated to D8 as Text (formatted) β
to
FieldPluginBase
, in 2017. This is just fixing the existing migration in core. - π
- Probably because it's necessary for β¨ [PP-1] Provide option for contrib modules to map their D6 / D7 field formatter and widget plugin IDs to the equivalent D9 plugin ID Postponed or #3108302: [PP-2] Field formatter & widget settings: fall back to default if missing plugin β or both. If we can get by here without these changes, then let's drop them! Confusingly, the comment is being reworded but is effectively still saying the same thing. Which seems to indicate you're right! π
- π©πͺGermany Grevil
Patch from #58 doesn't apply anymore to current 11.x. Here is the new reroll.
- last update
10 months ago 29,675 pass, 55 fail - π©πͺGermany Grevil
Not working much with patches... I can't seem to retest the latest patch with 11.x? Latest option is 10.1.x.