Ok, found one more D11 incompatibility issue. Also, some weird "negate" behavior, but this should be fixed in a follow-up issue.
Please review!
Funny thing is, dev is already d11 compatible: https://git.drupalcode.org/project/jsonapi_role_access/-/commit/512c00af....
But there never was a release.
That should be it, I couldn't find any incompatibilities.
Additionally to the rector patch, I removed the D9 compatibility.
Please review!
Thank you, @smustgrave! :)
Could you tag a new release? Would appreciate it!
Parent issue is fixed now! I'll create the needed changes. Afterward, we should wait for the release.
grevil → changed the visibility of the branch 3548238-broken-when-using-aggregation to hidden.
Maybe we should follow what the schema has where body is attached to the text plugin
The MR should have reflected that already, but it didn't. Now it should be correct.
Interesting, same pipeline failure as in 📌 MenuLinkContentAccessControlHandler does not allow "view" access without admin permission, making these entities inaccessible via REST, JSON API and GraphQL and entity reference fields Needs work : None of the tests fail, but the pipeline still says "failed".
Setting back to "Needs review", as all tests succeed.
I updated the issue summary. None of the tests fail, but the pipeline still says "failed" no idea why. Setting back to "Needs review".
Hm there is no "clearCache" on the token service. only "resetInfo" and I am not 100% sure it does the same thing.
Furthermore, there is no replacement defined in this CR: https://www.drupal.org/node/1973488 →
Since we are already using "token_clear_cache()" inside the normal "TokenCustomForm", I'd say we merge this as is. If it causes any trouble in the future, we can look further into it.
grevil → changed the visibility of the branch 3531812-deleting-custom-tokens to active.
grevil → changed the visibility of the branch 3531812-deleting-custom-tokens to hidden.
Although the changes do not match the Issue-Summary:
I have some user roles that I would like to be able to view the overview page, but not add, edit, or delete.
But the code:
entity.token_custom.collection:
path: '/admin/structure/token-custom'
defaults:
_title: 'Custom tokens'
_entity_list: 'token_custom'
requirements:
_permission: 'administer custom tokens+access custom tokens overview'
says that the user needs both permissions (add + edit + delete + overview access) to see the collection.
Either update the issue summary or the code.
Tests don't need any changes, they were broken before and just got fixed.
LGTM!
@anybody, yea I think that's better. Especially since "token_clear_cache()" is defined in the token contrib module.
But "token_clear_cache()" is also used in other places inside token custom... makes me wonder, whether this module is even compatible with tokens core. Probably not.
Thanks for the patch! Code LGTM and works as expected.
Test failures are unrelated.
Ok, I found the reason why the tests fail.
Inside most Functional, JS Functional and Nightwatch tests, the front page is configured as "user/login". Now if we use Methods like "Url::fromRoute('user.login')" we won't get "user/login" returned anymore, but instead we'll get "/".
IMO, this is fine and expected, but of course all the tests need adjustments to actually succeed now.
We have several ways to fix this issue:
- Define another front page on setup for all failing test classes. (Preferred)
- Globally, define a different front page.
- Adjust the tests to use other urls than "user/login" to test their functionality.
Postponed on 🐛 Add a tour view build alter hook, to alter the view output from the TourViewBuilder Active for now.
If you're not totally against it, @smustgrave, I'd create an issue to give the regular separation a try and we can simply check the results in a MR?
This is also reflected in the already existing schema:
tour.tip:
type: mapping
label: 'Tour tip'
mapping:
id:
type: machine_name
label: 'ID'
constraints:
# Tour IDs also allow dashes.
Regex:
pattern: '/^[a-z0-9_-]+$/'
message: "The %value machine name is not valid."
plugin:
type: string
label: 'Plugin'
constraints:
PluginExists:
manager: plugin.manager.tour.tip
interface: '\Drupal\tour\TipPluginInterface'
label:
type: required_label
label: 'Label'
weight:
type: weight
label: 'Weight'
position:
type: string
label: 'Position'
constraints:
Choice:
- auto
- auto-start
- auto-end
- top
- top-start
- top-end
- bottom
- bottom-start
- bottom-end
- right
- right-start
- right-end
- left
- left-start
- left-end
selector:
type: string
label: 'Selector'
nullable: true
constraints:
NotBlank:
allowNull: true
tour.tip.text:
type: tour.tip
label: 'Textual tour tip'
mapping:
body:
type: text
label: 'Body'
We have a limited amount of time to invest in this module. If the community is willing to create an MR to fix this issue, which is then approved by the community, we could take a look.
We have a limited amount of time to invest in this module. If the community is willing to create an MR to fix this issue, which is then approved by the community, we could take a look.
@yospyn, thank you for the report!
Pretty basic fix, someone made an empty check instead of checking for null. For 0 empty would be true, resulting in the fallback of 2.
The current release broke compatibility with Drupal 10! A quick fix is provided here 🐛 Optimize the getMentionsFromEntity() method Active . I'll create a new release with the fix ASAP, apologies for the regression!.
Yea I guess so, people already created critical issues for this...
Can not reproduce this issue. Have you tried flushing all caches after update using `drush cr`?
What Drupal Version are you using?
@anybody! Nono, this is a success! The tests now actually show failures! Before it simply timed out after 1 hour.
Definitely makes sense!
Tests are currently failing. Also, this requires further tests, thanks!
POSTPONED on 🐛 Formatter third party settings missing from Views UI Needs work .
Thanks, @ressa!
I added the info to the module page. I'll commit the README change, but we should POSTPONE this issue, until it is fixed in core!