- ๐ณ๐ฟNew Zealand quietone
In regard to #42, 'Node Reference URL Widget', is added to the list of modules that will be upgraded and it is tested.
+++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/MultilingualReviewPageTest.php @@ -101,6 +101,7 @@ protected function getAvailablePaths() { + 'Node Reference URL Widget', +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/NoMultilingualReviewPageTest.php @@ -93,6 +93,7 @@ protected function getAvailablePaths() { + 'Node Reference URL Widget', +++ b/core/modules/migrate_drupal_ui/tests/src/Functional/d6/Upgrade6Test.php @@ -150,6 +150,7 @@ protected function getAvailablePaths() { + 'Node Reference URL Widget',
To keep this moving I created a fresh D6 site, downloaded CCK and NodeReferenceUrl, and created content with a field that uses the url node reference widget. And here is a screenshot of upgrading that site from /upgrade
- Status changed to RTBC
almost 2 years ago 4:54pm 14 March 2023 - ๐บ๐ธUnited States smustgrave
Thanks @quietone, know we briefly spoke in slack about this one in the #migrate channel.
Change looks good and test coverage is there so think it's good.
The last submitted patch, 44: 3000717-44.patch, failed testing. View results โ
- Status changed to Needs work
almost 2 years ago 8:08am 22 March 2023 - ๐ณ๐ฟNew Zealand quietone
Test failure on
1) Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest::testButton Failed asserting that a NULL is not empty.
Retesting.
- Status changed to RTBC
almost 2 years ago 12:09pm 22 March 2023 - ๐บ๐ธUnited States smustgrave
Restarted the tests but thatโs one of the random ones we see now
The last submitted patch, 44: 3000717-44.patch, failed testing. View results โ
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Crediting @benjifisher
- Status changed to Downport
almost 2 years ago 10:49pm 3 April 2023 - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Committed to 10.1.x, needs re-roll for 10.0.x and 9.5.x so marking it as patch (to be ported).
-
larowlan โ
committed 491e05f8 on 10.1.x
Issue #3000717 by Grevil, Anybody, quietone, edysmp, benjifisher:...
-
larowlan โ
committed 491e05f8 on 10.1.x
- Status changed to Fixed
over 1 year ago 9:40am 26 May 2023 - ๐ฌ๐งUnited Kingdom catch
Committed/pushed/cherry-picked the backport to 10.0.x and 9.5.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.