🇳🇿New Zealand @quietone

I just read my comment, #3, and this was supposed to be moved to the CMS project. I am doing that now.

I don't see a review of the change record on this issue. Can someone confirm it is accurate?

I made that change.

Rebase with no conflict, back to RTBC

Rebase and add a sniff

@znerol, thanks for fixing the test.

Committed to 11.x and cherry-pick to 11.3.x

Thanks!

I found a duplicate of this, it is later but it has a PR and explains the problem nicely. #3281300: @param tags must use fully-qualified class names, even when the full namespace is given without the leading backslash. →

I am closing this as a duplicate.

Drupal core has enabled the sniff Drupal.Commenting.DataTypeNamespace but it does not report an error on

@param Drupal\Core\Theme\ActiveTheme $active_theme, from Line 436 of LibraryDiscorveryParser.php, even though ActiveTheme is in a use statement on use statement.

Regardless of the sniff, the error is not being reported.

@cburschka, I don't see that distinction in the issue summary. what am I missing.

Thanks, back to RTBC

Started an MR with a minor change just to show where this needs to be changed. Not sure if there are other places.

Or, the text could be like what is in the PHPStan docs

Class and Interface names should be a relative name like Baz when resolved on the current namespace or via a use statements. Otherwise use a fully-qualified name (FQN) like \Foo\Bar\Baz.

There is a later issue for this that is usually made the duplicate. However, that one reference the Coding Standards where this is a requirement. So, I am closing this one a the duplicate.

Sniffs are created in the Coder project, so moving this to that project.

I left 2 comment that need attention. I did not review the changes, I just looked at the deprecation messages. So, simple change.

Changing title because deprecation is the first step. I removed the 'remove' because removing the entire file is the next step. I thought this would be part of the meta about removing include files but when I finally found that one it is about core/includes only.

Usages of the toolbar hook

$ git grep -E "#\[Hook\('toolbar')]" | grep .php | grep -v core/modules/toolbar | grep -v core/modules/ckeditor5 | grep -v -i drupal7.php | grep -v Test
core/modules/announcements_feed/src/Hook/AnnouncementsFeedToolbarHooks.php:  #[Hook('toolbar')]
core/modules/contextual/src/Hook/ContextualHooks.php:  #[Hook('toolbar')]
core/modules/shortcut/src/Hook/ShortcutHooks.php:  #[Hook('toolbar')]
core/modules/user/src/Hook/UserHooks.php:  #[Hook('toolbar')]
core/modules/workspaces_ui/src/Hook/WorkspacesUiHooks.php:  #[Hook('toolbar')]
core/profiles/demo_umami/src/Hook/DemoUmamiHooks.php:  #[Hook('toolbar')]

And what could be the remaining

$ git grep -E "['\"]toolbar['\"]" | grep .php | grep -v core/modules/toolbar | grep -v core/modules/ckeditor5 | grep -v -i drupal7.php | grep -v Test
 | grep -v "#\[Hook"
core/modules/contextual/src/Hook/ContextualHooks.php:          ':toolbar' => \Drupal::moduleHandler()->moduleExists('toolbar') ? Url::fromRoute('help.page', [
core/modules/contextual/src/Hook/ContextualHooks.php:            'name' => 'toolbar',
core/modules/navigation/src/Hook/NavigationRequirements.php:    if ($this->moduleHandler->moduleExists('toolbar')) {
core/modules/navigation/src/Hook/NavigationRequirements.php:      $requirements['toolbar'] = [
core/modules/navigation/src/NavigationRenderer.php:    if (isset($page_top['toolbar'])) {
core/modules/navigation/src/NavigationRenderer.php:      unset($page_top['toolbar']);
core/modules/shortcut/src/Hook/ShortcutHooks.php:          ':toolbar-help' => \Drupal::moduleHandler()->moduleExists('toolbar') ? Url::fromRoute('help.page', [
core/modules/shortcut/src/Hook/ShortcutHooks.php:            'name' => 'toolbar',
core/modules/system/src/Hook/SystemHooks.php:    if ($extension === 'toolbar' && _system_is_claro_admin_and_not_active()) {

And test usages which need to be changed.

$ git grep -E "['\"]toolbar['\"]" | grep .php | grep -v core/modules/toolbar | grep -v core/modules/ckeditor5 | grep Test | awk -F: '{print $1}' | sort -u
core/modules/announcements_feed/tests/src/Functional/AnnouncementsCacheTest.php
core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php
core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
core/modules/announcements_feed/tests/src/Kernel/AnnounceFetcherUserTest.php
core/modules/config_translation/tests/src/Functional/ConfigTranslationListUiTest.php
core/modules/contact/tests/src/Functional/ConfigTranslationListUiTest.php
core/modules/contextual/tests/src/FunctionalJavascript/ContextualLinksTest.php
core/modules/contextual/tests/src/FunctionalJavascript/EditModeTest.php
core/modules/editor/tests/src/Functional/Rest/EditorResourceTestBase.php
core/modules/editor/tests/src/Kernel/EditorValidationTest.php
core/modules/jsonapi/tests/src/Functional/EditorTest.php
core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderToolbarTest.php
core/modules/navigation/tests/src/FunctionalJavascript/PerformanceTest.php
core/modules/responsive_image/tests/src/Unit/ResponsiveImageStyleConfigEntityUnitTest.php
core/modules/shortcut/tests/src/Functional/ShortcutCacheTagsTest.php
core/modules/shortcut/tests/src/Functional/ShortcutTestBase.php
core/modules/shortcut/tests/src/Functional/ShortcutTranslationUITest.php
core/modules/shortcut/tests/src/Kernel/ShortcutCacheTagsTest.php
core/modules/system/tests/src/Functional/Menu/MenuAccessTest.php
core/modules/system/tests/src/Functional/Theme/ToolbarClaroOverridesTest.php
core/modules/system/tests/src/Functional/UpdateSystem/UpdatePathTestBaseFilledTest.php
core/modules/views_ui/tests/src/Functional/DisplayPathTest.php
core/modules/workspaces/tests/src/Functional/WorkspaceSwitcherTest.php
core/modules/workspaces/tests/src/Functional/WorkspaceTest.php
core/modules/workspaces_ui/tests/src/FunctionalJavascript/WorkspaceToolbarIntegrationTest.php
core/profiles/demo_umami/tests/src/FunctionalJavascript/OpenTelemetryAuthenticatedPerformanceTest.php

quietone → created an issue.

s/@group legacy/#[IgnoreDeprecations]/

Updating this so it follows the policy for extension deprecation → .

There is work to do in the parent issue first.

Use extension instead of module in some places

quietone → created an issue.

quietone → created an issue.

Like process plugin, let's deprecate the two here and open an new issue for more discussion.

For EntityContentComplete I'd like to hear from mikelutz as he was the one who designed that, but that would be for the possible followup.

@shalini_jha, thanks for the update.

To review, I applied the diff and searched for Drupal.Commenting.FunctionComment.Missing on 11.x HEAD.

$ git grep phpcs:ignore | grep Drupal.Commenting.FunctionComment.Missing
core/lib/Drupal/Core/Extension/DatabaseDriver.php:  // phpcs:ignore Drupal.Commenting.FunctionComment.Missing
core/lib/Drupal/Core/Extension/module.api.php:// phpcs:ignore Drupal.Commenting.FunctionComment.Missing, Drupal.Commenting.FunctionComment.MissingReturnComment
core/lib/Drupal/Core/Extension/module.api.php:// phpcs:ignore Drupal.Commenting.FunctionComment.Missing
core/modules/views/src/Plugin/views/sort/SortPluginBase.php:  // phpcs:ignore Drupal.Commenting.FunctionComment.Missing
core/modules/views/src/Plugin/views/sort/SortPluginBase.php:  // phpcs:ignore Drupal.Commenting.FunctionComment.Missing

Of those we know the ones in SortPluginBase.php are needed but what about the ones in the other two files?

Also, this line, "* Set the text mode for the character data reader." in FilterHtml.php should be removed.

I've learned, again, to more thorough in writing issue summaries and have updated it with more detail. I hope it helps.

I restored UserData and updated the issue summary

This is postponed on Navigation being stable and it is stable now that 📌 Mark Navigation as a stable module Active was committed. Therefor setting this to active.

@dcam, Thanks

Add that 10.6 is the last minor for D10

@longwave, thanks.

I have updated the issue summary and the change record.

This needed a rebase that didn't go well. Changes that I reverted kept coming back in. So, I started over using the diff file. Then I made some tweaks in TitleResolvedTest. Those are in the last commit which should be checked.

I responded to all of @longwave's comments. And a rebase.

@shalini_jha, thanks for updating the MR.

This needs work to address the comments in the MR. Specifically there are out of scope changes. When all of those are fixed then phpstan should pass and all the tests should run.

@benjifisher, thanks.

So, we need a final decision on link_options and timezone.

Looking again timezone I see that it is in a d6 sub-directory. We should not have the d6 and d7 sub-directories in Drupal 12 so that one, at least has to move elsewhere.

@benjifisher, i am confused. #23 suggests keeping timezone not link_options. Are you suggesting keeping both?

Simple conflict due to removed code in 11.x, 📌 Remove unused class property \Drupal\views\Plugin\views\argument\Date::$option_name Active . I am restoring RTBC

I am glad to see this committed. It was challenging and time consuming to add the comments especially as I have not been involved in the many hook conversion issues. From my perspective, this is a good example of a case where test methods should be documented before commit.

@donquixote, thank you. As you know this can be re-opened if there is renewed interest.

I'll close as works as designed seems the best for for something that evolved over time.

Created 📌 Add 'Core JavaScript packages' core committers Active

The document needs to be reviewed to make sure it is using the new names for the core leadership team. For example, Drupal now longer has a BDFL.

And which guide will this be put into?

Convert to new template.

@jonathan1055, can you open a new issue for #49? Thanks.

Maybe the title can be shorter

The 11.2 MR agrees with the 11.x MR, except for the tests as explained in #12.

This was applied to 10.3.x, 10.4.x, 10.5.x, 11.1.x, and 11.x. It was applied to 11.0.x, which is no longer supported, but then reverted.
Therefore restoring the fixed status.

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

Thanks for the work on fixing this Critical bug.

About this time last year this was set to 11.0.x for backport to 11.0.x and 10.3.x. Since both of those versions are no longer supported this will not be backported to those versions. And the last report of this causing a problem was in Jan of this year so hopefully that has been resolved over the year. It is time to close this as fixed.

I updated credit.

@randy tang, did you see my comment in #7 and #12 about the version?

Everyone, the version for this issue is 11.x, our main development branch. Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Please leave the version at 11.x.

Hi, if this problem was discovered on a version of Drupal that is not 11.x, add that information in the issue summary and leave the version at 11.x. In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

There is very little information here. If you are still experience this problem, are you able to provide complete steps to reproduce the issue → starting from "Install Drupal core"?

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

For Drupal core, it is preferred that contributors add a comment that they are working on an issue instead of assigning it to themselves. See Assigning ownership of a Drupal core issue → .

Has this been resolved?

There is very little information here. The configuration of the view given in the issue summary has lost all the formatting so it can't be imported, so I am not able to test anything here. I am not aware of other reports of problems with the responsiveness of Olivero. Maybe this is a support request like the duplicate?

If this is a support request, then I'll add that the Drupal Core issue queue is not the ideal place for support requests. The 'support request' option is there for filing support issues for contributed modules and themes. There are several support options listed on our Support page → , including the Drupal Forums → and Drupal Answers. There is also Drupal Slack → . You may get better replies in one of those places.

It looks like it is this issue, https://github.com/ckeditor/ckeditor5/issues/10118

I am inclined to agree that this should be moved. The composer output can still be added.

This is filed on drupal 10.0 which hasn't been supported ended since Dec 2023. And I am not aware of an event listing in drupal core although there is one in Drupal CMS. I am moving this to that project.

Support for 10.0 ended in Dec 2023.

I tested this today on simplytestme, 11.2.x-dev. I wasn't able to reproduce the problem using the steps in the issue summary. However, using the steps in the related issue, I was able to reproduce the problem. The difference is that that issue specifies the precision and scale whereas this issue does not. But having played with both I think this really is a duplicate of that issue.

Therefore closing this as a duplicate.

I tested this with simplytestme using 11.2.x-dev. I followed the steps in the issue summary and was not able to reproduce the problem. Are there other steps needed to reproduce the problem?

Changing version because in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

This also needs to be converted to a merge request.

🐛 Drupal\Core\Render\Component\Exception\InvalidComponentException: [slots.messages] Array value found, but an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateDefinition() Active

@mrogers, thanks for the link.

I am closing this as a duplicate of that issue.

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → . Thanks.

Updated the API link to 11.x and changed to the standard template.

Support ended for Drupal 10.3 in June of this year. I am changing the version to 11.x.

Support for Drupal 10.2 ended in Dec 2024.

Does this happen on a currently supported version of Drupal? I am tentatively setting this to 11.x so that more people see this issue.

Just dropping to ask if you have read the drupal 11.1.9 release notes → ?

Another issue committed

The timezone plugin implements a very specific case and hard codes 2 of the 3 the input parameters to timezone_name_from_abbr. The process plugins in the migrate module are more generic and flexible. For that reason I think it should not stay in core.

@benjifisher, thanks for reviewing all the process plugins!

I have restored link_uri in the MR since it was used in a custom migration. I agree that user_langcode is one to keep. The others are possible too but let's hear from others before changing the MR. So far, there has been no response in the Slack thread.

I don't think it matters but I have asked the other release managers about deprecating the migrate_drupal process plugins:

Right now I don't think the kept process plugins should move to the migrate module. But let's explore that in a meeting or a separate issue.

why some items are struck through?

They were ones that I subsequently resolved.

However, I have updated the 'problem' section of the issue summary and removed the strike throughs.

Working on reviewing this in detail with support from @nod_.

Follow up created, 📌 Add 'Core JavaScript packages' core committers Active

quietone → created an issue.