Account created on 30 April 2013, over 12 years ago
#

Merge Requests

More

Recent comments

🇳🇿New Zealand quietone

I'm going to move the changes for HookOrder to another issue. Assigning to myself for that and to review other local changes before pushing.

🇳🇿New Zealand quietone

Small adjustments for removal

🇳🇿New Zealand quietone

Remove copy/paste error.

🇳🇿New Zealand quietone

@Bojhan, thank you for all your work on Drupal. I've had the pleasure to read your comments while triaging issues and I found them to be very helpful. And thanks for taking the time to reply.

Thanks and best wishes!

Committed to the active branches and updated the project node, google group, slack channel.

🇳🇿New Zealand quietone

Thanks sun for your comments, when triaging issues I always find them helpful.

Committed to the current branches and checked that that the status in the Google group, the core project node, and the Slack channel are correct.

Thanks!

🇳🇿New Zealand quietone

Move to Release management guide

🇳🇿New Zealand quietone

@donpas, thanks for fixing the typo. If you have reviewed your fix of a typo and are sure it is correct, you can probably skip setting the page to 'Needs Review'.

🇳🇿New Zealand quietone

I put the documentation at Guidelines for semantic versioning for contributed projects in the Creating a new project .

I did made some changes to make it easier to scan the page and added a into paragraph. The page is set to NR.

I updated the remaining tasks.

And then I noticed that I missed the suggestion by @joachim about a new guide. That seems like a good idea, but it is not strictly necessary to complete this piece of work. The doc can easily be moved later.

🇳🇿New Zealand quietone

Add Mailer, https://www.drupal.org/project/drupal/issues/3379794 📌 [PP-1] Add symfony mailer transports to DIC Postponed , adding that it is for 11.3

🇳🇿New Zealand quietone

Drupal 10 is now in maintenance mode, and there are limited allowed changes for a maintenance minor release . This change is not eligible for commit.

I suspect that this is still a problem on 11.x, so changing version. Although, this needs to be confirmed.

If this problem was discovered on a version of Drupal that is not 11.x, add that information in the issue summary and leave the version at 11.x. In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

Restoring issue template so we can keep track of progress.

🇳🇿New Zealand quietone

If this problem was discovered on a version of Drupal that is not 11.x, add that information in the issue summary and leave the version at 11.x. In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Also mentioned on the version section of the list of issue fields documentation. Thanks.

🇳🇿New Zealand quietone

If this problem was discovered on a version of Drupal that is not 11.x, add that information in the issue summary and leave the version at 11.x. In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

@terao3, For Drupal core, it is preferred that contributors add a comment that they are working on an issue instead of assigning it to themselves. See Assigning ownership of a Drupal core issue .

🇳🇿New Zealand quietone

If this problem was discovered on a version of Drupal that is not 11.x, add that information in the issue summary and leave the version at 11.x. In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

This also needs the standard issue template so progress can be tracked.

🇳🇿New Zealand quietone

I checked again today and I could not find references to removed extension files in 11.x

Thanks!

🇳🇿New Zealand quietone

quietone changed the visibility of the branch 3515661-fix-doccomment.missingshort-in to active.

🇳🇿New Zealand quietone

quietone changed the visibility of the branch 3515661-fix-doccomment.missingshort-in to hidden.

🇳🇿New Zealand quietone

@xjm, thanks.

Back to needs review for the recent changes.

🇳🇿New Zealand quietone

I read the help text added in #2091403: Create hook_help for Entity module for the Entity module. I then read the field UI help text and found that form and view modes are discussed. There is no longer direct reference to 'entity' in any help text which I am sure is intentional. The concept of 'entity' is not necessary to use a Drupal site.

Therefore I am closing this as outdated. If that is incorrect, explain in a comment and re-open.

🇳🇿New Zealand quietone

@starlightE, thanks for the idea.

I am not able to find any history in core of a 'subheading' content for the Basic page. There is also no support for this idea in the past 8 years. Because of that it doesn't met the Criteria for evaluating proposed changes . In this case, there is not demonstrated demand and support for the change.

If there is interest in this re-open the issue and add a comment. Or open a new issue and reference this one.

🇳🇿New Zealand quietone

OK, another rebase and update to catch up to HEAD.

🇳🇿New Zealand quietone

The only function referred to in _batch_do is _batch_process() and that has an @see.

🇳🇿New Zealand quietone

Update minor stable date.

🇳🇿New Zealand quietone

Since the point raised in #20 is specific to 10.6 I think that would be better discussed in it's own issue, a child of 🌱 [meta] Release preparation steps for 11.3.0 and 10.6.0 Postponed .

Maybe we should add this to docs in addition to the metas?

What docs are these?

🇳🇿New Zealand quietone

This came up again in the last 24 hours where the 11.2.0 release highlights needed a small change but I lacked access.

🇳🇿New Zealand quietone

There has been no support for this feature request in the last 9 years. Also, @berdir, explains how to do this in in #6.

Therefor, closing this issue.

🇳🇿New Zealand quietone

That has been postponed for some time waiting for @olli to reply. For what ever reason that hasn't happened in eight years, so I am going to close this. This can be re-opened if there is interest.

@olli, thanks for all your work in VDC and best wishes in you endeavors!

🇳🇿New Zealand quietone

Searched the logs with git log -S'function system_admin_menu' and as far as I can tell this is outdated. I trust someone to correct the status if that is incorrect.

🇳🇿New Zealand quietone

I removed 'proposed' from the CR and added a screenshot to the issue summary.

Everything appears to be in order here.

🇳🇿New Zealand quietone

This is postponed on 3 php-tuf issues and 1 core issue, so changing status. Update the issue to put the postponed items into the remaining tasks per the guidelines.

🇳🇿New Zealand quietone

Fix formatting in IS.

While this is blocked on https://github.com/php-tuf/php-tuf/issues/396, I am leaving at Needs work because for completing the dependency evaluation.

🇳🇿New Zealand quietone

Thanks for bringing this up. Those changes were in a section for Windows users and this page is meant to be very basic and directing people to further information. The Local Server Setup guide has the details for different environments, which is where there is already docs for Windows. Therefor I have reverted that change that added the instructions for Windows and no change is required.

🇳🇿New Zealand quietone

@ adao.boscolo , thank you for helping to maintain Drupal documentation! The place to add details for installing DDEV with Windows is the Local Server Setup guide , which is linked to on this page. @ nick hope has created a detailed tutorial for Windows users in the guide. Please improve those docs, thanks. This page is deliberately kept simple, with links to further information. For background, have a look at this issue, https://www.drupal.org/project/documentation/issues/3398293 🌱 Consolidate local development environment documentation to recommend DDEV Active . Therefor, I am going to revert this change.

🇳🇿New Zealand quietone

This looks like a duplicate of 📌 [PP-1] Require PHP-TUF's Composer integration plugin Postponed . That issue has an MR for adding the dependency. I am still comparing both issues.

🇳🇿New Zealand quietone

Adding postponed item to the list of remaining tasks per the issue summary field documentation, remaining task .

🇳🇿New Zealand quietone

Added dependency evaluation template to the issue summary, with several TBA that need to be completed.

🇳🇿New Zealand quietone

Changes are made on 11.x first.

🇳🇿New Zealand quietone

@longwave, thanks for the review. I made the corrections and checked if any other changes were needed due to the recent update of Coder.

🇳🇿New Zealand quietone

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks

🇳🇿New Zealand quietone

Drupal 10 is in maintenance mode and this doesn't meet the criteria for inclusion. Does this occur on Drupal 11.x, or 11.2?

There are quite a few issues for view, have you checked for a duplicate?

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies .

🇳🇿New Zealand quietone

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies .

🇳🇿New Zealand quietone

In Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies .

🇳🇿New Zealand quietone

Given these factors, the single best piece of advice we can
give is to review between 100 and 300 lines of code at a time and
spend 30-60 minutes to review it

This is from Code Review at Cisco Systems / 63 Code Review at Cisco Systems 2006. This is the study summarized in the report linked from the doc page, the current text in the issue summary.

Further searches only resulted in other articles using the same source.

I updated the handbook page to remove the 'diff size' since we aren't using patches anymore. Let's stay with LOC.

🇳🇿New Zealand quietone

Remove reference to diff size because patches are no longer used.

🇳🇿New Zealand quietone

This was discussed amongst the release managers, @catch, @longwave and myself. We touched on the fact that MySQL is sort of stagnating, but also we have issues to bring MongoDB to core. It was a reminder that any 'recommendation' for a database server may change. But also, we can't drop mention of MySQL, it is still widely used and we test using it. We don't test with a Percona server, so that should be removed. It also come up that we understood the 'recommendation' to be about using a MySQL equivalent instead of PostGreSQL or SQLite, and not necessarily MySQL itself.

As for the text, we agreed that that heading could use an update. And we decided to reduce it to "MySQL, MariaDB, or equivalent".

🇳🇿New Zealand quietone

Update per https://www.drupal.org/project/drupal/issues/3478097 🌱 MySQL should no longer be "Recommended" Active

🇳🇿New Zealand quietone

I updated credit.

This needs confirmation that the new doc page agrees with the proposed resolution.

🇳🇿New Zealand quietone

Thanks for the idea. The core ideas project is deprecated.

I asked in committer slack what to do with this 9 year old issue, and in light of the recent strategy direction and Drupal CMS. The produce manager lauriii replied that this can be closed, saying that any work on this idea would be done in the Experience Builder.

Therefore closing.

🇳🇿New Zealand quietone

I should have set this to needs review to get feedback on the proposal.

🇳🇿New Zealand quietone

The core ideas project is deprecated.

The meta issue in #11 is in the core issue queue so I am moving this issue to core.

🇳🇿New Zealand quietone

Based on the last two comments I am closing this as a duplicate. The work is being done in 🌱 [Meta] Make Drupal the first "design-system native" CMS + Unify & simplify render & theme systems Active

🇳🇿New Zealand quietone

I wondered what happened to this issue. This change would make it easier to complete some, but not all, of the core coding standards issues. I also think that core should be consistent in structure. We all know how that can benefit searching and organizing work.

🇳🇿New Zealand quietone

Conflict due to using attributes for @group.

🇳🇿New Zealand quietone

@catch, thanks.

I updated the two doc pages mentioned in the Issue Summary and updated credit.

🇳🇿New Zealand quietone

Add preference for Linux, see https://www.drupal.org/project/drupal/issues/3436617 🌱 [policy, no patch] Drop support for Windows in production in Drupal 11 Active .

🇳🇿New Zealand quietone

Update references to IIS, see https://www.drupal.org/project/drupal/issues/3436617 🌱 [policy, no patch] Drop support for Windows in production in Drupal 11 Active

🇳🇿New Zealand quietone

I checked today and the link in the Issue Summary still shows the action.info.yml file for 11.x. And so is forum, https://api.drupal.org/api/drupal/core%21modules%21forum%21forum.info.ym...

🇳🇿New Zealand quietone

Changes this to just the jsonapi tests, which are the easy ones. Moving work on the others to another issue.

🇳🇿New Zealand quietone

Changes are made on 11.x, the main development branch first. Thanks.

🇳🇿New Zealand quietone

Checked on 11.x HEAD today, standard install, and this still happens. I applied the latest diff, cleared cache and the problem removes.

Tagging for an issue summary update.

🇳🇿New Zealand quietone

The question in #12 hasn't been answered in 8 months. So, I testing this on 11.x with and without the link_attribute module. I was not able to reproduce the problem using the steps in the issue summary.

Therefore, closing as cannot reproduce. If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue starting from "Install Drupal core".

Thanks!

🇳🇿New Zealand quietone

Since no reason for making this change has been given in 7 months, I am closing this issue.

If you agree with change then add a comment explaining why this is needed and reopen the issue, by setting the status to 'Active'.
Thanks!

Production build 0.71.5 2024