Account created on 30 April 2013, over 12 years ago
#

Merge Requests

More

Recent comments

🇳🇿New Zealand quietone

Add menu link

🇳🇿New Zealand quietone

I just ran the script and found 26 links that are 404 where 3 of those do not have a status. The results are in a sheet, dated today.

  1. http://www.drupal.org/association"].trusted
  2. http://www.drupal.org/association"]/img[@alt="drupalimage
  3. https://www.drupal.org/project/project_module?f[2]=im_vid_3%3A105
  4. https://www.drupal.org/project/drupal/issues/2921123
  5. https://www.drupal.org/ ";s
  6. https://www.drupal.org/docs/8/core/modules/package-manager
  7. https://www.drupal.org/documentation/modules/mysqli
  8. https://www.drupal.org/files/projects/drupal-x.y.z.tar.gz
  9. https://www.drupal.org/node/141866
  10. https://www.drupal.org/node/169815
  11. https://www.drupal.org/node/202483
  12. https://www.drupal.org/node/202491
  13. https://www.drupal.org/node/243993
  14. https://www.drupal.org/node/3084859n
  15. https://www.drupal.org/node/3425340
  16. https://www.drupal.org/node/3508905
  17. https://www.drupal.org/node/3518065
  18. https://www.drupal.org/node/945102
  19. https://www.drupal.org/node/add/project-issue/auto_updates
  20. https://www.drupal.org/project/ $removed_module
  21. https://www.drupal.org/project/ $removed_theme
  22. https://www.drupal.org/project/announce-updated
  23. https://www.drupal.org/project/auto_updates/issues/3312619#comment-14801308 📌 Ensure all validation results use translatable strings except when created from throwables Fixed
  24. https://www.drupal.org/project/auto_updates/issues/3338651 📌 Drupal core's coding standards forbid translated exceptions, but does that anyway — f.e. FileValidationException Active
  25. https://www.drupal.org/project/caption
  26. https://www.drupal.org/project/drupal/issues/3550627
  27. https://www.drupal.org/project/media_wysiwyg
  28. https://www.drupal.org/project/node/3100115
  29. https://www.drupal.org/SA-CONTRIB-2019-02-02
🇳🇿New Zealand quietone

Can you summarize here what you did for Drupal 11. I don't recall.

🇳🇿New Zealand quietone

The changes have been made on #3552872: Add redirect for incorrect installation guide URL . That is good that core no longer directs to a 404. However, the information there does not include how to adjust permissions. And, as I recall, the original page did explain how to change permissions on a *nix system.

This URL is also used in the install process for the Media module. Sending someone to the Drupal install information when install a core module doesn't make sense. I think https://www.drupal.org/docs/administering-a-drupal-site/security-in-drup... is a better choice.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

Changes are made on 11.x, our main development branch, first.

🇳🇿New Zealand quietone

@andypost, thanks for updating the tests.

I reviewed the changes to the tests and I agree that they are correct.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies .

Changing tags per Issue tags field and Issue tags -- special tags

Thanks.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

Restoring standard issue template . The issue template is used to track progress and tasks on an issue.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

Un-assigning per Assigning ownership of a Drupal core issue . @apotek, if that is incorrect, add a comment and re-assign to yourself.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

🇳🇿New Zealand quietone

Hi, in Drupal core changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies . Thanks.

🇳🇿New Zealand quietone

On a first read the plan looks fine, with one addition and one exception. First, before opening tickets we should discuss scope. And the addition is a point raised by andypost in Slack, which was that all deprecations should have a follow up for the removal.

🇳🇿New Zealand quietone

@smustgrave, thanks for starting this conversation.

The removals will happen on 12.x when it is create.

🇳🇿New Zealand quietone

The UI for this was removed in Drupal 10.4, 📌 Remove adding an extension via a URL Fixed

🇳🇿New Zealand quietone

That was a mistake.

🇳🇿New Zealand quietone

@pameeela, thanks. I followed your advice and this screenshots shows the current database image for 'Content' and the new one for 'Files' and thus confirms this change.

🇳🇿New Zealand quietone

@catch, thanks. I have fixed that.

I rebased and there were more instances to fix, so back to NR for review, particularly the last two commits.

🇳🇿New Zealand quietone

Those two are Drupal.Commenting.VariableComment.MissingVar not phpcs:ignore VariableComment.Missing so they are out of scope for this issue.

🇳🇿New Zealand quietone

Even so, I think the README files should be changes as well. For example, in core 'please' was removed from INSTALL.txt, which is in effect a README. In fact, in core 'please' has been removed from the entire code base and is a flag word in core/.cspell.json.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

This leaves one instance, in \Drupal\views\Plugin\views\argument\Date for public $option_name = 'default_argument_date';. As far as I can tell that property is not used. That needs an issue.

🇳🇿New Zealand quietone

This was fixed in 🐛 Typo in WidgetInterface.php Active . Closing as a duplicate

🇳🇿New Zealand quietone

This issue has been open for 10 years and there is still a great deal of work to do. I think that the people who have managed this so far should be credited and not have to wait any more years for this to be completed.

Therefore I have updated credit. I am changing the title to include 'stage 1' and will open a new issues for 'stage 2'. I will also change the parent on any still open child. The new issue is #3553320: [meta] Fix PHP coding standards in core, stage 2 .

Thank you to everyone who contributed to get the coding standards process for core up and running and for keeping this meta up to date.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

Update to the typical format for dependency evaluation. And the dependency evaluation needs to be updated, 2.x is no longer supported.

🇳🇿New Zealand quietone

This will also make a change to the user interface, so there should be before and after screenshots. The screens should in the issue summary.

🇳🇿New Zealand quietone

Working off the supplied images doesn't truly review the change though.

I don't have that icon showing in the navigation. How to enable it?

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

The Ideas project is deprecated. As discussed in a core committer meeting issues that are adding modules are being moved to the Drupal CMS project for discussion.

🇳🇿New Zealand quietone

This is now being addressed in the Automatic Updates Initiative, which is being implemented in 🌱 Drupal 10 Core Roadmap for Automatic Updates Active . This particular proposal will not be implemented.

🇳🇿New Zealand quietone

In #15 this was marked postponed, presumably on 🐛 Move entity preparation from form controller to entity class: "last changed" timestamp not updated and "create new revision" setting not respected when updating entities via Entity API Postponed: needs info is blocked on #2544790: ContentEntityBase::setNewRevision(FALSE) is broken if ::setNewRevision(TRUE) was called previously . One has been fixed and the other Closed as outdated. So, this can be active. But maybe this is also outdated?

Is there work to be done here?

🇳🇿New Zealand quietone

quietone made their first commit to this issue’s fork.

🇳🇿New Zealand quietone

Per #41 and #42 this is not active.

🇳🇿New Zealand quietone

Yes, I could replicate this. The MigrateMessageInterface defines $message as a string, maybe that should be changed.

But for the assertion we can just cast $message to a string.

🇳🇿New Zealand quietone

Wait a minute. Now that I have had time to eat, I realize there is something wrong here. We only need to change migrations and migration tests if we are changing what the text_with_summary field migrates to in D11. I gather the plan is to deprecate text_with_summary in D11 and that is also when Migrate Drupal will be deprecated. So, both will be deprecated and migrate in core is not responsible for the migration to the new the destination, it will handled by a contrib module.

Checking the parent issue, that is what berdir and catch agreed to, See #3427095-18: [Meta] Deprecate text_with_summary and #3427095-19: [Meta] Deprecate text_with_summary . So, the migration and migration tests should remain unchanged.

Updating the title accordingly.

🇳🇿New Zealand quietone

Also, I still have my D6/D7 setups available. I can create the needed fields and update the fixture. I just need the details for the news fields. And I do wonder how they are different from the existing 4 text_long fields in the current fixture.

🇳🇿New Zealand quietone

I also do not think that existing fields in the migrate drupal text fixture should be changed. All the fields were added for a reason and test a particular possibly Drupal 7 configuration. By changing them we risk losing test coverage for a configuration that can exist in the wild.

Any needed new fields should be added. And they should be added using a Drupal 7 site so that we are sure all the configuration is as D7 site would create and that the fixture works in a D7 site.

🇳🇿New Zealand quietone

@andypost, thanks for the fixes.

Previously, I moved the needed test files to the module being deprecated, so let's try that.

🇳🇿New Zealand quietone

The User guide is maintained in the User Guide project not the Drupal core project. Therefor, I am moving this issue.

🇳🇿New Zealand quietone

LayoutBuilderFieldLayoutCompatibilityTest was moved to field_layout in 📌 Move field_layout tests to field_layout module Active .

🇳🇿New Zealand quietone

Based on the comment by longwave I am setting this back to needs review.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

quietone created an issue.

🇳🇿New Zealand quietone

To stop updates to the current d.o pages, I have marked them all deprecated and changed the title to start with [Obsolete]. A warning is on each page directing to the new GitLab pages. That should stop any changes to those docs.

I have updated the project page as well.

That just leaves 📌 Redirects for Coding standard pages to GitLab pages Active .

Production build 0.71.5 2024