- Issue created by @thomwilhelm
- 🇺🇸United States xjm
Good catch! This is probably due to the fact that the change dropping PHP 10 support landed late. (Note that we've also tentatively discussed re-widening the constraint.)
Fixed like so:
https://www.drupal.org/node/3530875/revisions/view/14038203/14061505 → - 🇺🇸United States xjm
Whoops, so PHPUnit 10 is still allowed, just not the default. Updated again:
https://www.drupal.org/node/3530875/revisions/view/14061515/14061550 → - 🇮🇹Italy mondrake 🇮🇹
To be precise, PHP 8.4 is not a strict requirement. PHPUnit 11 works with PHP 8.3. as well (core tests are by default executed on 8.3). This issue 📌 Switch the default test environment to PHP 8.4 Active is going to change the default to PHP 8.4.
- 🇬🇧United Kingdom longwave UK
core-recommended also requires sebastian/diff 6, but PHPUnit 10 requires sebastian/diff 5, so anyone using core-recommended will be forced to upgrade to PHPUnit 11.
🐛 Can't update to 11.2.0 Active will resolve that so core-recommended users should be able to use either version.
- 🇺🇸United States xjm
@mondrake Right but that will only affect 11.3.x and HEAD. This is specifically about the text of the 11.2 announcement. I think the
sebastian/diff
issue being in the known issues covers the rest. - 🇺🇸United States xjm
Forgot to post my diff for #8:
https://www.drupal.org/node/3530875/revisions/view/14061550/14061628 →Saving additional credits.
- 🇦🇺Australia thomwilhelm Sydney
Thanks for the updates so far, however I'm still finding this sentence a little confusing in the release notes:
https://www.drupal.org/project/drupal/releases/11.2.0 →
"PHPUnit 11 is now the default version and requires PHP 8.4."
I read this as PHPUnit 11 is being used in Drupal 11.2. So far so good. However PHP 8.4 isn't a requirement of PHPUnit 11 itself from what I can see: https://phpunit.de/announcements/phpunit-11.html
Only reason I mention this is that it implies you need to upgrade to PHP 8.4 in order for PHPUnit 11 to work in Drupal 11.2. Which I don't think is the case?
- 🇬🇧United Kingdom catch
I think there was one point where we were only running phpunit 11 against PHP 8.4 in core CI runs, before it became the default for everything, and the sentences gradually got updated until they no longer made sense. I've removed the 'and requires PHP 8.4' - good spot!
Moving this back to fixed again.