- Issue created by @quietone
- Status changed to Postponed
3 months ago 7:27am 19 June 2025 - πΊπΈUnited States smustgrave
This one was pretty easy with only 10 files. Reviewed the changes and they seem fine, no objection to any. Re-ran the build failure but 99.9% sure it's random
LGTM
The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π³πΏNew Zealand quietone
quietone β changed the visibility of the branch 3515661-fix-doccomment.missingshort-in to hidden.
- π³πΏNew Zealand quietone
quietone β changed the visibility of the branch 3515661-fix-doccomment.missingshort-in to active.
- πΊπΈUnited States xjm
NW for small things... fortunately, this one is a nice small scope. Thanks!
- First commit to issue fork.
Hey, please review the doc blocks tweaks. Let me know if I missed anything. Thanks!
- πΊπΈUnited States xjm
Thanks @joaopauloscho! Those changes look good to me. I made a couple small fixes to add the article "a" where it was missing.
I am leaving the issue at "Needs review" for now for another person to confirm the review. (That way I can still potentially commit it.)
- π§π·Brazil charlliequadros
Hi @xjm, @joaopauloscho
Iβve reviewed the comments and everything looks fine to me. If you need anything else, please let me know
- πΊπΈUnited States xjm
Committed to 11.x. I also backported it to 11.2.x without the enabled PHPCS rule as follows:
[ayrton:maintainer | Sat 11:37:23] $ git checkout 11.2.x Switched to branch '11.2.x' Your branch is up to date with 'origin/11.2.x'. [ayrton:maintainer | Sat 11:38:06] $ git pull Already up to date. [ayrton:maintainer | Sat 11:38:33] $ git cherry-pick -x 11.x # ... [ayrton:maintainer | Sat 11:38:58] $ git commit --amend -m 'Issue #3515661 by quietone, joaopauloscho, xjm, charlliequadros: Fix '\''DocComment.MissingShort'\'' in FunctionalJavascript tests'
Thanks everyone!
Automatically closed - issue fixed for 2 weeks with no activity.