🇧🇷Brazil @charlliequadros

Using DDEV, follow the steps below to verify if the issue has been resolved:

Run the command: ddev drush php

Enter the following code:

$url = \Drupal\Core\Url::fromUri('internal:<nolink>');

The expected behavior is that no errors are thrown.

charlliequadros → made their first commit to this issue’s fork.

Hi @aaron.ferris,

I think the current behavior makes sense — it counts down until the specified time, and then starts counting up to show how much time has passed since then.

One thing I think could be nice to add is a message that indicates how much time is left until the specified time, and another one that shows how much time has passed after it.

Does that make sense to you?

Hi @jan kellermann, English isn’t my first language either, but I’d like to share my opinion.

I asked ChatGPT to revise the text, and according to it, the best option would be simply to remove "be".

It also suggested a slightly more polished version, which would look like this:

The two Klaro! dialog types:

The Klaro! notice dialog briefly informs users about the use of external services and cookies. The consent dialog modal is used to allow users to manage their consent preferences for specific services or purposes.

I think this version could work better. We can wait for @lieb to confirm which option is preferred.

I’m happy to make the change if needed.

Hi @aaron.ferris,

I’d like to work on this, but I didn’t quite understand how it’s supposed to work.

For example, when the date is in the future, it shows a countdown timer until the selected date. Once the date has passed — meaning it's now or in the past — it starts showing the time that has passed since then.

My question is: what’s the expected behavior? Should it stop when it reaches the selected date?

aaron.ferris → credited charlliequadros → .

aaron.ferris → credited charlliequadros → .

aaron.ferris → credited charlliequadros → .

Hi @aaron.ferris,

the issue happening here is the following:

On the configuration screen, the redirect time is being set as ["'time'"]. When we try to convert this value to a number, it returns NaN because it can’t properly interpret this format — the value is coming as a string with single quotes inside double quotes.

To fix this, we need to remove the single quotes (') from the value. In fact, this value doesn't even need to be a string at this point.

https://git.drupalcode.org/project/jstimer/-/blob/2.0.x/modules/jst_timer/jst_timer.module?ref_type=heads#L260

I'm leaving this fix for someone who's just getting started, as it's a great opportunity to understand how contributions work in Drupal.

I'll work on that.

I fixed the PHPStan error, but now I'm encountering an issue with Nightwatch. I’m not sure how to test it locally to resolve it. If anyone can help me with the steps I need to take, I’d be happy to fix it as well.

I'll work on it

charlliequadros → changed the visibility of the branch 2873447-views-rest-export to hidden.

Hi @smustgrave

Sorry, but I still don’t fully understand what I need to do. Could you clarify the next step?

Either way, if it’s not possible to explain right now, I’ll keep an eye on this ticket to see how the issue gets resolved.

The file StreamWrapperManagerInterface.php had execution permission, as shown in the image.

I have removed this permission. Could someone review it?

Hi @nexusnovaz

The code seems to work.
It's possible to do something similar, which might be more optimized, but it could also be harder to understand.

$am_pm = $hr < 12 ? "am" : "pm";
$hr = $hr % 12 ?: 12;

So, this approach might be the best option.

Hey everyone, the issue with the Stylelint in the CSS was caused by the order of the elements, so I fixed it. You can check the change in this link. It was correct before, but I might have mistakenly modified it during the merge.

Additionally, I removed some @nest rules that were added to the light theme. Could someone validate if any further changes are needed?

I’d also like to understand why this issue is happening. I’ve noticed it occurring in several issues I contributed to. If possible, I’d love to learn how this works and help fix it if necessary.

Hi everyone,

I did the rebase on the MR, and there were several changes.
I'm not sure if it would be better to create a new MR with the updates.
If that would be safer, please let me know, and I'll make the change.

charlliequadros → made their first commit to this issue’s fork.

I have made the necessary changes for compatibility with Drupal 11.x. Please let me know if any further modifications are needed

charlliequadros → made their first commit to this issue’s fork.

Hi @smustgrave,

made the change you suggested and also did the rebase.

charlliequadros → made their first commit to this issue’s fork.

Hi @mglaman

I'd be happy to test this, but it's not very clear how to do it. Could you provide more details on the process?

Hi @smustgrave

I've done the rebase. Let me know if you need anything else.

Can someone help me understand what I need to check here?

Hi @smustgrave,

The comment on the MR didn't make much sense to me either. Could you explain that part better?

Also I think the replacement is to use the typeConfigManager property as is done in ::validateForm()

Is anything else needed for this issue?
I'd be happy to work on it if necessary!

Hey @smustgrave,
I’ve done the rebase as you requested. Do I need to do anything else regarding the questions I asked here 📌 ConfigFormBase::typedConfigManager() should have been removed when deprecations were removed in 11.0 Active

Hi @adwivedi008 ,

I left a comment, but I'm just starting to contribute to the community.
Maybe we can check with someone more experienced to see if what I said makes sense.

I fixed the issue where the checkboxes for "Reversed" and "First and last only" were not being saved.

Hi @catch

I'd like to clarify a few doubts before making the changes.

If I remove only the redundant part, won't the comment look strange with just "There is no replacement."?

Also, I didn't understand this other part.

Also I think the replacement is to use the typeConfigManager property as is done in ::validateForm()

Now that 'typedConfigManager' is injected as a dependency, there will always be a valid object.

In that case, wouldn't the return already be correct? Am I mistaken?

Could you explain these points to me before I proceed with the changes?

Hi @catch
Is the file name "nodehooks1"?
I couldn't find it. Could you tell me where it is located?

I’ve fixed the code standards issues.

charlliequadros → made their first commit to this issue’s fork.

We must follow this documentation to deprecate anything in Drupal.
→

Hi @alexpott, @longwave,
I re-added the comment, fixed the typo, and submitted it for review again.

charlliequadros → made their first commit to this issue’s fork.

Hi @pfrenssen,

I've made the changes, but I'm facing some errors.
Could you help me understand how to fix them?

Thanks!

charlliequadros → made their first commit to this issue’s fork.

Hi @penyaskito,
I resolved the conflict in the MR.

charlliequadros → made their first commit to this issue’s fork.

Hi @sivaji,
I made the change to organize it in the correct granularity order.

Hi @joachim,
it's not clear what the comment is meant to convey. To me, it should include something like:

// If $form_state->isRebuilding() was set by $form_state->setRebuild() and the input was
// processed without validation errors, we are in a multi-step workflow
// that is not yet complete. In this case, a new $form needs to be constructed based on
// the changes made to $form_state during the request.

Hi @joachim,
I made the change you requested, assigning null to the second parameter to make the code clearer and easier to understand when read. It seems like there's an issue, but I'm not sure how to fix it.
I'm just starting to contribute, and I would really appreciate your advice on how to resolve this.

charlliequadros → made their first commit to this issue’s fork.

Patch from comment 14 updated for compatibility with Drupal 10.4.1. Available for anyone who needs it.

Hi @romulasry, I believe this error is expected.
You need to add a token because, when the module generates URLs automatically, it requires something to differentiate them.
You can try something like "/board/term/[node:title]" or click on "Browse available tokens" to check which token best fits the 'forum' pattern type.

This patch was modified to work with Drupal 10.3.6.

When the user does not select the 'Enforce auto logout on admin pages' option and leaves a window open on a non-configuration page, the system continues counting the time and logs out, even if the user is working on a configuration page in another window. To prevent this, I added this part to the code

 if (localSettings.refresh_only) {
        // On pages where user shouldn't be logged out, don't set the timer.
        localStorage.setItem('autologout_page_activity', 'true');
        t = setTimeout(keepAlive, localSettings.timeout);

which keeps the session active at all times while the user is on an administrative page.

updated patch

charlliequadros → created an issue.

I was also facing the issue when removing the condition, so I updated the patch.

Hi @cilefen,

I followed your suggestion to identify when the issue was introduced.

This issue arose during the resolution of this issue. https://www.drupal.org/project/drupal/issues/3414287 📌 Avoid reading session from the database multiple times during a request Needs work

I couldn’t determine which call was removed to avoid two database requests. Was it "$request->getSession()->save();" or "$this->session->start();

Hi @catch,

I created this issue https://www.drupal.org/project/drupal/issues/3468632 🐛 The session is not being updated. Needs work and, upon investigation, identified that the problem was introduced by this issue. I’d like to understand if the issue is related to calling the
$this->session->start() function twice.

Could you help me clarify this?

Thank you!

Hi @cilefen

In Drupal version 10.2.7, the user's session was updated with each request, meaning that as long as the user interacted with the site, the session time was refreshed, preventing it from expiring during use. However, after updating to version 10.3.0, this behavior changed: the session time is no longer updated. So, if the timeout is reached, the session will be automatically closed, regardless of what the user is doing, such as during content creation or editing, for example. What's not working after the update is the session time being refreshed while the user is interacting with the site.

I created an MR. I'm not sure if it's the best solution, but it solves the problem until someone can fix it properly. I'm available to work on this ticket if anyone can help me figure out a permanent solution to the issue.

charlliequadros → created an issue.

Patch updated to Drupal version 10.3.1.

Hi @Chandansha,
I added the check that @mfb requested in the function where the error occurs. I hope you don't mind.

Hi @smustgrave

The issue occurs because when an unknown file type is created, it doesn't find the MIME type, resulting in a null return from this function.

https://git.drupalcode.org/project/drupal/-/blob/11.0.0/core/lib/Drupal/Core/File/MimeType/ExtensionMimeTypeGuesser.php#L929

One solution would be to set 'application/octet-stream' as the MIME type for unknown file types. This would prevent the error from occurring. However, I'm not sure if this would be the best approach or if the current implementation in the MR is sufficient, as it already resolves the problem.

fixed patch 15

resolve the conflicts they were having
@aaron.ferris

Patch update to the latest released version 3.0.0-rc2.

I will work on this ticket

I will work on it

charlliequadros → made their first commit to this issue’s fork.

charlliequadros → made their first commit to this issue’s fork.

I tested the patch #3, and it worked as expected for me.

I've created a MR, if there's any adjustments needed, please let me know.

The getRawData function wasn't returning the altered data from the settings file, leading to the inability to retrieve the added settings data. Following the suggestion from [name of the person who made the suggestion], it was changed to the get method, which retrieves all data, including those being overwritten in the settings. If my contribution was helpful, please consider giving me some credit. Thank you very much!

charlliequadros → made their first commit to this issue’s fork.

charlliequadros → made their first commit to this issue’s fork.

As mentioned on #258 the patch from #257 can't be applied to Drupal 10.2, therefore I created a new patch for it.