- π¬π§United Kingdom aaron.ferris
I can't reproduce this, but then I can't reproduce the redirect at all, so this appears to be broken.
- π¬π§United Kingdom aaron.ferris
Actually I can reproduce this, the issue is that the redirect_path is being converted to String(), but the contents of that are nonsensical even if you have a redirect such as /node/1. I can however see that the redirect is called continuously.
- π§π·Brazil charlliequadros
Hi @aaron.ferris,
the issue happening here is the following:
On the configuration screen, the redirect time is being set as ["'time'"]. When we try to convert this value to a number, it returns NaN because it canβt properly interpret this format β the value is coming as a string with single quotes inside double quotes.
To fix this, we need to remove the single quotes (') from the value. In fact, this value doesn't even need to be a string at this point.
I'm leaving this fix for someone who's just getting started, as it's a great opportunity to understand how contributions work in Drupal.
- π¬π§United Kingdom aaron.ferris
Hello @charlliequadros
Thanks for that, very helpful and thanks @jonathandealmeida for taking a look.
- π§π·Brazil jonathandealmeida
I finished the fix, after the review, this can to go to the tests.
- π¬π§United Kingdom aaron.ferris
Thanks jonathandealmeida , ill pull this down and take a look.
- π¬π§United Kingdom aaron.ferris
Tested this with a redirect time of 10 seconds and a redirect of node/1 and it did seem to function as expected. As above, will leave this open in case for further testing.
- π¬π§United Kingdom dani volpe
Tested this with a redirect time of 22 seconds and a redirect of node/1 and it did seem to function as expected. See attached GIF
-
aaron.ferris β
committed 6d9a4028 on 2.0.x authored by
jonathandealmeida β
#2144769: Fix redirect <reload>
-
aaron.ferris β
committed 6d9a4028 on 2.0.x authored by
jonathandealmeida β
- π¬π§United Kingdom aaron.ferris
Adding credit for all those involved in Zoocha contrib initiative, including mentors.