- ๐บ๐ธUnited States smustgrave
Thank you @gaurav-mathur but the screenshots were added in #28 so this was duplicated effort.
Reviewing the code
list($prefix, $suffix)
1. Think we shouldn't be using list instead arrayTagging for novice.
- Status changed to Needs review
3 months ago 4:34pm 24 September 2024 - ๐ฌ๐งUnited Kingdom rachel_norfolk UK
This looks like it is ready for a review at DrupalCon Barcelona 2024, if a budding contributor would like to take it on...
- ๐บ๐ธUnited States smustgrave
So this contains a UI change so screenshots should probably be added to the issue summary (part of the standard template).
Also fixes should be in MRs vs patches.
Feel free to keep working just marking with the DrupalCon message.
Novice issue reserved for the Mentored Contribution during DrupalCon
Barcelona 2024. After the 27th of September 2024, this issue returns to being
open to all. Thanks - ๐ฏ๐ดJordan issa.haddadin
Working on this as part of the first contribution session in DrupalCon 2024
- ๐ฏ๐ดJordan issa.haddadin
Just added patch #33 for the fork and added my changes on top of it to include a fieldset that wraps the display order settings
- ๐ฌ๐ชGeorgia iamdroid
Hi folks. I've reviewed the code and tested the actual behavior, everything looks good. Thanks.
Changing to RTBC.
- ๐ฌ๐งUnited Kingdom rachel_norfolk UK
I wonder, Iamdroid, if you or someone else can โproveโ the review by posting some before and after screenshots? Iโd suggest simply firing up 11.x in https://simplytest.me and also doing the same in 11.x with the patch attached.
- ๐ณ๐ฑNetherlands rkolen
I am testing this with proof on DrupalConBarcelona with jacobupal
- ๐ฌ๐งUnited Kingdom jacobupal Leeds
Here is a screenshot of before the changes.
- ๐บ๐ธUnited States smustgrave
Issue summary update still appears to be needed.
Recommend using standard issue template.
- ๐ฌ๐ชGeorgia iamdroid
Just tested it again and noticed that the state of the checkboxes is not actually saved.