Improve layout for Multiple Field Settings in Views

Thank you @gaurav-mathur but the screenshots were added in #28 so this was duplicated effort.

Reviewing the code

list($prefix, $suffix)
1. Think we shouldn't be using list instead array

Tagging for novice.

Tried to address #31.

This looks like it is ready for a review at DrupalCon Barcelona 2024, if a budding contributor would like to take it on...

So this contains a UI change so screenshots should probably be added to the issue summary (part of the standard template).

Also fixes should be in MRs vs patches.

Feel free to keep working just marking with the DrupalCon message.

Novice issue reserved for the Mentored Contribution during DrupalCon
Barcelona 2024. After the 27th of September 2024, this issue returns to being
open to all. Thanks

Working on this as part of the first contribution session in DrupalCon 2024

Just added patch #33 for the fork and added my changes on top of it to include a fieldset that wraps the display order settings

Hi folks. I've reviewed the code and tested the actual behavior, everything looks good. Thanks.

Changing to RTBC.

I wonder, Iamdroid, if you or someone else can “prove” the review by posting some before and after screenshots? I’d suggest simply firing up 11.x in https://simplytest.me and also doing the same in 11.x with the patch attached.

I am testing this with proof on DrupalConBarcelona with jacobupal

Here is a screenshot of before the changes.

Here is a screenshot showing the after changes.

Issue summary update still appears to be needed.

Recommend using standard issue template.

Just tested it again and noticed that the state of the checkboxes is not actually saved.

I fixed the issue where the checkboxes for "Reversed" and "First and last only" were not being saved.

#49 still seems true, have not reviewed

I have tested the fix and confirmed that the "Reversed" and "First and last only" checkboxes are now being saved correctly.

Steps I followed to test:

• Added a field to a content type with multiple values.
• Created a View and added the field.
• Configured the Multiple Field Settings in Views.
• Checked and saved the "Reversed" and "First and last only" options.
• Revisited the form to confirm that the selections were retained.
• Verified no errors in logs.

The issue is now resolved as expected. Marking this as RTBC.

Addressed #49 as well.

I hope you don’t mind me saying, sarveetsingh, but that is a really well written test comment. Contains everything it should. Nice work!