🇬🇧United Kingdom @damiankloip

Account created on 22 November 2010, over 13 years ago
#

Recent comments

🇬🇧United Kingdom damiankloip

Thanks Xano, tstoeckler. Sorry for gatecrashing.

🇬🇧United Kingdom damiankloip

Oh, that part is totally different :) That is implemented internally in the views UI.

🇬🇧United Kingdom damiankloip

Sorry, but some UI text was changed but others not :)

We have a 'Duplicate' value for the submit label, but still 'Clone' for the form title, name default value, and placeholder text. AS well are a path still using 'clone' - That seems confusing for people, even if it is only in the interim.

Plus the changes are pretty minimal IMO.

🇬🇧United Kingdom damiankloip

You might as well just change the route name too? As you seem to have changed basically every other instance of views UI using 'clone' to 'Duplicate' anyway. In fact that is 90% of the patch? :)

🇬🇧United Kingdom damiankloip
+++ b/core/lib/Drupal/Core/Entity/EntityAccessController.php
@@ -129,6 +129,13 @@ protected function processAccessHookResults(array $access) {
+    // Duplication is the act of creating a new entity based on the information
+    // that an existing entity contains. A user therefore needs to 'view' the
+    // existing entity in order to create a new one.

This just doesn't see right. If you are duplicating an entity. You need create access atleast?

So maybe this could be simplified more, and create == duplicate or something? Rather than having to have a cumbersome condition in the EntityAccessController?

🇬🇧United Kingdom damiankloip
+++ b/core/lib/Drupal/Core/Entity/EntityListController.php
@@ -106,6 +106,12 @@ public function getOperations(EntityInterface $entity) {
+        'title' => t('Duplicate'),

Some sort of $this->t?

Production build https://api.contrib.social 0.61.6-2-g546bc20