I've moved to Needs Review but I'll be leading some new contributors tomorrow through things and this would be a great one for them to check. Can you leave any review until at least the weekend? Thanks!
removing Novice tag as it isn't too clear what the next action is
So, for example:
@heddn, @realityloop, @ekl1773 - you have the time and energy to contribute, just not the “access” to the actual events. Would you be amenable to things like helping to run the monthly meetings in Slack a couple of times a year? Or perhaps helping to coordinate some of the issue triage exercises? Each of those things are definitely remote-accessible and help us keep things moving.
If we could have an indication either way, that would help us push this issue forward.
And, for the record, I miss you all terribly, too!
I’d say the question isn’t just about what kind of contributions does the mentoring team need from the coordinators on this list but what guidance and leadership do they need. There are a whole bunch of ways they can (and do) give that - through running meetings, encouraging volunteers, recruiting future coordinators and mentoring them. It’s definitely more than what takes place “in the room” on contrib day at DrupalCon.
I think the question those who are unsure need to ask themselves is do they want to engage with new mentors, help to build their experience, and develop them into the coordinators of tomorrow. If so, they’re definitely a coordinator and being on the list is the right place to be. If they feel they have “done their part” (and everyone mentioned has played a big part!) then that is also fine.
Ey up!
As I am now “back in the Drupal Community” (honestly, do we ever really leave?), I’m keen to get back into mentoring coordination. Looking forward to Barcelona!
Actually, made a couple of tiny language changes, just to make it read better around activities.
Also, changed organising “summits” to “training” as there are many ways to train a mentor.
Honestly, this looks great to me.
💙
Only once contribution attribution has been given on the various issues. I have been back and updated a few that were already closed but it needs checking on others.
Adding contribution credit. Please don’t just close issues without giving credit
Adding contribution credit. Please don’t just close issues without giving credit
Adding contribution credit. Please don’t just close issues without giving credit
Okay, I have been testing both the MR against 6.0.x and the latest patch file (thanks @peachez) against 6.05 and they look good. I have tested both BEF exposed filters in their default UI and altered to use others, like checkboxes and radio buttons. The behaviour of using AJAX to reset the form seems consistent and performant.
We have had several good iterations now and I believe this is ready for RTBC.
Adding attribution as i was sat in the office in Cambridge!
Adding contribution recognition. Because it matters.
Just re-tagging with the official tag :-)
You have a good point, though. Would you be able to propose some text? It would almost certainly be correct!
Just re-tagging with the official tag :-)
Just re-tagging with the official tag :-)
Just re-tagging with the official tag :-)
Just re-tagging with the official tag :-)
Just re-tagging with the official tag :-)
Just re-tagging with the official tag :-)
Just re-tagging with the official tag :-)
only removing the Portland tag to avoid people accidentally using the incorrect one at DrupalCon.
retagging
retagging
retagging
retagging
retagging...
Ah - I notice that the site is making use of the Client Side Hierarchical Select module, drupal/cshs. I also note that the module fills the $choice variable with a Drupal\cshs\Component\CshsOption object that does have a “label” property but that it is protected so this module cannot read it. It does not have a toString method as a last resort way to get some content.
Okay, I’m seeing this behaviour.
I have a view of media entities that have a taxonomy link on them. I want to use BEF to display the normally working dropdown list of items as a set of radio buttons to select. I see a javascript error when previewing the view in views_ui and a blog error of Error: Object of class Drupal\cshs\Component\CshsOption could not be converted to string in Drupal\better_exposed_filters\BetterExposedFiltersHelper::flattenOptions() (line 131 of /var/www
xjm → credited rachel_norfolk → .
Adding attribution
jjchinquist → credited rachel_norfolk → .
Awesome!
Thanks
dan2k3k4 → credited rachel_norfolk → .
adding meeting data...
Yeah, I'll host this one
Adding more information to guide people giving feedback...
OMG yes!! I said this many times when I was at the DA, I’m afraid to deaf ears.
Increasing the major version number doesn’t bring new features, they come in the minor releases. All that a major release brings is the dropping of outdated code and dependencies.
Celebrate the minor releases, not the major ones. In all things of life.
just updating attribution...
just updating attribution...
dan2k3k4 → credited rachel_norfolk → .
dan2k3k4 → credited rachel_norfolk → .
Whoa!
What exactly are you trying to do? This project isn’t Drupal core and it isn’t a module or theme. No code is here to patch.
Let me know what you are trying to do and I’ll try to help but I’m going to close this issue as it’s making no sense.
What are you trying to fix, this project isn’t a code project so there no code to make a patch against?
Hi Chris - the change includes both right now - a new max_allowed_packet and a PHP memory size. I have no problem with the max_allowed_packet. I'm just querying the PHP memory size change.
See https://github.com/simplytestme/website/pull/350/files#diff-188015a49750... for reference.
What is the “must have” memory requirement? Is it 512M?
Good question on what the actual requirement is. I just noted 512M in the original MR. Will inquire…
Updated the tests pretty much according to the revised configuration BUT I’m not happy with simply changing the php memory limit to 512M. It seems wildly excessive for just one module???
adding screenshot showing logs when installing without the key 512M php config
I’d really rather not be requiring 512M for every install on STM and it does seem a wildly excessive requirement for the module.
rachel_norfolk → created an issue.
I am an idiot and didn’t run the unit tests! They need work...
So, with the PR (!) applied, the project browser does run. It is giving sensible composer commands to install, etc etc.
MR migrated to GitHub - see https://github.com/simplytestme/website/pull/350
We have not received an update on this issue in a four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in a four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in the mentioned four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in the mentioned four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in the mentioned four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in the mentioned four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in the mentioned four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
We have not received an update on this issue in the mentioned four week period so we’re going to close it. This lets us focus on the issues that are getting the most engagement.
I’m going to close this, especially given Thunder no longer being supported.
As we are moving development over to github.com, this message no longer appears on the project page.
Hi
The University Plus theme is a proprietary theme supplied by drupalthemes.io
For help, you need to ask on their help system.
So, in an ideal world, the combination wouldn’t be selectable because a composer.json and module.info.yml would say that Drupal/ckeditor5 was not compatible with versions 9.5.0 upwards.
If that was the case, we’d never get to the point of attempting to install (and, therefore, needing a better error message that’s buried in the depths of React code where dragons hang out…)
Is that even possible?
Merged!
Oh - that’s an interesting one!
We have made a few changes recently (preparation for moving it to D10) but this doesn’t seem connected.
This is adding the 1.0-dev release of ckeditor5, right?
Merged
Great to have this merged - we can take the patch out of simplytest.me now!
Ah! My apologies.
Drupal.org has received that data for many years. You can see how it is used in the statistic data on module usage section on project pages.
You can opt not to send the data by disabling the update module. But I’d prefer if you didn’t - good quality data on usage improves the quality of contribution.
For the announcements feed, if that is not something you want, disable the announcements module. The feed will go away.
The announcements module is only enabled by default on newly installed sites, not upgrades.
As it happens, the inclusion of the announcements module as a default in new sites was announced in https://www.drupal.org/blog/drupal-10-2-0 → — always a good reason to follow the feed!
Given this has been in production for some time as an applied patch, I'm sure we can apply it to the repo!
We have all been testing it.
I like it. If someone can test that this is now working, describing the steps they took to test it, I'll merge it.
Tested this as part of upgrading simplytest.me to d10 and does appear to resolve all of the d10- prerequisites.
A release would be awesome to move onto he next stage...
Consider also the size of the “Mentor box” in which they should ideally be packed.
It’s good to keep everything together.
I do like the idea of splitting log output into multiple sections.
We currently log a huge number of items where we are tracking hit repos and it makes the log a little unusable. Difficult to scroll and find important stuff.
See:
just updating Issue summary
rachel_norfolk → created an issue.
I’m unclear what this issue is raising here. What is the expected behaviour and what is actually happening?
This must be outdated! ;)
As stm no longer has a /qa page, we don’t have this incorrect info any more. The old domain names don’t seem to be mentioned elsewhere.
Marking as requiring more info from reporter
I think this issue may have applied to a very old release of stm. I’m very happy to be proven wrong but things seem correct now.
I believe a private files area is now defined. Can you retest and confirm?
If still an issue, please give detail and set the issue as Active. If we hear nothing in four weeks, we will assume resolved and close. Thanks.
I believe the large number of changes made to stm over last couple of years will have resolved this specific error.
If you can reproduce the “113% error”, please mark this issue as active. After four weeks, I’ll mark it as closed (outdated) as we try to get some focus in this issue queue.
Thanks
added GitHub PR https://github.com/simplytestme/website/pull/315
The most basic answer to that question is if it is listed in Packagist, then you can simply reference it. Even if it is a js library
If not, it get more complicated.
I believe this issue is discussing an animation on the header of a Drupal 10 site in the default Olivero theme. Whilst that is something that might need examination, it is not part of the simplytest.me system.
I suggest checking out the Drupal core issue queue → . There appear to be a couple of relevant issues already created.
So, for D8 and beyond, that is achieved through dependencies declared in the module’s composer.json file and we know that is working in stm.
Are you specifically needing drush make dependency support for D7 or something?