- There are messages displayed if config is overriden in the settings.php file (so that site builders don't get confused why the config change in the GUI doesn't have an effect). That should work together somehow, and look consistent.
-- yes, I would suggest the code sits alongside that, too. - If something is in config ignore, then it also shouldn't show up - or show up with a different message?
-- very good point! Should be a reasonably easy check to make, I expect - This shouldn't show up on a development site because it would drive site builder crazy. May a toggle to turn it off, that can be overridden in a local settings.php file?
-- yeah, I was thinking we could have a option in the development section of admin that is turned off by default - a site owner only turns it on for prod sites, if they want. - The wording of the message: This is also relevant for projects that don't have a dev team - as long as there is a separate copy of the site for development and exporting config. Something like "This configuration should better be changed in the development environment and then exported. Otherwise they will be reverted back during the next config import."
- And maybe... and option for an extra field for whom to contact if this really needs changing on prod to ensure it doesn't get lost?
-- yeah - another option in the development area, I would suggest, though I guess the whole text could be overidden just like any text can be overridden in the site.
The code above actually works, Tony. It inspects what base classes the form is implementing and can make a prediction of whether it will affect running config from that. This means it even works on contrib modules!
mradcliffe → credited rachel_norfolk → .
updating vienna names
mradcliffe → credited rachel_norfolk → .
rachel_norfolk → created an issue.
Note: BlockListBuilder extends ConfigEntityListBuilder and that ’s probably worth looking out for, rather than the special case of blocks.
Playing around with this a little and the following working “pseudo code” (i.e. please don’t actually use this as is - it is just to test ideas) gives the idea of what I’m thinking:
function xx_form_alter(&$form, FormStateInterface $form_state, $form_id) :void {
// Get out of here if it is not an admin form.
if (!\Drupal::service('router.admin_context')->isAdminRoute()) {
return;
}
// We need an actual object rather than just a jumble of array items.
$form_object = $form_state->getFormObject();
// Assume forms have no config to begin with.
$has_config = FALSE;
// Does the getEditableConfigNames method exist on the form?
if (method_exists($form_object, 'getEditableConfigNames')) {
$has_config = TRUE;
}
// Are we editing an entity that has config form for it's setup?
if ($form_object instanceof EntityForm) {
$entity = $form_object->getEntity();
if ($entity instanceof ConfigEntityInterface && !$entity->isNew()) {
$has_config = TRUE;
}
}
// Permisions being permissions.
if ($form_object instanceof UserPermissionsForm) {
$has_config = TRUE;
}
// Blocks being blocks.
if ($form_object instanceof BlockListBuilder) {
$has_config = TRUE;
}
// Okay, warn people.
if ($has_config) {
\Drupal::service('messenger')->addWarning(t("This form is likely to alter the running configuration of the site and, therefore, changes should probably go through the development quality processes."));
}
}
Adding an option for the warning to include a custom message.
Adding link to Config Override Warn as inspiration
rachel_norfolk → created an issue.
changes needed
- add step to set status of new cloned issue to Active
rachel_norfolk → created an issue.
Thank you all!
I tell you what, lostcarpark, let me run this meeting to test the script above, then you can test any changes we make next month?
adding contributors
Following the notes for the meeting next week as testing...
just editing slightly as I think we said it was me looking at GitLag, not Chris?
rachel_norfolk → created an issue.
adding that spreadsheet structure to get us started... https://docs.google.com/spreadsheets/d/1WdwP4fFr2k2ADOTWB59w1evjdf6djAdB...
rachel_norfolk → created an issue.
Just a note that this change would be an absolute gift to those who like to game the credit system
I do love the seemingly random way component is set as we move issues between projects ;-)
As we are happy as a team to progress this, it seems time to move into the core project so someone can make an MR.
mradcliffe → credited rachel_norfolk → .
Just formatting the tag correctly so it gets counted along with all the others.
I would be delighted to add James to our list. He is bringing exactly what makes mentoring successful.
chrisdarke → credited rachel_norfolk → .
Who authored the node? I can’t remember.
mradcliffe → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
mradcliffe → credited rachel_norfolk → .
Hi - did you mean to post this here? This is not a support issue queue.
I suggest you ask the question on the Drupal Slack Drupal.org/slack
I hope you don’t mind me saying, sarveetsingh, but that is a really well written test comment. Contains everything it should. Nice work!
mradcliffe → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
Adding credit for Ángela Saldaña Contreras who made the logo actually work for us!!!
That’s good news, sali38, and much appreciated!
For the record, there seem to be a number of other related projects with the same restriction claimed.
rachel_norfolk → created an issue.
They will quite possibly have a Bash CLI. Especially if they are a new user, though, it may not be clear at all that they need to use it.
rachel_norfolk → created an issue.
Did a little chasing and slashrsm very kindly pressed all the right buttons. Thank you Janez!
Urgh - as I’m not a maintainer, I can’t give them the credit they deserve...
Gonna contact a couple of the maintainers and see what we can rustle up..
Events insurance purchased via www.events-insurance.co.uk. Insurance certificate in the Venue folder on google drive.
rachel_norfolk → created an issue.
Feels like this is complete - after all, drupalcampengland.org
Okay, let’s get this moving…
On February 14th, we will update the list according to these rules:
- If you have positively indicated you will take an active part i the running of the core mentoring program and have participated in running meetings etc in the last nine months, you stay in the list
- If you have not positively indicated you intend to do so, we will remove you from the list and say thank you for all of the work you have done to this point.
Thanks
As it happens, I’ve archived the OpenCollective entities, rather than deleted them. Maybe we will use them in the future.
I guess we no longer need this now we have the CIC.
I’ll shut down the OC bits and pieces and close this ticket now, I think.
avpaderno → credited rachel_norfolk → .
mradcliffe → credited rachel_norfolk → .
mradcliffe → credited rachel_norfolk → .
mradcliffe → credited rachel_norfolk → .
mradcliffe → credited rachel_norfolk → .
Okay, let’s give this a test!
I’ve rolled the test out to https://rachelnorfolk.me and it does appear in the list of meta tags in head.
Exporting meta tag configuration does appear to work correctly.
Articles posted on a correctly configured account do appear to give attribution correctly. See https://norfolk.social/@rachel/113640387689376743
Looks great to me!!
rachel_norfolk → created an issue.
removing ‘singapore’ tag on this old issue so it doesn’t confuse contributors at DrupalCon.
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
liampower → credited rachel_norfolk → .
Adding credit for all those at the meeting - if I missed you, add yourself!
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
Rachel to find a suitable host and report back exact costs and requirements.
Noted that we will look into our own entity, bank account etc if no suitable host found
OpenCollective doesn’t charge for the platform but there are a number of fiscal hosts in the system, which might.
https://platform6.coop/oc-terms-of-service provides an OC fiscal host that might suit us as they like to see projects move to their own bank account within the year, which suits us, and the costs are very low - basically just the Stripe transaction costs
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
rachel_norfolk → created an issue.
I’m going to assume you didn’t mean to change the status, Dave.weiner?
and trying again - it’s persistent today ;-)
updating my attribution
xjm → credited rachel_norfolk → .
Just keeping the active threads…
: Roll Call! Who’s here today? Comment in a thread here to introduce yourself, include your drupal.org name, and if you're up to answering an icebreaker, what is your vehicles name (if you name it)?
10 replies
Rachel Lawson
9 Oct at 21:15
Rachel here from UK. Rachel_norfolk and my motorbike is called Hedy Lamarr
:kitty-thumbsup:
1
Tim Lehnen
9 Oct at 21:16
Tim from the DA
hestenet
The license plate on my track car is 'NARNIA' :slightly_smiling_face:
:pirateparrot:
1
AmyJune Hineline (volkswagenchick)
9 Oct at 21:29
AMyJune, Oakland, CA - USA volkswagenchick
Um, so my volkswagen is named Deacon
:pirateparrot:
1
Tim Lehnen
9 Oct at 21:29
Deacon :heart_eyes:
James Shields (lostcarpark)
9 Oct at 21:44
James from Ireland (lostcarpark). Our car doesn't have a name, but one of my bicycles is called Sylvester.
:pirateparrot:
2
:black_cat:
1
Mark Casias
10 Oct at 00:09
markie here.. My Volkswagen is called... ummm... car? I don't know..
:pirateparrot:
1
Kristen Pol
:palm_tree: 10 Oct at 06:04
Kristen :wave: California... haha... I don't have a name for my car but I know someone who used to have a name for his and it was called the "Brown Hornet" and it was an old car that he hand painted in thick muted (think 60s/70s colors) stripes at an angle... he had a racing harness in the car so he would race it at local non-professional races... he got pulled over a lot by police because of the paint job
:pirateparrot:
1
Gregg Marshall
10 Oct at 18:57
Gregg Colorado, car is nameless
:pirateparrot:
1
Amanda Marshall
10 Oct at 19:04
Amanda, Amarshall My car is named Chloe
:pirateparrot:
1
Monet Fort
10 Oct at 21:06
Monet Fort from Atlanta GA, monet-fort on drupal.org. My Honda sedan is named Bender. Because I bent him.
:pirateparrot:
1
DrupalCon Barcelona - we had a great time! Tell us, what went well, what can we improve on?
10 replies
Tim Lehnen
9 Oct at 21:18
Thank you everyone for what you were able to do! Sorry I wasn't there directly, but I've heard only good things
:blue_heart:
1
Rachel Lawson
9 Oct at 21:19
It was fab for Dries to be able to spend significant time at the tables chatting with people. They were so thrilled
The live commit went really well. Thanks
@xjm
Bit challenging how we had to rush in and out at specific times for coffee and food
:heart:
2
Rachel Lawson
9 Oct at 21:24
How is the leg, Tim?
Tim Lehnen
9 Oct at 21:26
Pin came out a week ago! I've been able to walk with a boot and get out some. Big relief.
:heart:
5
Rachel Lawson
9 Oct at 21:35
We need to get into the early comms about the event how the contrib day is absolutely a day to be at the conference. Think we had too many flying that day
James Shields (lostcarpark)
9 Oct at 21:46
Personally I think they should make Thursday contrib day, and put Driesnote on Friday!
:sunglasses:
3
21:50
I was disappointed a copy of the new roll-up banner didn't get produced. I'd tried bringing it up a couple of times, but I was hit by Covid in August, so my ability to nag people was greatly reduced. Also, one of the people I'd have been nagging would have been Tim, who was also incapacitated.
21:52
The live commit was fantastic. I was mentoring someone on a potential issue for it, but she had to go for her flight. But her issue got merged the week after, so another success!
:heart:
2
Kristen Pol
:palm_tree: 10 Oct at 06:06
We seemed to have ample mentors for a change which was nice... I feel like maybe less people (ratio wise) were in the mentored room vs general contribution area... but my understanding is the European event attendees are generally more technical and people with more experience
Rachel Lawson
10 Oct at 08:48
You are probably correct there, Kristen. But it does mean there is an opportunity to attract more 1st timers
:+1:
2
: :one:: https://www.drupal.org/project/drupal/issues/3454075
:two:: :two:: We have follow up tasks, with regard to reaching out to each member on the Maintainers.txt to check current status
4 replies
Rachel Lawson
9 Oct at 21:23
How long do we want to leave for this now? We have asked questions but I think we have enough answers to create the MR now?
AmyJune Hineline (volkswagenchick)
9 Oct at 21:30
My status is still the same in the issue ;(
:sad-panda:
1
James Shields (lostcarpark)
9 Oct at 21:57
If you are looking for new mentoring coordinators, I would be happy to be added. I still feel a bit of a noob, so would need some mentoring.
:blue_heart:
2
AmyJune Hineline (volkswagenchick)
9 Oct at 22:01
I +1 to James becoming provisional.
1 reply
James Shields (lostcarpark)
10 Oct at 00:53
Is it one issue for each meeting type? Ive started one for the Slack meetings. Can someone advise if it's on the right track?
https://www.drupal.org/project/mentoring/issues/3479788
Rachel Lawson
9 Oct at 21:27
:five:: DrupalCon Singapore 2024 - 2024.12.09 - 2024.12.11 - Contribution day is 12.11.
:five:: :one:: DrupalCon Singapore - who's planning on attending?
:no_party:
1
5 replies
Rachel Lawson
9 Oct at 21:28
I’m afraid I defiantly can’t make it to this one. :disappointed:
Tim Lehnen
9 Oct at 21:29
Neil will be there from the eng team.
:blue_heart:
1
Rachel Lawson
9 Oct at 21:30
As it happens, I’m sending nine of my team. But, because I’m sending them, someone has to stay home!
:blue_heart:
2
James Shields (lostcarpark)
9 Oct at 22:03
Sadly I don't think I'll be able to.
Kristen Pol
:palm_tree: 10 Oct at 06:07
Don't plan on it as it would be out of pocket and expensive
michael anello
Sunday at 15:58
Hoping. I am doing a training there as long as enough seats are sold to pay my way.
:pray:
2
xjm
Monday at 18:08
I booked my travel over the weekend... well most of it
:pirateparrot:
1
Anto Jose
Tuesday at 05:41
I'll be there.
:pirateparrot:
1
:tada:
1
xjm
Tuesday at 15:53
So that is me, Anto, and Mike so far :crossed_fingers:
:crossed_fingers:
2
Rachel Lawson
9 Oct at 21:32
:six:: Open floor/other topics. Please start a new thread.
4 replies
Mark Casias
10 Oct at 00:12
we doing anything for BADCamp?
Kristen Pol
:palm_tree: 10 Oct at 06:07
Luke said he'd like to have a contribution day on Friday
:heart:
1
06:08
I'll be there
Luke McCormick
10 Oct at 07:01
I don't want to promise too much -- we're only two weeks away! -- but if there are going to be mentors in the house, we'll do what we can to make use of that. DM me if you have particular thoughts or needs. (Or just to say "hi" :slightly_smiling_face: )
Awesome, thanks Sagar. Can you repeat the test looking at the page via the Claro theme? Then, if successful, set the status to Reviewed and Tested by the Community?
Removed Needs Change Record tag.
Ran the MR in simplytest.me and it is applying the sort order to fields, as expected.
I think we are finally good to go...
added some alt text to the draft change record screenshots.
@nidash: can you say which section of the page you are actually following? Is this for simplytest.me, drupalpod, or some other way of testing?
Also, your comment below says "drupal/core 1.0.0 (exact version match: 1.0.0 or 1.0.0.0)” but that would imply Drupal 1? Did you copy that correctly?