๐Ÿ‡ฎ๐Ÿ‡ณIndia @sarvjeetsingh

Account created on 29 January 2020, about 5 years ago
  • Backend Engineer at QED42ย 
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia sarvjeetsingh

I have addressed the following issue in the last MR:

  • Add another option to the Form that allows for an 'Inline' placement
  • Refactor deepchat-init.js to only include functionality related to the chat itself and separate functionality related to the placement and toggling of the 'bottom left/right' assistant to its own .js file.

Pending:
(and any other styles, gin dark and claro style)

This requirement needs further clarification.

Kindly review the changes and share guidance on the above point.



๐Ÿ‡ฎ๐Ÿ‡ณIndia sarvjeetsingh

sarvjeetsingh โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sarvjeetsingh

sarvjeetsingh โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sarvjeetsingh

I have tested the fix and confirmed that the "Reversed" and "First and last only" checkboxes are now being saved correctly.

Steps I followed to test:

  • Added a field to a content type with multiple values.
  • Created a View and added the field.
  • Configured the Multiple Field Settings in Views.
  • Checked and saved the "Reversed" and "First and last only" options.
  • Revisited the form to confirm that the selections were retained.
  • Verified no errors in logs.

The issue is now resolved as expected. Marking this as RTBC.

Addressed #49 as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia sarvjeetsingh

Hi @lauriii,

I attempted to reproduce the issue, but the context menu seems to be working correctly for both code components and library components.

I've attached screenshots for reference. Could you please provide more details if the issue persists on your end or if there are specific steps where it fails?

Looking forward to your insights!

๐Ÿ‡ฎ๐Ÿ‡ณIndia sarvjeetsingh

The patch is same as #113, re--rolled it for 8.x-1.0-rc17

Production build 0.71.5 2024