Contrib.social

refactor switch() in Drupal\views\Plugin\views\sort\Date to match()

Open on Drupal.org →
Created on 2 January 2025, 3 months ago

Problem/Motivation

Drupal\views\Plugin\views\sort\Date::query() has a switch() statement that could be rewritten as a match().

match() is easier to read, and has less potential for bugs because of the lack of break; statements. This is particularly relevant in this case, as the switch() mixes breaks and returns.

This is postponed on ✨ Add weekly granularity to views date sort Needs work which is also making changes here.

Steps to reproduce

Proposed resolution

Replace switch() with something like:

$formula = match () {
// seconds and default return NULL
}

if ($formula) {
    $this->query->addOrderBy(NULL, $formula, $this->options['order'], $this->tableAlias . '_' . $this->field . '_' . $this->options['granularity']);
}
else {
        $this->query->addOrderBy($this->tableAlias, $this->realField, $this->options['order']);
}

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Postponed

Version

11.0 🔥

Component

views.module

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024