Singapore
Account created on 15 January 2009, about 16 years ago
#

Merge Requests

More

Recent comments

🇸🇬Singapore anish.a Singapore

Moving back to active, as dependent issue was fixed.

🇸🇬Singapore anish.a Singapore

Access is revoked now. That's good.

🇸🇬Singapore anish.a Singapore

Thank you. That helps. Will send an initial MR soon.

🇸🇬Singapore anish.a Singapore

I need some guidance on it. One lodash function we use is debounce. Are we supposed to create a new custom debounce function?

🇸🇬Singapore anish.a Singapore

Should we close this issue since 2.x is released?

🇸🇬Singapore anish.a Singapore

Adding related issue so that the link is present.

🇸🇬Singapore anish.a Singapore

I can't reproduce it now either.

🇸🇬Singapore anish.a Singapore

anish.a made their first commit to this issue’s fork.

🇸🇬Singapore anish.a Singapore

@joachim Should I create another issue for the same?

🇸🇬Singapore anish.a Singapore

Removed unwanted code. Tests are passing.

🇸🇬Singapore anish.a Singapore

Test failure was a random error. Now working fine.

🇸🇬Singapore anish.a Singapore

Merge request is updated to 11.x branch. It has a test failure though. Needs further analysis.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-add-weekly-granularity to hidden.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-add-weekly-granularity to active.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-views-weekly-granularity to hidden.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-views-weekly-granularity to active.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-add-weekly-granularity to hidden.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 11.x to hidden.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-add-weekly-granularity to active.

🇸🇬Singapore anish.a Singapore

I was trying to rebase with 11.x. Some functions are deprecated. Not sure which way should I go to fix this.

🇸🇬Singapore anish.a Singapore

anish.a made their first commit to this issue’s fork.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3246454-add-weekly-granularity to hidden.

🇸🇬Singapore anish.a Singapore

anish.a made their first commit to this issue’s fork.

🇸🇬Singapore anish.a Singapore

Adding screenshot of working module from D11.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3434141-automated-drupal-11 to hidden.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch project-update-bot-only to hidden.

🇸🇬Singapore anish.a Singapore

Drupal 11 compatibility is already in 1.x-dev and this issue is outdated. We just need a release.

🇸🇬Singapore anish.a Singapore

There is a call to deprecated function getEntityTranslation. This needs to be fixed.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3495766-drupal-11-compatibility to hidden.

🇸🇬Singapore anish.a Singapore

Can we do a release for Drupal 11 compatibility?

🇸🇬Singapore anish.a Singapore

Adding the fix. Empty string instead of NULL fixes the warning.

🇸🇬Singapore anish.a Singapore

I am using 2.0.0-beta5.

I am not sure whether it happened after the beta. I think I selected some wrong options and got locked out of the page.

These are the warnings I was seeing in the Drupal messages.

Warning: Undefined array key "#row" in Drupal\entityreference_filter\Plugin\views\filter\EntityReferenceFilterViewResult->processOptions() (line 211 of modules/contrib/entityreference_filter/src/Plugin/views/filter/EntityReferenceFilterViewResult.php).

Error message
Warning: Attempt to read property "_entity" on null in Drupal\entityreference_filter\Plugin\views\filter\EntityReferenceFilterViewResult->processOptions() (line 211 of modules/contrib/entityreference_filter/src/Plugin/views/filter/EntityReferenceFilterViewResult.php).

I tried debugging and found that this is getting as $renderable in processOptions. This obviously is not the array it is expecting.

Array
(
    [0] => views_view__entity_reference_view__entityreference_4
    [1] => views_view__entityreference_4
    [2] => views_view__default
    [3] => views_view__entity_reference_view__default
    [4] => views_view__default
    [5] => views_view__entity_reference_view
    [6] => views_view
)

I am stuck here. Sending the configuration file for the view.

🇸🇬Singapore anish.a Singapore

From what I read, the code can be removed. Let me reproduce the issue on Drupal 9.0.x.

🇸🇬Singapore anish.a Singapore

Adding the reference issue.

🇸🇬Singapore anish.a Singapore

You just removed that comment!

What was the context for the comment? What change was needed?

🇸🇬Singapore anish.a Singapore

I had submitted a rough draft and I need some help on finishing it.

🇸🇬Singapore anish.a Singapore

Changing the status and assigning to me as I am continuing working on this.

🇸🇬Singapore anish.a Singapore

Created a draft MR. I still need to fix the dependency injection errors, continuing the work.

🇸🇬Singapore anish.a Singapore

I am taking this up. I will push the changes on what I had done by today itself.

🇸🇬Singapore anish.a Singapore

@rahul_ Can you push the WIP in the branch, so that I can take a look.

🇸🇬Singapore anish.a Singapore

Working on this

🇸🇬Singapore anish.a Singapore

@lavanyatalwar It is already being worked on by @rahul_ in DrupalCon Singapore and he is already in finishing stages. I suggest to take up another issue to avoid duplicate work.

🇸🇬Singapore anish.a Singapore

Tests are missing and we need to write tests to verify the functionality.

🇸🇬Singapore anish.a Singapore

This will work only after the related issue is fixed.

🇸🇬Singapore anish.a Singapore

I am taking it up.

🇸🇬Singapore anish.a Singapore

FYI, these are the errors

 30/30 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------ 
  Line   quicktabs_accordion/src/Plugin/TabRenderer/AccordionTabs.php                  
 ------ ------------------------------------------------------------------------------ 
  54     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   quicktabs_jqueryui/src/Plugin/TabRenderer/UiTabs.php                          
 ------ ------------------------------------------------------------------------------ 
  27     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Controller/QuickTabsController.php                                             
 ------ ----------------------------------------------------------------------------------- 
  48     Unsafe usage of new static().                                                      
         💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Form/QuickTabsInstanceEditForm.php                                             
 ------ ----------------------------------------------------------------------------------- 
  49     Unsafe usage of new static().                                                      
         💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   src/Plugin/Block/QuickTabsBlock.php                                                
 ------ ----------------------------------------------------------------------------------- 
  50     Unsafe usage of new static().                                                      
         💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ----------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/Derivative/QuickTabsBlock.php                                      
 ------ ------------------------------------------------------------------------------ 
  18     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/TabRenderer/QuickTabs.php                                          
 ------ ------------------------------------------------------------------------------ 
  74     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/TabType/BlockContent.php                                           
 ------ ------------------------------------------------------------------------------ 
  67     \Drupal calls should be avoided in classes, use dependency injection instead  
  69     \Drupal calls should be avoided in classes, use dependency injection instead  
  75     \Drupal calls should be avoided in classes, use dependency injection instead  
  81     \Drupal calls should be avoided in classes, use dependency injection instead  
  97     \Drupal calls should be avoided in classes, use dependency injection instead  
  98     \Drupal calls should be avoided in classes, use dependency injection instead  
  121    \Drupal calls should be avoided in classes, use dependency injection instead  
  122    \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/TabType/NodeContent.php                                                                                  
 ------ -------------------------------------------------------------------------------------------------------------------- 
  35     \Drupal calls should be avoided in classes, use dependency injection instead                                        
  60     \Drupal calls should be avoided in classes, use dependency injection instead                                        
  62     Method Drupal\quicktabs\Plugin\TabType\NodeContent::render() should return string but return statement is missing.  
  64     \Drupal calls should be avoided in classes, use dependency injection instead                                        
  70     \Drupal calls should be avoided in classes, use dependency injection instead                                        
 ------ -------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/TabType/QtabsContent.php                                           
 ------ ------------------------------------------------------------------------------ 
  27     \Drupal calls should be avoided in classes, use dependency injection instead  
  48     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/TabType/ViewContent.php                                            
 ------ ------------------------------------------------------------------------------ 
  76     \Drupal calls should be avoided in classes, use dependency injection instead  
  81     \Drupal calls should be avoided in classes, use dependency injection instead  
  86     \Drupal calls should be avoided in classes, use dependency injection instead  
  89     \Drupal calls should be avoided in classes, use dependency injection instead  
  102    \Drupal calls should be avoided in classes, use dependency injection instead  
  180    \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

 ------ -------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/views/style/Quicktabs.php                                                                                
 ------ -------------------------------------------------------------------------------------------------------------------- 
  5      Interface Drupal\Core\Form\FormStateInterface referenced with incorrect case: Drupal\core\form\FormStateInterface.  
 ------ -------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 29 errors                                                                                                
                                                                                                                        

🇸🇬Singapore anish.a Singapore

anish.a made their first commit to this issue’s fork.

🇸🇬Singapore anish.a Singapore

Removing Needs Screenshots

🇸🇬Singapore anish.a Singapore

I think this fixes the issue mentioned and we can raise a feature ticket for Adding custom field for title. Let me create a ticket and link to this.

🇸🇬Singapore anish.a Singapore

anish.a changed the visibility of the branch 3241489-fix-fullcalendarfieldisdate-re to hidden.

🇸🇬Singapore anish.a Singapore

Updating the branch as its still present in latest DEV

🇸🇬Singapore anish.a Singapore
For MacOS

$ cd /path/to/drupal/root
$ drush cex -y
$ cd /path/to/config
$ for f in $(ls core*title.yml); do sed -i '' 's,^required: false,required: true,' $f; done
$ drush cim -y
🇸🇬Singapore anish.a Singapore

I represented Drupal Thiruvananthapuram Community as a panelist.

🇸🇬Singapore anish.a Singapore

I am able to reproduce this issue. Will try to reproduce with only Core, Registration and Conditional Fields

🇸🇬Singapore anish.a Singapore

Removing needs-reroll as it is already rerolled.

🇸🇬Singapore anish.a Singapore

There are test failures. I am unsure about how to fix it.

🇸🇬Singapore anish.a Singapore

We are taking up this issue in DrupalCampPune2024

🇸🇬Singapore anish.a Singapore

Just changing core version won't work

🇸🇬Singapore anish.a Singapore

The issue raised by heikkiy is already addressed by issue #3269746. This works fine and can be merged.

🇸🇬Singapore anish.a Singapore

This can be merged. Tested and working fine

🇸🇬Singapore anish.a Singapore

Any pointers to fix the issue where -Any- appears last?

🇸🇬Singapore anish.a Singapore

Adding a custom migration yml file that I used to test this.

🇸🇬Singapore anish.a Singapore

Adding more details.

Please see the attached screenshot. Eventhough the D7 site has fields populated, The source comes out as empty. I checked using debugging turned on.

Not sure how to proceed further.

🇸🇬Singapore anish.a Singapore

I am facing the same issue. How did you fix that?

🇸🇬Singapore anish.a Singapore

I was having same issue with the webform_validation. I had to manually downgrade views_templates module also.

🇸🇬Singapore anish.a Singapore

It would be good if you can merge and make it compatible to D10.

🇸🇬Singapore anish.a Singapore

I apologize for the same. I had to use drush generate to generate the module and forms. This was developed for the usage in multiple websites for a client and we decided to publish it so that others can benefit.

I understand that the module is too small to opt into security coverage. So, I am closing the task.

🇸🇬Singapore anish.a Singapore

Sorry, I don't have any other modules/themes listed in drupal.org. Is there any approximate number of lines in the code to qualify for a review?

Production build 0.71.5 2024