Fix fullcalendar_field_is_date() re: non-entity Views fields (e.g. 'Custom text')

anish.a → made their first commit to this issue’s fork.

Updating the branch as its still present in latest DEV

anish.a → changed the visibility of the branch 3241489-fix-fullcalendarfieldisdate-re to hidden.

Tested the issue and is ready for merge.

Thanks, this is a good thing to catch!

I got a white screen when adding a custom field without this patch when going to a view where a custom text field had been added, so it's more than an AJAX error.

While this does allow for a custom field to be added to a FullCalendar view without erroring out, the field cannot be used for the title. I'm not sure what other use case there is for one. Contents of a modal popup?

This technically solves the issue, but either a child issue should be created to address using a custom text field as the title or this should be changed to needs work. I haven't looked at the code at all.

FYI - it's not up to community norms to list your own work as RBTC, the idea behind it is that someone else confirms it works (hence the by the community part). :)

I think this fixes the issue mentioned and we can raise a feature ticket for Adding custom field for title. Let me create a ticket and link to this.

Makes sense to me. :)

This was broken by this commit, which was committed directly to the repo without a d.o issue.

I discussed this with @anish.a at DrupalCon, and while I suggested that he add test coverage, there are no tests in the module that I could find!

Bumping priority to major and assigning to @mandclu

I don't think removing the type declaration is the right approach here. I've added a commit that adds it back, but adds Custom as an additional, accepted type. This also resolved the reported error in my testing, but please verify.

Tested the issue branch with mandclu's commit and custom fields can be added to the view without errors and the view renders fine in Drupal 10.3.

That does look like a better approach to scope it. :)

Great! Merged in

Automatically closed - issue fixed for 2 weeks with no activity.