@dieterholvoet I fully support your application to be a co-maintainer, and would appreciate your help. Unfortunately, I do not have access to manage maintainers.
I was added as a maintainer by eme → in #3175187: Offering to co-maintain Form mode control → so it seems the best path forward is to contact him.
Thanks for your work on this! My only concern is that only updating the order in the scheduler won't fix how the time slots are order elsewhere, particularly the schedule. So we should either make sure the schedule has the proper sort defined, or have this updte the order of the taxonomy terms themselves
seantwalsh → credited mandclu → .
phenaproxima → credited mandclu → .
matthews → credited mandclu → .
I'm tempted to say this is expected behavior (knowing how core works) , but I can appreciate that from a site builder viewpoint this would be unexpected.
I'm tempted to say that this should be a feature request, to provide a means (maybe automatic?) to reset the ordering for a taxonomy vocabulary when the generator is run.
matthews → credited mandclu → .
At some point it might be helpful to have a release of this module that required Devel >= 5.4.0 and the main Kint module
Thanks for identifying this, and for providing a fix. Merged in.
volkswagenchick → credited mandclu → .
mandclu → created an issue.
mandclu → created an issue. See original summary → .
I have a project that started throw 15 phpcs errors of the exact type mentioned in the IS and also one other, all in .yml files. I can't personally see what useful feedback we would get from running a php check against .yml files.
This was addressed in previous commits, in particular New and updated block placement
Moving this to Event Platform since the cause probably needs a fix in the config page admin labels.
Also, updating the IS to reflect the new understanding, as well as the fact that the order of the fields has changed.
seantwalsh → credited mandclu → .
seantwalsh → credited mandclu → .
Ironic to have a typo in the issue name lol
mandclu → created an issue. See original summary → .
jdleonard → credited mandclu → .
Adding a patch for composer patching
Question: are you testing the same ics file for both Apple Calendar and Outlook? By design this module generates an ics already optimized for Outlook if you click the Outlook link, so it should already be doing a lot of the things in the linked PR.
The change actually broke the all day tests, so I updated the test. I verified that core date-only ranges store the start and end as the same value for single-day events, so the upside is that the test data now matches that.
I also left one test with different start and end dates, but updated the expected markup to reflect a two-day event. I thought it made sense to have test coverage of a multi-day event.
I've manually verified the updated links in Google and Apple Calendar, but still need to verify them with Outlook.
After some additional testing, it turns out that the previously cited issue about all day events including times was specific to core date fields, and is actually an upstream bug with Smart Date. It has been fixed in 🐛 Core date-only fields should always show as all day Active .
Updating this issue to focus on "adding one day", which still needs to be fixed here.
I'm not entirely sure we shouldn't also be applying some form of conversion for core datetime values, but the changes here do address the specific problem with date-only fields.
@jonathanshaw thank you for all your work on this. Merged in, and I will try to get a new release out shortly.