Account created on 9 March 2006, almost 19 years ago
  • Senior Solutions Engineer at Acquia 
#

Merge Requests

More

Recent comments

🇨🇦Canada mandclu

Great! Merged in, and I will roll a new release.

🇨🇦Canada mandclu

We shouldn't move away from using dependency injection. Please review MR!3 and let me know if this resolves the original error.

🇨🇦Canada mandclu

mandclu made their first commit to this issue’s fork.

🇨🇦Canada mandclu

I'm not sure I understand. Are you assuming that the events created will repeat weekly?

🇨🇦Canada mandclu

We didn't have anyone from the later timezones on the last call, so we'll try having the next one at 9:30am EST, on Jan 8. Hopefully that won't be too early for the folks on CST.

🇨🇦Canada mandclu

The tricky thing is that the last meeting included at least one person from a PST timezone, and moving the meeting 1h 30m earlier would make the meeting 6:30am for them. I'm happy to revisit the question of the timing, and we could also potentially look at alternating between early times (that would work better for EU folks) and late meetings (that would work better for Pacific / APJ folks)

🇨🇦Canada mandclu

To be clear, Fast.ly is a global CDN, with a variety of Points of Presence within the EU as well as other parts of the world, so it still isn't clear to me why the assets need to originate only within the EU.

🇨🇦Canada mandclu

@wattdesigns have you tried applying the patch? The goal of this issue is really to figure out how we can get the core Views functionality to work the way the Views UX promises it will, e.g. creating a menu item when asked. I agree with your experience, I have not been able to simply set the menu item to "already exists" and have it work as intended with the tabs.

🇨🇦Canada mandclu

As of 📌 Enable privacy app when applying Event recipe Active the map tiles are not loaded automatically, unless the user explicitly chooses to load them, or their privacy settings have been changed to load third-party content. To my thinking, that should address GDPR concerns, at the very least. Is this change still needed?

🇨🇦Canada mandclu

Based on some initial investigation, this Github project seems promising, and the result UX is pretty painless, especially since it can store the preferred instance. Share2Fedi is another popular option, using either an existing hosted instance or potentially we could spin up a new instance somewhere, following the hosting instructions. Another possibility would be some kind of integration with Drupal's ActivityPub module , but that would require some investigation.

🇨🇦Canada mandclu

I wonder if maybe this is too close to a standard calendar icon? My hesitation is that currently the Event Platform doesn't actually use a calendar display, and if anything is more organized around the idea of a session agenda. Any thoughts on how we could convey that visually?

🇨🇦Canada mandclu

I don't think removing the type declaration is the right approach here. I've added a commit that adds it back, but adds Custom as an additional, accepted type. This also resolved the reported error in my testing, but please verify.

🇨🇦Canada mandclu

mandclu made their first commit to this issue’s fork.

🇨🇦Canada mandclu

This reminds me of #3172696: Search API-made exposed forms are not styled within Olivero , maybe it's time to revisit that. Olivero has some really nice search styling out of the box, but it hasn't played nicely with Search API.

🇨🇦Canada mandclu

@cosmicdreams can you provide code examples of the current, generated markup, as well as what you are proposing?

🇨🇦Canada mandclu

We had a good discussion today, but I have a feeling not everyone who wanted to participate in the discussion was able to, potentially because of scheduling issues. I have opened a thread to discuss an alternate time for future meetings: 📌 Set time and time for future meetings Active

🇨🇦Canada mandclu

Since maintainers of the Recipes system are adamant that recipes are always applied and not installed, I am not in favour of the Project Browser using terminology that will ultimately cause confusion. If we expect people to use this interface as part of their first experience of Drupal, it should not be sending people down the wrong path in understanding how to think about how it all works. So, a -1 for me on "Install" as a label.

I also agree that as we think about other things (like components) that could be made available through the project browser, "Install" makes less sense. I think "Add to Site" as a button label is generic enough.

🇨🇦Canada mandclu

I added a couple of lines to the README in the new 1.1.x branch.

🇨🇦Canada mandclu

I'm good with the second option.

🇨🇦Canada mandclu

The ability to exclude the default time display was implemented in Provide an option to exclude time display Active and the title field rewriting was recently fixed in 🐛 Render re-written title fields Active , so the suggested fix of excluding the default time display and rewriting the title field to include a formatted time should now be possible.

🇨🇦Canada mandclu

Merged in, and will roll a new release with this shortly.

🇨🇦Canada mandclu

@roromedia Thanks! That is indeed exactly what was needed.

🇨🇦Canada mandclu

I believe I have see talk about a config action to add dashboard items from a recipe, maybe something along those lines could be a stopgap until there's a way to have a more sophisticated display of related recipes in project browse

🇨🇦Canada mandclu

In testing I did identify an issue (and have released a fix) with the way the geocoder is defined in the Locations recipe. Please grab the latest version and try it again.

🇨🇦Canada mandclu

Sounds like this is working as expected now, so closing. Feel free to reopen if more work is needed.

🇨🇦Canada mandclu

@thejimbirch I'm a little confused here. creatIfNotExists was adopted in an early commit for the form and display modes. Maybe something else is the source of your error?

🇨🇦Canada mandclu

IMHO if the recipes won't be applied as part of the initial site install, it makes more sense to not load dependencies until the recipes are going to be applied. Happy to defer to @pameeela on this, however.

🇨🇦Canada mandclu

Based on the comments in this thread, closing this in favor of a suggests-only approach in 📌 Suggest Event add-ons Active .

🇨🇦Canada mandclu

Based on the comments in this thread, closing this in favor of a suggests-only approach in 📌 Suggest Event add-ons Active .

🇨🇦Canada mandclu

Here's a small MR to add suggestions for the event add-ons that already exist in the contrib space, instead of reproducing them as small, additional recipes within Drupal CMS.

Production build 0.71.5 2024