I will also add that this seems to severely impact the intended reusability of the recipes within Drupal CMS. I can include one such recipe in my own recipe (tested successfully with drupal_cms_admin_ui) but my recipe fails to apply if I add another (tested by adding drupal_cms_anti_spam, which only adds another 5 dependencies, based on the command line output).
+1 on the need for this. I can install the Event Platform project (which has loads of nested dependencies) in less than 20 seconds via the Drupal UI or drush. If I implement a recipe that installs this project (and does nothing else, even forcing the configuration to load) then the recipe runner tries for several minutes and then inevitably fails.
In my own testing, I get an error while trying to build a view:
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "storage_item" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of /var/www/html/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php).
Postponed until there is specific feedback for the 3.0 branch of IEF
@mxh I don't have words to sufficiently express how much we as a community value the work you have put into this and other Drupal modules. I don't see a need to remove you as a maintainer just because you don't currently have the bandwidth to help.
If, however, you would prefer to not even see the notifications for this module, then I will remove you a maintainer if that is your preference.
Thanks for everyone's work here. I do agree that this is an improvement, including structuring the messages to be more like core.
Thanks for identifying this, and for providing a fix. Merged in, and will roll this into a new 1.4.x release soon.
@nicxvan I probably just haven't had enough coffee yet today, but could you add steps to reproduce here?
I was able to reproduce the cited issue and verify that with the patch applied, the additional checkbox is not seen. The only potential issue I see is that with an existing storage bundle, if you click to enable the revision checkbox in the bundle configuration, you will not immediately see the revision option in the form. You need to also enable the field in the form display. Would we say that's expected behaviour?
Is this ready for review?
mandclu → created an issue.
Moving the work to allow session authors to confirm on their own to a child issue.
Now that we have our own, configurable Event Horizon theme, this issue can be closed
This was completed and merged into the 2.0.x branch
@penyaskito could you point me in the direction of a custom xb transform that has already been implemented?
mandclu → made their first commit to this issue’s fork.
I believe this should be resolved now, so marking this as outdated. Feel free to reopen if additional work is needed.
It looks like this got fixed upstream, so marking this as outdated. Feel free to reopen if some action is needed here.
The only bummer about the Navigation module is that it has Layout Builder as a dependency.
mandclu → created an issue. See original summary → .
I believe the issues you encountered should now be fixed on the dev branch. Please test it again.
Great catch. The MR has been updated to include what should be all the info.yml files.
teknorah → credited mandclu → .
I think we should start working on a site recipe that can populate initial content like this, as well as some other general configuration that will be helpful (like allowing people to register) as well as implementing general best practices around SEO, UX, etc.
Maybe we could call the project Event Platform Starter? Or Event Platform Genesis? Open to suggestions.
Here's an MR that updates the info.yml file
What you're asking for is possible using Smart Date's Recurring formatter, which can work with dates that aren't recurring. You will need to install the submodule, however.
Here are the settings I would recommend for the formatter:
Force chronological: enabled
Recent Instances: 0
Upcoming Instances: 1
Show next instance separately: enabled
Based on my testing this works exactly as you describe.
mandclu → created an issue.
I'm not sure we should limit it to 3, since a camp with more than three days may want more values. I agree that using storage entities probably makes sense, and perhaps once those are defined we could even use them to make the tabs in the schedule display a little nicer.
I've added an update hook which fixed an existing block in my test environment. Please review.
This is definitely something we're looking at. I don't think that commerce integration will be core to the Event Platform since some events / camps may still want to use Eventbrite etc. but I would love to provide an easy to use Commerce setup as a drop-in alternative
hestenet → credited mandclu → .
hestenet → credited mandclu → .
Circling back on this, @nickdjm any chance you've had a chance to review this yet? I would really like to use this module in the Drupal Event Platform → but I need something that supports taxonomy terms.
I encountered this same bug, using Leaflet on a fresh install of Drupal 11. Here are steps to reproduce the problem on a newly installed site:
- Require and apply the Locations recipe →
- Go to add a location node
- On save, you will encounter the error
Here is the full error output:
TypeError thrown with message "Drupal\Component\Utility\Html::decodeEntities(): Argument #1 ($text) must be of type string, Drupal\Core\Render\Markup given, called in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php on line 1461"
Stacktrace:
#39 TypeError in /var/www/html/web/core/lib/Drupal/Component/Utility/Html.php:393
#38 Drupal\Component\Utility\Html:decodeEntities in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php:1461
#37 Drupal\leaflet_views\Plugin\views\style\LeafletMap:processFeatureTooltips in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php:1368
#36 Drupal\leaflet_views\Plugin\views\style\LeafletMap:processFeature in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php:1116
#35 Drupal\leaflet_views\Plugin\views\style\LeafletMap:processEntityFeatures in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php:999
#34 Drupal\leaflet_views\Plugin\views\style\LeafletMap:processGeofield in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php:940
#33 Drupal\leaflet_views\Plugin\views\style\LeafletMap:processResultsGroups in /var/www/html/web/modules/contrib/leaflet/modules/leaflet_views/src/Plugin/views/style/LeafletMap.php:897
#32 Drupal\leaflet_views\Plugin\views\style\LeafletMap:render in /var/www/html/web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php:2203
#31 Drupal\views\Plugin\views\display\DisplayPluginBase:render in /var/www/html/web/core/modules/views/src/ViewExecutable.php:1593
#30 Drupal\views\ViewExecutable:render in /var/www/html/web/core/modules/views/src/Plugin/views/display/Page.php:201
#29 Drupal\views\Plugin\views\display\Page:execute in /var/www/html/web/core/modules/views/src/ViewExecutable.php:1690
#28 Drupal\views\ViewExecutable:executeDisplay in /var/www/html/web/core/modules/views/src/Element/View.php:81
#27 Drupal\views\Element\View:preRenderViewElement in /var/www/html/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php:107
#26 call_user_func_array in /var/www/html/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php:107
#25 Drupal\Core\Render\Renderer:doTrustedCallback in /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php:830
#24 Drupal\Core\Render\Renderer:doCallback in /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php:387
#23 Drupal\Core\Render\Renderer:doRender in /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php:203
#22 Drupal\Core\Render\Renderer:render in /var/www/html/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php:238
#21 Drupal\Core\Render\MainContent\HtmlRenderer:Drupal\Core\Render\MainContent\{closure} in /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php:593
#20 Drupal\Core\Render\Renderer:executeInRenderContext in /var/www/html/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php:231
#19 Drupal\Core\Render\MainContent\HtmlRenderer:prepare in /var/www/html/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php:128
#18 Drupal\Core\Render\MainContent\HtmlRenderer:renderResponse in /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php:90
#17 Drupal\Core\EventSubscriber\MainContentViewSubscriber:onViewRenderArray in /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:246
#16 Symfony\Component\EventDispatcher\EventDispatcher:Symfony\Component\EventDispatcher\{closure} in /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:206
#15 Symfony\Component\EventDispatcher\EventDispatcher:callListeners in /var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:56
#14 Symfony\Component\EventDispatcher\EventDispatcher:dispatch in /var/www/html/vendor/symfony/http-kernel/HttpKernel.php:188
#13 Symfony\Component\HttpKernel\HttpKernel:handleRaw in /var/www/html/vendor/symfony/http-kernel/HttpKernel.php:76
#12 Symfony\Component\HttpKernel\HttpKernel:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php:53
#11 Drupal\Core\StackMiddleware\Session:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php:48
#10 Drupal\Core\StackMiddleware\KernelPreHandle:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php:28
#9 Drupal\Core\StackMiddleware\ContentLength:handle in /var/www/html/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php:32
#8 Drupal\big_pipe\StackMiddleware\ContentLength:handle in /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php:116
#7 Drupal\page_cache\StackMiddleware\PageCache:pass in /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php:90
#6 Drupal\page_cache\StackMiddleware\PageCache:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php:48
#5 Drupal\Core\StackMiddleware\ReverseProxyMiddleware:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php:51
#4 Drupal\Core\StackMiddleware\NegotiationMiddleware:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php:36
#3 Drupal\Core\StackMiddleware\AjaxPageState:handle in /var/www/html/web/modules/contrib/whoops/src/StackMiddleware/WhoopsMiddleware.php:49
#2 Drupal\whoops\StackMiddleware\WhoopsMiddleware:handle in /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php:51
#1 Drupal\Core\StackMiddleware\StackedHttpKernel:handle in /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php:709
#0 Drupal\Core\DrupalKernel:handle in /var/www/html/web/index.php:19
I also found that reverting back to the previous release resolved the issue, but the patch gets things working as expected too.
teknorah → credited mandclu → .
borisson_ → credited mandclu → .
I would still be happy to help @eelkeblok maintain this module. That said, I am thankful for the D11 release.
One other possibility would be to make more general-purpose version of this theme, and then make this project a more opinionated subtheme of that. I don't really have the bandwidth to take that on at the moment, however.
Maybe it would be more appropriate to discuss getting Same Page Preview into Drupal CMS?
The benefit of Same Page Preview is that it allows Drupal to incorporate a feature of competing CMS solutions that user testing has identified gives content authors a higher degree of confidence that they are using the system properly. Being able to see the rendered version of a piece of content as they are filling out a structured form does provide value to the user.
If XB is planned to offer live preview while filling out a content form (e.g. not working with components etc) then Same Page Preview is not needed, but I think we should validate that before we close this issue.
Another +1 from me.
The scope of changes in the MR may be wider than the maintainers are looking for, and if so I would be happy to tweak as needed. The changes in there do meet my need for creating a condition that works for moderated taxonomy terms, however.
This may need a dedicated project, similar to Scheduler for ECK →