I added video tags to the IS but I suppose drupal.org doesn't support those, which does make sense. you can use the links in the previous comment to see the problem (first video) and then the problem resolved with the patch applied (second link).
This was with a recent install of Drupal CMS → . Maybe the problem is specific to having that as a starting point?
How I experienced the problem is this:
On a canvas page, if I click to select a meta image, the media library modal launches. If I select an image and click the button to "insert selected", however, the media field reverts to its previous state. No thumbnail of the selected image is shown, and the text under the field says that 0 of 1 media items have been selected.
With the patch applied, the field works as expected, showing the thumbnail for the selected image and the text stating that 1 of 1 media items have been been selected.
I will also point out that this patch is being used in production currently.
I ran into this same issue, and can verify that the proposed code resolved my issue. I'm tempted to mark this as RTBC, but it should probably be an MR first.
I'm using a fresh install of Drupal 11.2.4 and Storage dev-1.4.x. I am able to successfully access the storage overview page without or without existing storage entities in the database. Clear steps to reproduce are needed before I can evaluate the proposed changes.
I just tried to follow the steps to reproduce on a fresh install of Drupal 11.2.4 and the latest code in the 1.4.x branch. I was able to access the Revisions page and even view a revision without an error. Can you review the steps again and see if something else is needed to see the error?
@fathershawn Thanks for your work on this. I can't seem to reproduce a scenario where storage entities don't already work this way. Can you add steps to reproduce?
Thanks everyone. Merged this in, and will try to roll a new release shortly.
@megan_m this sounds like an important fix but I don't see an MR. Any chance you have the required code change handy?
Adding the checklist preferred by the project ownership team. Please correct if there are any inaccuracies in the information I have entered.
It's worth mentioning in this thread that Smart Date's included support for Fullcalendar View is deprecated and will be removed from an upcoming v5 release. Anyone wanting to use Smart Date with an interactive calendar should transition to the Fullcalendar → project instead, which includes a variety of improvements, including the processing optimization suggested here.
My own personal preference would be to use the form called out in #10 as the place where Automators are defined. Then, the field widget is the only place they need to be associated with a particular field (since the action elements are currently only for forms). Maybe the widget configuration piece could allow an Automator to be defined in the settings tray or in a modal?
I think it makes sense for Automators to be able to share configuration between fields, as this will may it easy for the same element to work in the same way in different places on the site. If a different field needs an automator to work in a different way, we should allow Automators to be easily cloned.
@dieterholvoet I fully support your application to be a co-maintainer, and would appreciate your help. Unfortunately, I do not have access to manage maintainers.
I was added as a maintainer by eme → in #3175187: Offering to co-maintain Form mode control → so it seems the best path forward is to contact him.
Thanks for your work on this! My only concern is that only updating the order in the scheduler won't fix how the time slots are order elsewhere, particularly the schedule. So we should either make sure the schedule has the proper sort defined, or have this updte the order of the taxonomy terms themselves
seantwalsh → credited mandclu → .
phenaproxima → credited mandclu → .
matthews → credited mandclu → .
I'm tempted to say this is expected behavior (knowing how core works) , but I can appreciate that from a site builder viewpoint this would be unexpected.
I'm tempted to say that this should be a feature request, to provide a means (maybe automatic?) to reset the ordering for a taxonomy vocabulary when the generator is run.
matthews → credited mandclu → .
At some point it might be helpful to have a release of this module that required Devel >= 5.4.0 and the main Kint module
Thanks for identifying this, and for providing a fix. Merged in.
volkswagenchick → credited mandclu → .
mandclu → created an issue.
mandclu → created an issue. See original summary → .
I have a project that started throw 15 phpcs errors of the exact type mentioned in the IS and also one other, all in .yml files. I can't personally see what useful feedback we would get from running a php check against .yml files.
This was addressed in previous commits, in particular New and updated block placement
Moving this to Event Platform since the cause probably needs a fix in the config page admin labels.
Also, updating the IS to reflect the new understanding, as well as the fact that the order of the fields has changed.
seantwalsh → credited mandclu → .
seantwalsh → credited mandclu → .
Ironic to have a typo in the issue name lol