[PP-1] Use actual page URL instead of hardcoding the query string in unlock URL

Changes looks good to me, but it needs to be done in different file due to ✨ GUI install multiple modules at once. Needs work . Also instead of patch, it will be good if we use MR.

We are taking up this issue in DrupalCampPune2024

Rebased to latest 2.0.x and It's ready for review.

I don't think this actually solves the problem. Here's why.

If the err.unlock_url property looks like this: /admin/modules/browse/unlock, then the current code will generate this: /admin/modules/browse/unlock&destination=my+current+url. That's an invalid URL which will lead to a 404 or worse.

What we need here is:

• If the unlock URL looks something like /admin/modules/browse/unlock?some_param=foo, then the generated URL has to look like: /admin/modules/browse/unlock?some_param=foo&destination=my+current+url. This, to be fair, is what the code in HEAD already does.
• But if the unlock URL doesn't have a query string, then we need to append it, prefixed by a question mark.

Looks fine to me!

We have native JS API's for this now, so we don't need to do our own string concat. I think something like this would make the code more readable. (Bear in mind this is GPT-generated and untested, but point being we should use URL - https://developer.mozilla.org/en-US/docs/Web/API/URL )

// Get the current page URL as a URL object for easier manipulation
const currentUrl = new URL(window.location.href);

if (err.unlock_url) {
  const unlockUrl = new URL(err.unlock_url);

  // Append the 'destination' parameter to unlockUrl
  unlockUrl.searchParams.set('destination', currentUrl.toString());

  // Update the HTML content
  div.innerHTML += `<p>${errorMessage} <a href="${unlockUrl.toString()}">${Drupal.t(
    'Unlock Install Stage'
  )}</a></p>`;
} else {
  div.innerHTML += `<p>${errorMessage}</p>`;
}

The failing tests are not related to the changes in this MR, so marking this NR again.

Changes not implemented as suggested in #17